Skip to contentSkip to conversation

bad CONFIG variable references from Makefiles

PATCH New Robert P. J. Day 5 participants 10 messages Jul 28, 2008 – Aug 5, 2008 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

a complete list of all references to non-existent CONFIG variables
exclusively from Makefiles in the tree. since the list is so short, i'm not bothering to break it up by subsystem or arch. enjoy.

===== ARCH_OMAP3 =====
./arch/arm/mach-omap2/Makefile:obj-$(CONFIG_ARCH_OMAP3) += clock34xx.o
===== CACHE_XSC3L2 =====
./arch/arm/mm/Makefile:obj-$(CONFIG_CACHE_XSC3L2) += cache-xsc3l2.o
===== ETRAXFS_SIM ===== ./arch/cris/arch-v32/kernel/Makefile:obj-$(CONFIG_ETRAXFS_SIM) += vcs_hook.o ===== FB_SH7343VOU =====
./drivers/video/Makefile:obj-$(CONFIG_FB_SH7343VOU) += sh7343_voufb.o
===== HDPU_FEATURES =====
./drivers/misc/Makefile:obj-$(CONFIG_HDPU_FEATURES) += hdpuftrs/
./drivers/misc/hdpuftrs/Makefile:obj-$(CONFIG_HDPU_FEATURES) := hdpu_cpustate.o hdpu_nexus.o ===== MSPETH ===== ./arch/mips/pmc-sierra/msp71xx/Makefile:obj-$(CONFIG_MSPETH) += msp_eth.o ===== OMAP_MBOX_FWK ===== ./arch/arm/plat-omap/Makefile:obj-$(CONFIG_OMAP_MBOX_FWK) += mailbox.o
===== PROFILE =====
./arch/mn10300/kernel/Makefile:obj-$(CONFIG_PROFILE) += profile.o profile-low.o ===== RADIO_MIROPCM20 ===== ./drivers/media/radio/Makefile:obj-$(CONFIG_RADIO_MIROPCM20) += miropcm20.o ===== RADIO_MIROPCM20_RDS ===== ./drivers/media/radio/Makefile:obj-$(CONFIG_RADIO_MIROPCM20_RDS) += miropcm20-rds.o ===== SA1100_USB =====
./arch/arm/mach-sa1100/Makefile:#obj-$(CONFIG_SA1100_USB) += usb/
===== TTY_LOG =====
./arch/um/os-Linux/Makefile:obj-$(CONFIG_TTY_LOG) += tty_log.o ./arch/um/os-Linux/Makefile:user-objs-$(CONFIG_TTY_LOG) += tty_log.o
===== USB_MSP71XX ===== ./arch/mips/pmc-sierra/msp71xx/Makefile:obj-$(CONFIG_USB_MSP71XX) += msp_usb.o ===== V850E_UART =====
./drivers/serial/Makefile:obj-$(CONFIG_V850E_UART) += v850e_uart.o
===== XEN_XENCOMM =====
./drivers/xen/Makefile:obj-$(CONFIG_XEN_XENCOMM) += xencomm.o
===== XFS_TRACE =====
./fs/xfs/Makefile:xfs-$(CONFIG_XFS_TRACE) += xfs_dir2_trace.o
./fs/xfs/Makefile:xfs-$(CONFIG_XFS_TRACE) += support/ktrace.o
===== XTENSA_VARIANT_LINUX_CUSTOM =====
./arch/xtensa/Makefile:variant-$(CONFIG_XTENSA_VARIANT_LINUX_CUSTOM) := custom

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.

http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================

#1 lore raw
Quoted 8 lines · Robert P. J. Day

a complete list of all references to non-existent CONFIG variables
exclusively from Makefiles in the tree. since the list is so short, i'm not bothering to break it up by subsystem or arch. enjoy.

===== FB_SH7343VOU =====
./drivers/video/Makefile:obj-$(CONFIG_FB_SH7343VOU) += sh7343_voufb.o

Seems to have crept in from a working local tree. It's obviously bogus and can simply be killed off.

#2 lore raw
Quoted 7 lines · Paul Mundt
Quoted 6 lines · Robert P. J. Day

a complete list of all references to non-existent CONFIG variables
exclusively from Makefiles in the tree. since the list is so short, i'm not bothering to break it up by subsystem or arch. enjoy.

Quoted 5 lines
Quoted 2 lines

===== FB_SH7343VOU =====
./drivers/video/Makefile:obj-$(CONFIG_FB_SH7343VOU) += sh7343_voufb.o

Seems to have crept in from a working local tree. It's obviously bogus and can simply be killed off.

ok, i can slap together a patch unless someone else gets to it first.

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.

http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================

#3 lore raw
Quoted 9 lines · Robert P. J. Day
Quoted 7 lines · Paul Mundt
Quoted 6 lines · Robert P. J. Day

a complete list of all references to non-existent CONFIG variables
exclusively from Makefiles in the tree. since the list is so short, i'm not bothering to break it up by subsystem or arch. enjoy.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

===== FB_SH7343VOU =====
./drivers/video/Makefile:obj-$(CONFIG_FB_SH7343VOU) += sh7343_voufb.o

Seems to have crept in from a working local tree. It's obviously bogus and can simply be killed off.

ok, i can slap together a patch unless someone else gets to it first.

Already in my tree, forgot to mention :-)

#4 lore raw
Quoted 14 lines · Paul Mundt
Quoted 13 lines · Robert P. J. Day
Quoted 11 lines · Paul Mundt
Quoted 9 lines · Robert P. J. Day

a complete list of all references to non-existent CONFIG
variables exclusively from Makefiles in the tree. since the list is so short, i'm not bothering to break it up by subsystem or arch. enjoy.

===== FB_SH7343VOU =====
./drivers/video/Makefile:obj-$(CONFIG_FB_SH7343VOU) += sh7343_voufb.o

Quoted 7 lines
Quoted 6 lines
Quoted 2 lines

Seems to have crept in from a working local tree. It's obviously bogus and can simply be killed off.

ok, i can slap together a patch unless someone else gets to it first.

Already in my tree, forgot to mention :-)

i believe that qualifies as "getting to it first."

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.

http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================

#5 lore raw
In reply to Robert P. J. Day
Quoted 10 lines · Robert P. J. Day

a complete list of all references to non-existent CONFIG variables
exclusively from Makefiles in the tree. since the list is so short, i'm not bothering to break it up by subsystem or arch. enjoy.
...
===== RADIO_MIROPCM20 ===== ./drivers/media/radio/Makefile:obj-$(CONFIG_RADIO_MIROPCM20) += miropcm20.o ===== RADIO_MIROPCM20_RDS ===== ./drivers/media/radio/Makefile:obj-$(CONFIG_RADIO_MIROPCM20_RDS) += miropcm20-rds.o
...

Mauro, 1.5 years ago you said you wanted this code to stay for having it perhaps ported to ALSA.

Do you still want it to stay or could it be removed now (if anyone suddenly feels the desire to work on it the code is still in older kernels)?

Quoted 1 line

rday

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#6 lore raw

Hi Adrian,

Quoted 13 lines · On Tue, 29 Jul 2008 00:48:41 +0300 Adrian Bunk <[email protected]> wrote:
Quoted 11 lines · Robert P. J. Day

a complete list of all references to non-existent CONFIG variables
exclusively from Makefiles in the tree. since the list is so short, i'm not bothering to break it up by subsystem or arch. enjoy.
...
===== RADIO_MIROPCM20 ===== ./drivers/media/radio/Makefile:obj-$(CONFIG_RADIO_MIROPCM20) += miropcm20.o ===== RADIO_MIROPCM20_RDS ===== ./drivers/media/radio/Makefile:obj-$(CONFIG_RADIO_MIROPCM20_RDS) += miropcm20-rds.o
...

Quoted 7 lines

Mauro, 1.5 years ago you said you wanted this code to stay for having it perhaps ported to ALSA.

Do you still want it to stay or could it be removed now (if anyone suddenly feels the desire to work on it the code is still in older kernels)?

Douglas started working on this, but never finished a changeset. Since nobody ever complained about this during this 1.5 years period, IMO, we should just drop it.

Cheers,
Mauro

#7 lore raw

PATCH 1/1 remove the dead CONFIG_RADIO_MIROPCM20{,_RDS} code

Quoted 21 lines · Mauro Carvalho Chehab

Hi Adrian,

Quoted 16 lines · On Tue, 29 Jul 2008 00:48:41 +0300 Adrian Bunk <[email protected]> wrote:
Quoted 11 lines · Robert P. J. Day

a complete list of all references to non-existent CONFIG variables
exclusively from Makefiles in the tree. since the list is so short, i'm not bothering to break it up by subsystem or arch. enjoy.
...
===== RADIO_MIROPCM20 ===== ./drivers/media/radio/Makefile:obj-$(CONFIG_RADIO_MIROPCM20) += miropcm20.o ===== RADIO_MIROPCM20_RDS ===== ./drivers/media/radio/Makefile:obj-$(CONFIG_RADIO_MIROPCM20_RDS) += miropcm20-rds.o
...

Mauro, 1.5 years ago you said you wanted this code to stay for having it perhaps ported to ALSA.

Quoted 8 lines
Quoted 4 lines

Do you still want it to stay or could it be removed now (if anyone suddenly feels the desire to work on it the code is still in older kernels)?

Douglas started working on this, but never finished a changeset. Since nobody ever complained about this during this 1.5 years period, IMO, we should just drop it.

Patch below.

Quoted 2 lines

Cheers,
Mauro

cu
Adrian

<-- snip -->

The CONFIG_RADIO_MIROPCM20{,_RDS} code became dead code 1.5 years ago.

---

 drivers/media/radio/Makefile             |    4 
 drivers/media/radio/miropcm20-radio.c    |  266 -----------------------
 drivers/media/radio/miropcm20-rds-core.c |  211 ------------------
 drivers/media/radio/miropcm20-rds-core.h |   19 -
 drivers/media/radio/miropcm20-rds.c      |  136 -----------
 5 files changed, 636 deletions(-)

d9753b7ed4d193099bf15c8fcf1496b92682481d

drivers/media/radio/Makefile +0 -4
index a30159f..7ca71ab 100644
@@ -2,8 +2,6 @@
 # Makefile for the kernel character device drivers.
 #
 
-miropcm20-objs	:= miropcm20-rds-core.o miropcm20-radio.o
-
 obj-$(CONFIG_RADIO_AZTECH) += radio-aztech.o
 obj-$(CONFIG_RADIO_RTRACK2) += radio-rtrack2.o
 obj-$(CONFIG_RADIO_SF16FMI) += radio-sf16fmi.o
@@ -14,8 +12,6 @@ obj-$(CONFIG_RADIO_TERRATEC) += radio-terratec.o
 obj-$(CONFIG_RADIO_MAXIRADIO) += radio-maxiradio.o
 obj-$(CONFIG_RADIO_RTRACK) += radio-aimslab.o
 obj-$(CONFIG_RADIO_ZOLTRIX) += radio-zoltrix.o
-obj-$(CONFIG_RADIO_MIROPCM20) += miropcm20.o
-obj-$(CONFIG_RADIO_MIROPCM20_RDS) += miropcm20-rds.o
 obj-$(CONFIG_RADIO_GEMTEK) += radio-gemtek.o
 obj-$(CONFIG_RADIO_GEMTEK_PCI) += radio-gemtek-pci.o
 obj-$(CONFIG_RADIO_TRUST) += radio-trust.o
drivers/media/radio/miropcm20-radio.c deleted +0 -266

266 lines not on this page · raw message

drivers/media/radio/miropcm20-rds-core.c deleted +0 -211

211 lines not on this page · raw message

drivers/media/radio/miropcm20-rds-core.h deleted +0 -19
deleted file mode 100644
index aeb5761..0000000
@@ -1,19 +0,0 @@
-#ifndef _MIROPCM20_RDS_CORE_H_
-#define _MIROPCM20_RDS_CORE_H_
-
-extern int aci_rds_cmd(unsigned char cmd, unsigned char databuffer[], int datasize);
-
-#define RDS_STATUS      0x01
-#define RDS_STATIONNAME 0x02
-#define RDS_TEXT        0x03
-#define RDS_ALTFREQ     0x04
-#define RDS_TIMEDATE    0x05
-#define RDS_PI_CODE     0x06
-#define RDS_PTYTATP     0x07
-#define RDS_RESET       0x08
-#define RDS_RXVALUE     0x09
-
-extern void __exit unload_aci_rds(void);
-extern int __init attach_aci_rds(void);
-
-#endif /* _MIROPCM20_RDS_CORE_H_ */
drivers/media/radio/miropcm20-rds.c deleted +0 -136

136 lines not on this page · raw message

#8 lore raw
In reply to Robert P. J. Day
Quoted 8 lines · Robert P. J. Day

a complete list of all references to non-existent CONFIG variables
exclusively from Makefiles in the tree. since the list is so short, i'm not bothering to break it up by subsystem or arch. enjoy.
...
===== CACHE_XSC3L2 =====
./arch/arm/mm/Makefile:obj-$(CONFIG_CACHE_XSC3L2) += cache-xsc3l2.o
...

Comparing commit 20072fd0c93349e19527dd2fa9588b4335960e62 ([ARM] pxa: add support for L2 outer cache on XScale3) with the patch that originally went to linux-arm-kernel it seems only a tiny fragment of the original patch arrived in the tree.

Quoted 1 line

rday

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#9 lore raw
Quoted 10 lines · Adrian Bunk
Quoted 8 lines · Robert P. J. Day

a complete list of all references to non-existent CONFIG variables
exclusively from Makefiles in the tree. since the list is so short, i'm not bothering to break it up by subsystem or arch. enjoy.
...
===== CACHE_XSC3L2 =====
./arch/arm/mm/Makefile:obj-$(CONFIG_CACHE_XSC3L2) += cache-xsc3l2.o
...

Quoted 4 lines

Comparing commit 20072fd0c93349e19527dd2fa9588b4335960e62 ([ARM] pxa: add support for L2 outer cache on XScale3) with the patch that originally went to linux-arm-kernel it seems only a tiny fragment of the original patch arrived in the tree.

Very interesting. It was applied using git-am from a mailbox sent to me by Eric. Strangly, the commit only contains the second file patched by the contents of that message.

No idea how that happened.

Wonder how much other stuff has gone awry...

I'll strip out the second file from that message and reapply it. Expect it to be fixed post-rc1 though.

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of: