Skip to contentSkip to conversation

toshiba_acpi: depends on INPUT

PATCH In review Randy Dunlap 2 participants 2 messages Sep 19, 2008 – Oct 10, 2008 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 toshiba_acpi: depends on INPUT

From: Randy Dunlap <[email protected]>

CONFIG_ACPI_TOSHIBA can =y when CONFIG_INPUT=m, so prevent that combination and its subsequent build errors:

toshiba_acpi.c:(.text+0x3e877): undefined reference to input_event' toshiba_acpi.c:(.text+0x3e98a): undefined reference to input_unregister_polled_device' toshiba_acpi.c:(.text+0x3e994): undefined reference to input_free_polled_device' toshiba_acpi.c:(.init.text+0x21b4): undefined reference to input_allocate_polled_device' toshiba_acpi.c:(.init.text+0x2263): undefined reference to `input_register_polled_device' make[1]: *** [.tmp_vmlinux1] Error 1

---
 drivers/acpi/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/Kconfig +1 -1
@@ -270,7 +270,7 @@ config ACPI_PANASONIC
 
 config ACPI_TOSHIBA
 	tristate "Toshiba Laptop Extras"
-	depends on X86
+	depends on X86 && INPUT
 	select INPUT_POLLDEV
 	select NET
 	select RFKILL
reviewer
#1 lore raw

not sure how you coaxed a =m on CONFIG_INPUT,
but this patch is fine, and applied to acpi-test.

thanks,
-Len

Quoted 29 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

CONFIG_ACPI_TOSHIBA can =y when CONFIG_INPUT=m, so prevent that combination and its subsequent build errors:

toshiba_acpi.c:(.text+0x3e877): undefined reference to input_event' toshiba_acpi.c:(.text+0x3e98a): undefined reference to input_unregister_polled_device' toshiba_acpi.c:(.text+0x3e994): undefined reference to input_free_polled_device' toshiba_acpi.c:(.init.text+0x21b4): undefined reference to input_allocate_polled_device' toshiba_acpi.c:(.init.text+0x2263): undefined reference to `input_register_polled_device' make[1]: *** [.tmp_vmlinux1] Error 1

---
 drivers/acpi/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/Kconfig +1 -1
@@ -270,7 +270,7 @@ config ACPI_PANASONIC
 
 config ACPI_TOSHIBA
 	tristate "Toshiba Laptop Extras"
-	depends on X86
+	depends on X86 && INPUT
 	select INPUT_POLLDEV
 	select NET
 	select RFKILL