Skip to contentSkip to conversation

ACPICA: add debug dump of BIOS _OSI strings

PATCH In review Len Brown 2 participants 3 messages Feb 3, 2009 – Feb 6, 2009

Subsystems (2)
lore
Share & tools
lore

Len Brown

author reviewer
#0 lore raw

PATCH 1/1 ACPICA: add debug dump of BIOS _OSI strings

Bob,
I'd like to make this minor change to the (linuxized) ACPICA code, for it can tell us a little about the BIOS w/o having the user go to the trouble to dump the tables etc.

If you made this change in the upstream ACPICA code, then that would be dandy.

thanks,
-Len

Quoted 1 line

From 3e0676a9b699d12b2bd0a8807459ac4277b181fc Mon Sep 17 00:00:00 2001

From: Len Brown <[email protected]>
Date: Tue, 3 Feb 2009 18:04:39 -0500
Subject: [PATCH] ACPICA: add debug dump of BIOS _OSI strings
Organization: Intel Open Source Technology Center

on boot, print out the OSI strings the BIOS uses to query the OS.

To see this output...

build with CONFIG_ACPI_DEBUG

boot with
"acpi.debug_level=4" (ACPI_LV_INFO) (enabled by default) and
"acpi.debug_level=1" (ACPI_UTILITIES) (default is 0)

example output:

ACPI: BIOS _OSI(Windows 2001) supported
ACPI: BIOS _OSI(Windows 2001 SP1) supported
ACPI: BIOS _OSI(Windows 2001 SP2) supported
ACPI: BIOS _OSI(Windows 2006) supported
ACPI: BIOS _OSI(Linux) not-supported
ACPI: BIOS _OSI(FreeBSD) not-supported

---
 drivers/acpi/acpica/uteval.c |   21 +++++++++------------
 1 files changed, 9 insertions(+), 12 deletions(-)
drivers/acpi/acpica/uteval.c +9 -12
index da9450b..9c9897d 100644
@@ -116,9 +116,9 @@ acpi_status acpi_ut_osi_implementation(struct acpi_walk_state *walk_state)
 		return_ACPI_STATUS(AE_NO_MEMORY);
 	}
 
-	/* Default return value is SUPPORTED */
+	/* Default return value is 0, NOT-SUPPORTED */
 
-	return_desc->integer.value = ACPI_UINT32_MAX;
+	return_desc->integer.value = 0;
 	walk_state->return_desc = return_desc;
 
 	/* Compare input string to static table of supported interfaces */
@@ -127,10 +127,8 @@ acpi_status acpi_ut_osi_implementation(struct acpi_walk_state *walk_state)
 		if (!ACPI_STRCMP
 		    (string_desc->string.pointer,
 		     acpi_interfaces_supported[i])) {
-
-			/* The interface is supported */
-
-			return_ACPI_STATUS(AE_OK);
+			return_desc->integer.value = ACPI_UINT32_MAX;
+			goto done;
 		}
 	}
 
@@ -141,15 +139,14 @@ acpi_status acpi_ut_osi_implementation(struct acpi_walk_state *walk_state)
 	 */
 	status = acpi_os_validate_interface(string_desc->string.pointer);
 	if (ACPI_SUCCESS(status)) {
-
-		/* The interface is supported */
-
-		return_ACPI_STATUS(AE_OK);
+		return_desc->integer.value = ACPI_UINT32_MAX;
 	}
 
-	/* The interface is not supported */
+done:
+	ACPI_DEBUG_PRINT_RAW((ACPI_DB_INFO, "ACPI: BIOS _OSI(%s) %ssupported\n",
+		string_desc->string.pointer,
+		return_desc->integer.value == 0 ? "not-" : ""));
 
-	return_desc->integer.value = 0;
 	return_ACPI_STATUS(AE_OK);
 }
 
Signature · 1 line
1.6.1.2.319.gbd9e
#1 lore raw

I'll put it in.
Bob

Quoted 111 lines

-----Original Message-----
From: [email protected] [mailto:linux-acpi- [email protected]] On Behalf Of Len Brown
Sent: Tuesday, February 03, 2009 3:18 PM
To: [email protected]
Cc: [email protected]
Subject: [PATCH] ACPICA: add debug dump of BIOS _OSI strings

Bob,
I'd like to make this minor change to the (linuxized) ACPICA code, for it can tell us a little about the BIOS w/o having the user go to the trouble to dump the tables etc.

If you made this change in the upstream ACPICA code, then that would be dandy.

thanks,
-Len

From 3e0676a9b699d12b2bd0a8807459ac4277b181fc Mon Sep 17 00:00:00 2001
From: Len Brown <[email protected]>
Date: Tue, 3 Feb 2009 18:04:39 -0500
Subject: [PATCH] ACPICA: add debug dump of BIOS _OSI strings
Organization: Intel Open Source Technology Center

on boot, print out the OSI strings the BIOS uses to query the OS.

To see this output...

build with CONFIG_ACPI_DEBUG

boot with
"acpi.debug_level=4" (ACPI_LV_INFO) (enabled by default) and
"acpi.debug_level=1" (ACPI_UTILITIES) (default is 0)

example output:

ACPI: BIOS _OSI(Windows 2001) supported
ACPI: BIOS _OSI(Windows 2001 SP1) supported
ACPI: BIOS _OSI(Windows 2001 SP2) supported
ACPI: BIOS _OSI(Windows 2006) supported
ACPI: BIOS _OSI(Linux) not-supported
ACPI: BIOS _OSI(FreeBSD) not-supported

---
drivers/acpi/acpica/uteval.c | 21 +++++++++------------

1 files changed, 9 insertions(+), 12 deletions(-)
drivers/acpi/acpica/uteval.c +2 -2
index da9450b..9c9897d 100644
@@ -116,9 +116,9 @@ acpi_status acpi_ut_osi_implementation(struct
 acpi_walk_state *walk_state)
               return_ACPI_STATUS(AE_NO_MEMORY);
       }
 
-       /* Default return value is SUPPORTED */
+       /* Default return value is 0, NOT-SUPPORTED */
 
-       return_desc->integer.value = ACPI_UINT32_MAX;
+       return_desc->integer.value = 0;
       walk_state->return_desc = return_desc;
 
       /* Compare input string to static table of supported interfaces */
drivers/acpi/acpica/uteval.c +7 -10
@@ -127,10 +127,8 @@ acpi_status acpi_ut_osi_implementation(struct
 acpi_walk_state *walk_state)
               if (!ACPI_STRCMP
                   (string_desc->string.pointer,
                    acpi_interfaces_supported[i])) {
-
-                       /* The interface is supported */
-
-                       return_ACPI_STATUS(AE_OK);
+                       return_desc->integer.value = ACPI_UINT32_MAX;
+                       goto done;
               }
       }
@@ -141,15 +139,14 @@ acpi_status acpi_ut_osi_implementation(struct
 acpi_walk_state *walk_state)
        */
       status = acpi_os_validate_interface(string_desc->string.pointer);
       if (ACPI_SUCCESS(status)) {
-
-               /* The interface is supported */
-
-               return_ACPI_STATUS(AE_OK);
+               return_desc->integer.value = ACPI_UINT32_MAX;
       }
 
-       /* The interface is not supported */
+done:
+       ACPI_DEBUG_PRINT_RAW((ACPI_DB_INFO, "ACPI: BIOS _OSI(%s)
 %ssupported\n",
+               string_desc->string.pointer,
+               return_desc->integer.value == 0 ? "not-" : ""));
 
-       return_desc->integer.value = 0;
       return_ACPI_STATUS(AE_OK);

}

--
1.6.1.2.319.gbd9e

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
In reply to Len Brown

Done, for the next release of ACPICA. Available in the git tree now.

I also removed a couple of the uses of DB_INFO that were too verbose.

Quoted 19 lines

-----Original Message-----
From: [email protected] [mailto:linux-acpi- [email protected]] On Behalf Of Len Brown
Sent: Tuesday, February 03, 2009 3:18 PM
To: [email protected]
Cc: [email protected]
Subject: [PATCH] ACPICA: add debug dump of BIOS _OSI strings

Bob,
I'd like to make this minor change to the (linuxized) ACPICA code, for it can tell us a little about the BIOS w/o having the user go to the trouble to dump the tables etc.

If you made this change in the upstream ACPICA code, then that would be dandy.

thanks,
-Len