RAMDISK: Remove long-deprecated "ramdisk=" boot-time
Subsystems (3)
PATCH 1/1 RAMDISK: Remove long-deprecated "ramdisk=" boot-time
The "ramdisk" parameter was removed from the defunct rd.c file quite some time ago, in favour of the more specific "ramdisk_size" parameter so, for consistency, the same should be done here.
---
the earlier removal was in fac8b209b1084bc85748bd54e13d00c1262b220f.
drivers/block/brd.c +1 -6
@@ -407,12 +407,7 @@ static int __init ramdisk_size(char *str) rd_size =simple_strtol (str,NULL ,0 ); return 1; } -static int __init ramdisk_size2 (char *str) -{ -return ramdisk_size (str); -} -__setup ("ramdisk=" , ramdisk_size); -__setup ("ramdisk_size=" , ramdisk_size2); +__setup ("ramdisk_size=" , ramdisk_size);#endif /*
====================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca Linked In: http://www.linkedin.com/in/rpjday Twitter: http://twitter.com/rpjday
====================================
Quoted 19 lines · Robert P. J. Day
The "ramdisk" parameter was removed from the defunct
rd.cfile quite some time ago, in favour of the more specific "ramdisk_size" parameter so, for consistency, the same should be done here.Signed-off-by Robert P. J. Day <[email protected]>---
the earlier removal was in
fac8b209b1084bc85748bd54e13d00c1262b220f.drivers/block/brd.c +0
-0@@ -407,12 +407,7 @@ static int __init ramdisk_size(char *str) rd_size =simple_strtol (str,NULL ,0 );return 1 ; }
drivers/block/brd.c static int __init ramdisk_size(char *str) · line 413
Quoted 10 lines
drivers/block/brd.c +1
-6-static int __init ramdisk_size2 (char *str) -{ -return ramdisk_size (str); -} -__setup ("ramdisk=" , ramdisk_size); -__setup ("ramdisk_size=" , ramdisk_size2); +__setup ("ramdisk_size=" , ramdisk_size);#endif /*
i do not use this parameter but people will be confused if it suddenly vanish. IMHO it would be better to add something like
printk(KERN_ERR "'ramdisk=' will be removed with kernel 2.6.35 ....";
pleae note there is a clear kernel number what will put pressure on everyone really to remove the parameter.
just my two cents,
wh
Quoted 35 lines · walter harms
Quoted 19 lines · Robert P. J. Day
The "ramdisk" parameter was removed from the defunct
rd.cfile quite some time ago, in favour of the more specific "ramdisk_size" parameter so, for consistency, the same should be done here.Signed-off-by Robert P. J. Day <[email protected]>---
the earlier removal was in
fac8b209b1084bc85748bd54e13d00c1262b220f.drivers/block/brd.c +0
-0@@ -407,12 +407,7 @@ static int __init ramdisk_size(char *str) rd_size =simple_strtol (str,NULL ,0 );return 1 ; }drivers/block/brd.c static int __init ramdisk_size(char *str) · line 413
Quoted 10 lines
drivers/block/brd.c +1
-6-static int __init ramdisk_size2 (char *str) -{ -return ramdisk_size (str); -} -__setup ("ramdisk=" , ramdisk_size); -__setup ("ramdisk_size=" , ramdisk_size2); +__setup ("ramdisk_size=" , ramdisk_size);#endif /* i do not use this parameter but people will be confused if it suddenly vanish. IMHO it would be better to add something like
Quoted 7 lines
printk(KERN_ERR "'ramdisk=' will be removed with kernel 2.6.35 ....";
pleae note there is a clear kernel number what will put pressure on everyone really to remove the parameter.
just my two cents,
wh
that deprecated parameter was removed entirely in an earlier patch i
submitted (see above), and everyone signed off on it. so it seems unlikely to cause major problems to remove it a second time after it was re-introduced, but i'll leave that decision to others.
rday
--
====================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Annoying Kernel Pedantry.
Web page: http://crashcourse.ca Linked In: http://www.linkedin.com/in/rpjday Twitter: http://twitter.com/rpjday
====================================
Re: [PATCH] RAMDISK: Remove long-deprecated "ramdisk=" boot-time param.
In reply to Robert P. J. DayQuoted 42 lines · Robert P. J. Day
Quoted 40 lines · walter harms
Quoted 19 lines · Robert P. J. Day
The "ramdisk" parameter was removed from the defunct
rd.cfile quite some time ago, in favour of the more specific "ramdisk_size" parameter so, for consistency, the same should be done here.Signed-off-by Robert P. J. Day <[email protected]>---
the earlier removal was in
fac8b209b1084bc85748bd54e13d00c1262b220f.drivers/block/brd.c +0
-0@@ -407,12 +407,7 @@ static int __init ramdisk_size(char *str) rd_size =simple_strtol (str,NULL ,0 );return 1 ; }drivers/block/brd.c static int __init ramdisk_size(char *str) · line 413
Quoted 10 lines
drivers/block/brd.c +1
-6-static int __init ramdisk_size2 (char *str) -{ -return ramdisk_size (str); -} -__setup ("ramdisk=" , ramdisk_size); -__setup ("ramdisk_size=" , ramdisk_size2); +__setup ("ramdisk_size=" , ramdisk_size);#endif /* i do not use this parameter but people will be confused if it suddenly vanish. IMHO it would be better to add something like
printk(KERN_ERR "'ramdisk=' will be removed with kernel 2.6.35 ....";
pleae note there is a clear kernel number what will put pressure on everyone really to remove the parameter.
Quoted 7 lines
Quoted 2 lines
just my two cents,
whthat deprecated parameter was removed entirely in an earlier patch i
submitted (see above), and everyone signed off on it. so it seems unlikely to cause major problems to remove it a second time after it was re-introduced, but i'll leave that decision to others.
OK, the commit to remove that must have gone in concurently to my rewrite, because I just copied those parameters.
It probably takes all of a couple of bytes, of init text at that. But since you'd already got that patch in to remove it completely, and fixed up the documentation...
Do you care to send it to Linus?