Skip to contentSkip to conversation

Increase MAX_STACK_TRACE_ENTRIES

PATCH In review John Kacur 2 participants 2 messages Sep 21, 2009 – Sep 22, 2009

lore
Share & tools
lore

John Kacur

author
#0 lore raw

PATCH 1/1 Increase MAX_STACK_TRACE_ENTRIES

Ingo: please consider this patch if there are no negative consequences to increasing this value. It fixes a problem that we have seen in the past on (at least) the real-time kernel. (BUG: MAX_STACK_TRACE_ENTRIES).

This patch applies to the current tip/master

Thank You

Author: Clark Williams <[email protected]>
Date: Mon, 21 Sep 2009 18:29:30 +0200
Subject: [PATCH] Increase MAX_STACK_TRACE_ENTRIES to compensate for lockdep and debug options eating up backtrace slots.

---
 kernel/lockdep_internals.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/lockdep_internals.h +1 -1
index a2ee95a..953745c 100644
@@ -65,7 +65,7 @@ enum {
  * Stack-trace: tightly packed array of stack backtrace
  * addresses. Protected by the hash_lock.
  */
-#define MAX_STACK_TRACE_ENTRIES	262144UL
+#define MAX_STACK_TRACE_ENTRIES	393216UL
 
 extern struct list_head all_lock_classes;
 extern struct lock_chain lock_chains[];
Signature · 1 line
1.6.0.6
#1 lore raw
Quoted 5 lines · John Kacur

Ingo: please consider this patch if there are no negative consequences to increasing this value. It fixes a problem that we have seen in the past on (at least) the real-time kernel. (BUG: MAX_STACK_TRACE_ENTRIES).

This patch applies to the current tip/master

Hrmm,.. this is growing to be very large indeed.

It would be nice to know where all these extra entries are coming from. How large are:

# cat /proc/lockdep | grep -v -e "\->" -e "^$" | wc -l
437
# cat /proc/lockdep | grep -v -e "\->" -e "^$" | awk '{print $6}' | 
                      tr -d ".:" | grep -v "^$" | wc -c
1031

On your machine?

Quoted 2 lines
kernel/lockdep_internals.h +1 -1
-#define MAX_STACK_TRACE_ENTRIES	262144UL
+#define MAX_STACK_TRACE_ENTRIES	393216UL