Skip to contentSkip to conversation

difference between V_PROMPT and CONFIG_SYS_PROMPT?

U-Boot Robert P. J. Day 2 participants 3 messages Nov 19, 2009 – Dec 8, 2009

lore
Share & tools
lore
#0 lore raw

another beginner-level question, i'm sure, but what's the
distinction between V_PROMPT and CONFIG_SYS_PROMPT for customizing the u-boot prompt?

based on the output from a straightforward grep, it appears that
every example of customizing the prompt has the form:

#define V_PROMPT "OMAP3_EVM # "
... snip ...
#define CONFIG_SYS_PROMPT V_PROMPT

as in, V_PROMPT is set, for no other reason than to subsequently set CONFIG_SYS_PROMPT a few lines later, at which point V_PROMPT never seems to be used again.

is this just a historical holdover? any reason why
CONFIG_SYS_PROMPT can't be set directly and V_PROMPT ignored/removed?

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================

#1 lore raw

Dear "Robert P. J. Day",

Quoted 4 lines · In message <alpine.LFD.2.00.0911190255590.29408@localhost> you wrote:

another beginner-level question, i'm sure, but what's the
distinction between V_PROMPT and CONFIG_SYS_PROMPT for customizing the u-boot prompt?

The difference is that CONFIG_SYS_PROMPT (which probably should be renamed into CONFIG_PROMPT) is an official, documented configuration option, while V_PROMPT is a private and apparently redundant definition that should be removed.

Cleanup patches welcome.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Quantum Mechanics is God's version of "Trust me."
#2 lore raw
Quoted 8 lines · Wolfgang Denk

Dear "Robert P. J. Day",

Quoted 4 lines · In message <alpine.LFD.2.00.0911190255590.29408@localhost> you wrote:

another beginner-level question, i'm sure, but what's the
distinction between V_PROMPT and CONFIG_SYS_PROMPT for customizing the u-boot prompt?

Quoted 6 lines

The difference is that CONFIG_SYS_PROMPT (which probably should be renamed into CONFIG_PROMPT) is an official, documented configuration option, while V_PROMPT is a private and apparently redundant definition that should be removed.

Cleanup patches welcome.

submitted. if CONFIG_SYS_PROMPT really should be renamed, that can
be done in a followup patch as a separate logical action.

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================