Skip to contentSkip to conversation

Fix typo, "CFG_LONGHELP" -> "CONFIG_LONGHELP".

PATCH In review Robert P. J. Day 2 participants 3 messages Dec 22, 2009 – Dec 23, 2009

lore
Share & tools
lore

Robert P. J. Day

author
#0 lore raw

PATCH 1/1 Fix typo, "CFG_LONGHELP" -> "CONFIG_LONGHELP".

Signed-off-by Robert P. J. Day <[email protected]>

---

while this fixes an obvious typo in this file, it's really just a
band-aid since this header file sets *numerous* CONFIG_-prefixed macros, which it shouldn't be doing. any macros prefixed with CONFIG_ should be reserved for the Kconfig namespace, so it wouldn't hurt to apply this patch, but it's clear that this file needs a lot more work at some point in the future.

board/eco920/config.h +1 -1
index 3fb8beb..6f8f8ea 100644
@@ -112,7 +112,7 @@
 
 #define CFG_BAUDRATE_TABLE	{115200 , 19200, 38400, 57600, 9600 }
 
-#define	CFG_LONGHELP				/* undef to save memory		*/
+#define	CONFIG_LONGHELP				/* undef to save memory		*/
 #define CFG_PROMPT		"barebox> "	/* Monitor Command Prompt */
 #define CFG_CBSIZE		1024		/* Console I/O Buffer Size */
 #define CFG_MAXARGS		32		/* max number of command args */

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

#1 lore raw

Hi Robert,

Quoted 11 lines · Robert P. J. Day
Signed-off-by Robert P. J. Day <[email protected]>

---

while this fixes an obvious typo in this file, it's really just a
band-aid since this header file sets *numerous* CONFIG_-prefixed macros, which it shouldn't be doing. any macros prefixed with CONFIG_ should be reserved for the Kconfig namespace, so it wouldn't hurt to apply this patch, but it's clear that this file needs a lot more work at some point in the future.

I used the eco920 during early development. We maybe have the opportunity to work on this board in the next time and then I'll fix this. Otherwise I tend to remove the board completely.

Sascha

Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
author
#2 lore raw
Quoted 15 lines · Sascha Hauer

Hi Robert,

Quoted 11 lines · Robert P. J. Day
Signed-off-by Robert P. J. Day <[email protected]>

---

while this fixes an obvious typo in this file, it's really just
a band-aid since this header file sets *numerous* CONFIG_-prefixed macros, which it shouldn't be doing. any macros prefixed with CONFIG_ should be reserved for the Kconfig namespace, so it wouldn't hurt to apply this patch, but it's clear that this file needs a lot more work at some point in the future.

Quoted 3 lines

I used the eco920 during early development. We maybe have the opportunity to work on this board in the next time and then I'll fix this. Otherwise I tend to remove the board completely.

no problem. don't think you need to explain dropping any patch
submissions from me -- obviously, i don't know the history of the software. whatever you decide.

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox