Skip to contentSkip to conversation

still worth running kernel cleanup scripts after merge windows?

DISCUSSION Robert P. J. Day 2 participants 3 messages Mar 8, 2010 – Mar 9, 2010

lore
Share & tools
lore
#0 lore raw

just curious if there's still value in running my kernel scanning
scripts after each merge window closes and posting results. there's still a fair bit of inconsistency and mismatches in the Kconfig files.

as a single example, here's a snippet from the
drivers/message/fusion directory, identifying an apparently bad reference to a non-existent CONFIG variable:

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

FUSION_MAX_FC_SGE

drivers/message/fusion/mptbase.h:179:#ifdef CONFIG_FUSION_MAX_FC_SGE drivers/message/fusion/mptbase.h:180:#if CONFIG_FUSION_MAX_FC_SGE < 16 drivers/message/fusion/mptbase.h:182:#elif CONFIG_FUSION_MAX_FC_SGE > 256 drivers/message/fusion/mptbase.h:185:#define MPT_SCSI_FC_SG_DEPTH CONFIG_FUSION_MAX_FC_SGE

but there is no such Kconfig variable FUSION_MAX_FC_SGE. however:

$ grep -r FUSION_MAX drivers/message/fusion
drivers/message/fusion/Kconfig:config FUSION_MAX_SGE
drivers/message/fusion/mptbase.h:#ifdef CONFIG_FUSION_MAX_SGE
drivers/message/fusion/mptbase.h:#if CONFIG_FUSION_MAX_SGE  < 16
drivers/message/fusion/mptbase.h:#elif CONFIG_FUSION_MAX_SGE  > 128
drivers/message/fusion/mptbase.h:#define MPT_SCSI_SG_DEPTH	CONFIG_FUSION_MAX_SGE
drivers/message/fusion/mptbase.h:#ifdef CONFIG_FUSION_MAX_FC_SGE
drivers/message/fusion/mptbase.h:#if CONFIG_FUSION_MAX_FC_SGE  < 16
drivers/message/fusion/mptbase.h:#elif CONFIG_FUSION_MAX_FC_SGE  > 256
drivers/message/fusion/mptbase.h:#define MPT_SCSI_FC_SG_DEPTH	CONFIG_FUSION_MAX_FC_SGE
$

so is that a typo? should "FUSION_MAX_FC_SGE" really be just
"FUSION_MAX_SGE"? anyway, you get the idea. or maybe i should just put the scripts up at my wiki and people can run their at their leisure on whatever part of the source tree interests them.

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================

#1 lore raw
Quoted 4 lines · Robert P. J. Day

just curious if there's still value in running my kernel scanning
scripts after each merge window closes and posting results. there's still a fair bit of inconsistency and mismatches in the Kconfig files.

I say Yes.

Quoted 24 lines

as a single example, here's a snippet from the
drivers/message/fusion directory, identifying an apparently bad reference to a non-existent CONFIG variable:

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

FUSION_MAX_FC_SGE

drivers/message/fusion/mptbase.h:179:#ifdef CONFIG_FUSION_MAX_FC_SGE drivers/message/fusion/mptbase.h:180:#if CONFIG_FUSION_MAX_FC_SGE < 16 drivers/message/fusion/mptbase.h:182:#elif CONFIG_FUSION_MAX_FC_SGE > 256 drivers/message/fusion/mptbase.h:185:#define MPT_SCSI_FC_SG_DEPTH CONFIG_FUSION_MAX_FC_SGE

but there is no such Kconfig variable FUSION_MAX_FC_SGE. however:

$ grep -r FUSION_MAX drivers/message/fusion
drivers/message/fusion/Kconfig:config FUSION_MAX_SGE
drivers/message/fusion/mptbase.h:#ifdef CONFIG_FUSION_MAX_SGE
drivers/message/fusion/mptbase.h:#if CONFIG_FUSION_MAX_SGE  < 16
drivers/message/fusion/mptbase.h:#elif CONFIG_FUSION_MAX_SGE  > 128
drivers/message/fusion/mptbase.h:#define MPT_SCSI_SG_DEPTH	CONFIG_FUSION_MAX_SGE
drivers/message/fusion/mptbase.h:#ifdef CONFIG_FUSION_MAX_FC_SGE
drivers/message/fusion/mptbase.h:#if CONFIG_FUSION_MAX_FC_SGE  < 16
drivers/message/fusion/mptbase.h:#elif CONFIG_FUSION_MAX_FC_SGE  > 256
drivers/message/fusion/mptbase.h:#define MPT_SCSI_FC_SG_DEPTH	CONFIG_FUSION_MAX_FC_SGE
$
Quoted 4 lines

so is that a typo? should "FUSION_MAX_FC_SGE" really be just
"FUSION_MAX_SGE"? anyway, you get the idea. or maybe i should just put the scripts up at my wiki and people can run their at their leisure on whatever part of the source tree interests them.

Yes, please.

AFAIK, the fusion maintainer doesn't read lkml.

Please use MAINTAINERS:
LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI)
M: Eric Moore <[email protected]>
M: [email protected]
L: [email protected]
L: [email protected]
W: http://www.lsilogic.com/support
S: Supported
F: drivers/message/fusion/

Signature · 1 line
~Randy
#2 lore raw
Quoted 26 lines · Randy Dunlap
Quoted 24 lines · Robert P. J. Day

as a single example, here's a snippet from the
drivers/message/fusion directory, identifying an apparently bad reference to a non-existent CONFIG variable:

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

FUSION_MAX_FC_SGE

drivers/message/fusion/mptbase.h:179:#ifdef CONFIG_FUSION_MAX_FC_SGE drivers/message/fusion/mptbase.h:180:#if CONFIG_FUSION_MAX_FC_SGE < 16 drivers/message/fusion/mptbase.h:182:#elif CONFIG_FUSION_MAX_FC_SGE > 256 drivers/message/fusion/mptbase.h:185:#define MPT_SCSI_FC_SG_DEPTH CONFIG_FUSION_MAX_FC_SGE

but there is no such Kconfig variable FUSION_MAX_FC_SGE. however:

$ grep -r FUSION_MAX drivers/message/fusion
drivers/message/fusion/Kconfig:config FUSION_MAX_SGE
drivers/message/fusion/mptbase.h:#ifdef CONFIG_FUSION_MAX_SGE
drivers/message/fusion/mptbase.h:#if CONFIG_FUSION_MAX_SGE  < 16
drivers/message/fusion/mptbase.h:#elif CONFIG_FUSION_MAX_SGE  > 128
drivers/message/fusion/mptbase.h:#define MPT_SCSI_SG_DEPTH	CONFIG_FUSION_MAX_SGE
drivers/message/fusion/mptbase.h:#ifdef CONFIG_FUSION_MAX_FC_SGE
drivers/message/fusion/mptbase.h:#if CONFIG_FUSION_MAX_FC_SGE  < 16
drivers/message/fusion/mptbase.h:#elif CONFIG_FUSION_MAX_FC_SGE  > 256
drivers/message/fusion/mptbase.h:#define MPT_SCSI_FC_SG_DEPTH	CONFIG_FUSION_MAX_FC_SGE
$
Quoted 6 lines
Quoted 4 lines

so is that a typo? should "FUSION_MAX_FC_SGE" really be just
"FUSION_MAX_SGE"? anyway, you get the idea. or maybe i should just put the scripts up at my wiki and people can run their at their leisure on whatever part of the source tree interests them.

Yes, please.

http://www.crashcourse.ca/wiki/index.php/Kernel_cleanup_scripts

have fun. (only the first script is there at the moment, additional scripts to appear shortly.)

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================