Skip to contentSkip to conversation

KFIFO: kfifo_is_{full,empty} should return bools, not ints.

PATCH New Robert P. J. Day 1 participant 1 message Mar 14, 2010 Kfifo

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 KFIFO: kfifo_is_{full,empty} should return bools, not ints.

For consistency with other kfifo routines, return bool, not int.

---

include/linux/kfifo.h +2 -2
index bc0fc79..d6af6df 100644
@@ -172,7 +172,7 @@ static inline unsigned int kfifo_len(struct kfifo *fifo)
  * kfifo_is_empty - returns true if the fifo is empty
  * @fifo: the fifo to be used.
  */
-static inline __must_check int kfifo_is_empty(struct kfifo *fifo)
+static inline __must_check bool kfifo_is_empty(struct kfifo *fifo)
 {
 	return fifo->in == fifo->out;
 }
@@ -181,7 +181,7 @@ static inline __must_check int kfifo_is_empty(struct kfifo *fifo)
  * kfifo_is_full - returns true if the fifo is full
  * @fifo: the fifo to be used.
  */
-static inline __must_check int kfifo_is_full(struct kfifo *fifo)
+static inline __must_check bool kfifo_is_full(struct kfifo *fifo)
 {
 	return kfifo_len(fifo) == kfifo_size(fifo);
 }

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================