Skip to contentSkip to conversation

acpi_pad: "processor_aggregator" name too long

PATCH Applied [email protected] 2 participants 2 messages Apr 27, 2010 – May 1, 2010 ACPI

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 4/4 acpi_pad: "processor_aggregator" name too long

From: Dan Carpenter <[email protected]>

cpi_device_class can only be 19 characters and a NULL terminator.

With the current name we get a buffer overflow in acpi_pad_add()

	strcpy(acpi_device_class(device), ACPI_PROCESSOR_AGGREGATOR_CLASS);
[[email protected]: call it acpi_pad, per Shaohua Li]
Signed-off-by Dan Carpenter <[email protected]>
Cc walter harms <[email protected]>
Cc Shaohua Li <[email protected]>
Cc Len Brown <[email protected]>
Acked-by Pavel Machek <[email protected]>
Signed-off-by Andrew Morton <[email protected]>

---

 drivers/acpi/acpi_pad.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/acpi_pad.c renamed from drivers/acpi/acpi_pad.c~acpi_pad-processor_aggregator-name-too-long +1 -1
diff -puN drivers/acpi/acpi_pad.c~acpi_pad-processor_aggregator-name-too-long drivers/acpi/acpi_pad.c
@@ -31,7 +31,7 @@
 #include <acpi/acpi_bus.h>
 #include <acpi/acpi_drivers.h>
 
-#define ACPI_PROCESSOR_AGGREGATOR_CLASS	"processor_aggregator"
+#define ACPI_PROCESSOR_AGGREGATOR_CLASS	"acpi_pad"
 #define ACPI_PROCESSOR_AGGREGATOR_DEVICE_NAME "Processor Aggregator"
 #define ACPI_PROCESSOR_AGGREGATOR_NOTIFY 0x80
 static DEFINE_MUTEX(isolated_cpus_lock);

_

reviewer Applied
#1 lore raw

applied

thanks,
Len Brown, Intel Open Source Technology Center