Skip to contentSkip to conversation

x86: unify current 3 similar ways of saving IRQ info

PATCH Thomas Gleixner 1 participant 3 messages May 17, 2010 3 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20100517153156.4439d62b@feng-i7

#1 lore raw
Quoted 2 lines · Feng Tang

-static void __init assign_to_mp_irq(struct mpc_intsrc *m,

Why are you removing __init ?

Review static void __init assign_to_mpc_intsrc(struct mpc_intsrc *mp_irq, · line 194

Quoted 11 lines
(quoted diff) +2 -1
+static void assign_to_mp_irq(struct mpc_intsrc *m,
 				    struct mpc_intsrc *mp_irq)
 {
 	mp_irq->dstapic = m->dstapic;
@@ -190,7 +190,7 @@ static void __init assign_to_mpc_intsrc(struct mpc_intsrc *mp_irq,
 	m->dstirq = mp_irq->dstirq;
 }
 
-static int __init mp_irq_mpc_intsrc_cmp(struct mpc_intsrc *mp_irq,
+static int mp_irq_mpc_intsrc_cmp(struct mpc_intsrc *mp_irq,
 					struct mpc_intsrc *m)

Ditto

Review static int __init mp_irq_mpc_intsrc_cmp(struct mpc_intsrc *mp_irq, · line 215

Quoted 9 lines
(quoted diff) +2 -1
 {
 	if (mp_irq->dstapic != m->dstapic)
@@ -211,7 +211,8 @@ static int __init mp_irq_mpc_intsrc_cmp(struct mpc_intsrc *mp_irq,
 	return 0;
 }
 
-static void __init MP_intsrc_info(struct mpc_intsrc *m)
+/* Will also be called in acpi/sfi related code */
+void mp_save_irq(struct mpc_intsrc *m)

Again, this code is called from __init context only and should stay __init.

Thanks,

tglx

A message that is not in the archive (sent off-list or not yet received): 20100517162521.6fc93552@feng-i7

#3 lore raw
Quoted 18 lines · Feng Tang
Quoted 8 lines · On Mon, 17 May 2010 16:07:05 +0800 Thomas Gleixner <[email protected]> wrote:
Quoted 6 lines · Feng Tang

{

(quoted diff) +0 -0
 	if (mp_irq->dstapic != m->dstapic)
@@ -211,7 +211,8 @@ static int __init mp_irq_mpc_intsrc_cmp(struct
 mpc_intsrc *mp_irq, return 0;
 }
 
Quoted 6 lines

Review static int __init mp_irq_mpc_intsrc_cmp(struct · line 215

Quoted 3 lines
(quoted diff) +2 -1
-static void __init MP_intsrc_info(struct mpc_intsrc *m)
+/* Will also be called in acpi/sfi related code */
+void mp_save_irq(struct mpc_intsrc *m)

Again, this code is called from __init context only and should stay __init.

Quoted 4 lines

Hi Thomas,

The reason I removed the __init is it will be called by non __init functions from acpi/boot.c and mrst.c

Why should that happen ?

Thanks,

tglx

A message that is not in the archive (sent off-list or not yet received): 20100517164244.3fc80d60@feng-i7

#5 lore raw
Quoted 25 lines · Feng Tang
Quoted 22 lines · On Mon, 17 May 2010 16:16:40 +0800 Thomas Gleixner <[email protected]> wrote:
Quoted 20 lines · Feng Tang
Quoted 8 lines · On Mon, 17 May 2010 16:07:05 +0800 Thomas Gleixner <[email protected]> wrote:
Quoted 6 lines · Feng Tang

{

(quoted diff) +0 -0
 	if (mp_irq->dstapic != m->dstapic)
@@ -211,7 +211,8 @@ static int __init
 mp_irq_mpc_intsrc_cmp(struct mpc_intsrc *mp_irq, return 0;
 }
 
Quoted 6 lines

Review static int __init · line 215

Quoted 3 lines
(quoted diff) +2 -1
-static void __init MP_intsrc_info(struct mpc_intsrc *m)
+/* Will also be called in acpi/sfi related code */
+void mp_save_irq(struct mpc_intsrc *m)

Again, this code is called from __init context only and should
stay __init.

Hi Thomas,

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

The reason I removed the __init is it will be called by non __init functions from acpi/boot.c and mrst.c

Why should that happen ?

The place calling this API from mrst.c should be changed to __init, for acpi, it will be called by acpi_register_gsi(), which is exported out and used by several places in drivers/

Ok, missed the acpi_register_gsi() context.

Thanks,

tglx