PNP: log PNP resources, as we do for PCI
Subsystems (2)
PATCH 1/1 PNP: log PNP resources, as we do for PCI
I fat-fingered the linux-acpi address, sorry.
---------- Forwarded Message ----------
Subject: [PATCH] PNP: log PNP resources, as we do for PCI
Date: Wednesday, September 29, 2010, 12:23:58 pm
From: Bjorn Helgaas <[email protected]>
To: Len Brown <[email protected]>
CC: [email protected], Adam Belay <[email protected]>
ACPI devices are often involved in address space conflicts with PCI devices, so I think it's worth logging the resources they use. Otherwise we have to depend on lspnp or groping around in sysfs to find them.
Signed-off-by Bjorn Helgaas <[email protected]>
---
drivers/pnp/core.c | 5 +++-- drivers/pnp/resource.c | 10 +++++----- 2 files changed, 8 insertions(+), 7 deletions(-)
drivers/pnp/core.c +3 -2
@@ -194,8 +194,9 @@ int pnp_add_device(struct pnp_dev *dev)for (id = dev->id; id; id = id->next) len +=scnprintf (buf + len,sizeof (buf) - len," %s" , id->id); -pnp_dbg (&dev->dev,"%s device, IDs%s (%s)\n" , - dev->protocol->name, buf, dev->active ?"active" :"disabled" ); +dev_printk (KERN_DEBUG , &dev->dev,"%s device, IDs%s (%s)\n" , + dev->protocol->name, buf, + dev->active ?"active" :"disabled" );return 0 ; }
drivers/pnp/resource.c +5 -5
@@ -523,7 +523,7 @@ struct pnp_resource *pnp_add_irq_resource(struct pnp_dev *dev, int irq, res->start = irq; res->end = irq; -pnp_dbg (&dev->dev," add %pr\n" , res); +dev_printk (KERN_DEBUG , &dev->dev,"%pR\n" , res);return pnp_res; }
@@ -544,7 +544,7 @@ struct pnp_resource *pnp_add_dma_resource(struct pnp_dev *dev, int dma, res->start = dma; res->end = dma; -pnp_dbg (&dev->dev," add %pr\n" , res); +dev_printk (KERN_DEBUG , &dev->dev,"%pR\n" , res);return pnp_res; }
@@ -568,7 +568,7 @@ struct pnp_resource *pnp_add_io_resource(struct pnp_dev *dev, res->start = start; res->end = end; -pnp_dbg (&dev->dev," add %pr\n" , res); +dev_printk (KERN_DEBUG , &dev->dev,"%pR\n" , res);return pnp_res; }
@@ -592,7 +592,7 @@ struct pnp_resource *pnp_add_mem_resource(struct pnp_dev *dev, res->start = start; res->end = end; -pnp_dbg (&dev->dev," add %pr\n" , res); +dev_printk (KERN_DEBUG , &dev->dev,"%pR\n" , res);return pnp_res; }
@@ -616,7 +616,7 @@ struct pnp_resource *pnp_add_bus_resource(struct pnp_dev *dev, res->start = start; res->end = end; -pnp_dbg (&dev->dev," add %pr\n" , res); +dev_printk (KERN_DEBUG , &dev->dev,"%pR\n" , res);return pnp_res; }
-----------------------------------------
Len Brown
reviewerapplied to acpi-test
thanks,
Len Brown, Intel Open Source Technology Center