ext3/4: remove some unnecessary comments
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 ext3/4: remove some unnecessary comments
The comments in the code are unnecessary, because every generic_file_write() is replaced by generic_file_aio_write().
--- fs/ext3/inode.c | 4 ---- fs/ext4/inode.c | 4 ---- 2 files changed, 8 deletions(-)
fs/ext3/inode.c +0 -4
@@ -3212,10 +3212,6 @@ out_brelse:* * We are called from a few places: * -* - Within generic_file_write() for O_SYNC files. -* Here, there will be no transaction running. We wait for any running -* transaction to commit. -* * - Within sys_sync(), kupdate and such. * We wait on commit, if tol to. *
fs/ext4/inode.c +0 -4
@@ -4399,10 +4399,6 @@ out_brelse:* * We are called from a few places: * -* - Within generic_file_write() for O_SYNC files. -* Here, there will be no transaction running. We wait for any running -* transaction to commit. -* * - Within sys_sync(), kupdate and such. * We wait on commit, if tol to. *
Signature · 4 lines
1.8.1.4 .
Quoted 8 lines · ZhangZhen
Date: Thu, 27 Feb 2014 17:26:09 +0800
From: ZhangZhen <[email protected]>
To: [email protected], [email protected]
Cc: [email protected]
Subject: [PATCH] ext3/4: remove some unnecessary commentsThe comments in the code are unnecessary, because every
generic_file_write()is replaced bygeneric_file_aio_write().
I am sorry I do not understand. Is it unnecessary or wrong ? If it's wrong why it is wrong ?
Your description suggests that this should be changed to mention generic_file_aio_write() rather than generic_file_write().
Thanks!
-Lukas
Quoted 38 lines
Signed-off-by Zhang Zhen <[email protected]>--- fs/ext3/inode.c | 4 ---- fs/ext4/inode.c | 4 ---- 2 files changed, 8 deletions(-)fs/ext3/inode.c +0
-4@@ -3212,10 +3212,6 @@ out_brelse:* * We are called from a few places: * -* - Within generic_file_write() for O_SYNC files. -* Here, there will be no transaction running. We wait for any running -* transaction to commit. -* * - Within sys_sync(), kupdate and such. * We wait on commit, if tol to. * fs/ext4/inode.c +0
-4@@ -4399,10 +4399,6 @@ out_brelse:* * We are called from a few places: * -* - Within generic_file_write() for O_SYNC files. -* Here, there will be no transaction running. We wait for any running -* transaction to commit. -* * - Within sys_sync(), kupdate and such. * We wait on commit, if tol to. *
Quoted 11 lines · Lukáš Czerner
Quoted 8 lines · ZhangZhen
Date: Thu, 27 Feb 2014 17:26:09 +0800
From: ZhangZhen <[email protected]>
To: [email protected], [email protected]
Cc: [email protected]
Subject: [PATCH] ext3/4: remove some unnecessary commentsThe comments in the code are unnecessary, because every
generic_file_write()is replaced bygeneric_file_aio_write().
Quoted 9 lines
I am sorry I do not understand. Is it unnecessary or wrong ? If it's wrong why it is wrong ?
Your description suggests that this should be changed to mention
generic_file_aio_write()rather thangeneric_file_write().Thanks!
-Lukas
Thanks for reviewing!
Here should be changed to mention generic_file_aio_write() rather than generic_file_write().
I will modify this patch for V2.
Quoted 30 lines
Quoted 30 lines
Signed-off-by Zhang Zhen <[email protected]>--- fs/ext3/inode.c | 4 ---- fs/ext4/inode.c | 4 ---- 2 files changed, 8 deletions(-)fs/ext3/inode.c +0
-4@@ -3212,10 +3212,6 @@ out_brelse:* * We are called from a few places: * -* - Within generic_file_write() for O_SYNC files. -* Here, there will be no transaction running. We wait for any running -* transaction to commit. -* * - Within sys_sync(), kupdate and such. * We wait on commit, if tol to. * fs/ext4/inode.c +0
-0@@ -4399,10 +4399,6 @@ out_brelse:* * We are called from a few places: *
Quoted 10 lines
fs/ext4/inode.c out_brelse: · line 4404
Quoted 8 lines
fs/ext4/inode.c +0
-4-* - Within generic_file_write() for O_SYNC files. -* Here, there will be no transaction running. We wait for any running -* transaction to commit. -* * - Within sys_sync(), kupdate and such. * We wait on commit, if tol to. *
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html