Skip to contentSkip to conversation

bootm.c: "-o" option should refer to "DTB", not "DTS"

PATCH Applied Robert P. J. Day 2 participants 2 messages Jul 4, 2014 – Jul 7, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bootm.c: "-o" option should refer to "DTB", not "DTS"

Fix option explanation, and a couple grammar fixes.

---

unless i misread this, the bootm "-o" option should take a DTB
argument, not a DTS, yes? and since i was there, a couple trivial grammar fixes.

commands/bootm.c +3 -3
index 617acd6..a65864a 100644
@@ -143,7 +143,7 @@ err_out:
 BAREBOX_CMD_HELP_START(bootm)
 BAREBOX_CMD_HELP_TEXT("Options:")
 BAREBOX_CMD_HELP_OPT ("-c\t",  "crc check uImage data")
-BAREBOX_CMD_HELP_OPT ("-d\t",  "dryrun: check data, but do not run")
+BAREBOX_CMD_HELP_OPT ("-d\t",  "dry run: check data, but do not run")
 BAREBOX_CMD_HELP_OPT ("-f\t",  "load images even if type is undetectable")
 #ifdef CONFIG_CMD_BOOTM_INITRD
 BAREBOX_CMD_HELP_OPT ("-r INITRD","specify an initrd image")
@@ -152,7 +152,7 @@ BAREBOX_CMD_HELP_OPT ("-L ADDR\t","specify initrd load address")
 BAREBOX_CMD_HELP_OPT ("-a ADDR\t","specify os load address")
 BAREBOX_CMD_HELP_OPT ("-e OFFS\t","entry point to the image relative to start (0)")
 #ifdef CONFIG_OFTREE
-BAREBOX_CMD_HELP_OPT ("-o DTS\t","specify open firmware device tree")
+BAREBOX_CMD_HELP_OPT ("-o DTB\t","specify open firmware device tree")
 #endif
 #ifdef CONFIG_CMD_BOOTM_VERBOSE
 BAREBOX_CMD_HELP_OPT ("-v\t","verbose")
@@ -178,7 +178,7 @@ BAREBOX_CMD_START(bootm)
 	BAREBOX_CMD_HELP(cmd_bootm_help)
 BAREBOX_CMD_END
 
-BAREBOX_MAGICVAR(bootargs, "Linux Kernel parameters");
+BAREBOX_MAGICVAR(bootargs, "Linux kernel parameters");
 BAREBOX_MAGICVAR_NAMED(global_bootm_image, global.bootm.image, "bootm default boot image");
 BAREBOX_MAGICVAR_NAMED(global_bootm_image_loadaddr, global.bootm.image.loadaddr, "bootm default boot image loadaddr");
 BAREBOX_MAGICVAR_NAMED(global_bootm_initrd, global.bootm.initrd, "bootm default initrd");
Signature · 12 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Applied
#1 lore raw
Quoted 10 lines · Robert P. J. Day

Fix option explanation, and a couple grammar fixes.

---

unless i misread this, the bootm "-o" option should take a DTB
argument, not a DTS, yes? and since i was there, a couple trivial grammar fixes.

Yes, bootm doesn't take DTS files, it always needs a dtb.

Applied, thanks

Sascha

Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox