two variations for distro-specific FILESEXTRAPATHS prepending
just ran across this in the meta-yocto layer but it's a general OE
question -- the psplash_git.bbappend file contains the following distro-conditional line:
FILESEXTRAPATHS_prepend_poky := "${THISDIR}/files:"and the accompanying files/ directory has, unsurprisingly, a poky-specific splash image file, "psplash-poky-img.h".
but based on how FILESEXTRAPATHS is processed by incorporating all
of the FILESOVERRIDES variations (one of which is the distro name), would it not have been entirely equivalent to have used simply
FILESEXTRAPATHS_prepend := "${THISDIR}/files:"and placed that splash file in the accompanying directory files/poky/? would these two approaches do the same thing? is there a preferred way? that's the only example of that i've seen in all the layers i've played with.
rday
Signature · 7 lines
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================Quoted 13 lines · Robert P. J. Day
just ran across this in the meta-yocto layer but it's a general OE
question -- the psplash_git.bbappend file contains the following distro-conditional line:FILESEXTRAPATHS_prepend_poky := "${THISDIR}/files:"and the accompanying files/ directory has, unsurprisingly, a poky-specific splash image file, "
psplash-poky-img.h".but based on how FILESEXTRAPATHS is processed by incorporating all
of the FILESOVERRIDES variations (one of which is the distro name), would it not have been entirely equivalent to have used simply
Quoted 7 lines
FILESEXTRAPATHS_prepend := "${THISDIR}/files:"and placed that splash file in the accompanying directory files/poky/? would these two approaches do the same thing? is there a preferred way? that's the only example of that i've seen in all the layers i've played with.
Both would do the same thing, I'm personally of the opinion that the latter would be more consistent with how such things are normally done.
Signature · 5 lines
Christopher Larson clarson at kergoth dot com Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics
Quoted 23 lines · Christopher Larson
On Wed, Jul 16, 2014 at 4:26 AM, Robert P. J. Day <[email protected]> wrote:
just ran across this in the meta-yocto layer but it's a general OE question -- the psplash_git.bbappend file contains the following distro-conditional line:
FILESEXTRAPATHS_prepend_poky:= "${THISDIR}/files:"and the accompanying files/ directory has, unsurprisingly, a poky-specific splash image file, "
psplash-poky-img.h".but based on how FILESEXTRAPATHS is processed by incorporating all of the FILESOVERRIDES variations (one of which is the distro name), would it not have been entirely equivalent to have used simply
FILESEXTRAPATHS_prepend:= "${THISDIR}/files:"and placed that splash file in the accompanying directory files/poky/? would these two approaches do the same thing? is there a preferred way? that's the only example of that i've seen in all the layers i've played with.
Quoted 3 lines
Both would do the same thing, I'm personally of the opinion that the latter would be more consistent with how such things are normally done.
i was ready to bet internal organs that they had the same effect,
but i've perused the OE code base enough that i trip over oddities and i just really want to make sure i know what i'm looking at.
rday
p.s. if someone wants to submit a poky patch that changes that, feel free. otherwise, i'll just use it in class as a "check out what someone did *here*!" example. :-)
Signature · 7 lines
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================