staging wlan-ng: Add missing a blank line after declarations
PATCH 1/1 staging wlan-ng: Add missing a blank line after declarations
Fixing trivial checkpatch warnings about missing line after declarations
--- drivers/staging/wlan-ng/hfa384x.h | 3 +++ 1 file changed, 3 insertions(+)
drivers/staging/wlan-ng/hfa384x.h +3 -0
@@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void *buf, u16 len);static inline int hfa384x_drvr_getconfig16 (hfa384x_t *hw,u16 rid,void *val) {int result =0 ; + result =hfa384x_drvr_getconfig (hw, rid, val,sizeof (u16));if (result ==0 ) *((u16 *) val) =le16_to_cpu (*((u16 *) val));
@@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)static inline int hfa384x_drvr_setconfig16 (hfa384x_t *hw,u16 rid,u16 val) {u16 value =cpu_to_le16 (val); +return hfa384x_drvr_setconfig (hw, rid, &value,sizeof (value)); }
@@ -1402,6 +1404,7 @@ static inline int hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val) {u16 value =cpu_to_le16 (val); +return hfa384x_drvr_setconfig_async (hw, rid, &value,sizeof (value),NULL ,NULL ); }
Signature · 1 line
1.9.1
PATCH 1/1 staging wlan-ng: Add missing a blank line after declarations
Quoted 29 lines · Nicholas Krause
Fixing trivial checkpatch warnings about missing line after declarations
Signed-off-by Nicholas Krause <[email protected]>--- drivers/staging/wlan-ng/hfa384x.h | 3 +++ 1 file changed, 3 insertions(+)drivers/staging/wlan-ng/hfa384x.h +2
-0@@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void *buf, u16 len);static inline int hfa384x_drvr_getconfig16 (hfa384x_t *hw,u16 rid,void *val) {int result =0 ; + result =hfa384x_drvr_getconfig (hw, rid, val,sizeof (u16));if (result ==0 ) *((u16 *) val) =le16_to_cpu (*((u16 *) val));@@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)static inline int hfa384x_drvr_setconfig16 (hfa384x_t *hw,u16 rid,u16 val) {u16 value =cpu_to_le16 (val); +return hfa384x_drvr_setconfig (hw, rid, &value,sizeof (value)); }
drivers/staging/wlan-ng/hfa384x.h static inline int · line 1410
Quoted 7 lines
drivers/staging/wlan-ng/hfa384x.h +1
-0@@ -1402,6 +1404,7 @@ static inline int hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val) {u16 value =cpu_to_le16 (val); +return hfa384x_drvr_setconfig_async (hw, rid, &value,sizeof (value),NULL ,NULL ); }
I checked this patch and there seems to be issues that any of you have stated before after not applying or grammar e.t.c. If there are any other errors I am missing please let me known. Nick
PATCH 1/1 staging wlan-ng: Add missing a blank line after declarations
Quoted 2 lines · nick
I checked this patch and there seems to be issues that any of you have stated before after not applying or grammar
e.t.c.
If there seem to be issues, why did you bother posting it?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 848 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140916/b5633977/attachment.bin
PATCH 1/1 staging wlan-ng: Add missing a blank line after declarations
In reply to Nicholas Krause and for a third (fourth?) time, unable to use proper grammar in the
commit message. shocked ... shocked, i am.
rday
Signature · 7 lines
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================PATCH 1/1 staging wlan-ng: Add missing a blank line after declarations
In reply to Nicholas KrauseQuoted 28 lines · Nicholas Krause
Fixing trivial checkpatch warnings about missing line after declarations
Signed-off-by Nicholas Krause <[email protected]>--- drivers/staging/wlan-ng/hfa384x.h | 3 +++ 1 file changed, 3 insertions(+)drivers/staging/wlan-ng/hfa384x.h +2
-0@@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void *buf, u16 len);static inline int hfa384x_drvr_getconfig16 (hfa384x_t *hw,u16 rid,void *val) {int result =0 ; + result =hfa384x_drvr_getconfig (hw, rid, val,sizeof (u16));if (result ==0 ) *((u16 *) val) =le16_to_cpu (*((u16 *) val));@@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)static inline int hfa384x_drvr_setconfig16 (hfa384x_t *hw,u16 rid,u16 val) {u16 value =cpu_to_le16 (val); +return hfa384x_drvr_setconfig (hw, rid, &value,sizeof (value)); }
drivers/staging/wlan-ng/hfa384x.h static inline int · line 1410
Quoted 7 lines
drivers/staging/wlan-ng/hfa384x.h +1
-0@@ -1402,6 +1404,7 @@ static inline int hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val) {u16 value =cpu_to_le16 (val); +return hfa384x_drvr_setconfig_async (hw, rid, &value,sizeof (value),NULL ,NULL ); }
for the benefit of other kernel newbies who would, some day, like to
get some patches into the linux kernel, let me explain why the above, even if it was correct, is utterly worthless rubbish.
among all the other properties of a good kernel patch, one property
suggests that a patch should have some *value*. it should address some actual issue, fix a bug or, at the very least, clean up some code. and if you're going to just clean things up, then it would make sense to do that cleanup across a wide swath of code to avoid submitting trivial patch after trivial patch.
as you can see above, nick has submitted a patch whose *entire*
functionality is ... to add three blank lines to a file. yes, after two months of failure after failure, nick has become so desperate to get *something* into the kernel that he has officially submitted a patch that adds three blank lines to a file, and fixes no errors whatever.
this is where have finally ended up ... nick is reduced to a patch
that adds blank lines to a file, and he can't even get *that* right.
rday
Signature · 7 lines
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================