leftover b43-related cruft in drivers/net/wireless?

DISCUSSION Robert P. J. Day 2 participants 2 messages Sep 18, 2014

Share & tools

Robert P. J. Day

author

2014-09-18 09:02 UTC #0 lore raw

i have a shell script that scans selected parts of the kernel source
tree to locate, among other things, unused config variables in Kconfig files, and it identified the following under drivers/net/wireless:

$ find_unused_configs.sh drivers/net/wireless

Quoted 1 line

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
B43_BCMA_PIO

drivers/net/wireless/b43/Kconfig:113:config B43_BCMA_PIO

Quoted 1 line

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
B43_BUSES_SSB

drivers/net/wireless/b43/Kconfig:52:config B43_BUSES_SSB

Quoted 1 line

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
B43LEGACY_DMA_MODE

drivers/net/wireless/b43legacy/Kconfig:85:config B43LEGACY_DMA_MODE

Quoted 1 line

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
B43LEGACY_PCICORE_AUTOSELECT

drivers/net/wireless/b43legacy/Kconfig:31:config B43LEGACY_PCICORE_AUTOSELECT

Quoted 1 line

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
B43LEGACY_PIO_MODE

drivers/net/wireless/b43legacy/Kconfig:92:config B43LEGACY_PIO_MODE

Quoted 1 line

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
B43_PCICORE_AUTOSELECT

drivers/net/wireless/b43/Kconfig:68:config B43_PCICORE_AUTOSELECT

Quoted 1 line

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
B43_PIO

drivers/net/wireless/b43/Kconfig:119:config B43_PIO $

no real harm, just means that there are Kconfig definitions of the
above variables that no one appears to be testing for in the entire kernel source tree, so they're potentially safe to be removed.

feel free to do with that what you will.

rday

Signature · 7 lines

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Rafał Miłecki

2014-09-18 09:17 UTC #1 lore raw

Quoted 17 lines · Robert P. J. Day

i have a shell script that scans selected parts of the kernel source
tree to locate, among other things, unused config variables in Kconfig files, and it identified the following under drivers/net/wireless:
$ find_unused_configs.sh drivers/net/wireless
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
B43_BCMA_PIO
drivers/net/wireless/b43/Kconfig:113:config B43_BCMA_PIO
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
B43_BUSES_SSB
drivers/net/wireless/b43/Kconfig:52:config B43_BUSES_SSB
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
B43LEGACY_DMA_MODE
drivers/net/wireless/b43legacy/Kconfig:85:config B43LEGACY_DMA_MODE
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
B43LEGACY_PCICORE_AUTOSELECT
drivers/net/wireless/b43legacy/Kconfig:31:config B43LEGACY_PCICORE_AUTOSELECT
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
B43LEGACY_PIO_MODE
drivers/net/wireless/b43legacy/Kconfig:92:config B43LEGACY_PIO_MODE
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
B43_PCICORE_AUTOSELECT

Quoted 8 lines

drivers/net/wireless/b43/Kconfig:68:config B43_PCICORE_AUTOSELECT
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
B43_PIO
drivers/net/wireless/b43/Kconfig:119:config B43_PIO $
no real harm, just means that there are Kconfig definitions of the
above variables that no one appears to be testing for in the entire kernel source tree, so they're potentially safe to be removed.

I didn't check all the symbols, but some of them are kind of helpers for configuring the driver.

For example B43_BUSES_SSB while looks unused, it is here for select-ing B43_SSB. I wanted to use "choice" to prevent users from compiling b43 without any bus support which doesn't make much sense.

The same applies to the B43_BCMA_PIO and B43_PIO (this one should be B43_SSB_PIO actually), they are helpers for selecting PIO support at bus driver level.