Skip to contentSkip to conversation

isn't "do_install_append_pn-uclibc" partly redundant?

DISCUSSION Robert P. J. Day 2 participants 3 messages Oct 16, 2014

lore
Share & tools
lore
#0 lore raw

perusing recipes for my courseware and ran across this in the listed
file:

meta/recipes-core/uclibc/uclibc.inc:do_install_append_pn-uclibc () {

now, given that the above file is clearly the general include file for the uclibc package, could the task append definition:

  do_install_append_pn-uclibc () {

not have been written more simply as:

  do_install_append () {

as in, given that this task append is clearly only for the uclibc package, it seems unnecessary to add a package-specific override. most other recipes use the second, shorter form, so i was wondering if there was something subtle about the uclibc recipe that necessitated the first form.

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#1 lore raw
Quoted 9 lines · Robert P. J. Day

meta/recipes-core/uclibc/uclibc.inc:do_install_append_pn-uclibc () {

now, given that the above file is clearly the general include file for the uclibc package, could the task append definition:

  do_install_append_pn-uclibc () {

not have been written more simply as:

Quoted 8 lines
  do_install_append () {

as in, given that this task append is clearly only for the uclibc package, it seems unnecessary to add a package-specific override. most other recipes use the second, shorter form, so i was wondering if there was something subtle about the uclibc recipe that necessitated the first form.

uclibc.inc is included by both uclibc-initial and uclibc.

Signature · 5 lines
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
#2 lore raw

Re: isn't "do_install_append_pn-uclibc" partly redundant? [NEVER MIND]

In reply to Robert P. J. Day
Quoted 13 lines · Robert P. J. Day

perusing recipes for my courseware and ran across this in the listed
file:

meta/recipes-core/uclibc/uclibc.inc:do_install_append_pn-uclibc () {

now, given that the above file is clearly the general include file for the uclibc package, could the task append definition:

  do_install_append_pn-uclibc () {

not have been written more simply as:

Quoted 7 lines
  do_install_append () {

as in, given that this task append is clearly only for the uclibc package, it seems unnecessary to add a package-specific override. most other recipes use the second, shorter form, so i was wondering if there was something subtle about the uclibc recipe that necessitated the first form.

oh, wait, i just saw the associated recipe for uclibc-initial, so
the package-specific override in the .inc file for just the uclibc package now makes sense.

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================