Skip to contentSkip to conversation

meta-oe: php, given "_append", remove superfluous "+="

PATCH In review Robert P. J. Day 3 participants 6 messages Aug 18, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 meta-oe: php, given "_append", remove superfluous "+="

---

again, not compile-tested since it seems obvious

meta-oe/recipes-devtools/php/php.inc +1 -1
index ee7a143..23de2b1 100644
@@ -15,7 +15,7 @@ SRC_URI = "http://php.net/distributions/php-${PV}.tar.bz2 \
            file://0001-acinclude-use-pkgconfig-for-libxml2-config.patch \
           "
 
-SRC_URI_append_class-target += " \
+SRC_URI_append_class-target = " \
             file://iconv.patch \
             file://imap-fix-autofoo.patch \
             file://pear-makefile.patch \
Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#1 lore raw
Quoted 15 lines · Robert P. J. Day

---

again, not compile-tested since it seems obvious

meta-oe/recipes-devtools/php/php.inc +0 -0
index ee7a143..23de2b1 100644

meta-oe/recipes-devtools/php/php.inc SRC_URI = "http://php.net/distributions/php-${PV}.tar.bz2 \ · line 18

Quoted 5 lines
meta-oe/recipes-devtools/php/php.inc +1 -1
@@ -15,7 +15,7 @@ SRC_URI = "http://php.net/distributions/php-${PV}.tar.bz2 \
           file://0001-acinclude-use-pkgconfig-for-libxml2-config.patch \
          "
 
-SRC_URI_append_class-target += " \
+SRC_URI_append_class-target = “ \

nitpick: You do not need a space here since its already added after newline

Quoted 19 lines
meta-oe/recipes-devtools/php/php.inc +0 -1
            file://iconv.patch \
            file://imap-fix-autofoo.patch \
            file://pear-makefile.patch \
 
--

========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday

========================================================================

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#2 lore raw
Quoted 18 lines · Khem Raj
Quoted 18 lines · Robert P. J. Day

---

again, not compile-tested since it seems obvious

meta-oe/recipes-devtools/php/php.inc +0 -0
index ee7a143..23de2b1 100644
@@ -15,7 +15,7 @@ SRC_URI = "http://php.net/distributions/php-${PV}.tar.bz2 \
           file://0001-acinclude-use-pkgconfig-for-libxml2-config.patch \
          "
 
Quoted 4 lines

meta-oe/recipes-devtools/php/php.inc SRC_URI = "http://php.net/distributions/php-${PV}.tar.bz2 \ · line 18

Quoted 2 lines
meta-oe/recipes-devtools/php/php.inc +1 -1
-SRC_URI_append_class-target += " \
+SRC_URI_append_class-target = “ \

nitpick: You do not need a space here since its already added after newline

since i did that more than once, i'll resubmit those patches. if i'm
going to be annoyingly nitpicky, i might as well do it correctly.

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#3 lore raw

Don't resend, it's already in master-next (all 4 squashed into one) and I would keep the space before \ because we always use space before \ even when it's not really necessary.

Quoted 52 lines · Robert P. J. Day
Quoted 2 lines · Khem Raj
Quoted 2 lines

On Aug 18, 2016, at 2:37 AM, Robert P. J. Day <[email protected]>

Quoted 9 lines · wrote:

Review

Quoted 9 lines

---

again, not compile-tested since it seems obvious

(quoted diff) +0 -0

b/meta-oe/recipes-devtools/php/php.inc

Quoted 4 lines

meta-oe/recipes-devtools/php/php.inc SRC_URI = "http://php.net/distributions/

Quoted 4 lines

index ee7a143..23de2b1 100644

meta-oe/recipes-devtools/php/php.inc +0 -0
@@ -15,7 +15,7 @@ SRC_URI = "http://php.net/distributions/

php-${PV}.tar.bz2 \

Quoted 1 line

meta-oe/recipes-devtools/php/php.inc SRC_URI = "http://php.net/distributions/ · line 15

Quoted 1 line
meta-oe/recipes-devtools/php/php.inc +0 -0
           file://0001-acinclude-use-pkgconfig-for-libxml2-config.patch

\

Quoted 6 lines

meta-oe/recipes-devtools/php/php.inc SRC_URI = "http://php.net/distributions/php-${PV}.tar.bz2 \

Quoted 4 lines
meta-oe/recipes-devtools/php/php.inc +1 -1
          "
 
-SRC_URI_append_class-target += " \
+SRC_URI_append_class-target = “ \

nitpick: You do not need a space here since its already added after

newline

since i did that more than once, i'll resubmit those patches. if i'm
going to be annoyingly nitpicky, i might as well do it correctly.

rday

--

========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday

========================================================================

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#4 lore raw
Quoted 3 lines · Martin Jansa

Don't resend, it's already in master-next (all 4 squashed into one) and I would keep the space before \ because we always use space before \ even when it's not really necessary.

that's what i thought, which is why i left it there. good to know,
thanks. time to start writing a style guide, methinks.

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#5 lore raw
In reply to Khem Raj
Quoted 18 lines · Khem Raj
Quoted 18 lines · Robert P. J. Day

---

again, not compile-tested since it seems obvious

meta-oe/recipes-devtools/php/php.inc +0 -0
index ee7a143..23de2b1 100644
@@ -15,7 +15,7 @@ SRC_URI = "http://php.net/distributions/php-${PV}.tar.bz2 \
           file://0001-acinclude-use-pkgconfig-for-libxml2-config.patch \
          "
 
Quoted 9 lines

meta-oe/recipes-devtools/php/php.inc SRC_URI = "http://php.net/distributions/php-${PV}.tar.bz2 \ · line 18

Quoted 2 lines
meta-oe/recipes-devtools/php/php.inc +1 -1
-SRC_URI_append_class-target += " \
+SRC_URI_append_class-target = “ \

nitpick: You do not need a space here since its already added after newline

Quoted 4 lines
meta-oe/recipes-devtools/php/php.inc +0 -0
            file://iconv.patch \
            file://imap-fix-autofoo.patch \
            file://pear-makefile.patch \

ah, quite so.

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================