Skip to contentSkip to conversation

watchdog: Remove misleading word "legacy" for /dev/watchdog

PATCH In review Robert P. J. Day 2 participants 3 messages Oct 16, 2016 Watchdog device drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 watchdog: Remove misleading word "legacy" for /dev/watchdog

The word "legacy" should not be used for the special file /dev/watchdog, as that file is still essential for watchdog operations.

---

i expressed my reservations about use of the word "legacy" here:

https://lists.kernelnewbies.org/pipermail/kernelnewbies/2016-October/017054.html

drivers/watchdog/watchdog_dev.c +4 -4
index 32930a0..0cc5ab8 100644
@@ -891,7 +891,7 @@ static struct miscdevice watchdog_miscdev = {
  *	@wdd: watchdog device
  *	@devno: character device number
  *
- *	Register a watchdog character device including handling the legacy
+ *	Register a watchdog character device including handling the
  *	/dev/watchdog node. /dev/watchdog is actually a miscdevice and
  *	thus we set it up like that.
  */
@@ -968,7 +968,7 @@ static int watchdog_cdev_register(struct watchdog_device *wdd, dev_t devno)
  *	watchdog_cdev_unregister: unregister watchdog character device
  *	@watchdog: watchdog device
  *
- *	Unregister watchdog character device and if needed the legacy
+ *	Unregister watchdog character device and if needed the
  *	/dev/watchdog device.
  */
 
@@ -1002,7 +1002,7 @@ static struct class watchdog_class = {
  *	watchdog_dev_register: register a watchdog device
  *	@wdd: watchdog device
  *
- *	Register a watchdog device including handling the legacy
+ *	Register a watchdog device including handling the
  *	/dev/watchdog node. /dev/watchdog is actually a miscdevice and
  *	thus we set it up like that.
  */
@@ -1040,7 +1040,7 @@ int watchdog_dev_register(struct watchdog_device *wdd)
  *	watchdog_dev_unregister: unregister a watchdog device
  *	@watchdog: watchdog device
  *
- *	Unregister watchdog device and if needed the legacy
+ *	Unregister watchdog device and if needed the
  *	/dev/watchdog device.
  */
 
Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
maintainer
#1 lore raw
Quoted 4 lines · Robert P. J. Day

The word "legacy" should not be used for the special file /dev/watchdog, as that file is still essential for watchdog operations.

NAK. The non-legacy name is /dev/watchdog0.

Guenter

Quoted 49 lines

---

i expressed my reservations about use of the word "legacy" here:

https://lists.kernelnewbies.org/pipermail/kernelnewbies/2016-October/017054.html

drivers/watchdog/watchdog_dev.c +4 -4
index 32930a0..0cc5ab8 100644
@@ -891,7 +891,7 @@ static struct miscdevice watchdog_miscdev = {
  *	@wdd: watchdog device
  *	@devno: character device number
  *
- *	Register a watchdog character device including handling the legacy
+ *	Register a watchdog character device including handling the
  *	/dev/watchdog node. /dev/watchdog is actually a miscdevice and
  *	thus we set it up like that.
  */
@@ -968,7 +968,7 @@ static int watchdog_cdev_register(struct watchdog_device *wdd, dev_t devno)
  *	watchdog_cdev_unregister: unregister watchdog character device
  *	@watchdog: watchdog device
  *
- *	Unregister watchdog character device and if needed the legacy
+ *	Unregister watchdog character device and if needed the
  *	/dev/watchdog device.
  */
 
@@ -1002,7 +1002,7 @@ static struct class watchdog_class = {
  *	watchdog_dev_register: register a watchdog device
  *	@wdd: watchdog device
  *
- *	Register a watchdog device including handling the legacy
+ *	Register a watchdog device including handling the
  *	/dev/watchdog node. /dev/watchdog is actually a miscdevice and
  *	thus we set it up like that.
  */
@@ -1040,7 +1040,7 @@ int watchdog_dev_register(struct watchdog_device *wdd)
  *	watchdog_dev_unregister: unregister a watchdog device
  *	@watchdog: watchdog device
  *
- *	Unregister watchdog device and if needed the legacy
+ *	Unregister watchdog device and if needed the
  *	/dev/watchdog device.
  */
 
#2 lore raw
Quoted 7 lines · Guenter Roeck
Quoted 4 lines · Robert P. J. Day

The word "legacy" should not be used for the special file /dev/watchdog, as that file is still essential for watchdog operations.

NAK. The non-legacy name is /dev/watchdog0.

ah, that wasn't clear from the source file.

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================