Skip to contentSkip to conversation

delete Kbuild "select" of long-dead SPL_DISABLE_OF_CONTROL

PATCH New Robert P. J. Day 3 participants 3 messages Apr 14, 2019 – May 5, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 delete Kbuild "select" of long-dead SPL_DISABLE_OF_CONTROL

From way back in 2015:

commit dffb86e468c8e02ba77283989aefef214d904dc5
Author: Masahiro Yamada <[email protected]>
Date: Wed Aug 12 07:31:54 2015 +0900

of: flip CONFIG_SPL_DISABLE_OF_CONTROL into CONFIG_SPL_OF_CONTROL

As we discussed a couple of times, negative CONFIG options make our life difficult; CONFIG_SYS_NO_FLASH, CONFIG_SYS_DCACHE_OFF, ... and here is another one.

Now, there are three boards enabling OF_CONTROL on SPL:
- socfpga_arria5_defconfig
- socfpga_cyclone5_defconfig
- socfpga_socrates_defconfig

This commit adds CONFIG_SPL_OF_CONTROL for them and deletes CONFIG_SPL_DISABLE_OF_CONTROL from the other boards to invert the logic.

---

AFAICT, simple deletion should be sufficient but i'm willing to be
convinced otherwise.

arch/arm/mach-exynos/Kconfig +0 -2
index 3807770362..14347e7c7d 100644
@@ -116,7 +116,6 @@ config TARGET_SNOW
 config TARGET_SPRING
 	bool "Spring board"
 	select OF_CONTROL
-	select SPL_DISABLE_OF_CONTROL
 	select SUPPORT_SPL
 
 config TARGET_SMDK5420
@@ -150,7 +149,6 @@ config  TARGET_ESPRESSO7420
 	select OF_CONTROL
 	select PINCTRL
 	select PINCTRL_EXYNOS7420
-	select SPL_DISABLE_OF_CONTROL
 	select SUPPORT_SPL
 
 endchoice
Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                         http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#1 lore raw

PATCH 1/1 delete Kbuild "select" of long-dead SPL_DISABLE_OF_CONTROL

Quoted 19 lines · Robert P. J. Day

From way back in 2015:

commit dffb86e468c8e02ba77283989aefef214d904dc5
Author: Masahiro Yamada <[email protected]>
Date: Wed Aug 12 07:31:54 2015 +0900

of: flip CONFIG_SPL_DISABLE_OF_CONTROL into CONFIG_SPL_OF_CONTROL

As we discussed a couple of times, negative CONFIG options make our life difficult; CONFIG_SYS_NO_FLASH, CONFIG_SYS_DCACHE_OFF, ... and here is another one.

Now, there are three boards enabling OF_CONTROL on SPL:
- socfpga_arria5_defconfig
- socfpga_cyclone5_defconfig
- socfpga_socrates_defconfig

Quoted 7 lines

This commit adds CONFIG_SPL_OF_CONTROL for them and deletes CONFIG_SPL_DISABLE_OF_CONTROL from the other boards to invert the logic.

Thanks for catching this.

Quoted 39 lines

---

AFAICT, simple deletion should be sufficient but i'm willing to be
convinced otherwise.

arch/arm/mach-exynos/Kconfig +0 -3
index 3807770362..14347e7c7d 100644
@@ -116,7 +116,6 @@ config TARGET_SNOW
 config TARGET_SPRING
        bool "Spring board"
        select OF_CONTROL
-       select SPL_DISABLE_OF_CONTROL
        select SUPPORT_SPL
 
 config TARGET_SMDK5420
@@ -150,7 +149,6 @@ config  TARGET_ESPRESSO7420
        select OF_CONTROL
        select PINCTRL
        select PINCTRL_EXYNOS7420
-       select SPL_DISABLE_OF_CONTROL
        select SUPPORT_SPL
 
 endchoice
 
--

========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday

========================================================================
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

Signature · 2 lines
Best Regards
Masahiro Yamada
#2 lore raw

PATCH 1/1 delete Kbuild "select" of long-dead SPL_DISABLE_OF_CONTROL

In reply to Robert P. J. Day
Quoted 17 lines · Robert P. J. Day
Quoted 1 line

From way back in 2015:

commit dffb86e468c8e02ba77283989aefef214d904dc5
Author: Masahiro Yamada <[email protected]>
Date: Wed Aug 12 07:31:54 2015 +0900

of: flip CONFIG_SPL_DISABLE_OF_CONTROL into CONFIG_SPL_OF_CONTROL

As we discussed a couple of times, negative CONFIG options make our life difficult; CONFIG_SYS_NO_FLASH, CONFIG_SYS_DCACHE_OFF, ... and here is another one.

Now, there are three boards enabling OF_CONTROL on SPL:
- socfpga_arria5_defconfig
- socfpga_cyclone5_defconfig
- socfpga_socrates_defconfig

Quoted 8 lines

This commit adds CONFIG_SPL_OF_CONTROL for them and deletes CONFIG_SPL_DISABLE_OF_CONTROL from the other boards to invert the logic.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190504/58633db3/attachment.sig>