relationship between "ARM_DCC" and "DEBUG_UART_ARM_DCC"?
just noticed the oddness regarding those two Kbuild symbols:
$ git grep ARM_DCC arch/x86/include/asm/acpi_table.h:#define ACPI_DBG2_ARM_DCC 0x000F configs/zynq_cse_qspi_defconfig:CONFIG_DEBUG_UART_ARM_DCC=y drivers/serial/Kconfig:config DEBUG_UART_ARM_DCC drivers/serial/Makefile:obj-$(CONFIG_ARM_DCC) += arm_dcc.o drivers/serial/arm_dcc.c:#ifdef CONFIG_DEBUG_UART_ARM_DCC include/configs/xilinx_versal.h:#define CONFIG_ARM_DCC include/configs/xilinx_zynqmp.h:#define CONFIG_ARM_DCC include/configs/zynq-common.h:#define CONFIG_ARM_DCC scripts/config_whitelist.txt:CONFIG_ARM_DCC $
strangely(?), there is a Kbuild config directive for the latter:
drivers/serial/Kconfig:config DEBUG_UART_ARM_DCC
but not the former, which is just hardcoded in some xilinx-associated header files. is this deliberate? it just seems ... weird.
rday
Signature · 7 lines
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================Quoted 15 lines · Robert P. J. Day
just noticed the oddness regarding those two
Kbuildsymbols:$ git grep ARM_DCC arch/x86/include/asm/acpi_table.h:#define ACPI_DBG2_ARM_DCC 0x000F configs/zynq_cse_qspi_defconfig:CONFIG_DEBUG_UART_ARM_DCC=y drivers/serial/Kconfig:config DEBUG_UART_ARM_DCC drivers/serial/Makefile:obj-$(CONFIG_ARM_DCC) += arm_dcc.o drivers/serial/arm_dcc.c:#ifdef CONFIG_DEBUG_UART_ARM_DCC include/configs/xilinx_versal.h:#define CONFIG_ARM_DCC include/configs/xilinx_zynqmp.h:#define CONFIG_ARM_DCC include/configs/zynq-common.h:#define CONFIG_ARM_DCC scripts/config_whitelist.txt:CONFIG_ARM_DCC $
Quoted 6 lines
strangely(?), there is a
Kbuildconfig directive for the latter:drivers/serial/Kconfig:config
DEBUG_UART_ARM_DCCbut not the former, which is just hardcoded in some xilinx-associated header files. is this deliberate? it just seems ... weird.
Simply none has had time to convert ARM_DCC to Kconfig that's why it is enabled via base platform.
And because debug symbol is in Kconfig it is enabled for platform which needs it.
Feel free to send a patch to move symbol there.
Thanks,
Michal
Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190423/a75f016a/attachment.sig>
Quoted 20 lines · Michal Simek
Quoted 19 lines · Robert P. J. Day
just noticed the oddness regarding those two
Kbuildsymbols:$ git grep ARM_DCC arch/x86/include/asm/acpi_table.h:#define ACPI_DBG2_ARM_DCC 0x000F configs/zynq_cse_qspi_defconfig:CONFIG_DEBUG_UART_ARM_DCC=y drivers/serial/Kconfig:config DEBUG_UART_ARM_DCC drivers/serial/Makefile:obj-$(CONFIG_ARM_DCC) += arm_dcc.o drivers/serial/arm_dcc.c:#ifdef CONFIG_DEBUG_UART_ARM_DCC include/configs/xilinx_versal.h:#define CONFIG_ARM_DCC include/configs/xilinx_zynqmp.h:#define CONFIG_ARM_DCC include/configs/zynq-common.h:#define CONFIG_ARM_DCC scripts/config_whitelist.txt:CONFIG_ARM_DCC $strangely(?), there is a
Kbuildconfig directive for the latter:drivers/serial/Kconfig:config
DEBUG_UART_ARM_DCC
Quoted 7 lines
Quoted 2 lines
but not the former, which is just hardcoded in some xilinx-associated header files. is this deliberate? it just seems ... weird.
Simply none has had time to convert
ARM_DCCtoKconfigthat's why it is enabled via base platform. And because debug symbol is inKconfigit is enabled for platform which needs it. Feel free to send a patch to move symbol there.
ok, i can do that. i'm assuming the Kconfig file should define both
symbols:
config ARM_DCC
and
config DEBUG_UART_ARM_DCC
depends on ARM_DCC
based on the current Makefile and arm_dcc.c file.
rday
Signature · 7 lines
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================út 23. 4. 2019 v 13:14 odesílatel Robert P. J. Day <[email protected]> napsal:
Quoted 33 lines · Michal Simek
Quoted 21 lines · Robert P. J. Day
Quoted 19 lines
just noticed the oddness regarding those two
Kbuildsymbols:$ git grep ARM_DCC arch/x86/include/asm/acpi_table.h:#define ACPI_DBG2_ARM_DCC 0x000F configs/zynq_cse_qspi_defconfig:CONFIG_DEBUG_UART_ARM_DCC=y drivers/serial/Kconfig:config DEBUG_UART_ARM_DCC drivers/serial/Makefile:obj-$(CONFIG_ARM_DCC) += arm_dcc.o drivers/serial/arm_dcc.c:#ifdef CONFIG_DEBUG_UART_ARM_DCC include/configs/xilinx_versal.h:#define CONFIG_ARM_DCC include/configs/xilinx_zynqmp.h:#define CONFIG_ARM_DCC include/configs/zynq-common.h:#define CONFIG_ARM_DCC scripts/config_whitelist.txt:CONFIG_ARM_DCC $strangely(?), there is a
Kbuildconfig directive for the latter:drivers/serial/Kconfig:config
DEBUG_UART_ARM_DCCQuoted 7 lines
Quoted 2 lines
but not the former, which is just hardcoded in some xilinx-associated header files. is this deliberate? it just seems ... weird.
Simply none has had time to convert
ARM_DCCtoKconfigthat's why it is enabled via base platform. And because debug symbol is inKconfigit is enabled for platform which needs it. Feel free to send a patch to move symbol there.ok, i can do that. i'm assuming the
Kconfigfile should define both
symbols:
Quoted 9 lines
config
ARM_DCCand
config
DEBUG_UART_ARM_DCC
depends onARM_DCCbased on the current
Makefileandarm_dcc.cfile.
Make sense.
M
Signature · 5 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs