s390/pci: PCI_IOV_RESOURCES loop refactoring in zpci_map_resources
PATCH 1/1 s390/pci: PCI_IOV_RESOURCES loop refactoring in zpci_map_resources
This patch alters the for loop iteration scheme in zpci_map_resources to make it more usual. Thus, the patch generalizes the style for PCI_IOV_RESOURCES iteration and improves readability.
--- arch/s390/pci/pci.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
arch/s390/pci/pci.c +4 -4
@@ -431,13 +431,13 @@ static void zpci_map_resources(struct pci_dev *pdev) }#ifdef CONFIG_PCI_IOV - i =PCI_IOV_RESOURCES ; +for (i =0 ; i <PCI_SRIOV_NUM_BARS ; i++) { +int bar = i +PCI_IOV_RESOURCES ; -for (; i <PCI_SRIOV_NUM_BARS +PCI_IOV_RESOURCES ; i++) { - len =pci_resource_len (pdev, i); + len =pci_resource_len (pdev, bar);if (!len)continue ; - pdev->resource[i].parent = &iov_res; + pdev->resource[bar].parent = &iov_res; }#endif }
Signature · 1 line
2.21.0
Quoted 5 lines · Denis Efremov
This patch alters the for loop iteration scheme in
zpci_map_resourcesto make it more usual. Thus, the patch generalizes the style forPCI_IOV_RESOURCESiteration and improves readability.Signed-off-by Denis Efremov <[email protected]>
Applied for inclusion via s390/linux.git . Thanks!
Sebastian
Thanks for the patch!
Sebastian may have silently fixed this, but for future reference,
$ git log --oneline arch/s390/pci/pci.c c7ff0e918a7c s390/pci: deal with devices that have no support for MIO instructions dcd33b23c9f3 s390/pci: fix assignment of bus resources 56271303808f s390/pci: add parameter to disable usage of MIO instructions 71ba41c9b1d9 s390/pci: provide support for MIO instructions 81deca12c202 s390/pci: move io address mapping code to pci_insn.c fbfe07d440f2 s390/pci: add parameter to force floating irqs c840927cf5f2 s390/pci: move everything irq related to pci_irq.c 066ee72aecdc s390/pci: remove unused define ...
shows that the typical style there is to start the subject with a verb so it's an imperative sentence.
Quoted 34 lines · Denis Efremov
This patch alters the for loop iteration scheme in
zpci_map_resourcesto make it more usual. Thus, the patch generalizes the style forPCI_IOV_RESOURCESiteration and improves readability.Signed-off-by Denis Efremov <[email protected]>--- arch/s390/pci/pci.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)arch/s390/pci/pci.c +4
-4@@ -431,13 +431,13 @@ static void zpci_map_resources(struct pci_dev *pdev) }#ifdef CONFIG_PCI_IOV - i =PCI_IOV_RESOURCES ; +for (i =0 ; i <PCI_SRIOV_NUM_BARS ; i++) { +int bar = i +PCI_IOV_RESOURCES ; -for (; i <PCI_SRIOV_NUM_BARS +PCI_IOV_RESOURCES ; i++) { - len =pci_resource_len (pdev, i); + len =pci_resource_len (pdev, bar);if (!len)continue ; - pdev->resource[i].parent = &iov_res; + pdev->resource[bar].parent = &iov_res; }#endif }Signature · 1 line
2.21.0