Skip to contentSkip to conversation

why would systemd-systemctl-native need underlying sysvinit?

DISCUSSION Robert P. J. Day 2 participants 2 messages Feb 24, 2020

lore
Share & tools
lore
#0 lore raw

in midst of migrating old YP layer to newer one and running across
all sorts of oddities. in this case, in current master branch of oe-core, we have:

recipes-bsp/keymaps/keymaps_1.0.bb:PACKAGE_WRITE_DEPS_append = " ${@bb.utils.contains('DISTRO_FEATURES','systemd sysvinit','systemd-systemctl-native','',d)}"

recipes-core/psplash/psplash_git.bb:PACKAGE_WRITE_DEPS_append = " ${@bb.utils.contains('DISTRO_FEATURES','systemd','systemd-systemctl-native','',d)}"

recipes-core/dbus/dbus_1.12.16.bb:PACKAGE_WRITE_DEPS += "${@bb.utils.contains('DISTRO_FEATURES','systemd sysvinit','systemd-systemctl-native','',d)}"

recipes-core/initscripts/initscripts_1.0.bb:PACKAGE_WRITE_DEPS_append = " ${@bb.utils.contains('DISTRO_FEATURES','systemd','systemd-systemctl-native','',d)}"

recipes-kernel/modutils-initscripts/modutils-initscripts.bb:PACKAGE_WRITE_DEPS_append = " ${@bb.utils.contains('DISTRO_FEATURES','systemd','systemd-systemctl-native','',d)}"

i'm curious as to why, in some cases, systemd-systemctl-native
requires *both* systemd and sysvinit to be contained in DISTRO_FEATURES, but not in other cases. the migration section to YP 2.3 talks only about systemd.

thoughts?

rday

Signature · 7 lines
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                         http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
#1 lore raw
Quoted 9 lines · Robert P. J. Day

in midst of migrating old YP layer to newer one and running across
all sorts of oddities. in this case, in current master branch of oe-core, we have:

recipes-bsp/keymaps/keymaps_1.0.bb:PACKAGE_WRITE_DEPS_append = " ${@bb.utils.contains('DISTRO_FEATURES','systemd sysvinit','systemd-systemctl-native','',d)}"

commit ee3ac7c64ed4c96062e7d21eed1355d4b60b78c4

Author: Jonas Bonn <[email protected]>
Date:   Tue Jan 29 08:24:42 2019 +0100

keymaps: tighten package write dependency

The dependency on systemd-systemctl-native is only needed if _both_ systemd and sysvinit are in play.

(From OE-Core rev: 3ea08f4b24f8a49c3d5039b62b39d6419cfe234c)

which is then obvious once you read the source:

pkg_postinst_${PN} () {
        if ${@bb.utils.contains('DISTRO_FEATURES','systemd
sysvinit','true','false',d)}; then
                if [ -n "$D" ]; then
                        OPTS="--root=$D"
                fi
                systemctl $OPTS mask keymap.service
        fi
}

And then the commit which added that makes it even clearer:

commit c57427b4a7991e33b806d4fd0956b6010ed52f62

Author: Chen Qi <[email protected]>
Date:   Wed Sep 3 15:09:17 2014 +0800

keymaps: mask keymap when necessary

When 'sysvinit' and 'systemd' are both in DISTRO_FEATURES, we need to prevent the init script from running via systemd.
This is because that the functionality of the init script has implemented in systemd internally.

(From OE-Core rev: 8cfba07e24dae3d1837ccb5cb04e11f362519b0a)

I'd guess the others are similar.

Signature · 1 line
Alex Kiernan