safe to get rid of refs to CVSDIR, SVNDIR, GITDIR?
cleaning up docs, and just noticed this from several months back:
commit 4ff058226cfc3e7d5bf9a873d1de4475f65ef2f2
Author: Andre McCurdy <[email protected]> Date: Fri Aug 23 13:51:32 2019 -0700
bitbake.conf: drop FETCHCMD, GITDIR, etc fetcher over-rides
This completes cleanup originally proposed in 2012:
http://lists.openembedded.org/pipermail/openembedded-core/2012-July/064224.html
Current versions of bitbake have "sane" default fetcher commands so it's no longer necessary for bitbake.conf to over-ride them.
meta/conf/bitbake.conf +0 -0
@@ -360,12 +360,6 @@ CACHE = "${TMPDIR}/cache${@['', '/' +
str(d.getVar('MACHINE'))][bool(d.getVar('M
# The persistent cache should be shared by all builds PERSISTENT_DIR = "${TOPDIR}/cache"
LOG_DIR = "${TMPDIR}/log"
-CO_DIR = "${DL_DIR}"
-CVSDIR = "${CO_DIR}/cvs"
-SVNDIR = "${CO_DIR}/svn"
-GITDIR = "${CO_DIR}/git2"
-BZRDIR = "${CO_DIR}/bzr"
-HGDIR = "${CO_DIR}/hg"
so is it safe to remove the remnants of references to those
variables? all that's left is [doc] references to CVSDIR, SVNDIR and GITDIR, and this from meta/lib/oe/recipeutils.py:
def get_recipe_upgrade_status(recipes=None):
pkgs_list = []
data_copy_list = []
copy_vars = ('SRC_URI',
'PV',
'GITDIR', <---
'DL_DIR',
'PN',
'CACHE',all of that safe to delete? any others that can go with it? (i didn't notice any.)
rday
Quoted 51 lines · On Mon, 2020-03-23 at 08:19 -0400, [email protected] wrote:
cleaning up docs, and just noticed this from several months back:
commit
4ff058226cfc3e7d5bf9a873d1de4475f65ef2f2Author: Andre McCurdy <[email protected]> Date: Fri Aug 23 13:51:32 2019 -0700bitbake.conf: drop FETCHCMD, GITDIR, etc fetcher over-rides
This completes cleanup originally proposed in 2012:
http://lists.openembedded.org/pipermail/openembedded-core/2012-July/064224.html
Current versions of bitbake have "sane" default fetcher commands so it's no longer necessary for bitbake.conf to over-ride them.
Signed-off-by Andre McCurdy <[email protected]>Signed-off-by Richard Purdie <[email protected]Quoted 1 line
meta/conf/bitbake.conf +0
-0@@ -360,12 +360,6 @@ CACHE = "${TMPDIR}/cache${@['', '/' +str(d.getVar('MACHINE'))][bool(d.getVar('M
# The persistent cache should be shared by all buildsPERSISTENT_DIR= "${TOPDIR}/cache"
LOG_DIR= "${TMPDIR}/log"meta/conf/bitbake.conf +0
-6-CO_DIR = "${DL_DIR}" -CVSDIR = "${CO_DIR}/cvs" -SVNDIR = "${CO_DIR}/svn" -GITDIR = "${CO_DIR}/git2" -BZRDIR = "${CO_DIR}/bzr" -HGDIR = "${CO_DIR}/hg" so is it safe to remove the remnants of references to thosevariables? all that's left is [doc] references to CVSDIR, SVNDIR and GITDIR, and this from
meta/lib/oe/recipeutils.py:def
get_recipe_upgrade_status(recipes=None):pkgs_list = [] data_copy_list = [] copy_vars = ('SRC_URI', 'PV', 'GITDIR', <--- 'DL_DIR', 'PN', 'CACHE',
Quoted 2 lines
all of that safe to delete? any others that can go with it? (i didn't notice any.)
Yes, well spotted, I've queued two patches for this.
Cheers,
Richard