Skip to contentSkip to conversation

Makefile: manpages: only add get_cyclictest_snapshot if PYLIB

PATCH In review Anders Roxell 2 participants 2 messages Oct 9, 2020 – Oct 19, 2020 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Makefile: manpages: only add get_cyclictest_snapshot if PYLIB

Since the installation of get_cyclictest_snapshot.py is done if PYLIB then we should only install the manpages then as well.

---
Hi,

I wasn't sure if this is the correct way for the manpages or if we just want to remove the "ifdef PYLIB" around the src/hwlatdetect/hwlatdetect.8 ?

What do you prefer ?

Cheers,
Anders

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index c3ebbd7b2a2e..5f34075a4aa1 100644
@@ -49,10 +49,10 @@ MANPAGES = src/cyclictest/cyclictest.8 \
 	   src/sched_deadline/deadline_test.8 \
 	   src/ssdd/ssdd.8 \
 	   src/sched_deadline/cyclicdeadline.8 \
-	   src/cyclictest/get_cyclictest_snapshot.8 \
 	   src/oslat/oslat.8
 
 ifdef PYLIB
+	MANPAGES += src/cyclictest/get_cyclictest_snapshot.8 \
 	MANPAGES += src/hwlatdetect/hwlatdetect.8
 endif
 
Signature · 1 line
2.28.0
#1 lore raw
Quoted 37 lines · Anders Roxell

Since the installation of get_cyclictest_snapshot.py is done if PYLIB then we should only install the manpages then as well.

---
Hi,

I wasn't sure if this is the correct way for the manpages or if we just want to remove the "ifdef PYLIB" around the src/hwlatdetect/hwlatdetect.8 ?

What do you prefer ?

Cheers,
Anders

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index c3ebbd7b2a2e..5f34075a4aa1 100644
@@ -49,10 +49,10 @@ MANPAGES = src/cyclictest/cyclictest.8 \
 	   src/sched_deadline/deadline_test.8 \
 	   src/ssdd/ssdd.8 \
 	   src/sched_deadline/cyclicdeadline.8 \
-	   src/cyclictest/get_cyclictest_snapshot.8 \
 	   src/oslat/oslat.8
 
 ifdef PYLIB
+	MANPAGES += src/cyclictest/get_cyclictest_snapshot.8 \
 	MANPAGES += src/hwlatdetect/hwlatdetect.8
 endif
 
Signature · 1 line
2.28.0