Drop more useless casts from void * to pointer
PATCH v2 1/1 Drop more useless casts from void * to pointer
---
v2:
* PATCH 1+2 merged as commit 0a553c12c7 and 3f7febc937
* PATCH 3 change to util/coroutine-ucontext.c dropped [Laurent]
bsd-user/elfload.c | 2 +- contrib/plugins/cache.c | 8 ++++---- contrib/vhost-user-blk/vhost-user-blk.c | 2 +- hw/core/qdev-clock.c | 2 +- hw/hyperv/vmbus.c | 2 +- hw/net/cadence_gem.c | 2 +- hw/net/virtio-net.c | 2 +- hw/nvme/ctrl.c | 4 ++-- hw/rdma/vmw/pvrdma_cmd.c | 9 +++------ hw/rdma/vmw/pvrdma_qp_ops.c | 6 +++--- hw/virtio/virtio-iommu.c | 3 +-- linux-user/syscall.c | 2 +- target/i386/hax/hax-all.c | 2 +- tests/tcg/aarch64/system/semiheap.c | 4 ++-- util/vfio-helpers.c | 2 +- 15 files changed, 24 insertions(+), 28 deletions(-)
bsd-user/elfload.c +1 -1
@@ -156,7 +156,7 @@ static abi_ulong copy_elf_strings(int argc, char **argv, void **page, --p; --tmp; --len;if (--offset <0 ) { offset = p %TARGET_PAGE_SIZE ; - pag = (char *)page[p /TARGET_PAGE_SIZE ]; + pag = page[p /TARGET_PAGE_SIZE ];if (!pag) { pag =g_try_malloc0 (TARGET_PAGE_SIZE ); page[p /TARGET_PAGE_SIZE ] = pag;
contrib/plugins/cache.c +4 -4
@@ -405,7 +405,7 @@ static void vcpu_mem_access(unsigned int vcpu_index, qemu_plugin_meminfo_t info,g_mutex_lock (&l1_dcache_locks[cache_idx]); hit_in_l1 =access_cache (l1_dcaches[cache_idx], effective_addr);if (!hit_in_l1) { - insn = (InsnData *) userdata; + insn = userdata;__atomic_fetch_add (&insn->l1_dmisses,1 , __ATOMIC_SEQ_CST); l1_dcaches[cache_idx]->misses++; }
@@ -419,7 +419,7 @@ static void vcpu_mem_access(unsigned int vcpu_index, qemu_plugin_meminfo_t info,g_mutex_lock (&l2_ucache_locks[cache_idx]);if (!access_cache (l2_ucaches[cache_idx], effective_addr)) { - insn = (InsnData *) userdata; + insn = userdata;__atomic_fetch_add (&insn->l2_misses,1 , __ATOMIC_SEQ_CST); l2_ucaches[cache_idx]->misses++; }
@@ -440,7 +440,7 @@ static void vcpu_insn_exec(unsigned int vcpu_index, void *userdata)g_mutex_lock (&l1_icache_locks[cache_idx]); hit_in_l1 =access_cache (l1_icaches[cache_idx], insn_addr);if (!hit_in_l1) { - insn = (InsnData *) userdata; + insn = userdata;__atomic_fetch_add (&insn->l1_imisses,1 , __ATOMIC_SEQ_CST); l1_icaches[cache_idx]->misses++; }
@@ -454,7 +454,7 @@ static void vcpu_insn_exec(unsigned int vcpu_index, void *userdata)g_mutex_lock (&l2_ucache_locks[cache_idx]);if (!access_cache (l2_ucaches[cache_idx], insn_addr)) { - insn = (InsnData *) userdata; + insn = userdata;__atomic_fetch_add (&insn->l2_misses,1 , __ATOMIC_SEQ_CST); l2_ucaches[cache_idx]->misses++; }
contrib/vhost-user-blk/vhost-user-blk.c +1 -1
@@ -193,7 +193,7 @@ vub_discard_write_zeroes(VubReq *req, struct iovec *iov, uint32_t iovcnt,#if defined(__linux__) && defined(BLKDISCARD ) && defined(BLKZEROOUT )VubDev *vdev_blk = req->vdev_blk; - desc = (struct virtio_blk_discard_write_zeroes *)buf; + desc = buf;uint64_t range[2 ] = {le64toh (desc->sector) <<9 ,le32toh (desc->num_sectors) <<9 };if (type ==VIRTIO_BLK_T_DISCARD ) {
hw/core/qdev-clock.c +1 -1
@@ -134,7 +134,7 @@ void qdev_init_clocks(DeviceState *dev, const ClockPortInitArray clocks)Clock **clkp;/* offset cannot be inside the DeviceState part */ assert (elem->offset >sizeof (DeviceState)); - clkp = (Clock **)(((void *) dev) + elem->offset); + clkp = ((void *)dev) + elem->offset;if (elem->is_output) { *clkp =qdev_init_clock_out (dev, elem->name); }else {
hw/hyperv/vmbus.c +1 -1
@@ -2104,7 +2104,7 @@ static void process_message(VMBus *vmbus) goto out; } msgdata = hv_msg->payload; - msg = (struct vmbus_message_header *)msgdata; + msg = msgdata;trace_vmbus_process_incoming_message (msg->message_type);
hw/net/cadence_gem.c +1 -1
@@ -1429,7 +1429,7 @@ static uint64_t gem_read(void *opaque, hwaddr offset, unsigned size) {CadenceGEMState *s;uint32_t retval; - s = (CadenceGEMState *)opaque; + s = opaque; offset >>=2 ; retval = s->regs[offset];
hw/net/virtio-net.c +1 -1
@@ -2472,7 +2472,7 @@ static size_t virtio_net_rsc_receive6(void *opq, NetClientState *nc,VirtioNetRscChain *chain;VirtioNetRscUnit unit; - chain = (VirtioNetRscChain *)opq; + chain = opq; hdr_len = ((VirtIONet *)(chain->n))->guest_hdr_len; if (size < (hdr_len + sizeof(struct eth_header) + sizeof(struct ip6_header)
hw/nvme/ctrl.c +2 -2
@@ -4104,14 +4104,14 @@ static uint16_t nvme_zone_mgmt_recv(NvmeCtrl *n, NvmeRequest *req) nr_zones++; } } - header = (NvmeZoneReportHeader *)buf; + header = buf; header->nr_zones =cpu_to_le64 (nr_zones); buf_p = buf +sizeof (NvmeZoneReportHeader);for (; zone_idx < ns->num_zones && max_zones >0 ; zone_idx++) { zone = &ns->zone_array[zone_idx];if (nvme_zone_matches_filter (zrasf, zone)) { - z = (NvmeZoneDescr *)buf_p; + z = buf_p; buf_p +=sizeof (NvmeZoneDescr); z->zt = zone->d.zt;
hw/rdma/vmw/pvrdma_cmd.c +3 -6
@@ -269,8 +269,7 @@ static int create_cq_ring(PCIDevice *pci_dev , PvrdmaRing **ring, r =g_malloc (sizeof (*r)); *ring = r; - r->ring_state = (PvrdmaRingState *) -rdma_pci_dma_map (pci_dev, tbl[0 ],TARGET_PAGE_SIZE ); + r->ring_state =rdma_pci_dma_map (pci_dev, tbl[0 ],TARGET_PAGE_SIZE );if (!r->ring_state) {rdma_error_report ("Failed to map to CQ ring state" );
@@ -405,8 +404,7 @@ static int create_qp_rings(PCIDevice *pci_dev, uint64_t pdir_dma, *rings = sr;/* Create send ring */ - sr->ring_state = (PvrdmaRingState *) -rdma_pci_dma_map (pci_dev, tbl[0 ],TARGET_PAGE_SIZE ); + sr->ring_state =rdma_pci_dma_map (pci_dev, tbl[0 ],TARGET_PAGE_SIZE );if (!sr->ring_state) {rdma_error_report ("Failed to map to QP ring state" ); goto out_free_sr_mem;
@@ -646,8 +644,7 @@ static int create_srq_ring(PCIDevice *pci_dev, PvrdmaRing **ring, r =g_malloc (sizeof (*r)); *ring = r; - r->ring_state = (PvrdmaRingState *) -rdma_pci_dma_map (pci_dev, tbl[0 ],TARGET_PAGE_SIZE ); + r->ring_state =rdma_pci_dma_map (pci_dev, tbl[0 ],TARGET_PAGE_SIZE );if (!r->ring_state) {rdma_error_report ("Failed to map tp SRQ ring state" ); goto out_free_ring_mem;
hw/rdma/vmw/pvrdma_qp_ops.c +3 -3
@@ -149,7 +149,7 @@ void pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle) ring = (PvrdmaRing *)qp->opaque; - wqe = (struct PvrdmaSqWqe *)pvrdma_ring_next_elem_read (ring); + wqe =pvrdma_ring_next_elem_read (ring);while (wqe) {CompHandlerCtx *comp_ctx;
@@ -212,7 +212,7 @@ void pvrdma_qp_recv(PVRDMADev *dev, uint32_t qp_handle) ring = &((PvrdmaRing *)qp->opaque)[1 ]; - wqe = (struct PvrdmaRqWqe *)pvrdma_ring_next_elem_read (ring); + wqe =pvrdma_ring_next_elem_read (ring);while (wqe) {CompHandlerCtx *comp_ctx;
@@ -254,7 +254,7 @@ void pvrdma_srq_recv(PVRDMADev *dev, uint32_t srq_handle) ring = (PvrdmaRing *)srq->opaque; - wqe = (struct PvrdmaRqWqe *)pvrdma_ring_next_elem_read (ring); + wqe =pvrdma_ring_next_elem_read (ring);while (wqe) {CompHandlerCtx *comp_ctx;
hw/virtio/virtio-iommu.c +1 -2
@@ -775,8 +775,7 @@ static void virtio_iommu_handle_command(VirtIODevice *vdev, VirtQueue *vq) output_size = s->config.probe_size +sizeof (tail); buf =g_malloc0 (output_size); - ptail = (struct virtio_iommu_req_tail *) - (buf + s->config.probe_size); + ptail = buf + s->config.probe_size; ptail->status =virtio_iommu_handle_probe (s, iov, iov_cnt, buf);break ; }
linux-user/syscall.c +1 -1
@@ -5471,7 +5471,7 @@ static abi_long do_ioctl_rt(const IOCTLEntry *ie, uint8_t *buf_temp,for (i =0 ; i < se->nb_fields; i++) {if (dst_offsets[i] == offsetof(struct rtentry , rt_dev)) {assert (*field_types ==TYPE_PTRVOID ); - target_rt_dev_ptr = (abi_ulong *)(argptr + src_offsets[i]); + target_rt_dev_ptr = argptr + src_offsets[i]; host_rt_dev_ptr = (unsigned long *)(buf_temp + dst_offsets[i]);if (*target_rt_dev_ptr !=0 ) { *host_rt_dev_ptr = (unsigned long)lock_user_string(
target/i386/hax/hax-all.c +1 -1
@@ -388,7 +388,7 @@ static int hax_handle_io(CPUArchState *env, uint32_t df, uint16_t port,MemTxAttrs attrs = {0 };if (!df) { - ptr = (uint8_t *) buffer; + ptr = buffer; }else { ptr = buffer + size * count - size; }
tests/tcg/aarch64/system/semiheap.c +2 -2
@@ -73,11 +73,11 @@ int main(int argc, char *argv[argc])ml_printf ("stack: %p <- %p\n" , info.stack_limit, info.stack_base);/* finally can we read/write the heap */ - ptr_to_heap = (uint32_t *) info.heap_base; + ptr_to_heap = info.heap_base;for (i =0 ; i <512 ; i++) { *ptr_to_heap++ = i; } - ptr_to_heap = (uint32_t *) info.heap_base; + ptr_to_heap = info.heap_base;for (i =0 ; i <512 ; i++) {uint32_t tmp = *ptr_to_heap;if (tmp != i) {
util/vfio-helpers.c +1 -1
@@ -271,7 +271,7 @@ static void collect_usable_iova_ranges(QEMUVFIOState *s, void *buf)if (!cap->next) {return ; } - cap = (struct vfio_info_cap_header *)(buf + cap->next); + cap = buf + cap->next; } cap_iova_range = (struct vfio_iommu_type1_info_cap_iova_range *)cap;
Signature · 1 line
2.37.3
Quoted 29 lines · Markus Armbruster
Signed-off-by Markus Armbruster <[email protected]>Reviewed-by Laurent Vivier <[email protected]>---
v2:
* PATCH 1+2 merged as commit0a553c12c7and3f7febc937
* PATCH 3 change toutil/coroutine-ucontext.cdropped [Laurent]bsd-user/elfload.c | 2 +- contrib/plugins/cache.c | 8 ++++---- contrib/vhost-user-blk/vhost-user-blk.c | 2 +- hw/core/qdev-clock.c | 2 +- hw/hyperv/vmbus.c | 2 +- hw/net/cadence_gem.c | 2 +- hw/net/virtio-net.c | 2 +- hw/nvme/ctrl.c | 4 ++-- hw/rdma/vmw/pvrdma_cmd.c | 9 +++------ hw/rdma/vmw/pvrdma_qp_ops.c | 6 +++--- hw/virtio/virtio-iommu.c | 3 +-- linux-user/syscall.c | 2 +- target/i386/hax/hax-all.c | 2 +- tests/tcg/aarch64/system/semiheap.c | 4 ++-- util/vfio-helpers.c | 2 +- 15 files changed, 24 insertions(+), 28 deletions(-)bsd-user/elfload.c +0
-0
bsd-user/elfload.c static abi_ulong copy_elf_strings(int argc, char **argv, void **page, · line 159
Quoted 5 lines
bsd-user/elfload.c +1
-1@@ -156,7 +156,7 @@ static abi_ulong copy_elf_strings(int argc, char **argv, void **page, --p; --tmp; --len;if (--offset <0 ) { offset = p %TARGET_PAGE_SIZE ; - pag = (char *)page[p /TARGET_PAGE_SIZE ]; + pag = page[p /TARGET_PAGE_SIZE ];
I think arithmetic on void pointer was undefined at least in the past so some compilers may warn for it but not sure if this is still the case for the compilers we care about. Apparently not if this now compiles but that explains why this cast was not useless. Found some more info on this here:
https://stackoverflow.com/questions/3523145/pointer-arithmetic-for-void-pointer-in-c
Regards,
BALATON Zoltan
Quoted 41 lines · BALATON Zoltan
Quoted 29 lines · Markus Armbruster
Signed-off-by Markus Armbruster <[email protected]>Reviewed-by Laurent Vivier <[email protected]>---
v2:
* PATCH 1+2 merged as commit0a553c12c7and3f7febc937
* PATCH 3 change toutil/coroutine-ucontext.cdropped [Laurent]bsd-user/elfload.c | 2 +- contrib/plugins/cache.c | 8 ++++---- contrib/vhost-user-blk/vhost-user-blk.c | 2 +- hw/core/qdev-clock.c | 2 +- hw/hyperv/vmbus.c | 2 +- hw/net/cadence_gem.c | 2 +- hw/net/virtio-net.c | 2 +- hw/nvme/ctrl.c | 4 ++-- hw/rdma/vmw/pvrdma_cmd.c | 9 +++------ hw/rdma/vmw/pvrdma_qp_ops.c | 6 +++--- hw/virtio/virtio-iommu.c | 3 +-- linux-user/syscall.c | 2 +- target/i386/hax/hax-all.c | 2 +- tests/tcg/aarch64/system/semiheap.c | 4 ++-- util/vfio-helpers.c | 2 +- 15 files changed, 24 insertions(+), 28 deletions(-)bsd-user/elfload.c +0
-0bsd-user/elfload.c static abi_ulong copy_elf_strings(int argc, char **argv, void **page, · line 159
Quoted 5 lines
bsd-user/elfload.c +1
-1@@ -156,7 +156,7 @@ static abi_ulong copy_elf_strings(int argc, char **argv, void **page, --p; --tmp; --len;if (--offset <0 ) { offset = p %TARGET_PAGE_SIZE ; - pag = (char *)page[p /TARGET_PAGE_SIZE ]; + pag = page[p /TARGET_PAGE_SIZE ];I think arithmetic on void pointer was undefined at least in the past so some compilers may warn for it but not sure if this is still the case for the compilers we care about. Apparently not if this now compiles but that explains why this cast was not useless. Found some more info on this here:
QEMU explicitly only targets GCC + Clang, so portability to other compilers is not required.
With regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Quoted 26 lines · Daniel P. Berrangé
Quoted 25 lines · BALATON Zoltan
Quoted 24 lines · Markus Armbruster
Signed-off-by Markus Armbruster <[email protected]>Reviewed-by Laurent Vivier <[email protected]>---
v2:
* PATCH 1+2 merged as commit0a553c12c7and3f7febc937
* PATCH 3 change toutil/coroutine-ucontext.cdropped [Laurent]bsd-user/elfload.c | 2 +- contrib/plugins/cache.c | 8 ++++---- contrib/vhost-user-blk/vhost-user-blk.c | 2 +- hw/core/qdev-clock.c | 2 +- hw/hyperv/vmbus.c | 2 +- hw/net/cadence_gem.c | 2 +- hw/net/virtio-net.c | 2 +- hw/nvme/ctrl.c | 4 ++-- hw/rdma/vmw/pvrdma_cmd.c | 9 +++------ hw/rdma/vmw/pvrdma_qp_ops.c | 6 +++--- hw/virtio/virtio-iommu.c | 3 +-- linux-user/syscall.c | 2 +- target/i386/hax/hax-all.c | 2 +- tests/tcg/aarch64/system/semiheap.c | 4 ++-- util/vfio-helpers.c | 2 +- 15 files changed, 24 insertions(+), 28 deletions(-)
Quoted 15 lines
Quoted 7 lines
Quoted 7 lines
bsd-user/elfload.c +0
-0@@ -156,7 +156,7 @@ static abi_ulong copy_elf_strings(int argc, char **argv, void **page, --p; --tmp; --len;if (--offset <0 ) {Quoted 8 lines
bsd-user/elfload.c static abi_ulong copy_elf_strings(int argc, char **argv, void **page, · line 159
Quoted 3 lines
bsd-user/elfload.c +1
-1offset = p %TARGET_PAGE_SIZE ; - pag = (char *)page[p /TARGET_PAGE_SIZE ]; + pag = page[p /TARGET_PAGE_SIZE ];I think arithmetic on void pointer was undefined at least in the past so some compilers may warn for it but not sure if this is still the case for the compilers we care about. Apparently not if this now compiles but that explains why this cast was not useless.
I don't think so :)
@pag is char *.
@page is void **.
page[p / TARGET_PAGE_SIZE] is void *. No need to cast to char * before assigning to @pag.
No pointer arithmetic so far. There's some further down: pag + offset. @pag is char * before and after my patch.
Quoted 6 lines
Quoted 3 lines
Found some more info on this here:
https://stackoverflow.com/questions/3523145/pointer-arithmetic-for-void-pointer-in-c
QEMU explicitly only targets GCC + Clang, so portability to other compilers is not required.
Correct. We do arithmentic with void * in many places already.
If we cared for portability to other compilers, we'd enable
'-Wpointer-arith'
Warn about anything that depends on the "size of" a function type or of 'void'. GNU C assigns these types a size of 1, for convenience in calculations with 'void *' pointers and pointers to functions. In C++, warn also when an arithmetic operation involves 'NULL'. This warning is also enabled by '-Wpedantic'.
But we don't.
Quoted 43 lines · Markus Armbruster
Quoted 26 lines · Daniel P. Berrangé
Quoted 25 lines · BALATON Zoltan
Quoted 24 lines · Markus Armbruster
Signed-off-by Markus Armbruster <[email protected]>Reviewed-by Laurent Vivier <[email protected]>---
v2:
* PATCH 1+2 merged as commit0a553c12c7and3f7febc937
* PATCH 3 change toutil/coroutine-ucontext.cdropped [Laurent]bsd-user/elfload.c | 2 +- contrib/plugins/cache.c | 8 ++++---- contrib/vhost-user-blk/vhost-user-blk.c | 2 +- hw/core/qdev-clock.c | 2 +- hw/hyperv/vmbus.c | 2 +- hw/net/cadence_gem.c | 2 +- hw/net/virtio-net.c | 2 +- hw/nvme/ctrl.c | 4 ++-- hw/rdma/vmw/pvrdma_cmd.c | 9 +++------ hw/rdma/vmw/pvrdma_qp_ops.c | 6 +++--- hw/virtio/virtio-iommu.c | 3 +-- linux-user/syscall.c | 2 +- target/i386/hax/hax-all.c | 2 +- tests/tcg/aarch64/system/semiheap.c | 4 ++-- util/vfio-helpers.c | 2 +- 15 files changed, 24 insertions(+), 28 deletions(-)Quoted 15 lines
Quoted 7 lines
Quoted 7 lines
bsd-user/elfload.c +0
-0@@ -156,7 +156,7 @@ static abi_ulong copy_elf_strings(int argc, char **argv, void **page, --p; --tmp; --len;if (--offset <0 ) {Quoted 8 lines
bsd-user/elfload.c static abi_ulong copy_elf_strings(int argc, char **argv, void **page, · line 159
Quoted 3 lines
bsd-user/elfload.c +1
-1offset = p %TARGET_PAGE_SIZE ; - pag = (char *)page[p /TARGET_PAGE_SIZE ]; + pag = page[p /TARGET_PAGE_SIZE ];I think arithmetic on void pointer was undefined at least in the past so some compilers may warn for it but not sure if this is still the case for the compilers we care about. Apparently not if this now compiles but that explains why this cast was not useless.
Quoted 8 lines
I don't think so :)
@pag is char *.
@page is void **.
page[p /
TARGET_PAGE_SIZE] is void *. No need to cast to char * before assigning to @pag.
You are right. Although I'm not sure what page[] counts as because it adds an offset to the pointer but [] is higher priority than (type) cast so it does not matter and that cast is not needed here then. Maybe I should be more attentive to details but I did not take the time to look at it more carefully. I did not say we should keep the cast anyway (considering only gcc and clang are targeted), I was just trying to understand why it might have been there in the first place.
Regards,
BALATON Zoltan
Quoted 24 lines
No pointer arithmetic so far. There's some further down: pag + offset. @pag is char * before and after my patch.
Quoted 6 lines
Quoted 3 lines
Found some more info on this here:
https://stackoverflow.com/questions/3523145/pointer-arithmetic-for-void-pointer-in-c
QEMU explicitly only targets GCC + Clang, so portability to other compilers is not required.
Correct. We do arithmentic with void * in many places already.
If we cared for portability to other compilers, we'd enable
'-Wpointer-arith'
Warn about anything that depends on the "size of" a function type or of 'void'. GNU C assigns these types a size of 1, for convenience in calculations with 'void *' pointers and pointers to functions. In C++, warn also when an arithmetic operation involves 'NULL'. This warning is also enabled by '-Wpedantic'.But we don't.
Quoted 50 lines · BALATON Zoltan
Quoted 49 lines · Markus Armbruster
Quoted 26 lines · Daniel P. Berrangé
Quoted 25 lines · BALATON Zoltan
Quoted 24 lines · Markus Armbruster
Signed-off-by Markus Armbruster <[email protected]>Reviewed-by Laurent Vivier <[email protected]>---
v2:
* PATCH 1+2 merged as commit0a553c12c7and3f7febc937
* PATCH 3 change toutil/coroutine-ucontext.cdropped [Laurent]bsd-user/elfload.c | 2 +- contrib/plugins/cache.c | 8 ++++---- contrib/vhost-user-blk/vhost-user-blk.c | 2 +- hw/core/qdev-clock.c | 2 +- hw/hyperv/vmbus.c | 2 +- hw/net/cadence_gem.c | 2 +- hw/net/virtio-net.c | 2 +- hw/nvme/ctrl.c | 4 ++-- hw/rdma/vmw/pvrdma_cmd.c | 9 +++------ hw/rdma/vmw/pvrdma_qp_ops.c | 6 +++--- hw/virtio/virtio-iommu.c | 3 +-- linux-user/syscall.c | 2 +- target/i386/hax/hax-all.c | 2 +- tests/tcg/aarch64/system/semiheap.c | 4 ++-- util/vfio-helpers.c | 2 +- 15 files changed, 24 insertions(+), 28 deletions(-)Quoted 15 lines
Quoted 7 lines
Quoted 7 lines
bsd-user/elfload.c +0
-0@@ -156,7 +156,7 @@ static abi_ulong copy_elf_strings(int argc, char **argv, void **page, --p; --tmp; --len;if (--offset <0 ) {Quoted 8 lines
bsd-user/elfload.c static abi_ulong copy_elf_strings(int argc, char **argv, void **page, · line 159
Quoted 3 lines
bsd-user/elfload.c +1
-1offset = p %TARGET_PAGE_SIZE ; - pag = (char *)page[p /TARGET_PAGE_SIZE ]; + pag = page[p /TARGET_PAGE_SIZE ];I think arithmetic on void pointer was undefined at least in the past so some compilers may warn for it but not sure if this is still the case for the compilers we care about. Apparently not if this now compiles but that explains why this cast was not useless.
I don't think so :)
@pag is char *.
@page is void **.
Quoted 7 lines
Quoted 2 lines
page[p /
TARGET_PAGE_SIZE] is void *. No need to cast to char * before assigning to @pag.You are right. Although I'm not sure what page[] counts as because it adds an offset to the pointer but [] is higher priority than (type) cast so it does not matter and that cast is not needed here then. Maybe I should be more attentive to details but I did not take the time to look at it more carefully. I did not say we should keep the cast anyway (considering only gcc and clang are targeted), I was just trying to understand why it might have been there in the first place.
And that's perfectly okay!