replace() system call needed (was Re: EXT4-ish "fixes" in UBIFS)
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 6 lines · Pavel Machek
My proposal is
rename()stays.
replace(src, bar)is rename that ensures that bar will contain valid data after powerfail.
This can be done using implicit logic:
->E.g. on close(), mark inodes without being sync()ed as poisoned. (I can think of more sophisticated logic, but ...)
->On completing the inode with the delayed allocations, unpoison it. ->Don't commit rename()s if the corresponding inode is poisoned.
Et Voila, everything replace is supposed to guarantee is guaranteed.
Quoted 6 lines · Bodo Eggert
This can be done using implicit logic:
->E.g. on
close(), mark inodes without being sync()ed as poisoned. (I can think of more sophisticated logic, but ...)
->On completing the inode with the delayed allocations, unpoison it. ->Don't commit rename()s if the corresponding inode is poisoned.
Send us patches if you think it's that easy to do what you are
proposing. I assure it's not easy.
- Ted
Quoted 10 lines · Theodore Tso
Quoted 6 lines · Bodo Eggert
This can be done using implicit logic:
->E.g. on
close(), mark inodes without being sync()ed as poisoned. (I can think of more sophisticated logic, but ...)
->On completing the inode with the delayed allocations, unpoison it. ->Don't commit rename()s if the corresponding inode is poisoned.Send us patches if you think it's that easy to do what you are
proposing. I assure it's not easy.
Well, implementing replace() syscall would be quite easy. Would you want such a patch?
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 10 lines · Pavel Machek
Quoted 9 lines · Theodore Tso
Quoted 6 lines · Bodo Eggert
This can be done using implicit logic:
->E.g. on
close(), mark inodes without being sync()ed as poisoned. (I can think of more sophisticated logic, but ...)
->On completing the inode with the delayed allocations, unpoison it. ->Don't commit rename()s if the corresponding inode is poisoned.
Quoted 5 lines
Quoted 2 lines
Send us patches if you think it's that easy to do what you are
proposing. I assure it's not easy.Well, implementing
replace()syscall would be quite easy. Would you want such a patch?
You'd need - minus setting the flag on close - about the same logic:
- detecting if the inode are dirty
- detecting when the inode gets into a clean state
- delaying the commit of the rename() until then
- not replaying parts of the journal
As I understand, the replace() should not behave different from rename(), except for making a guaranty. Since this guaranty is desired anyway, I think making it automatically would be a good thing. Especially until all applications are rewritten ...
Off cause if you call replace, you know it's going to be OK, but you could also use pathconf($configdir, _PC_SYNC_BEFORE_RENAME)
(== 0: Sync or barrier implicit, (data = ordered)
1: small chance of data loss due to not syncing, (vfat?) 2: guarantee of data loss without sync (ext4))
// userspace.c
static inline int sync_before_rename(char * where, int is_important_data)
{
#ifndef _PC_SYNC_BEFORE_RENAME
// be optimistic for unimportant data
return is_important_data;
#else
int ret = pathconf(where, _PC_SYNC_BEFORE_RENAME);
if (is_important_data)
return ret;
return (ret > 1);
#endif
}Signature · 1 line
How do I set my laser printer on stun?