Skip to contentSkip to conversation

mm/migrate.c: attach_page_private already does the get_page

PATCH In review Hugh Dickins 2 participants 2 messages Jun 2, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/migrate.c: attach_page_private already does the get_page

Just finished bisecting mmotm, to find why a test which used to take four minutes now took more than an hour: the __buffer_migrate_page() cleanup left behind a get_page() which attach_page_private() now does.

Fixes cd0f37154443 ("mm/migrate.c: call detach_page_private to cleanup code")

---
Fixes the 048/128 of last night's (or today's) incoming from akpm:
sorry I didn't complete the bisection before it went into Linus's tree.

 mm/migrate.c |    1 -
 1 file changed, 1 deletion(-)
mm/migrate.c +0 -1
@@ -798,7 +798,6 @@ recheck_buffers:
 		goto unlock_buffers;
 
 	attach_page_private(newpage, detach_page_private(page));
-	get_page(newpage);
 
 	bh = head;
 	do {
#1 lore raw
Quoted 3 lines · Hugh Dickins

Fixes the 048/128 of last night's (or today's) incoming from akpm:
sorry I didn't complete the bisection before it went into Linus's tree.

Oh well. I've applied your fix on top of my tree now.

Linus