Skip to contentSkip to conversation

mac68k: fix mac_irq_pending() for PSC MACE and SCC

PATCH Applied Finn Thain 2 participants 2 messages Jul 18, 2011 – Aug 13, 2011

Subsystems (2)
lore
Share & tools
lore

Finn Thain

author
#0 lore raw

PATCH 1/1 mac68k: fix mac_irq_pending() for PSC MACE and SCC

Add missing return statement. The docs say that the level 4 PSC IRQs relate to MACE DMA and SCC. Since those drivers don't call mac_irq_pending() this patch has no affect. But it should be fixed all the same, since it can be useful for MACE debugging.

---
 arch/m68k/mac/macints.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/m68k/mac/macints.c +1 -1
Index: linux-2.6.39/arch/m68k/mac/macints.c
===================================================================
@@ -370,7 +370,7 @@ int mac_irq_pending(unsigned int irq)
 		break;
 	case 4:
 		if (psc_present)
-			psc_irq_pending(irq);
+			return psc_irq_pending(irq);
 		break;
 	}
 	return 0;
maintainer Applied
#1 lore raw
Quoted 4 lines · Finn Thain

Add missing return statement. The docs say that the level 4 PSC IRQs relate to MACE DMA and SCC. Since those drivers don't call mac_irq_pending() this patch has no affect. But it should be fixed all the same, since it can be useful for MACE debugging.

Thanks, applied. Will queue for 3.2.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds