pinctrl: microchip-sgpio: add missing select REGMAP_MMIO
Subsystems (3)
PATCH v2 1/1 pinctrl: microchip-sgpio: add missing select REGMAP_MMIO
The driver calls ocelot_regmap_from_resource() via <linux/mfd/ocelot.h>, which internally uses devm_regmap_init_mmio() and requires REGMAP_MMIO. The Kconfig entry does not select REGMAP_MMIO, causing a build failure when no other driver in the config happens to pull in REGMAP_MMIO:
include/linux/mfd/ocelot.h:34:24: error: implicit declaration of function 'devm_regmap_init_mmio'
Found by randconfig testing on arm64; tinyconfig reproducer below.
---
Reproducer (tinyconfig, arm64, without patch):
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- tinyconfig
scripts/config --enable CONFIG_PINCTRL
scripts/config --enable CONFIG_GPIOLIB
scripts/config --enable CONFIG_PINCTRL_MICROCHIP_SGPIO
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- olddefconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- \
drivers/pinctrl/pinctrl-microchip-sgpio.o
-> CONFIG_REGMAP_MMIO absent, build fails as shown above.drivers/pinctrl/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/pinctrl/Kconfig +1 -0
@@ -426,6 +426,7 @@ config PINCTRL_MICROCHIP_SGPIO select GENERIC_PINCONF select GENERIC_PINCTRL_GROUPS select GENERIC_PINMUX_FUNCTIONS + select REGMAP_MMIO help Support for the serial GPIO interface used on Microsemi and Microchip SoCs. By using a serial interface, the SIO
Signature · 1 line
2.55.0
Quoted 7 lines · Benjamin Boortz
The driver calls
ocelot_regmap_from_resource()via <linux/mfd/ocelot.h>, which internally usesdevm_regmap_init_mmio()and requiresREGMAP_MMIO. TheKconfigentry does not selectREGMAP_MMIO, causing a build failure when no other driver in the config happens to pull inREGMAP_MMIO:
include/linux/mfd/ocelot.h:34:24: error: implicit declaration of function 'devm_regmap_init_mmio'
Quoted 7 lines
Found by randconfig testing on arm64; tinyconfig reproducer below.
Fixes 2afbbab45c26 ("pinctrl: microchip-sgpio: update to support regmap")Signed-off-by Benjamin Boortz <[email protected]>Reviewed-by Andy Shevchenko <[email protected]>---
This is v2. It misses a changelog here.
No need to resend _this_ time, just reply to this query with what has been changed v1..v2.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 16 lines · Andy Shevchenko
Quoted 7 lines · Benjamin Boortz
The driver calls
ocelot_regmap_from_resource()via <linux/mfd/ocelot.h>, which internally usesdevm_regmap_init_mmio()and requiresREGMAP_MMIO. TheKconfigentry does not selectREGMAP_MMIO, causing a build failure when no other driver in the config happens to pull inREGMAP_MMIO:
include/linux/mfd/ocelot.h:34:24: error: implicit declaration of function 'devm_regmap_init_mmio'Quoted 7 lines
Found by randconfig testing on arm64; tinyconfig reproducer below.
Fixes 2afbbab45c26 ("pinctrl: microchip-sgpio: update to support regmap")Signed-off-by Benjamin Boortz <[email protected]>Reviewed-by Andy Shevchenko <[email protected]>---
Quoted 10 lines
This is v2. It misses a changelog here.
No need to resend _this_ time, just reply to this query with what has been changed v1..v2.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Changes in v2:
- Reduced error block to one most significant line
- Fixed Fixes: tag to 2afbbab45c26 ("pinctrl: microchip-sgpio: update to support regmap")
- Added Reviewed-by
BR,
Benni Boortz
Linus Walleij
maintainerQuoted 5 lines · Benjamin Boortz
The driver calls
ocelot_regmap_from_resource()via <linux/mfd/ocelot.h>, which internally usesdevm_regmap_init_mmio()and requiresREGMAP_MMIO. TheKconfigentry does not selectREGMAP_MMIO, causing a build failure when no other driver in the config happens to pull inREGMAP_MMIO:
Quoted 8 lines
include/linux/mfd/ocelot.h:34:24: error: implicit declaration of function 'devm_regmap_init_mmio'Found by randconfig testing on arm64; tinyconfig reproducer below.
Fixes 2afbbab45c26 ("pinctrl: microchip-sgpio: update to support regmap")Signed-off-by Benjamin Boortz <[email protected]>Reviewed-by Andy Shevchenko <[email protected]>
Patch applied for fixes.
Yours,
Linus Walleij