igc: Remove unreachable break after return
Subsystems (3)
PATCH 1/1 igc: Remove unreachable break after return
The break statement immediately following the return statement is unreachable and can never be executed.
Remove the redundant break statement.
No functional change intended.
Signed-off-by Hungyu Lin <[email protected]>
--- drivers/net/ethernet/intel/igc/igc_main.c | 1 - 1 file changed, 1 deletion(-)
drivers/net/ethernet/intel/igc/igc_main.c +0 -1
@@ -2528,7 +2528,6 @@ static int __igc_xdp_run_prog(struct igc_adapter *adapter,if (xdp_do_redirect (adapter->netdev, xdp, prog) <0 ) goto out_failure;return IGC_XDP_REDIRECT ; -break ;default :bpf_warn_invalid_xdp_action (adapter->netdev, prog, act); fallthrough;
Signature · 1 line
2.43.0
Quoted 17 lines · Hungyu Lin
The break statement immediately following the return statement is unreachable and can never be executed.
Remove the redundant break statement.
No functional change intended.
Signed-off-by Hungyu Lin <[email protected]>--- drivers/net/ethernet/intel/igc/igc_main.c | 1 - 1 file changed, 1 deletion(-)drivers/net/ethernet/intel/igc/igc_main.c +0
-0
drivers/net/ethernet/intel/igc/igc_main.c static int __igc_xdp_run_prog(struct igc_adapter *adapter, · line 2531
Quoted 4 lines
drivers/net/ethernet/intel/igc/igc_main.c +0
-1@@ -2528,7 +2528,6 @@ static int __igc_xdp_run_prog(struct igc_adapter *adapter,if (xdp_do_redirect (adapter->netdev, xdp, prog) <0 ) goto out_failure;return IGC_XDP_REDIRECT ; -break ;
Hm, from Documentation/process/maintainer-netdev.rst:
Netdev discourages patches which perform simple clean-ups, which are not in the context of other work.
I think this patch probably meets the definition of patches which are discouraged.