audit: add FSCONFIG auxiliary record to log filesystem configuration
PATCH v2 1/1 audit: add FSCONFIG auxiliary record to log filesystem configuration
Modern mount tools (util-linux >= 2.39.1) use the new mount API (fsopen, fsconfig, fsmount, move_mount) instead of the legacy mount(2) syscall. The generic SYSCALL audit record logs the fsconfig syscall but does not capture the configuration parameters, creating an audit gap for critical mount information such as the device being mounted.
Add an FSCONFIG auxiliary record that logs the command type, parameter name (key), parameter value, and aux parameter passed to fsconfig(2).
----
type=SYSCALL : syscall=fsconfig ... a1=FSCONFIG_SET_STRING ... type=FSCONFIG : fs_cmd=1 fs_key=source fs_val="tmpfs" fs_aux=0
----
type=SYSCALL : syscall=fsconfig ... a1=FSCONFIG_CMD_CREATE ... type=FSCONFIG : fs_cmd=6 fs_key=(null) fs_val=(null) fs_aux=0
----
type=SYSCALL : syscall=fsconfig ... a1=FSCONFIG_SET_BINARY ... type=FSCONFIG : fs_cmd=2 fs_key=hidepid fs_val="<binary>" fs_aux=4
---
Changes in v2:
- Fixed null-check for fs_key field.
- Clarified trimmed SYSCALL output in commit message examples.
fs/fsopen.c | 7 +++++++ include/linux/audit.h | 13 +++++++++++++ include/uapi/linux/audit.h | 1 + kernel/auditsc.c | 27 +++++++++++++++++++++++++++ 4 files changed, 48 insertions(+)
fs/fsopen.c +7 -0
@@ -15,6 +15,7 @@#include <linux/namei.h> #include <linux/file.h> #include <uapi/linux/mount.h> +#include <linux/audit.h> #include "internal.h" #include "mount.h"
@@ -357,6 +358,7 @@ SYSCALL_DEFINE5(fsconfig,struct fs_context *fc;int ret;int lookup_flags =0 ; +const char *value_str =NULL ;struct fs_parameter param = { .type = fs_value_is_undefined,
@@ -423,6 +425,7 @@ SYSCALL_DEFINE5(fsconfig, goto out_key; } param.size =strlen (param.string); + value_str = param.string;break ;case FSCONFIG_SET_BINARY : param.type = fs_value_is_blob;
@@ -432,6 +435,7 @@ SYSCALL_DEFINE5(fsconfig, ret =PTR_ERR (param.blob); goto out_key; } + value_str ="<binary>" ;break ;case FSCONFIG_SET_PATH_EMPTY : lookup_flags =LOOKUP_EMPTY ;
@@ -445,6 +449,7 @@ SYSCALL_DEFINE5(fsconfig, } param.dirfd = aux; param.size =strlen (param.name->name); + value_str = param.name->name;break ;case FSCONFIG_SET_FD : param.type = fs_value_is_file;
@@ -458,6 +463,8 @@ SYSCALL_DEFINE5(fsconfig,break ; } +audit_log_fsconfig (cmd, param.key, value_str, aux); + ret =mutex_lock_interruptible (&fc->uapi_mutex);if (ret ==0 ) { ret =vfs_fsconfig_locked (fc, cmd, ¶m);
include/linux/audit.h +13 -0
@@ -449,6 +449,8 @@ extern void __audit_tk_injoffset(struct timespec64 offset);extern void __audit_ntp_log (const struct audit_ntp_data *ad);extern void __audit_log_nfcfg (const char *name,u8 af,unsigned int nentries,enum audit_nfcfgop op,gfp_t gfp); +extern void __audit_log_fsconfig (unsigned int cmd,const char *key, +const char *value,int aux);static inline void audit_ipc_obj (struct kern_ipc_perm *ipcp) {
@@ -598,6 +600,13 @@ static inline void audit_log_nfcfg(const char *name, u8 af, __audit_log_nfcfg(name, af, nentries, op, gfp); } +static inline void audit_log_fsconfig (unsigned int cmd,const char *key, +const char *value,int aux) +{ +if (!audit_dummy_context ()) +__audit_log_fsconfig (cmd, key, value, aux); +} +extern int audit_n_rules;extern int audit_signals;#else /* CONFIG_AUDITSYSCALL */
@@ -730,6 +739,10 @@ static inline void audit_log_nfcfg(const char *name, u8 af, enum audit_nfcfgop op, gfp_t gfp) { } +static inline void audit_log_fsconfig (unsigned int cmd,const char *key, +const char *value,int aux) +{ } +#define audit_n_rules 0#define audit_signals 0#endif /* CONFIG_AUDITSYSCALL */
include/uapi/linux/audit.h +1 -0
@@ -122,6 +122,7 @@#define AUDIT_OPENAT2 1337/* Record showing openat2 how args */ #define AUDIT_DM_CTRL 1338/* Device Mapper target control */ #define AUDIT_DM_EVENT 1339/* Device Mapper events */ +#define AUDIT_FSCONFIG 1341/* Record showing fsconfig args */ #define AUDIT_AVC 1400/* SE Linux avc denial or grant */ #define AUDIT_SELINUX_ERR 1401/* Internal SE Linux Errors */
kernel/auditsc.c +27 -0
@@ -2882,6 +2882,33 @@ void __audit_log_nfcfg(const char *name, u8 af, unsigned int nentries, }EXPORT_SYMBOL_GPL (__audit_log_nfcfg); +void __audit_log_fsconfig (unsigned int cmd,const char *key, +const char *value,int aux) +{ +struct audit_buffer *ab; + + ab =audit_log_start (audit_context (),GFP_KERNEL ,AUDIT_FSCONFIG ); +if (!ab) +return ; + +audit_log_format (ab,"fs_cmd=%u" , cmd); +audit_log_format (ab," fs_key=" ); +if (key) +audit_log_untrustedstring (ab, key); +else +audit_log_format (ab,"(null)" ); + +audit_log_format (ab," fs_val=" ); +if (value) +audit_log_untrustedstring (ab, value); +else +audit_log_format (ab,"(null)" ); + +audit_log_format (ab," fs_aux=%d" , aux); + +audit_log_end (ab); +} +static void audit_log_task (struct audit_buffer *ab) {kuid_t auid, uid;
Signature · 1 line
2.53.0
Quoted 19 lines · Ricardo Robaina
Modern mount tools (util-linux >= 2.39.1) use the new mount API (fsopen, fsconfig, fsmount,
move_mount) instead of the legacy mount(2) syscall. The generic SYSCALL audit record logs the fsconfig syscall but does not capture the configuration parameters, creating an audit gap for critical mount information such as the device being mounted.Add an FSCONFIG auxiliary record that logs the command type, parameter name (key), parameter value, and aux parameter passed to fsconfig(2).
----
type=SYSCALL : syscall=fsconfig ... a1=FSCONFIG_SET_STRING ... type=FSCONFIG : fs_cmd=1 fs_key=source fs_val="tmpfs" fs_aux=0
----
type=SYSCALL : syscall=fsconfig ... a1=FSCONFIG_CMD_CREATE ... type=FSCONFIG : fs_cmd=6 fs_key=(null) fs_val=(null) fs_aux=0
----
type=SYSCALL : syscall=fsconfig ... a1=FSCONFIG_SET_BINARY ... type=FSCONFIG : fs_cmd=2 fs_key=hidepid fs_val="<binary>" fs_aux=4
Quoted 3 lines
Quoted 155 lines
---
Changes in v2:
- Fixed null-check forfs_keyfield.
- Clarified trimmed SYSCALL output in commit message examples.fs/fsopen.c | 7 +++++++ include/linux/audit.h | 13 +++++++++++++ include/uapi/linux/audit.h | 1 + kernel/auditsc.c | 27 +++++++++++++++++++++++++++ 4 files changed, 48 insertions(+)fs/fsopen.c +7
-0@@ -15,6 +15,7 @@#include <linux/namei.h> #include <linux/file.h> #include <uapi/linux/mount.h> +#include <linux/audit.h> #include "internal.h" #include "mount.h" @@ -357,6 +358,7 @@ SYSCALL_DEFINE5(fsconfig,struct fs_context *fc;int ret;int lookup_flags =0 ; +const char *value_str =NULL ;struct fs_parameter param = { .type = fs_value_is_undefined,@@ -423,6 +425,7 @@ SYSCALL_DEFINE5(fsconfig, goto out_key; } param.size =strlen (param.string); + value_str = param.string;break ;case FSCONFIG_SET_BINARY : param.type = fs_value_is_blob;@@ -432,6 +435,7 @@ SYSCALL_DEFINE5(fsconfig, ret =PTR_ERR (param.blob); goto out_key; } + value_str ="<binary>" ;break ;case FSCONFIG_SET_PATH_EMPTY : lookup_flags =LOOKUP_EMPTY ;@@ -445,6 +449,7 @@ SYSCALL_DEFINE5(fsconfig, } param.dirfd = aux; param.size =strlen (param.name->name); + value_str = param.name->name;break ;case FSCONFIG_SET_FD : param.type = fs_value_is_file;@@ -458,6 +463,8 @@ SYSCALL_DEFINE5(fsconfig,break ; } +audit_log_fsconfig (cmd, param.key, value_str, aux); + ret =mutex_lock_interruptible (&fc->uapi_mutex);if (ret ==0 ) { ret =vfs_fsconfig_locked (fc, cmd, ¶m);include/linux/audit.h +13
-0@@ -449,6 +449,8 @@ extern void __audit_tk_injoffset(struct timespec64 offset);extern void __audit_ntp_log (const struct audit_ntp_data *ad);extern void __audit_log_nfcfg (const char *name,u8 af,unsigned int nentries,enum audit_nfcfgop op,gfp_t gfp); +extern void __audit_log_fsconfig (unsigned int cmd,const char *key, +const char *value,int aux);static inline void audit_ipc_obj (struct kern_ipc_perm *ipcp) {@@ -598,6 +600,13 @@ static inline void audit_log_nfcfg(const char *name, u8 af, __audit_log_nfcfg(name, af, nentries, op, gfp); } +static inline void audit_log_fsconfig (unsigned int cmd,const char *key, +const char *value,int aux) +{ +if (!audit_dummy_context ()) +__audit_log_fsconfig (cmd, key, value, aux); +} +extern int audit_n_rules;extern int audit_signals;#else /* CONFIG_AUDITSYSCALL */ @@ -730,6 +739,10 @@ static inline void audit_log_nfcfg(const char *name, u8 af, enum audit_nfcfgop op, gfp_t gfp) { } +static inline void audit_log_fsconfig (unsigned int cmd,const char *key, +const char *value,int aux) +{ } +#define audit_n_rules 0#define audit_signals 0#endif /* CONFIG_AUDITSYSCALL */ include/uapi/linux/audit.h +1
-0@@ -122,6 +122,7 @@#define AUDIT_OPENAT2 1337/* Record showing openat2 how args */ #define AUDIT_DM_CTRL 1338/* Device Mapper target control */ #define AUDIT_DM_EVENT 1339/* Device Mapper events */ +#define AUDIT_FSCONFIG 1341/* Record showing fsconfig args */ #define AUDIT_AVC 1400/* SE Linux avc denial or grant */ #define AUDIT_SELINUX_ERR 1401/* Internal SE Linux Errors */ kernel/auditsc.c +27
-0@@ -2882,6 +2882,33 @@ void __audit_log_nfcfg(const char *name, u8 af, unsigned int nentries, }EXPORT_SYMBOL_GPL (__audit_log_nfcfg); +void __audit_log_fsconfig (unsigned int cmd,const char *key, +const char *value,int aux) +{ +struct audit_buffer *ab; + + ab =audit_log_start (audit_context (),GFP_KERNEL ,AUDIT_FSCONFIG ); +if (!ab) +return ; + +audit_log_format (ab,"fs_cmd=%u" , cmd); +audit_log_format (ab," fs_key=" ); +if (key) +audit_log_untrustedstring (ab, key); +else +audit_log_format (ab,"(null)" ); + +audit_log_format (ab," fs_val=" ); +if (value) +audit_log_untrustedstring (ab, value); +else +audit_log_format (ab,"(null)" ); + +audit_log_format (ab," fs_aux=%d" , aux); + +audit_log_end (ab); +} +static void audit_log_task (struct audit_buffer *ab) {kuid_t auid, uid;Signature · 1 line
2.53.0
- RGB
--
Richard Guy Briggs <[email protected]>
Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada
Upstream IRC: SunRaycer
Voice: +1.613.860 2354 SMS: +1.613.518.6570
Paul Moore
maintainerQuoted 63 lines · On Jul 27, 2026 Ricardo Robaina <[email protected]> wrote:
Modern mount tools (util-linux >= 2.39.1) use the new mount API (fsopen, fsconfig, fsmount,
move_mount) instead of the legacy mount(2) syscall. The generic SYSCALL audit record logs the fsconfig syscall but does not capture the configuration parameters, creating an audit gap for critical mount information such as the device being mounted.Add an FSCONFIG auxiliary record that logs the command type, parameter name (key), parameter value, and aux parameter passed to fsconfig(2).
----
type=SYSCALL : syscall=fsconfig ... a1=FSCONFIG_SET_STRING ... type=FSCONFIG : fs_cmd=1 fs_key=source fs_val="tmpfs" fs_aux=0
----
type=SYSCALL : syscall=fsconfig ... a1=FSCONFIG_CMD_CREATE ... type=FSCONFIG : fs_cmd=6 fs_key=(null) fs_val=(null) fs_aux=0
----
type=SYSCALL : syscall=fsconfig ... a1=FSCONFIG_SET_BINARY ... type=FSCONFIG : fs_cmd=2 fs_key=hidepid fs_val="<binary>" fs_aux=4Signed-off-by Ricardo Robaina <[email protected]>---
Changes in v2:
- Fixed null-check forfs_keyfield.
- Clarified trimmed SYSCALL output in commit message examples.fs/fsopen.c | 7 +++++++ include/linux/audit.h | 13 +++++++++++++ include/uapi/linux/audit.h | 1 + kernel/auditsc.c | 27 +++++++++++++++++++++++++++ 4 files changed, 48 insertions(+)fs/fsopen.c +3
-0@@ -15,6 +15,7 @@#include <linux/namei.h> #include <linux/file.h> #include <uapi/linux/mount.h> +#include <linux/audit.h> #include "internal.h" #include "mount.h" @@ -357,6 +358,7 @@ SYSCALL_DEFINE5(fsconfig,struct fs_context *fc;int ret;int lookup_flags =0 ; +const char *value_str =NULL ;struct fs_parameter param = { .type = fs_value_is_undefined,@@ -423,6 +425,7 @@ SYSCALL_DEFINE5(fsconfig, goto out_key; } param.size =strlen (param.string); + value_str = param.string;break ;case FSCONFIG_SET_BINARY : param.type = fs_value_is_blob;
fs/fsopen.c SYSCALL_DEFINE5(fsconfig, · line 438
Quoted 4 lines
fs/fsopen.c +1
-0@@ -432,6 +435,7 @@ SYSCALL_DEFINE5(fsconfig, ret =PTR_ERR (param.blob); goto out_key; } + value_str ="<binary>" ;
Is there a reason why we're not logging the binary data? We might want to impose a size limit to truncate the logged data (although we have provisions to log rather large binary chunks), but I don't see a reason why we couldn't log the binary data as a hex string.
Quoted 20 lines
fs/fsopen.c +3
-0break ;case FSCONFIG_SET_PATH_EMPTY : lookup_flags =LOOKUP_EMPTY ;@@ -445,6 +449,7 @@ SYSCALL_DEFINE5(fsconfig, } param.dirfd = aux; param.size =strlen (param.name->name); + value_str = param.name->name;break ;case FSCONFIG_SET_FD : param.type = fs_value_is_file;@@ -458,6 +463,8 @@ SYSCALL_DEFINE5(fsconfig,break ; } +audit_log_fsconfig (cmd, param.key, value_str, aux); + ret =mutex_lock_interruptible (&fc->uapi_mutex);if (ret ==0 ) { ret =vfs_fsconfig_locked (fc, cmd, ¶m);
...
Quoted 9 lines
kernel/auditsc.c +1
-0@@ -2882,6 +2882,33 @@ void __audit_log_nfcfg(const char *name, u8 af, unsigned int nentries, }EXPORT_SYMBOL_GPL (__audit_log_nfcfg); +void __audit_log_fsconfig(unsigned int cmd, const char *key,
kernel/auditsc.c void __audit_log_nfcfg(const char *name, u8 af, unsigned int nentries, · line 2895
Quoted 10 lines
kernel/auditsc.c +10
-0+ const char *value, int aux) +{ +struct audit_buffer *ab; + + ab =audit_log_start (audit_context (),GFP_KERNEL ,AUDIT_FSCONFIG ); +if (!ab) +return ; + +audit_log_format (ab,"fs_cmd=%u" , cmd); +audit_log_format (ab," fs_key=" );
Calling into audit_log_format() is expensive due to the string processing, we should combine this into a single audit_log_format() call:
audit_log_format(ab, "fs_cmd=%u fs_key=", cmd);
Quoted 21 lines
kernel/auditsc.c +16
-0+if (key) +audit_log_untrustedstring (ab, key); +else +audit_log_format (ab,"(null)" ); + +audit_log_format (ab," fs_val=" ); +if (value) +audit_log_untrustedstring (ab, value); +else +audit_log_format (ab,"(null)" ); + +audit_log_format (ab," fs_aux=%d" , aux); + +audit_log_end (ab); +} +static void audit_log_task (struct audit_buffer *ab) {kuid_t auid, uid;Signature · 1 line
2.53.0
--
paul-moore.com
Quoted 80 lines · Eastern Daylight Time Paul Moore
Quoted 79 lines · On Jul 27, 2026 Ricardo Robaina <[email protected]> wrote:
Modern mount tools (util-linux >= 2.39.1) use the new mount API (fsopen, fsconfig, fsmount,
move_mount) instead of the legacy mount(2) syscall. The generic SYSCALL audit record logs the fsconfig syscall but does not capture the configuration parameters, creating an audit gap for critical mount information such as the device being mounted.Add an FSCONFIG auxiliary record that logs the command type, parameter name (key), parameter value, and aux parameter passed to fsconfig(2).
----
type=SYSCALL : syscall=fsconfig ... a1=FSCONFIG_SET_STRING ... type=FSCONFIG : fs_cmd=1 fs_key=source fs_val="tmpfs" fs_aux=0
----
type=SYSCALL : syscall=fsconfig ... a1=FSCONFIG_CMD_CREATE ... type=FSCONFIG : fs_cmd=6 fs_key=(null) fs_val=(null) fs_aux=0
----
type=SYSCALL : syscall=fsconfig ... a1=FSCONFIG_SET_BINARY ... type=FSCONFIG : fs_cmd=2 fs_key=hidepid fs_val="<binary>" fs_aux=4Signed-off-by Ricardo Robaina <[email protected]>---
Changes in v2:
- Fixed null-check forfs_keyfield.
- Clarified trimmed SYSCALL output in commit message examples.fs/fsopen.c | 7 +++++++ include/linux/audit.h | 13 +++++++++++++ include/uapi/linux/audit.h | 1 + kernel/auditsc.c | 27 +++++++++++++++++++++++++++ 4 files changed, 48 insertions(+)fs/fsopen.c +1
-0@@ -15,6 +15,7 @@#include <linux/namei.h> #include <linux/file.h> #include <uapi/linux/mount.h> +#include <linux/audit.h> #include "
internal.h"
#include "mount.h"fs/fsopen.c +1
-0@@ -357,6 +358,7 @@ SYSCALL_DEFINE5(fsconfig,struct fs_context *fc;int ret;int lookup_flags =0 ; +const char *value_str =NULL ;fs/fsopen.c +1
-0struct fs_parameter param = { .type = fs_value_is_undefined,@@ -423,6 +425,7 @@ SYSCALL_DEFINE5(fsconfig, goto out_key; } param.size =strlen (param.string); + value_str = param.string;fs/fsopen.c +0
-0break ;case FSCONFIG_SET_BINARY : param.type = fs_value_is_blob;@@ -432,6 +435,7 @@ SYSCALL_DEFINE5(fsconfig, ret =PTR_ERR (param.blob); goto out_key;
Quoted 8 lines
fs/fsopen.c SYSCALL_DEFINE5(fsconfig, · line 438
Quoted 3 lines
fs/fsopen.c +1
-0} + value_str ="<binary>" ;Is there a reason why we're not logging the binary data? We might want to impose a size limit to truncate the logged data (although we have provisions to log rather large binary chunks), but I don't see a reason why we couldn't log the binary data as a hex string.
I did a search for any user of this. There are no known consumers. Last February, fsparam_blob() / fs_param_is_blob parser support was removed. That means we don't really have a use case. If, for example, someone decided to use this API to insert a private key used for decryption or something, we probably don't want that in logs. So, without an actual use case, it's hard to say if logging this would be a liability or something needed. But yes, it could be done with the hex string encoding if required.
-Steve
Quoted 85 lines
Quoted 31 lines
fs/fsopen.c +1
-0break ;case FSCONFIG_SET_PATH_EMPTY : lookup_flags =LOOKUP_EMPTY ;@@ -445,6 +449,7 @@ SYSCALL_DEFINE5(fsconfig, } param.dirfd = aux; param.size =strlen (param.name->name); + value_str = param.name->name;fs/fsopen.c +2
-0break ;case FSCONFIG_SET_FD : param.type = fs_value_is_file;@@ -458,6 +463,8 @@ SYSCALL_DEFINE5(fsconfig,break ; } +audit_log_fsconfig (cmd, param.key, value_str, aux); +fs/fsopen.c +0
-0ret =mutex_lock_interruptible (&fc->uapi_mutex);if (ret ==0 ) { ret =vfs_fsconfig_locked (fc, cmd, ¶m);...
Quoted 10 lines
kernel/auditsc.c +0
-0@@ -2882,6 +2882,33 @@ void __audit_log_nfcfg(const char *name, u8 af,unsigned int nentries,>
}
EXPORT_SYMBOL_GPL(__audit_log_nfcfg);kernel/auditsc.c +1
-0+void __audit_log_fsconfig(unsigned int cmd, const char *key,kernel/auditsc.c void __audit_log_nfcfg(const char *name, u8 af, unsigned int nentries, · line 2895
Quoted 10 lines
kernel/auditsc.c +10
-0+ const char *value, int aux) +{ +struct audit_buffer *ab; + + ab =audit_log_start (audit_context (),GFP_KERNEL ,AUDIT_FSCONFIG ); +if (!ab) +return ; + +audit_log_format (ab,"fs_cmd=%u" , cmd); +audit_log_format (ab," fs_key=" );Calling into
audit_log_format()is expensive due to the string processing, we should combine this into a singleaudit_log_format()call:
audit_log_format(ab, "fs_cmd=%u fs_key=", cmd);Quoted 11 lines
kernel/auditsc.c +11
-0+if (key) +audit_log_untrustedstring (ab, key); +else +audit_log_format (ab,"(null)" ); + +audit_log_format (ab," fs_val=" ); +if (value) +audit_log_untrustedstring (ab, value); +else +audit_log_format (ab,"(null)" ); +kernel/auditsc.c void __audit_log_nfcfg(const char *name, u8 af, unsigned int nentries, · line 2914
Quoted 10 lines
kernel/auditsc.c +5
-0+audit_log_format (ab," fs_aux=%d" , aux); + +audit_log_end (ab); +} +static void audit_log_task (struct audit_buffer *ab) {kuid_t auid, uid;--
paul-moore.com
Paul Moore
maintainerQuoted 90 lines · Steve Grubb
Quoted 80 lines · Eastern Daylight Time Paul Moore
Quoted 79 lines · On Jul 27, 2026 Ricardo Robaina <[email protected]> wrote:
Modern mount tools (util-linux >= 2.39.1) use the new mount API (fsopen, fsconfig, fsmount,
move_mount) instead of the legacy mount(2) syscall. The generic SYSCALL audit record logs the fsconfig syscall but does not capture the configuration parameters, creating an audit gap for critical mount information such as the device being mounted.Add an FSCONFIG auxiliary record that logs the command type, parameter name (key), parameter value, and aux parameter passed to fsconfig(2).
----
type=SYSCALL : syscall=fsconfig ... a1=FSCONFIG_SET_STRING ... type=FSCONFIG : fs_cmd=1 fs_key=source fs_val="tmpfs" fs_aux=0
----
type=SYSCALL : syscall=fsconfig ... a1=FSCONFIG_CMD_CREATE ... type=FSCONFIG : fs_cmd=6 fs_key=(null) fs_val=(null) fs_aux=0
----
type=SYSCALL : syscall=fsconfig ... a1=FSCONFIG_SET_BINARY ... type=FSCONFIG : fs_cmd=2 fs_key=hidepid fs_val="<binary>" fs_aux=4Signed-off-by Ricardo Robaina <[email protected]>---
Changes in v2:
- Fixed null-check forfs_keyfield.
- Clarified trimmed SYSCALL output in commit message examples.fs/fsopen.c | 7 +++++++ include/linux/audit.h | 13 +++++++++++++ include/uapi/linux/audit.h | 1 + kernel/auditsc.c | 27 +++++++++++++++++++++++++++ 4 files changed, 48 insertions(+)fs/fsopen.c +1
-0@@ -15,6 +15,7 @@#include <linux/namei.h> #include <linux/file.h> #include <uapi/linux/mount.h> +#include <linux/audit.h> #include "
internal.h"
#include "mount.h"fs/fsopen.c +1
-0@@ -357,6 +358,7 @@ SYSCALL_DEFINE5(fsconfig,struct fs_context *fc;int ret;int lookup_flags =0 ; +const char *value_str =NULL ;struct
fs_parameterparam = {.type =
fs_value_is_undefined,fs/fsopen.c +1
-0@@ -423,6 +425,7 @@ SYSCALL_DEFINE5(fsconfig, goto out_key; } param.size =strlen (param.string); + value_str = param.string;break; case FSCONFIG_SET_BINARY: param.type = fs_value_is_blob;fs/fsopen.c +0
-0@@ -432,6 +435,7 @@ SYSCALL_DEFINE5(fsconfig, ret =PTR_ERR (param.blob); goto out_key;Quoted 8 lines
fs/fsopen.c SYSCALL_DEFINE5(fsconfig, · line 438
Quoted 3 lines
fs/fsopen.c +1
-0} + value_str ="<binary>" ;Is there a reason why we're not logging the binary data? We might want to impose a size limit to truncate the logged data (although we have provisions to log rather large binary chunks), but I don't see a reason why we couldn't log the binary data as a hex string.
Quoted 7 lines
I did a search for any user of this. There are no known consumers. Last February,
fsparam_blob()/fs_param_is_blobparser support was removed. That means we don't really have a use case. If, for example, someone decided to use this API to insert a private key used for decryption or something, we probably don't want that in logs. So, without an actual use case, it's hard to say if logging this would be a liability or something needed. But yes, it could be done with the hex string encoding if required.
Let's just log the binary data.
Signature · 1 line
paul-moore.com
Quoted 100 lines · Paul Moore
Quoted 90 lines · Steve Grubb
Quoted 80 lines · Eastern Daylight Time Paul Moore
Quoted 79 lines · On Jul 27, 2026 Ricardo Robaina <[email protected]> wrote:
Modern mount tools (util-linux >= 2.39.1) use the new mount API (fsopen, fsconfig, fsmount,
move_mount) instead of the legacy mount(2) syscall. The generic SYSCALL audit record logs the fsconfig syscall but does not capture the configuration parameters, creating an audit gap for critical mount information such as the device being mounted.Add an FSCONFIG auxiliary record that logs the command type, parameter name (key), parameter value, and aux parameter passed to fsconfig(2).
----
type=SYSCALL : syscall=fsconfig ... a1=FSCONFIG_SET_STRING ... type=FSCONFIG : fs_cmd=1 fs_key=source fs_val="tmpfs" fs_aux=0
----
type=SYSCALL : syscall=fsconfig ... a1=FSCONFIG_CMD_CREATE ... type=FSCONFIG : fs_cmd=6 fs_key=(null) fs_val=(null) fs_aux=0
----
type=SYSCALL : syscall=fsconfig ... a1=FSCONFIG_SET_BINARY ... type=FSCONFIG : fs_cmd=2 fs_key=hidepid fs_val="<binary>" fs_aux=4Signed-off-by Ricardo Robaina <[email protected]>---
Changes in v2:
- Fixed null-check forfs_keyfield.
- Clarified trimmed SYSCALL output in commit message examples.fs/fsopen.c | 7 +++++++ include/linux/audit.h | 13 +++++++++++++ include/uapi/linux/audit.h | 1 + kernel/auditsc.c | 27 +++++++++++++++++++++++++++ 4 files changed, 48 insertions(+)fs/fsopen.c +1
-0@@ -15,6 +15,7 @@#include <linux/namei.h> #include <linux/file.h> #include <uapi/linux/mount.h> +#include <linux/audit.h> #include "
internal.h"
#include "mount.h"fs/fsopen.c +1
-0@@ -357,6 +358,7 @@ SYSCALL_DEFINE5(fsconfig,struct fs_context *fc;int ret;int lookup_flags =0 ; +const char *value_str =NULL ;struct
fs_parameterparam = {.type =
fs_value_is_undefined,fs/fsopen.c +1
-0@@ -423,6 +425,7 @@ SYSCALL_DEFINE5(fsconfig, goto out_key; } param.size =strlen (param.string); + value_str = param.string;break; case FSCONFIG_SET_BINARY: param.type = fs_value_is_blob;fs/fsopen.c +0
-0@@ -432,6 +435,7 @@ SYSCALL_DEFINE5(fsconfig, ret =PTR_ERR (param.blob); goto out_key;Quoted 8 lines
fs/fsopen.c SYSCALL_DEFINE5(fsconfig, · line 438
Quoted 3 lines
fs/fsopen.c +1
-0} + value_str ="<binary>" ;Is there a reason why we're not logging the binary data? We might want to impose a size limit to truncate the logged data (although we have provisions to log rather large binary chunks), but I don't see a reason why we couldn't log the binary data as a hex string.
Quoted 7 lines
I did a search for any user of this. There are no known consumers. Last February,
fsparam_blob()/fs_param_is_blobparser support was removed. That means we don't really have a use case. If, for example, someone decided to use this API to insert a private key used for decryption or something, we probably don't want that in logs. So, without an actual use case, it's hard to say if logging this would be a liability or something needed. But yes, it could be done with the hex string encoding if required.
Quoted 1 line
Let's just log the binary data.
Good. I'll be sending a new version shortly. Thank you all!
Quoted 4 lines
--
paul-moore.com
-Ricardo