udp: fix potential use-after-free in tunnel segmentation
Subsystems (2)
PATCH 1/1 udp: fix potential use-after-free in tunnel segmentation
From: Xuanqiang Luo <[email protected]>
__skb_udp_tunnel_segment() gets the UDP header before ensuring the tunnel header is in the skb head. If the pull reallocates skb->head, the saved UDP header pointer is no longer valid.
Get the UDP header after the pull to avoid a potential use-after-free.
--- net/ipv4/udp_offload.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
net/ipv4/udp_offload.c +3 -1
@@ -178,7 +178,7 @@ static struct sk_buff *__skb_udp_tunnel_segment(struct sk_buff *skb,int tnl_hlen =skb_inner_mac_header (skb) -skb_transport_header (skb);bool remcsum, need_csum, offload_csum, gso_partial;struct sk_buff *segs =ERR_PTR (-EINVAL ); -struct udphdr *uh =udp_hdr (skb); +struct udphdr *uh;u16 mac_offset = skb->mac_header;__be16 protocol = skb->protocol;u16 mac_len = skb->mac_len;
@@ -189,6 +189,8 @@ static struct sk_buff *__skb_udp_tunnel_segment(struct sk_buff *skb,if (unlikely (!pskb_may_pull (skb, tnl_hlen))) goto out; + uh =udp_hdr (skb); +/* Adjust partial header checksum to negate old length. * We cannot rely on the value contained in uh->len as it is * possible that the actual value exceeds the boundaries of the
Signature · 1 line
2.43.0
Quoted 10 lines · On Thu, Jul 30, 2026 at 05:35:54PM +0800, [email protected] wrote:
From: Xuanqiang Luo <[email protected]>
__skb_udp_tunnel_segment()gets the UDP header before ensuring the tunnel header is in the skb head. If the pull reallocatesskb->head, the saved UDP header pointer is no longer valid.Get the UDP header after the pull to avoid a potential use-after-free.
Fixes dbef491ebe7f ("udp: Use uh->len instead of skb->len to compute checksum in segmentation")Signed-off-by Xuanqiang Luo <[email protected]>
Quoted 29 lines
--- net/ipv4/udp_offload.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)net/ipv4/udp_offload.c +3
-1@@ -178,7 +178,7 @@ static struct sk_buff *__skb_udp_tunnel_segment(struct sk_buff *skb,int tnl_hlen =skb_inner_mac_header (skb) -skb_transport_header (skb);bool remcsum, need_csum, offload_csum, gso_partial;struct sk_buff *segs =ERR_PTR (-EINVAL ); -struct udphdr *uh =udp_hdr (skb); +struct udphdr *uh;u16 mac_offset = skb->mac_header;__be16 protocol = skb->protocol;u16 mac_len = skb->mac_len;@@ -189,6 +189,8 @@ static struct sk_buff *__skb_udp_tunnel_segment(struct sk_buff *skb,if (unlikely (!pskb_may_pull (skb, tnl_hlen))) goto out; + uh =udp_hdr (skb); +/* Adjust partial header checksum to negate old length. * We cannot rely on the value contained in uh->len as it is * possible that the actual value exceeds the boundaries of the Signature · 1 line
2.43.0
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Thu, 30 Jul 2026 17:35:54 +0800 you wrote:
From: Xuanqiang Luo <[email protected]>
__skb_udp_tunnel_segment()gets the UDP header before ensuring the tunnel header is in the skb head. If the pull reallocatesskb->head, the saved UDP header pointer is no longer valid.Get the UDP header after the pull to avoid a potential use-after-free.
[...]
Here is the summary with links:
- [net,v1] udp: fix potential use-after-free in tunnel segmentation
https://git.kernel.org/netdev/net/c/d0f86fb36eb2
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html