scsi: lpfc: remove unnnecessary NULL check
Subsystems (3)
PATCH 1/1 scsi: lpfc: remove unnnecessary NULL check
The "evt_dat" variale is non-NULL at this point so there is no need to check. Delete the check and pull the code in a tab.
--- drivers/scsi/lpfc/lpfc_bsg.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/scsi/lpfc/lpfc_bsg.c +2 -4
@@ -1329,10 +1329,8 @@ lpfc_bsg_hba_get_event(struct bsg_job *job)else bsg_reply->reply_payload_rcv_len =0 ; -if (evt_dat) { -kfree (evt_dat->data); -kfree (evt_dat); - } +kfree (evt_dat->data); +kfree (evt_dat);spin_lock_irqsave (&phba->ct_ev_lock, flags);lpfc_bsg_event_unref (evt);
Signature · 1 line
2.53.0
Quoted 27 lines · Dan Carpenter
The "
evt_dat" variale is non-NULL at this point so there is no need to check. Delete the check and pull the code in a tab.Signed-off-by Dan Carpenter <[email protected]>--- drivers/scsi/lpfc/lpfc_bsg.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/scsi/lpfc/lpfc_bsg.c +2
-5@@ -1329,10 +1329,8 @@ lpfc_bsg_hba_get_event(struct bsg_job *job)else bsg_reply->reply_payload_rcv_len =0 ; -if (evt_dat) { -kfree (evt_dat->data); -kfree (evt_dat); - } +kfree (evt_dat->data); +kfree (evt_dat);spin_lock_irqsave (&phba->ct_ev_lock, flags);lpfc_bsg_event_unref (evt); --
Quoted 2 lines
2.53.0
Yes, evt_data was already checked for NULL and the follow up check has no value. Looks good.
Dan,
Quoted 2 lines
The "
evt_dat" variale is non-NULL at this point so there is no need to check. Delete the check and pull the code in a tab.
Applied to 7.3/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen
Quoted 2 lines · Dan Carpenter
The "
evt_dat" variale is non-NULL at this point so there is no need to check. Delete the check and pull the code in a tab.
Applied to 7.3/scsi-queue, thanks!
[1/1] scsi: lpfc: remove unnnecessary NULL check
https://git.kernel.org/mkp/scsi/c/0ec418204f23
Signature · 1 line
Martin K. Petersen