Skip to contentSkip to conversation

drm/xe: tests: fix error message in xe_migrate_sanity_test()

PATCH In review Dan Carpenter 3 participants 3 messages Aug 13

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/xe: tests: fix error message in xe_migrate_sanity_test()

This is supposed to print the error code but there is a copy and paste bug so it prints "bo" instead of "err".

Fixes dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
---
 drivers/gpu/drm/xe/tests/xe_migrate.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/xe/tests/xe_migrate.c +1 -2
index 3c1be809be82..f10d9513747b 100644
@@ -198,8 +198,7 @@ static void xe_migrate_sanity_test(struct xe_migrate *m, struct kunit *test,
 
 	err = xe_bo_vmap(bo);
 	if (err) {
-		KUNIT_FAIL(test, "Failed to vmap our pagetables: %li\n",
-			   PTR_ERR(bo));
+		KUNIT_FAIL(test, "Failed to vmap our pagetables: %d\n", err);
 		return;
 	}
 
Signature · 1 line
2.53.0
#1 lore raw

✗ LGCI.VerificationFailed: failure for drm/xe: tests: fix error message in xe_migrate_sanity_test()

== Series Details ==

== Series Details ==

Series: drm/xe: tests: fix error message in xe_migrate_sanity_test()
URL : https://patchwork.freedesktop.org/series/172115/
State : failure

== Summary ==

Series author address '[email protected]' is not on the allowlist, which prevents CI from being automatically triggered. If you want CI to run for this series, ask Patchwork project owners to click 'retest' on the series in Patchwork. Exception occurred during validation, bailing out!
Build URL: http://intel-gfx-ci-public.igk.intel.com:8080/job/xe_pw_trigger/1246656/ (on master)

maintainer
#2 lore raw
In reply to Dan Carpenter
Quoted 5 lines · Dan Carpenter

This is supposed to print the error code but there is a copy and paste bug so it prints "bo" instead of "err".

Fixes dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")

pushed, thanks for the fix

Quoted 21 lines
---
 drivers/gpu/drm/xe/tests/xe_migrate.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/xe/tests/xe_migrate.c +1 -2
index 3c1be809be82..f10d9513747b 100644
@@ -198,8 +198,7 @@ static void xe_migrate_sanity_test(struct xe_migrate *m, struct kunit *test,
 
 	err = xe_bo_vmap(bo);
 	if (err) {
-		KUNIT_FAIL(test, "Failed to vmap our pagetables: %li\n",
-			   PTR_ERR(bo));
+		KUNIT_FAIL(test, "Failed to vmap our pagetables: %d\n", err);
 		return;
 	}
 
Signature · 1 line
2.53.0