Skip to contentSkip to conversation

ipmi: Remove all sysfs files on registration failure

PATCH In review Yuho Choi 2 participants 2 messages Aug 3 IPMI

lore
Share & tools
lore

Yuho Choi

author
#0 lore raw

PATCH 1/1 ipmi: Remove all sysfs files on registration failure

ipmi_add_smi() creates the nr_users and nr_msgs files before trying to create the maintenance_mode file. If that last creation fails, the error path removes only nr_users before dropping the final reference to the interface.

Remove nr_msgs as well so no sysfs attribute embedded in the freed interface remains registered.

Fixes 627118470fcc ("ipmi: Add a maintenance mode sysfs file")
---
 drivers/char/ipmi/ipmi_msghandler.c | 1 +
 1 file changed, 1 insertion(+)
drivers/char/ipmi/ipmi_msghandler.c +1 -0
index ab4c85f3d6fe..546b7ca8d68e 100644
@@ -3740,6 +3740,7 @@ int ipmi_add_smi(struct module         *owner,
 	sysfs_attr_init(&intf->maintenance_mode_devattr.attr);
 	rv = device_create_file(intf->si_dev, &intf->maintenance_mode_devattr);
 	if (rv) {
+		device_remove_file(intf->si_dev, &intf->nr_msgs_devattr);
 		device_remove_file(intf->si_dev, &intf->nr_users_devattr);
 		goto out_err_bmc_reg;
 	}
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 7 lines · Yuho Choi

ipmi_add_smi() creates the nr_users and nr_msgs files before trying to create the maintenance_mode file. If that last creation fails, the error path removes only nr_users before dropping the final reference to the interface.

Remove nr_msgs as well so no sysfs attribute embedded in the freed interface remains registered.

Thanks, this is queued for next release.

I've also copied stable for a backport to 6.18.

-corey

Quoted 22 lines
Fixes 627118470fcc ("ipmi: Add a maintenance mode sysfs file")
---
 drivers/char/ipmi/ipmi_msghandler.c | 1 +
 1 file changed, 1 insertion(+)
drivers/char/ipmi/ipmi_msghandler.c +1 -0
index ab4c85f3d6fe..546b7ca8d68e 100644
@@ -3740,6 +3740,7 @@ int ipmi_add_smi(struct module         *owner,
 	sysfs_attr_init(&intf->maintenance_mode_devattr.attr);
 	rv = device_create_file(intf->si_dev, &intf->maintenance_mode_devattr);
 	if (rv) {
+		device_remove_file(intf->si_dev, &intf->nr_msgs_devattr);
 		device_remove_file(intf->si_dev, &intf->nr_users_devattr);
 		goto out_err_bmc_reg;
 	}
Signature · 1 line
2.43.0