ipmi: Fix leak in __ipmi_bmc_register
PATCH 1/1 ipmi: Fix leak in __ipmi_bmc_register
In case that ida_alloc(&ipmi_bmc_ida,...) succeeds and then platform_device_register() fails, ipmi_bmc_ida is leaked. Fix by freeing the error path
Signed-off-by Michail Tatas <[email protected]>
--- drivers/char/ipmi/ipmi_msghandler.c | 1 + 1 file changed, 1 insertion(+)
drivers/char/ipmi/ipmi_msghandler.c +1 -0
@@ -3301,6 +3301,7 @@ static int __ipmi_bmc_register(struct ipmi_smi *intf,list_del (&intf->bmc_link);mutex_unlock (&bmc->dyn_mutex); intf->bmc = &intf->tmp_bmc; +ida_free (&ipmi_bmc_ida, bmc->pdev.id);put_device (&bmc->pdev.dev); goto out; }
Signature · 1 line
2.43.0
Corey Minyard
maintainerQuoted 3 lines · Michail Tatas
In case that
ida_alloc(&ipmi_bmc_ida,...)succeeds and thenplatform_device_register()fails,ipmi_bmc_idais leaked. Fix by freeing the error path
You are correct, added to my next tree. Thank you.
-corey
Quoted 21 lines
Signed-off-by Michail Tatas <[email protected]>--- drivers/char/ipmi/ipmi_msghandler.c | 1 + 1 file changed, 1 insertion(+)drivers/char/ipmi/ipmi_msghandler.c +1
-0@@ -3301,6 +3301,7 @@ static int __ipmi_bmc_register(struct ipmi_smi *intf,list_del (&intf->bmc_link);mutex_unlock (&bmc->dyn_mutex); intf->bmc = &intf->tmp_bmc; +ida_free (&ipmi_bmc_ida, bmc->pdev.id);put_device (&bmc->pdev.dev); goto out; }Signature · 1 line
2.43.0