crypto/krb5: use kfree_sensitive() for derived key buffers
Subsystems (2)
PATCH 1/1 crypto/krb5: use kfree_sensitive() for derived key buffers
crypto_krb5_prepare_encryption() and crypto_krb5_prepare_checksum() free the buffer holding the freshly derived keys with plain kfree(), leaving the key material behind in the freed slab object.
Fixes 3936f02bf2d3 ("crypto/krb5: Implement Kerberos crypto core")
Signed-off-by Jan Sebastian Götte <[email protected]>
--- crypto/krb5/krb5_api.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
crypto/krb5/krb5_api.c +4 -4
@@ -263,10 +263,10 @@ struct crypto_aead *crypto_krb5_prepare_encryption(const struct krb5_enctype *kr goto err; } -kfree (keys.data); +kfree_sensitive (keys.data);return ci; err: -kfree (keys.data); +kfree_sensitive (keys.data);return ERR_PTR (ret); }EXPORT_SYMBOL (crypto_krb5_prepare_encryption);
@@ -333,10 +333,10 @@ struct crypto_shash *crypto_krb5_prepare_checksum(const struct krb5_enctype *krb goto err; } -kfree (keys.data); +kfree_sensitive (keys.data);return ci; err: -kfree (keys.data); +kfree_sensitive (keys.data);return ERR_PTR (ret); }EXPORT_SYMBOL (crypto_krb5_prepare_checksum);
Signature · 1 line
2.53.0
Herbert Xu
maintainerQuoted 10 lines · Jan Sebastian Götte
crypto_krb5_prepare_encryption()andcrypto_krb5_prepare_checksum()free the buffer holding the freshly derived keys with plainkfree(), leaving the key material behind in the freed slab object.Fixes 3936f02bf2d3 ("crypto/krb5: Implement Kerberos crypto core")Signed-off-by Jan Sebastian Götte <[email protected]>--- crypto/krb5/krb5_api.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt