Skip to contentSkip to conversation

iio: adc: max1363: sign-extend bipolar differential channel reads

PATCH Applied Cong Nguyen 3 participants 3 messages Aug 10 – Aug 17 IIO

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 iio: adc: max1363: sign-extend bipolar differential channel reads

MAX1363 differential channels are bipolar (scan_type.sign = 's'), but max1363_read_single_chan() masks the raw value to the ADC resolution without sign-extending it. Negative differential readings are therefore reported to userspace as large positive values (e.g. -1 as 4095 on a 12-bit part).

Sign-extend the masked value from the resolution bit for differential channels. Single-ended channels are unipolar and are left unchanged.

Fixes d1325cf45077 ("Staging: IIO: max1363 ADC driver")
Assisted-by Claude:claude-opus-4

---
Changes in v2:
- Condense the commit message (Andy Shevchenko).
- Fix the Fixes: tag to the original driver commit d1325cf45077 rather than the staging->iio move; the bug has been present since the driver was added in staging (Andy Shevchenko).

 drivers/iio/adc/max1363.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/iio/adc/max1363.c +8 -0
index 4d0b79cfeb27..497f5daadcea 100644
@@ -405,6 +405,14 @@ static int max1363_read_single_chan(struct iio_dev *indio_dev,
 
 		data = rxbuf[0];
 	}
+
+	/*
+	 * Differential channels are bipolar and the device returns the sample
+	 * in two's complement, so sign-extend it from the resolution bit.
+	 */
+	if (chan->differential)
+		data = sign_extend32(data, st->chip_info->bits - 1);
+
 	*val = data;
 
 	return 0;
Signature · 1 line
2.25.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 1 line · Cong Nguyen

MAX1363 differential channels are bipolar (scan_type.sign = 's'), but

The (...) can also be dropped, but I leave that to Jonathan, no need to resend.

Quoted 7 lines

max1363_read_single_chan() masks the raw value to the ADC resolution without sign-extending it. Negative differential readings are therefore reported to userspace as large positive values (e.g. -1 as 4095 on a 12-bit part).

Sign-extend the masked value from the resolution bit for differential channels. Single-ended channels are unipolar and are left unchanged.

Now looks good to me,

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer Applied
#2 lore raw
Quoted 10 lines · On Mon, 10 Aug 2026 20:04:23 +0300 Andy Shevchenko…
Quoted 1 line · Cong Nguyen

MAX1363 differential channels are bipolar (scan_type.sign = 's'), but

The (...) can also be dropped, but I leave that to Jonathan, no need to resend.

Quoted 5 lines

max1363_read_single_chan() masks the raw value to the ADC resolution without sign-extending it. Negative differential readings are therefore reported to userspace as large positive values (e.g. -1 as 4095 on a 12-bit part).

Quoted 5 lines
Quoted 2 lines

Sign-extend the masked value from the resolution bit for differential channels. Single-ended channels are unipolar and are left unchanged.

Now looks good to me,

Applied. Amazing that's sat there for so long given it is a reasonably common part. Oops - that younger me wrote just as many bugs as the current version ;)

On the fixes-togreg branch but unlikely I'll do a pull request until I've rebased that on 7.3-rc1 in a few weeks time.

Jonathan

Quoted 1 line