Skip to contentSkip to conversation

tcp: fix use-after-free of the listener's ipv6_pinfo after IPV6_ADDRFORM

PATCH In review Hyunwoo Kim 2 participants 4 messages Aug 11 – Aug 14

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tcp: fix use-after-free of the listener's ipv6_pinfo after IPV6_ADDRFORM

IPV6_ADDRFORM moves an established AF_INET6 TCP socket over to tcp_prot and ipv4_specific. The socket is still a tcp6_sock though, so ->pinet6 keeps pointing at the ipv6_pinfo inside it and sk_destruct stays the IPv6 one; commit d38afeec26ed ("tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().") relies on that to release the IPv6 state.

Once such a socket is disconnected and listen()ed again, its children are cloned from an IPv6 parent but allocated from tcp_prot, so they have no ipv6_pinfo of their own and inherit the listener's ->pinet6 and its IPv6 destructor. The only thing that would fix that up is tcp_v6_mapped_child_init(), which is not passed to tcp_v4_syn_recv_sock() on this path. A child accepted from such a listener can outlive it, and its destructor then runs inet6_cleanup_sock() on the freed listener.

Commit 858d2a4f67ff ("tcp: fix potential race in tcp_v6_syn_recv_sock()") added opt_child_init for the v4-mapped child; this is the same stale ->pinet6 on the path that never gets it.

Clear the IPv6 fields on the child. The converted listener has to keep its own, so there is nothing to clear on the IPV6_ADDRFORM side.

Fixes d38afeec26ed ("tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().")
---
 net/ipv4/tcp_ipv4.c | 6 +++++-
 net/ipv6/af_inet6.c | 3 +++
 2 files changed, 8 insertions(+), 1 deletion(-)
net/ipv4/tcp_ipv4.c +5 -1
index 7f413f509d7dce..f830b212d38e49 100644
@@ -1730,8 +1730,12 @@ struct sock *tcp_v4_syn_recv_sock(const struct sock *sk, struct sk_buff *skb,
 	sk_setup_caps(newsk, dst);
 
 #if IS_ENABLED(CONFIG_IPV6)
-	if (opt_child_init)
+	if (opt_child_init) {
 		opt_child_init(newsk, sk);
+	} else {
+		newinet->pinet6 = NULL;
+		newinet->ipv6_fl_list = NULL;
+	}
 #endif
 	tcp_ca_openreq_child(newsk, dst);
 
net/ipv6/af_inet6.c +3 -0
index 282912a1199992..2090289408c035 100644
@@ -479,6 +479,9 @@ void inet6_cleanup_sock(struct sock *sk)
 	struct sk_buff *skb;
 	struct ipv6_txoptions *opt;
 
+	if (!np)
+		return;
+
 	/* Release rx options */
 
 	skb = xchg(&np->pktoptions, NULL);
Signature · 1 line
2.43.0
#1 lore raw
Quoted 35 lines · Hyunwoo Kim

IPV6_ADDRFORM moves an established AF_INET6 TCP socket over to tcp_prot and ipv4_specific. The socket is still a tcp6_sock though, so ->pinet6 keeps pointing at the ipv6_pinfo inside it and sk_destruct stays the IPv6 one; commit d38afeec26ed ("tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().") relies on that to release the IPv6 state.

Once such a socket is disconnected and listen()ed again, its children are cloned from an IPv6 parent but allocated from tcp_prot, so they have no ipv6_pinfo of their own and inherit the listener's ->pinet6 and its IPv6 destructor. The only thing that would fix that up is tcp_v6_mapped_child_init(), which is not passed to tcp_v4_syn_recv_sock() on this path. A child accepted from such a listener can outlive it, and its destructor then runs inet6_cleanup_sock() on the freed listener.

Commit 858d2a4f67ff ("tcp: fix potential race in tcp_v6_syn_recv_sock()") added opt_child_init for the v4-mapped child; this is the same stale ->pinet6 on the path that never gets it.

Clear the IPv6 fields on the child. The converted listener has to keep its own, so there is nothing to clear on the IPV6_ADDRFORM side.

Fixes d38afeec26ed ("tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().")
---
 net/ipv4/tcp_ipv4.c | 6 +++++-
 net/ipv6/af_inet6.c | 3 +++
 2 files changed, 8 insertions(+), 1 deletion(-)
net/ipv4/tcp_ipv4.c +0 -0
index 7f413f509d7dce..f830b212d38e49 100644

net/ipv4/tcp_ipv4.c struct sock *tcp_v4_syn_recv_sock(const struct sock *sk, struct sk_buff *skb, · line 1737

Quoted 9 lines
net/ipv4/tcp_ipv4.c +4 -1
@@ -1730,8 +1730,12 @@ struct sock *tcp_v4_syn_recv_sock(const struct sock *sk, struct sk_buff *skb,
        sk_setup_caps(newsk, dst);
 
 #if IS_ENABLED(CONFIG_IPV6)
-       if (opt_child_init)
+       if (opt_child_init) {
                opt_child_init(newsk, sk);
+       } else {
+               newinet->pinet6 = NULL;
+               newinet->ipv6_fl_list = NULL;

Instead of adding a new test in inet6_cleanup_sock(() I would add here :

newsk->sk_destruct = inet_sock_destruct;

Quoted 19 lines
net/ipv4/tcp_ipv4.c +1 -0
+       }
 #endif
        tcp_ca_openreq_child(newsk, dst);
 
net/ipv6/af_inet6.c +3 -1
index 282912a1199992..2090289408c035 100644
@@ -479,6 +479,9 @@ void inet6_cleanup_sock(struct sock *sk)
        struct sk_buff *skb;
        struct ipv6_txoptions *opt;
 
+       if (!np)
+               return;
+
        /* Release rx options */
 
        skb = xchg(&np->pktoptions, NULL);
--
Quoted 1 line

2.43.0

Also, it seems weird that all these issues caused by tcp_disconnect() are fixed by AI agents adding code in TCP fast paths.

What about adding code in tcp_disconnect() that only fuzzers are possibly using?

Untested patch:

net/ipv4/tcp.c +0 -0
index 455441f1b694904172cfa1d8e7bac7076b60cb24..9dd44b0a31c4dc751b22558dc6b53ed49598e0b6

100644

net/ipv4/tcp.c +9 -0
@@ -3501,6 +3501,15 @@ int tcp_disconnect(struct sock *sk, int flags)
                sk->sk_frag.page = NULL;
                sk->sk_frag.offset = 0;
        }
+
+#if IS_ENABLED(CONFIG_IPV6)
+       if (sk->sk_family == PF_INET &&
+           sk->sk_destruct == inet6_sock_destruct) {
+               sk->sk_destruct = inet_sock_destruct;
+               inet->pinet6 = NULL;
+       }
+#endif
+
        sk_error_report(sk);
        return 0;
 }
#2 lore raw
Quoted 87 lines · Eric Dumazet
Quoted 35 lines · Hyunwoo Kim

IPV6_ADDRFORM moves an established AF_INET6 TCP socket over to tcp_prot and ipv4_specific. The socket is still a tcp6_sock though, so ->pinet6 keeps pointing at the ipv6_pinfo inside it and sk_destruct stays the IPv6 one; commit d38afeec26ed ("tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().") relies on that to release the IPv6 state.

Once such a socket is disconnected and listen()ed again, its children are cloned from an IPv6 parent but allocated from tcp_prot, so they have no ipv6_pinfo of their own and inherit the listener's ->pinet6 and its IPv6 destructor. The only thing that would fix that up is tcp_v6_mapped_child_init(), which is not passed to tcp_v4_syn_recv_sock() on this path. A child accepted from such a listener can outlive it, and its destructor then runs inet6_cleanup_sock() on the freed listener.

Commit 858d2a4f67ff ("tcp: fix potential race in tcp_v6_syn_recv_sock()") added opt_child_init for the v4-mapped child; this is the same stale ->pinet6 on the path that never gets it.

Clear the IPv6 fields on the child. The converted listener has to keep its own, so there is nothing to clear on the IPV6_ADDRFORM side.

Fixes d38afeec26ed ("tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().")
---
 net/ipv4/tcp_ipv4.c | 6 +++++-
 net/ipv6/af_inet6.c | 3 +++
 2 files changed, 8 insertions(+), 1 deletion(-)
net/ipv4/tcp_ipv4.c +0 -0
index 7f413f509d7dce..f830b212d38e49 100644

net/ipv4/tcp_ipv4.c struct sock *tcp_v4_syn_recv_sock(const struct sock *sk, struct sk_buff *skb, · line 1737

Quoted 9 lines
net/ipv4/tcp_ipv4.c +4 -1
@@ -1730,8 +1730,12 @@ struct sock *tcp_v4_syn_recv_sock(const struct sock *sk, struct sk_buff *skb,
        sk_setup_caps(newsk, dst);
 
 #if IS_ENABLED(CONFIG_IPV6)
-       if (opt_child_init)
+       if (opt_child_init) {
                opt_child_init(newsk, sk);
+       } else {
+               newinet->pinet6 = NULL;
+               newinet->ipv6_fl_list = NULL;

Instead of adding a new test in inet6_cleanup_sock(() I would add here :

newsk->sk_destruct = inet_sock_destruct;

Quoted 19 lines
net/ipv4/tcp_ipv4.c +1 -0
+       }
 #endif
        tcp_ca_openreq_child(newsk, dst);
 
net/ipv6/af_inet6.c +3 -1
index 282912a1199992..2090289408c035 100644
@@ -479,6 +479,9 @@ void inet6_cleanup_sock(struct sock *sk)
        struct sk_buff *skb;
        struct ipv6_txoptions *opt;
 
+       if (!np)
+               return;
+
        /* Release rx options */
 
        skb = xchg(&np->pktoptions, NULL);
--
Quoted 1 line

2.43.0

Also, it seems weird that all these issues caused by tcp_disconnect() are fixed by AI agents adding code in TCP fast paths.

What about adding code in tcp_disconnect() that only fuzzers are possibly using?

Untested patch:

net/ipv4/tcp.c +0 -0
index 455441f1b694904172cfa1d8e7bac7076b60cb24..9dd44b0a31c4dc751b22558dc6b53ed49598e0b6

100644

net/ipv4/tcp.c int tcp_disconnect(struct sock *sk, int flags) · line 3507

Quoted 7 lines
net/ipv4/tcp.c +4 -0
@@ -3501,6 +3501,15 @@ int tcp_disconnect(struct sock *sk, int flags)
                sk->sk_frag.page = NULL;
                sk->sk_frag.offset = 0;
        }
+
+#if IS_ENABLED(CONFIG_IPV6)
+       if (sk->sk_family == PF_INET &&
+           sk->sk_destruct == inet6_sock_destruct) {

I tested this, and it does not work when tcp_v6_init_sock() has installed tcp6_destruct_sock.

static int tcp_v6_init_sock(struct sock *sk)
{

#if defined(CONFIG_TCP_MD5SIG) || defined(CONFIG_TCP_AO)
        tcp_sk(sk)->af_specific = &tcp_sock_ipv6_specific;
        sk->sk_destruct = tcp6_destruct_sock;

#endif

}

What about "if (sk->sk_family == PF_INET && inet->pinet6)" ?

net/ipv4/tcp.c int tcp_disconnect(struct sock *sk, int flags) · line 3508

Quoted 1 line
net/ipv4/tcp.c +1 -0
+               sk->sk_destruct = inet_sock_destruct;

IIRC overwriting sk_destruct here breaks things like ULPs? Not verified.

net/ipv4/tcp.c int tcp_disconnect(struct sock *sk, int flags) · line 3515

Quoted 7 lines
net/ipv4/tcp.c +4 -0
+               inet->pinet6 = NULL;
+       }
+#endif
+
        sk_error_report(sk);
        return 0;
 }

If sk_destruct is left alone the NULL check has to stay, so:

net/ipv4/tcp.c +8 -0
index 455441f1b69490..bbdd5b08593061 100644
@@ -3501,6 +3501,14 @@ int tcp_disconnect(struct sock *sk, int flags)
                sk->sk_frag.page = NULL;
                sk->sk_frag.offset = 0;
        }
+
+#if IS_ENABLED(CONFIG_IPV6)
+       if (sk->sk_family == PF_INET && inet->pinet6) {
+               inet->pinet6 = NULL;
+               inet->ipv6_fl_list = NULL;
+       }
+#endif
+
        sk_error_report(sk);
        return 0;
 }
net/ipv6/af_inet6.c +3 -0
index 282912a1199992..2090289408c035 100644
@@ -479,6 +479,9 @@ void inet6_cleanup_sock(struct sock *sk)
        struct sk_buff *skb;
        struct ipv6_txoptions *opt;
 
+       if (!np)
+               return;
+
        /* Release rx options */
 
        skb = xchg(&np->pktoptions, NULL);
#3 lore raw

I dug into this further and ran into a few obstacles.

Quoted 78 lines · Hyunwoo Kim
Quoted 77 lines · Eric Dumazet
Quoted 35 lines · Hyunwoo Kim

IPV6_ADDRFORM moves an established AF_INET6 TCP socket over to tcp_prot and ipv4_specific. The socket is still a tcp6_sock though, so ->pinet6 keeps pointing at the ipv6_pinfo inside it and sk_destruct stays the IPv6 one; commit d38afeec26ed ("tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().") relies on that to release the IPv6 state.

Once such a socket is disconnected and listen()ed again, its children are cloned from an IPv6 parent but allocated from tcp_prot, so they have no ipv6_pinfo of their own and inherit the listener's ->pinet6 and its IPv6 destructor. The only thing that would fix that up is tcp_v6_mapped_child_init(), which is not passed to tcp_v4_syn_recv_sock() on this path. A child accepted from such a listener can outlive it, and its destructor then runs inet6_cleanup_sock() on the freed listener.

Commit 858d2a4f67ff ("tcp: fix potential race in tcp_v6_syn_recv_sock()") added opt_child_init for the v4-mapped child; this is the same stale ->pinet6 on the path that never gets it.

Clear the IPv6 fields on the child. The converted listener has to keep its own, so there is nothing to clear on the IPV6_ADDRFORM side.

Fixes d38afeec26ed ("tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().")
---
 net/ipv4/tcp_ipv4.c | 6 +++++-
 net/ipv6/af_inet6.c | 3 +++
 2 files changed, 8 insertions(+), 1 deletion(-)
net/ipv4/tcp_ipv4.c +0 -0
index 7f413f509d7dce..f830b212d38e49 100644

net/ipv4/tcp_ipv4.c struct sock *tcp_v4_syn_recv_sock(const struct sock *sk, struct sk_buff *skb, · line 1737

Quoted 9 lines
net/ipv4/tcp_ipv4.c +4 -1
@@ -1730,8 +1730,12 @@ struct sock *tcp_v4_syn_recv_sock(const struct sock *sk, struct sk_buff *skb,
        sk_setup_caps(newsk, dst);
 
 #if IS_ENABLED(CONFIG_IPV6)
-       if (opt_child_init)
+       if (opt_child_init) {
                opt_child_init(newsk, sk);
+       } else {
+               newinet->pinet6 = NULL;
+               newinet->ipv6_fl_list = NULL;

Instead of adding a new test in inet6_cleanup_sock(() I would add here :

newsk->sk_destruct = inet_sock_destruct;

Quoted 19 lines
net/ipv4/tcp_ipv4.c +1 -0
+       }
 #endif
        tcp_ca_openreq_child(newsk, dst);
 
net/ipv6/af_inet6.c +3 -1
index 282912a1199992..2090289408c035 100644
@@ -479,6 +479,9 @@ void inet6_cleanup_sock(struct sock *sk)
        struct sk_buff *skb;
        struct ipv6_txoptions *opt;
 
+       if (!np)
+               return;
+
        /* Release rx options */
 
        skb = xchg(&np->pktoptions, NULL);
--
Quoted 1 line

2.43.0

Also, it seems weird that all these issues caused by tcp_disconnect() are fixed by AI agents adding code in TCP fast paths.

Quoted 1 line
Quoted 1 line

What about adding code in tcp_disconnect() that only fuzzers are possibly using?

Not touching the fast path would be best, but a few things make it look hard to fix by touching tcp_disconnect() alone:

1. The bad pointer is not created by tcp_disconnect(), it is created when the child is cloned. The converted listener still has its own ipv6_pinfo, but the child does not, and the child comes out pointing at the listener's one. This is the same as what 858d2a4f67ff fixed for the v4-mapped child, and here opt_child_init is NULL so that fix does not apply.

2. Clearing it in tcp_disconnect() means clearing it on a socket that is not closed yet and can still be entered through the IPv6 sockopt paths. do_ipv6_setsockopt() has options that are handled before the ADDRFORM recheck, and do_ipv6_getsockopt() has no such recheck, so a thread that entered before the conversion accesses that pointer.

If I understand it correctly, tcp_v4_syn_recv_sock() has no such point. The child is not in the hash yet, has no sk_socket, and already runs on ipv4_specific, so nothing is using this socket while assuming that pointer is valid. It looks like the only place where it can be cleared safely.

Quoted 28 lines
Quoted 9 lines

Untested patch:

net/ipv4/tcp.c +0 -0
index 455441f1b694904172cfa1d8e7bac7076b60cb24..9dd44b0a31c4dc751b22558dc6b53ed49598e0b6

100644

net/ipv4/tcp.c int tcp_disconnect(struct sock *sk, int flags) · line 3507

Quoted 7 lines
net/ipv4/tcp.c +4 -0
@@ -3501,6 +3501,15 @@ int tcp_disconnect(struct sock *sk, int flags)
                sk->sk_frag.page = NULL;
                sk->sk_frag.offset = 0;
        }
+
+#if IS_ENABLED(CONFIG_IPV6)
+       if (sk->sk_family == PF_INET &&
+           sk->sk_destruct == inet6_sock_destruct) {

I tested this, and it does not work when tcp_v6_init_sock() has installed tcp6_destruct_sock.

static int tcp_v6_init_sock(struct sock *sk)
{

#if defined(CONFIG_TCP_MD5SIG) || defined(CONFIG_TCP_AO)
        tcp_sk(sk)->af_specific = &tcp_sock_ipv6_specific;
        sk->sk_destruct = tcp6_destruct_sock;

#endif

Quoted 7 lines

}

What about "if (sk->sk_family == PF_INET && inet->pinet6)" ?

net/ipv4/tcp.c int tcp_disconnect(struct sock *sk, int flags) · line 3508

Quoted 1 line
net/ipv4/tcp.c +1 -0
+               sk->sk_destruct = inet_sock_destruct;

IIRC overwriting sk_destruct here breaks things like ULPs? Not verified.

(after fixing the condition properly) I tested this, and with a socket that had MD5 keys set, connected v4-mapped, then IPV6_ADDRFORM'ed and disconnected, I saw the MD5 keys leak. tcp_md5_destruct_sock() is only called from tcp4_destruct_sock and tcp6_destruct_sock, so replacing sk_destruct with inet_sock_destruct leaves nothing that frees them.

Quoted 35 lines

net/ipv4/tcp.c int tcp_disconnect(struct sock *sk, int flags) · line 3515

Quoted 8 lines
net/ipv4/tcp.c +4 -0
+               inet->pinet6 = NULL;
+       }
+#endif
+
        sk_error_report(sk);
        return 0;
 }

If sk_destruct is left alone the NULL check has to stay, so:

net/ipv4/tcp.c +8 -0
index 455441f1b69490..bbdd5b08593061 100644
@@ -3501,6 +3501,14 @@ int tcp_disconnect(struct sock *sk, int flags)
                sk->sk_frag.page = NULL;
                sk->sk_frag.offset = 0;
        }
+
+#if IS_ENABLED(CONFIG_IPV6)
+       if (sk->sk_family == PF_INET && inet->pinet6) {
+               inet->pinet6 = NULL;
+               inet->ipv6_fl_list = NULL;
+       }
+#endif
+
        sk_error_report(sk);
        return 0;
 }
net/ipv6/af_inet6.c +0 -0
index 282912a1199992..2090289408c035 100644

net/ipv6/af_inet6.c void inet6_cleanup_sock(struct sock *sk) · line 487

Quoted 9 lines
net/ipv6/af_inet6.c +3 -0
@@ -479,6 +479,9 @@ void inet6_cleanup_sock(struct sock *sk)
        struct sk_buff *skb;
        struct ipv6_txoptions *opt;
 
+       if (!np)
+               return;
+
        /* Release rx options */
 
        skb = xchg(&np->pktoptions, NULL);

IMHO, the original patch that touches the fast path still looks like the right approach:

net/ipv4/tcp_ipv4.c +5 -1
index 7f413f509d7dce..f830b212d38e49 100644
@@ -1730,8 +1730,12 @@ struct sock *tcp_v4_syn_recv_sock(const struct sock *sk, struct sk_buff *skb,
        sk_setup_caps(newsk, dst);
 
 #if IS_ENABLED(CONFIG_IPV6)
-       if (opt_child_init)
+       if (opt_child_init) {
                opt_child_init(newsk, sk);
+       } else {
+               newinet->pinet6 = NULL;
+               newinet->ipv6_fl_list = NULL;
+       }
 #endif
        tcp_ca_openreq_child(newsk, dst);
 
net/ipv6/af_inet6.c +3 -0
index 282912a1199992..2090289408c035 100644
@@ -479,6 +479,9 @@ void inet6_cleanup_sock(struct sock *sk)
        struct sk_buff *skb;
        struct ipv6_txoptions *opt;
 
+       if (!np)
+               return;
+
        /* Release rx options */
 
        skb = xchg(&np->pktoptions, NULL);

What do you think? Maybe there is a better way that does not touch the fast path.

---

While working on tcp_v4_syn_recv_sock() I also found a separate bug: if the route lookup for the child fails, the child is destroyed at put_and_exit before tcp_v6_mapped_child_init() has run, and it frees the listener's flow label list. This is probably better fixed by a separate patch...

net/ipv4/tcp_ipv4.c +5 -5
index 7f413f509d7dce..52eaaae27b6006 100644
@@ -1720,6 +1720,11 @@ struct sock *tcp_v4_syn_recv_sock(const struct sock *sk, struct sk_buff *skb,
        if (READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_reflect_tos))
                newinet->tos = tcp_rsk(req)->syn_tos & ~INET_ECN_MASK;
 
+#if IS_ENABLED(CONFIG_IPV6)
+       if (opt_child_init)
+               opt_child_init(newsk, sk);
+#endif
+
        if (!dst) {
                dst = inet_csk_route_child_sock(sk, newsk, req);
                if (!dst)
@@ -1728,11 +1733,6 @@ struct sock *tcp_v4_syn_recv_sock(const struct sock *sk, struct sk_buff *skb,
                /* syncookie case : see end of cookie_v4_check() */
        }
        sk_setup_caps(newsk, dst);
-
-#if IS_ENABLED(CONFIG_IPV6)
-       if (opt_child_init)
-               opt_child_init(newsk, sk);
-#endif
        tcp_ca_openreq_child(newsk, dst);
 
        tcp_sync_mss(newsk, dst4_mtu(dst));

Best regards,
Hyunwoo Kim