b4: Ignore Signed-off-by trailers in follow-up replies
PATCH 1/1 b4: Ignore Signed-off-by trailers in follow-up replies
When someone replies to a patch thread, sometimes they include a Signed-off-by trailer (for example, when providing inline diffs or snippets in a reply). Currently, b4 am/shazam collect these tags from replies and append them to the main patch's trailers.
I am not aware of any use case when collecting the Signed-off-by is needed, so drop it in this case.
---
I hit this when using:
b4 shazam -v1 https://lore.kernel.org/all/[email protected]/
It collected the tag from Marc's patch in my patch as in:
https://lore.kernel.org/all/[email protected]/
Which is wrong.
--- src/b4/__init__.py | 1 + 1 file changed, 1 insertion(+)
src/b4/__init__.py +1 -0
@@ -1857,6 +1857,7 @@ class LoreMessage: 'base-commit', 'change-id', 'message-id', + 'signed-off-by', } if trailer.lname not in badtrailers: trailer.lmsg = self
Signature · 1 line
2.55.0.654.g21b8a5bc05-goog
Quoted 11 lines · Mostafa Saleh
When someone replies to a patch thread, sometimes they include a Signed-off-by trailer (for example, when providing inline diffs or snippets in a reply). Currently, b4 am/shazam collect these tags from replies and append them to the main patch's trailers.
I am not aware of any use case when collecting the Signed-off-by is needed, so drop it in this case.
Assisted-by Gemini:gemini-3.1-pro-previewSigned-off-by Mostafa Saleh <[email protected]>
Quoted 7 lines
---
I hit this when using:
b4 shazam -v1 https://lore.kernel.org/all/[email protected]/It collected the tag from Marc's patch in my patch as in:
https://lore.kernel.org/all/[email protected]/
Which is wrong.
I have a simailar case?
My reply [1] contains a standard template of a commit message for Chinese translation patches with a sample Signed-off-by in it.
So when using 'b4 am/shazam', the sample Signed-off-by would be added as one trailer. I was curious and spent some time to figure out where the Sob exactly come from within that quite large series, since that sample name/maintainer didn't show up in that conversation at all. ;-)
And I am also not aware of any use case when collecting the Signed-off-by is needed, though I'm quite new in this community without much experience.
Thanks,
Weijie
Konstantin Ryabitsev
AppliedQuoted 1 line · Mostafa Saleh
b4: Ignore Signed-off-by trailers in follow-up replies
Applied, thanks!
[1/1] b4: Ignore Signed-off-by trailers in follow-up replies
commit: 663cf8ec750c1d5cf90d00d01c9ed337d9ec8e18
Best regards,
Signature · 1 line
Konstantin Ryabitsev <[email protected]>