arm64: dts: rockchip: rk3399pro-vmarc-som: add i2c2 scl timing
Subsystems (2)
PATCH 1/1 arm64: dts: rockchip: rk3399pro-vmarc-som: add i2c2 scl timing
The hym8563 on i2c2 does not ack:
rtc-hym8563 2-0051: could not init device, -6
It is also the ext_clock for sdio-pwrseq, so wifi does not come up either.
i2c2 runs at 400 kHz with no scl edge times. The core defaults both to 300 ns and rk3x-i2c calculates a 900 ns high period, which is short for this bus - it acks at 100 kHz. Set the edges to the values i2c3 already uses, giving 1050 ns at 400 kHz.
Tested on a Radxa ROCK Pi N10: rtc0 registers and keeps time across a reboot, and wifi activates.
--- arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi | 2 ++ 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi +2 -0
@@ -296,6 +296,8 @@ &i2c1 { &i2c2 { clock-frequency = <400000>; + i2c-scl-falling-time-ns = <15>; + i2c-scl-rising-time-ns = <450>; status = "okay"; hym8563: rtc@51 {
Signature · 1 line
2.53.0
Heiko Stuebner
maintainerHi Rudi,
Am Montag, 24. August 2026, 05:06:43 Mitteleuropäische Sommerzeit schrieb Rudi Heitbaum:
Quoted 7 lines
The hym8563 on i2c2 does not ack:
rtc-hym8563 2-0051: could not init device, -6
It is also the
ext_clockfor sdio-pwrseq, so wifi does not come up either.
Quoted 7 lines
i2c2 runs at 400 kHz with no scl edge times. The core defaults both to 300 ns and rk3x-i2c calculates a 900 ns high period, which is short for this bus - it acks at 100 kHz. Set the edges to the values i2c3 already uses, giving 1050 ns at 400 kHz.
Tested on a Radxa ROCK Pi N10: rtc0 registers and keeps time across a reboot, and wifi activates.
You tested on a Radxa Rock PI N10, but are changing the vmarc-som? I'm not really understanding this.
Heiko
Quoted 20 lines
Signed-off-by Rudi Heitbaum <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi | 2 ++ 1 file changed, 2 insertions(+)arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi +2
-0@@ -296,6 +296,8 @@ &i2c1 { &i2c2 { clock-frequency = <400000>; + i2c-scl-falling-time-ns = <15>; + i2c-scl-rising-time-ns = <450>; status = "okay"; hym8563: rtc@51 {
Quoted 15 lines · Heiko Stuebner
Hi Rudi,
Am Montag, 24. August 2026, 05:06:43 Mitteleuropäische Sommerzeit schrieb Rudi Heitbaum:
Quoted 12 lines
The hym8563 on i2c2 does not ack:
rtc-hym8563 2-0051: could not init device, -6
It is also the
ext_clockfor sdio-pwrseq, so wifi does not come up either.i2c2 runs at 400 kHz with no scl edge times. The core defaults both to 300 ns and rk3x-i2c calculates a 900 ns high period, which is short for this bus - it acks at 100 kHz. Set the edges to the values i2c3 already uses, giving 1050 ns at 400 kHz.
Quoted 5 lines
Quoted 2 lines
Tested on a Radxa ROCK Pi N10: rtc0 registers and keeps time across a reboot, and wifi activates.
You tested on a Radxa Rock PI N10, but are changing the vmarc-som? I'm not really understanding this.
Hi Heiko,
Thanks for looking at this. The rk3399pro-vmarc-som and the dalang-carrier are sold by Radxa as a Rock-Pi-N10. Radxa sold the Rock-Pi-N8 with the Dalang carrier but with a RK3288 som (I have taken this into account when making the changes to the dts files).
I had previously looked at completing the bringup done for this SBC, but on revisiting the bringup now have been able to complete the bring up of all IO on this board, but have considered that the dts needs to be broken across all of the 3 .dts files.
The fix 4 patches that I have submitted so far are the dependencies for the dts to work.
- arm64: dts: rockchip: rk3399pro-vmarc-som: add i2c2 scl timing
- usb: onboard_dev: add the Rockchip rk1808
- Bluetooth: btsdio: Do not bind to non-removable BCM4359
- dt-bindings: regulator: fan53555: add tcs,tcs4526
The followup commits are to the dts files:
- arch/arm/boot/dts/rockchip/rockchip-radxa-dalang-carrier.dtsi
- arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi
- arch/arm64/boot/dts/rockchip/rk3399pro-rock-pi-n10.dts
Thanks
Rudi
Quoted 26 lines
Heiko
Quoted 20 lines
Signed-off-by Rudi Heitbaum <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi | 2 ++ 1 file changed, 2 insertions(+)arch/arm64/boot/dts/rockchip/rk3399pro-vmarc-som.dtsi +2
-0@@ -296,6 +296,8 @@ &i2c1 { &i2c2 { clock-frequency = <400000>; + i2c-scl-falling-time-ns = <15>; + i2c-scl-rising-time-ns = <450>; status = "okay"; hym8563: rtc@51 {
Quoted 8 lines · Rudi Heitbaum
The hym8563 on i2c2 does not ack:
rtc-hym8563 2-0051: could not init device, -6
It is also the
ext_clockfor sdio-pwrseq, so wifi does not come up either.[...]
Applied, thanks!
[1/1] arm64: dts: rockchip: rk3399pro-vmarc-som: add i2c2 scl timing
commit: 7c40dc4055b6868c5ee7c4e30fd483544a25a58c
Best regards,
Signature · 1 line
Heiko Stuebner <[email protected]>