Address minor issues with status codes
Subsystems (3)
Chuck Lever
maintainercover Address minor issues with status codes
From: Chuck Lever <[email protected]>
Here are two examples of minor bugs I found when comparing NFSD's human-generated status code definitions with equivalent xdrgen- generated headers.
Chuck Lever (2):
NFSD: Remove NFSERR_EAGAIN
NFS: NFSERR_INVAL is not defined by NFSv2
fs/nfs_common/common.c | 1 - fs/nfsd/nfs4proc.c | 2 +- fs/nfsd/nfsd.h | 1 - fs/nfsd/nfsproc.c | 2 +- include/trace/misc/nfs.h | 2 -- include/uapi/linux/nfs.h | 3 +-- 6 files changed, 3 insertions(+), 8 deletions(-)
Signature · 1 line
2.52.0
Chuck Lever
maintainerPATCH 1/2 NFSD: Remove NFSERR_EAGAIN
From: Chuck Lever <[email protected]>
I haven't found an NFSERR_EAGAIN in RFCs 1094, 1813, 7530, or 8881. None of these RFCs have an NFS status code that match the numeric value "11".
Based on the meaning of the EAGAIN errno, I presume the use of this status in NFSD means NFS4ERR_DELAY. So replace the one usage of nfserr_eagain, and remove it from NFSD's NFS status conversion tables.
As far as I can tell, NFSERR_EAGAIN has existed since the pre-git era, but was not actually used by any code until commit f4e44b393389 ("NFSD: delay unmount source's export after inter-server copy completed."), at which time it become possible for NFSD to return a status code of 11 (which is not valid NFS protocol).
X-Cc: [email protected]
--- fs/nfs_common/common.c | 1 - fs/nfsd/nfs4proc.c | 2 +- fs/nfsd/nfsd.h | 1 - include/trace/misc/nfs.h | 2 -- include/uapi/linux/nfs.h | 1 - 5 files changed, 1 insertion(+), 6 deletions(-)
fs/nfs_common/common.c +0 -1
@@ -17,7 +17,6 @@ static const struct { { NFSERR_NOENT, -ENOENT }, { NFSERR_IO, -EIO }, { NFSERR_NXIO, -ENXIO }, -/* { NFSERR_EAGAIN, -EAGAIN }, */ { NFSERR_ACCES, -EACCES }, { NFSERR_EXIST, -EEXIST }, { NFSERR_XDEV, -EXDEV },
fs/nfsd/nfs4proc.c +1 -1
@@ -1504,7 +1504,7 @@ static __be32 nfsd4_ssc_setup_dul(struct nfsd_net *nn, char *ipaddr, (schedule_timeout(20*HZ) == 0)) {finish_wait (&nn->nfsd_ssc_waitq, &wait);kfree (work); -return nfserr_eagain; +return nfserr_jukebox; }finish_wait (&nn->nfsd_ssc_waitq, &wait); goto try_again;
fs/nfsd/nfsd.h +0 -1
@@ -233,7 +233,6 @@ void nfsd_lockd_shutdown(void);#define nfserr_noent cpu_to_be32(NFSERR_NOENT)#define nfserr_io cpu_to_be32(NFSERR_IO)#define nfserr_nxio cpu_to_be32(NFSERR_NXIO) -#define nfserr_eagain cpu_to_be32(NFSERR_EAGAIN)#define nfserr_acces cpu_to_be32(NFSERR_ACCES)#define nfserr_exist cpu_to_be32(NFSERR_EXIST)#define nfserr_xdev cpu_to_be32(NFSERR_XDEV)
include/trace/misc/nfs.h +0 -2
@@ -16,7 +16,6 @@ TRACE_DEFINE_ENUM(NFSERR_PERM);TRACE_DEFINE_ENUM (NFSERR_NOENT );TRACE_DEFINE_ENUM (NFSERR_IO );TRACE_DEFINE_ENUM (NFSERR_NXIO ); -TRACE_DEFINE_ENUM (NFSERR_EAGAIN );TRACE_DEFINE_ENUM (NFSERR_ACCES );TRACE_DEFINE_ENUM (NFSERR_EXIST );TRACE_DEFINE_ENUM (NFSERR_XDEV );
@@ -52,7 +51,6 @@ TRACE_DEFINE_ENUM(NFSERR_JUKEBOX); { NFSERR_NXIO, "NXIO" }, \ { ECHILD, "CHILD" }, \ { ETIMEDOUT, "TIMEDOUT" }, \ - { NFSERR_EAGAIN, "AGAIN" }, \ { NFSERR_ACCES, "ACCES" }, \ { NFSERR_EXIST, "EXIST" }, \ { NFSERR_XDEV, "XDEV" }, \
include/uapi/linux/nfs.h +0 -1
@@ -49,7 +49,6 @@NFSERR_NOENT =2 ,/* v2 v3 v4 */ NFSERR_IO =5 ,/* v2 v3 v4 */ NFSERR_NXIO =6 ,/* v2 v3 v4 */ -NFSERR_EAGAIN =11 ,/* v2 v3 */ NFSERR_ACCES =13 ,/* v2 v3 v4 */ NFSERR_EXIST =17 ,/* v2 v3 v4 */ NFSERR_XDEV = 18, /* v3 v4 */
Signature · 1 line
2.52.0
Chuck Lever
maintainerPATCH 2/2 NFS: NFSERR_INVAL is not defined by NFSv2
In reply to Chuck LeverFrom: Chuck Lever <[email protected]>
A documenting comment in include/uapi/linux/nfs.h claims incorrectly that NFSv2 defines NFSERR_INVAL. There is no such definition in either RFC 1094 or https://pubs.opengroup.org/onlinepubs/9629799/chap7.htm
NFS3ERR_INVAL is introduced in RFC 1813.
NFSD returns NFSERR_INVAL for PROC_GETACL, which has no specification (yet).
However, nfsd_map_status() maps nfserr_symlink and nfserr_wrong_type to nfserr_inval, which does not align with RFC 1094. This logic was introduced only recently by commit 438f81e0e92a ("nfsd: move error choice for incorrect object types to version-specific code."). Given that we have no INVAL or SERVERFAULT status in NFSv2, probably the only choice is NFSERR_IO.
--- fs/nfsd/nfsproc.c | 2 +- include/uapi/linux/nfs.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
fs/nfsd/nfsproc.c +1 -1
@@ -33,7 +33,7 @@ static __be32 nfsd_map_status(__be32 status)break ;case nfserr_symlink:case nfserr_wrong_type: - status = nfserr_inval; + status = nfserr_io;break ; }return status;
include/uapi/linux/nfs.h +1 -1
@@ -55,7 +55,7 @@NFSERR_NODEV =19 ,/* v2 v3 v4 */ NFSERR_NOTDIR =20 ,/* v2 v3 v4 */ NFSERR_ISDIR =21 ,/* v2 v3 v4 */ -NFSERR_INVAL =22 ,/* v2 v3 v4 */ +NFSERR_INVAL =22 ,/* v3 v4 */ NFSERR_FBIG =27 ,/* v2 v3 v4 */ NFSERR_NOSPC =28 ,/* v2 v3 v4 */ NFSERR_ROFS = 30, /* v2 v3 v4 */
Signature · 1 line
2.52.0
Re: [PATCH 2/2] NFS: NFSERR_INVAL is not defined by NFSv2
Chuck Lever schrieb am Di 09. Dez, 19:28 (-0500):
Quoted 7 lines
From: Chuck Lever <[email protected]>
A documenting comment in
include/uapi/linux/nfs.hclaims incorrectly that NFSv2 definesNFSERR_INVAL. There is no such definition in either RFC 1094 or https://pubs.opengroup.org/onlinepubs/9629799/chap7.htm
NFS3ERR_INVALis introduced in RFC 1813.
Hello,
since this commit 0ac903d1bfdce8ff40657c2b7d996947b72b6645 was added, U-Boot 2022.04 (I don't know about newer versions) can no longer access symlinks in NFS shares. When I revert this commit, U-Boot can load the file behind the symlink. Real files are no problem.
The file I want to load is a symlink at the server:
``` % ls -l /srv/nfs/boot/Image.gz* lrwxrwxrwx 1 root root 41 7. Jul 16:29 /srv/nfs-con/boot/Image.gz -> Image.gz-5.15.213-imx8mm+gfffa4b6d4aea+p1 -rw-r--r-- 1 root root 5279373 7. Jul 16:29 /srv/nfs-con/boot/Image.gz-5.15.213-imx8mm+gfffa4b6d4aea+p1 ```
Without this commit:
``` u-boot=> nfs 0x42000000 /srv/nfs/boot/Image.gz Filename '/srv/nfs-con/boot/Image.gz'. Load address: 0x42000000 Loading: ################################################################# done Bytes transferred = 5279373 (508e8d hex) ```
But with this commit:
``` u-boot=> nfs 0x42000000 /srv/nfs/boot/Image.gz Filename '/srv/nfs-con/boot/Image.gz'. Load address: 0x42000000 Loading: done ```
This is the network traffic:
``` No. Time Protocol Length Info 3 0.000370 Portmap 98 V2 GETPORT Call (Reply In 4) MOUNT(100005) V:1 UDP 4 0.000607 Portmap 70 V2 GETPORT Reply (Call In 3) Port:60340 5 0.000949 Portmap 98 V2 GETPORT Call (Reply In 6) NFS(100003) V:2 UDP 6 0.001046 Portmap 70 V2 GETPORT Reply (Call In 5) Port:2049 7 0.001368 MOUNT 126 V2 MNT Call (Reply In 8) /srv/nfs-con/boot 8 0.008026 MOUNT 102 V2 MNT Reply (Call In 7) 9 0.008389 NFS 146 V2 LOOKUP Call (Reply In 10), DH: 0x8c279135/Image.gz 10 0.008754 NFS 170 V2 LOOKUP Reply (Call In 9), FH: 0xcdddf154 11 0.009095 NFS 146 V2 READ Call (Reply In 12), FH: 0xcdddf154 Offset: 0 Count: 1024 TotalCount: 0 12 0.009189 NFS 70 V2 READ Reply (Call In 11) Error: NFS2ERR_IO 13 0.009511 MOUNT 102 V2 UMNTALL Call (Reply In 14) 14 0.010301 MOUNT 66 V2 UMNTALL Reply (Call In 13) ```
From packet 11 V2 READ Call
```
Remote Procedure Call, Type:Call XID:0x000050e1
XID: 0x000050e1 (20705)
Message Type: Call (0)
RPC Version: 2
Program: NFS (100003)
Program Version: 2
Procedure: READ (6)
[The reply to this request is in frame 12]
Credentials
Flavor: AUTH_UNIX (1)
Length: 20
Stamp: 0x00000000
Machine Name: <EMPTY>
UID: 0
GID: 0
Auxiliary GIDs (0)
Verifier
Flavor: AUTH_NULL (0)
Length: 0
Network File System, READ Call FH: 0xcdddf154 Offset: 0 Count: 1024 TotalCount: 0
[Program Version: 2]
[V2 Procedure: READ (6)]
file
[hash (CRC-32): 0xcdddf154]
FileHandle: 010004010100540020bb3809040054002f2edde4000000000000000000000000
Offset: 0
Count: 1024
Total Count: 0
```From packet 12 V2 READ Reply
```
Remote Procedure Call, Type:Reply XID:0x000050e1
XID: 0x000050e1 (20705)
Message Type: Reply (1)
[Program: NFS (100003)]
[Program Version: 2]
[Procedure: READ (6)]
Reply State: accepted (0)
[This is a reply to a request in frame 11]
[Time from request: 94.000 microseconds]
Verifier
Flavor: AUTH_NULL (0)
Length: 0
Accept State: RPC executed successfully (0)
Network File System, READ Reply Error: NFS2ERR_IO
[Program Version: 2]
[V2 Procedure: READ (6)]
Status: NFS2ERR_IO (5)
```I can locally revert this commit in our kernel, but is there any other way to get it working again?
Thanks in advance.
Best regards Jörg
Signature · 3 lines
Optimisten haben gar keine Ahnung von den freudigen Überraschungen, die
Pessimisten erleben.
(Peter Bramm)Re: [PATCH 2/2] NFS: NFSERR_INVAL is not defined by NFSv2
Quoted 119 lines · Jörg Sommer
Chuck Lever schrieb am Di 09. Dez, 19:28 (-0500):
Quoted 7 lines
From: Chuck Lever <[email protected]>
A documenting comment in
include/uapi/linux/nfs.hclaims incorrectly that NFSv2 definesNFSERR_INVAL. There is no such definition in either RFC 1094 or https://pubs.opengroup.org/onlinepubs/9629799/chap7.htm
NFS3ERR_INVALis introduced in RFC 1813.Hello,
since this commit
0ac903d1bfdce8ff40657c2b7d996947b72b6645was added, U-Boot 2022.04 (I don't know about newer versions) can no longer access symlinks in NFS shares. When I revert this commit, U-Boot can load the file behind the symlink. Real files are no problem.The file I want to load is a symlink at the server:
``` % ls -l /srv/nfs/boot/Image.gz* lrwxrwxrwx 1 root root 41 7. Jul 16:29 /srv/nfs-con/boot/Image.gz -> Image.gz-5.15.213-imx8mm+gfffa4b6d4aea+p1 -rw-r--r-- 1 root root 5279373 7. Jul 16:29 /srv/nfs-con/boot/Image.gz-5.15.213-imx8mm+gfffa4b6d4aea+p1 ```Without this commit:
``` u-boot=> nfs 0x42000000 /srv/nfs/boot/Image.gz Filename '/srv/nfs-con/boot/Image.gz'. Load address: 0x42000000 Loading: ################################################################# done Bytes transferred = 5279373 (508e8d hex) ```But with this commit:
``` u-boot=> nfs 0x42000000 /srv/nfs/boot/Image.gz Filename '/srv/nfs-con/boot/Image.gz'. Load address: 0x42000000 Loading: done ```This is the network traffic:
``` No. Time Protocol Length Info 3 0.000370 Portmap 98 V2 GETPORT Call (Reply In 4) MOUNT(100005) V:1 UDP 4 0.000607 Portmap 70 V2 GETPORT Reply (Call In 3) Port:60340 5 0.000949 Portmap 98 V2 GETPORT Call (Reply In 6) NFS(100003) V:2 UDP 6 0.001046 Portmap 70 V2 GETPORT Reply (Call In 5) Port:2049 7 0.001368 MOUNT 126 V2 MNT Call (Reply In 8) /srv/nfs-con/boot 8 0.008026 MOUNT 102 V2 MNT Reply (Call In 7) 9 0.008389 NFS 146 V2 LOOKUP Call (Reply In 10), DH: 0x8c279135/Image.gz 10 0.008754 NFS 170 V2 LOOKUP Reply (Call In 9), FH: 0xcdddf154 11 0.009095 NFS 146 V2 READ Call (Reply In 12), FH: 0xcdddf154 Offset: 0 Count: 1024 TotalCount: 0 12 0.009189 NFS 70 V2 READ Reply (Call In 11) Error: NFS2ERR_IO 13 0.009511 MOUNT 102 V2 UMNTALL Call (Reply In 14) 14 0.010301 MOUNT 66 V2 UMNTALL Reply (Call In 13) ```From packet 11 V2 READ Call
``` Remote Procedure Call, Type:Call XID:0x000050e1 XID: 0x000050e1 (20705) Message Type: Call (0) RPC Version: 2 Program: NFS (100003) Program Version: 2 Procedure: READ (6) [The reply to this request is in frame 12] Credentials Flavor: AUTH_UNIX (1) Length: 20 Stamp: 0x00000000 Machine Name: <EMPTY> UID: 0 GID: 0 Auxiliary GIDs (0) Verifier Flavor: AUTH_NULL (0) Length: 0 Network File System, READ Call FH: 0xcdddf154 Offset: 0 Count: 1024 TotalCount: 0 [Program Version: 2] [V2 Procedure: READ (6)] file [hash (CRC-32): 0xcdddf154] FileHandle: 010004010100540020bb3809040054002f2edde4000000000000000000000000 Offset: 0 Count: 1024 Total Count: 0 ```From packet 12 V2 READ Reply
``` Remote Procedure Call, Type:Reply XID:0x000050e1 XID: 0x000050e1 (20705) Message Type: Reply (1) [Program: NFS (100003)] [Program Version: 2] [Procedure: READ (6)] Reply State: accepted (0) [This is a reply to a request in frame 11] [Time from request: 94.000 microseconds] Verifier Flavor: AUTH_NULL (0) Length: 0 Accept State: RPC executed successfully (0) Network File System, READ Reply Error: NFS2ERR_IO [Program Version: 2] [V2 Procedure: READ (6)] Status: NFS2ERR_IO (5) ```
Quoted 2 lines
I can locally revert this commit in our kernel, but is there any other way to get it working again?
This is unfortunate.
U-boot has
} else if ((rlen == -NFSERR_ISDIR) || (rlen == -NFSERR_INVAL)) {
/* symbolic link */
nfs_state = STATE_READLINK_REQ;
nfs_send();so we either need nfsdv2 to return NFSERR_ISDIR (for something that isn't a directory) or NFSERR_INVAL (which is not a valid v2 error code), or change u-boot to also check for NFSERR_IO (which is 5).
There is no "good" option.
I suspect we should revert this change and document that we violate the RFC for historical compatibility with u-boot.
NeilBrown
Quoted 11 lines
Thanks in advance.
Best regards Jörg
Signature · 3 lines
Optimisten haben gar keine Ahnung von den freudigen Überraschungen, die Pessimisten erleben. (Peter Bramm)
Re: [PATCH 2/2] NFS: NFSERR_INVAL is not defined by NFSv2
NeilBrown schrieb am Fr 28. Aug, 21:33 (+1000):
Quoted 131 lines · Jörg Sommer
Quoted 119 lines
Chuck Lever schrieb am Di 09. Dez, 19:28 (-0500):
Quoted 7 lines
From: Chuck Lever <[email protected]>
A documenting comment in
include/uapi/linux/nfs.hclaims incorrectly that NFSv2 definesNFSERR_INVAL. There is no such definition in either RFC 1094 or https://pubs.opengroup.org/onlinepubs/9629799/chap7.htm
NFS3ERR_INVALis introduced in RFC 1813.Hello,
since this commit
0ac903d1bfdce8ff40657c2b7d996947b72b6645was added, U-Boot 2022.04 (I don't know about newer versions) can no longer access symlinks in NFS shares. When I revert this commit, U-Boot can load the file behind the symlink. Real files are no problem.The file I want to load is a symlink at the server:
``` % ls -l /srv/nfs/boot/Image.gz* lrwxrwxrwx 1 root root 41 7. Jul 16:29 /srv/nfs-con/boot/Image.gz -> Image.gz-5.15.213-imx8mm+gfffa4b6d4aea+p1 -rw-r--r-- 1 root root 5279373 7. Jul 16:29 /srv/nfs-con/boot/Image.gz-5.15.213-imx8mm+gfffa4b6d4aea+p1 ```Without this commit:
``` u-boot=> nfs 0x42000000 /srv/nfs/boot/Image.gz Filename '/srv/nfs-con/boot/Image.gz'. Load address: 0x42000000 Loading: ################################################################# done Bytes transferred = 5279373 (508e8d hex) ```But with this commit:
``` u-boot=> nfs 0x42000000 /srv/nfs/boot/Image.gz Filename '/srv/nfs-con/boot/Image.gz'. Load address: 0x42000000 Loading: done ```This is the network traffic:
``` No. Time Protocol Length Info 3 0.000370 Portmap 98 V2 GETPORT Call (Reply In 4) MOUNT(100005) V:1 UDP 4 0.000607 Portmap 70 V2 GETPORT Reply (Call In 3) Port:60340 5 0.000949 Portmap 98 V2 GETPORT Call (Reply In 6) NFS(100003) V:2 UDP 6 0.001046 Portmap 70 V2 GETPORT Reply (Call In 5) Port:2049 7 0.001368 MOUNT 126 V2 MNT Call (Reply In 8) /srv/nfs-con/boot 8 0.008026 MOUNT 102 V2 MNT Reply (Call In 7) 9 0.008389 NFS 146 V2 LOOKUP Call (Reply In 10), DH: 0x8c279135/Image.gz 10 0.008754 NFS 170 V2 LOOKUP Reply (Call In 9), FH: 0xcdddf154 11 0.009095 NFS 146 V2 READ Call (Reply In 12), FH: 0xcdddf154 Offset: 0 Count: 1024 TotalCount: 0 12 0.009189 NFS 70 V2 READ Reply (Call In 11) Error: NFS2ERR_IO 13 0.009511 MOUNT 102 V2 UMNTALL Call (Reply In 14) 14 0.010301 MOUNT 66 V2 UMNTALL Reply (Call In 13) ```From packet 11 V2 READ Call
``` Remote Procedure Call, Type:Call XID:0x000050e1 XID: 0x000050e1 (20705) Message Type: Call (0) RPC Version: 2 Program: NFS (100003) Program Version: 2 Procedure: READ (6) [The reply to this request is in frame 12] Credentials Flavor: AUTH_UNIX (1) Length: 20 Stamp: 0x00000000 Machine Name: <EMPTY> UID: 0 GID: 0 Auxiliary GIDs (0) Verifier Flavor: AUTH_NULL (0) Length: 0 Network File System, READ Call FH: 0xcdddf154 Offset: 0 Count: 1024 TotalCount: 0 [Program Version: 2] [V2 Procedure: READ (6)] file [hash (CRC-32): 0xcdddf154] FileHandle: 010004010100540020bb3809040054002f2edde4000000000000000000000000 Offset: 0 Count: 1024 Total Count: 0 ```From packet 12 V2 READ Reply
``` Remote Procedure Call, Type:Reply XID:0x000050e1 XID: 0x000050e1 (20705) Message Type: Reply (1) [Program: NFS (100003)] [Program Version: 2] [Procedure: READ (6)] Reply State: accepted (0) [This is a reply to a request in frame 11] [Time from request: 94.000 microseconds] Verifier Flavor: AUTH_NULL (0) Length: 0 Accept State: RPC executed successfully (0) Network File System, READ Reply Error: NFS2ERR_IO [Program Version: 2] [V2 Procedure: READ (6)] Status: NFS2ERR_IO (5) ```Quoted 2 lines
I can locally revert this commit in our kernel, but is there any other way to get it working again?
This is unfortunate.
U-boot has} else if ((rlen == -NFSERR_ISDIR) || (rlen == -NFSERR_INVAL)) { /* symbolic link */ nfs_state = STATE_READLINK_REQ; nfs_send();
Quoted 7 lines
so we either need nfsdv2 to return
NFSERR_ISDIR(for something that isn't a directory) orNFSERR_INVAL(which is not a valid v2 error code), or change u-boot to also check forNFSERR_IO(which is 5).There is no "good" option.
I suspect we should revert this change and document that we violate the RFC for historical compatibility with u-boot.
Maybe not revert the whole change, but add an exception for symlinks.
+++ fs/nfsd/nfsproc.c
@@ -33,7 +33,7 @@ static __be32 nfsd_map_status(__be32 status)
break; case nfserr_symlink: + /* this is invalid, but U-Boot ... */ + status = nfserr_inval; + break;
case nfserr_wrong_type:
- status = nfserr_inval;
+ status = nfserr_io;
Signature · 3 lines
Es liegt in der Natur des Menschen, vernünftig zu denken und unlogisch zu handeln! Das Gesagte ist nicht das Gemeinte und das Gehörte nicht das Verstandene!
Chuck Lever
maintainerRe: [PATCH 2/2] NFS: NFSERR_INVAL is not defined by NFSv2
In reply to NeilBrownQuoted 126 lines · NeilBrown
Quoted 119 lines · Jörg Sommer
Chuck Lever schrieb am Di 09. Dez, 19:28 (-0500):
Quoted 7 lines
From: Chuck Lever <[email protected]>
A documenting comment in
include/uapi/linux/nfs.hclaims incorrectly that NFSv2 definesNFSERR_INVAL. There is no such definition in either RFC 1094 or https://pubs.opengroup.org/onlinepubs/9629799/chap7.htm
NFS3ERR_INVALis introduced in RFC 1813.Hello,
since this commit
0ac903d1bfdce8ff40657c2b7d996947b72b6645was added, U-Boot 2022.04 (I don't know about newer versions) can no longer access symlinks in NFS shares. When I revert this commit, U-Boot can load the file behind the symlink. Real files are no problem.The file I want to load is a symlink at the server:
``` % ls -l /srv/nfs/boot/Image.gz* lrwxrwxrwx 1 root root 41 7. Jul 16:29 /srv/nfs-con/boot/Image.gz -> Image.gz-5.15.213-imx8mm+gfffa4b6d4aea+p1 -rw-r--r-- 1 root root 5279373 7. Jul 16:29 /srv/nfs-con/boot/Image.gz-5.15.213-imx8mm+gfffa4b6d4aea+p1 ```Without this commit:
``` u-boot=> nfs 0x42000000 /srv/nfs/boot/Image.gz Filename '/srv/nfs-con/boot/Image.gz'. Load address: 0x42000000 Loading: ################################################################# done Bytes transferred = 5279373 (508e8d hex) ```But with this commit:
``` u-boot=> nfs 0x42000000 /srv/nfs/boot/Image.gz Filename '/srv/nfs-con/boot/Image.gz'. Load address: 0x42000000 Loading: done ```This is the network traffic:
``` No. Time Protocol Length Info 3 0.000370 Portmap 98 V2 GETPORT Call (Reply In 4) MOUNT(100005) V:1 UDP 4 0.000607 Portmap 70 V2 GETPORT Reply (Call In 3) Port:60340 5 0.000949 Portmap 98 V2 GETPORT Call (Reply In 6) NFS(100003) V:2 UDP 6 0.001046 Portmap 70 V2 GETPORT Reply (Call In 5) Port:2049 7 0.001368 MOUNT 126 V2 MNT Call (Reply In 8) /srv/nfs-con/boot 8 0.008026 MOUNT 102 V2 MNT Reply (Call In 7) 9 0.008389 NFS 146 V2 LOOKUP Call (Reply In 10), DH: 0x8c279135/Image.gz 10 0.008754 NFS 170 V2 LOOKUP Reply (Call In 9), FH: 0xcdddf154 11 0.009095 NFS 146 V2 READ Call (Reply In 12), FH: 0xcdddf154 Offset: 0 Count: 1024 TotalCount: 0 12 0.009189 NFS 70 V2 READ Reply (Call In 11) Error: NFS2ERR_IO 13 0.009511 MOUNT 102 V2 UMNTALL Call (Reply In 14) 14 0.010301 MOUNT 66 V2 UMNTALL Reply (Call In 13) ```From packet 11 V2 READ Call
``` Remote Procedure Call, Type:Call XID:0x000050e1 XID: 0x000050e1 (20705) Message Type: Call (0) RPC Version: 2 Program: NFS (100003) Program Version: 2 Procedure: READ (6) [The reply to this request is in frame 12] Credentials Flavor: AUTH_UNIX (1) Length: 20 Stamp: 0x00000000 Machine Name: <EMPTY> UID: 0 GID: 0 Auxiliary GIDs (0) Verifier Flavor: AUTH_NULL (0) Length: 0 Network File System, READ Call FH: 0xcdddf154 Offset: 0 Count: 1024 TotalCount: 0 [Program Version: 2] [V2 Procedure: READ (6)] file [hash (CRC-32): 0xcdddf154] FileHandle: 010004010100540020bb3809040054002f2edde4000000000000000000000000 Offset: 0 Count: 1024 Total Count: 0 ```From packet 12 V2 READ Reply
``` Remote Procedure Call, Type:Reply XID:0x000050e1 XID: 0x000050e1 (20705) Message Type: Reply (1) [Program: NFS (100003)] [Program Version: 2] [Procedure: READ (6)] Reply State: accepted (0) [This is a reply to a request in frame 11] [Time from request: 94.000 microseconds] Verifier Flavor: AUTH_NULL (0) Length: 0 Accept State: RPC executed successfully (0) Network File System, READ Reply Error: NFS2ERR_IO [Program Version: 2] [V2 Procedure: READ (6)] Status: NFS2ERR_IO (5) ```Quoted 2 lines
I can locally revert this commit in our kernel, but is there any other way to get it working again?
This is unfortunate.
U-boot has
Quoted 8 lines
} else if ((rlen == -NFSERR_ISDIR) || (rlen == -NFSERR_INVAL)) { /* symbolic link */ nfs_state = STATE_READLINK_REQ; nfs_send();so we either need nfsdv2 to return
NFSERR_ISDIR(for something that isn't a directory) orNFSERR_INVAL(which is not a valid v2 error code), or change u-boot to also check forNFSERR_IO(which is 5).
U-Boot's NFSERR_ISDIR check (quoted above) is the Sun-compatible path. The NFSERR_INVAL arm was presumably added for Linux NFSD?
So the pre-0ac903d1bfdc code is not something I want to go back to. Returning NFSERR_INVAL is incompatible with the reference NFSv2 implementation, and so is NFSERR_IO.
Mapping nfserr_symlink to NFSERR_ISDIR affects the READ, WRITE, and SETATTR procedures. The Solaris NFS server returns NFSERR_ISDIR for READ and WRITE of a non-REG object, which suggests to me that is the behavior clients will expect.
IMO we should leave nfserr_wrong_type alone until we have a specific real-world complaint to address.
Signature · 1 line
Chuck Lever
Re: [PATCH 2/2] NFS: NFSERR_INVAL is not defined by NFSv2
Quoted 145 lines · Chuck Lever
Quoted 126 lines · NeilBrown
Quoted 119 lines · Jörg Sommer
Chuck Lever schrieb am Di 09. Dez, 19:28 (-0500):
Quoted 7 lines
From: Chuck Lever <[email protected]>
A documenting comment in
include/uapi/linux/nfs.hclaims incorrectly that NFSv2 definesNFSERR_INVAL. There is no such definition in either RFC 1094 or https://pubs.opengroup.org/onlinepubs/9629799/chap7.htm
NFS3ERR_INVALis introduced in RFC 1813.Hello,
since this commit
0ac903d1bfdce8ff40657c2b7d996947b72b6645was added, U-Boot 2022.04 (I don't know about newer versions) can no longer access symlinks in NFS shares. When I revert this commit, U-Boot can load the file behind the symlink. Real files are no problem.The file I want to load is a symlink at the server:
``` % ls -l /srv/nfs/boot/Image.gz* lrwxrwxrwx 1 root root 41 7. Jul 16:29 /srv/nfs-con/boot/Image.gz -> Image.gz-5.15.213-imx8mm+gfffa4b6d4aea+p1 -rw-r--r-- 1 root root 5279373 7. Jul 16:29 /srv/nfs-con/boot/Image.gz-5.15.213-imx8mm+gfffa4b6d4aea+p1 ```Without this commit:
``` u-boot=> nfs 0x42000000 /srv/nfs/boot/Image.gz Filename '/srv/nfs-con/boot/Image.gz'. Load address: 0x42000000 Loading: ################################################################# done Bytes transferred = 5279373 (508e8d hex) ```But with this commit:
``` u-boot=> nfs 0x42000000 /srv/nfs/boot/Image.gz Filename '/srv/nfs-con/boot/Image.gz'. Load address: 0x42000000 Loading: done ```This is the network traffic:
``` No. Time Protocol Length Info 3 0.000370 Portmap 98 V2 GETPORT Call (Reply In 4) MOUNT(100005) V:1 UDP 4 0.000607 Portmap 70 V2 GETPORT Reply (Call In 3) Port:60340 5 0.000949 Portmap 98 V2 GETPORT Call (Reply In 6) NFS(100003) V:2 UDP 6 0.001046 Portmap 70 V2 GETPORT Reply (Call In 5) Port:2049 7 0.001368 MOUNT 126 V2 MNT Call (Reply In 8) /srv/nfs-con/boot 8 0.008026 MOUNT 102 V2 MNT Reply (Call In 7) 9 0.008389 NFS 146 V2 LOOKUP Call (Reply In 10), DH: 0x8c279135/Image.gz 10 0.008754 NFS 170 V2 LOOKUP Reply (Call In 9), FH: 0xcdddf154 11 0.009095 NFS 146 V2 READ Call (Reply In 12), FH: 0xcdddf154 Offset: 0 Count: 1024 TotalCount: 0 12 0.009189 NFS 70 V2 READ Reply (Call In 11) Error: NFS2ERR_IO 13 0.009511 MOUNT 102 V2 UMNTALL Call (Reply In 14) 14 0.010301 MOUNT 66 V2 UMNTALL Reply (Call In 13) ```From packet 11 V2 READ Call
``` Remote Procedure Call, Type:Call XID:0x000050e1 XID: 0x000050e1 (20705) Message Type: Call (0) RPC Version: 2 Program: NFS (100003) Program Version: 2 Procedure: READ (6) [The reply to this request is in frame 12] Credentials Flavor: AUTH_UNIX (1) Length: 20 Stamp: 0x00000000 Machine Name: <EMPTY> UID: 0 GID: 0 Auxiliary GIDs (0) Verifier Flavor: AUTH_NULL (0) Length: 0 Network File System, READ Call FH: 0xcdddf154 Offset: 0 Count: 1024 TotalCount: 0 [Program Version: 2] [V2 Procedure: READ (6)] file [hash (CRC-32): 0xcdddf154] FileHandle: 010004010100540020bb3809040054002f2edde4000000000000000000000000 Offset: 0 Count: 1024 Total Count: 0 ```From packet 12 V2 READ Reply
``` Remote Procedure Call, Type:Reply XID:0x000050e1 XID: 0x000050e1 (20705) Message Type: Reply (1) [Program: NFS (100003)] [Program Version: 2] [Procedure: READ (6)] Reply State: accepted (0) [This is a reply to a request in frame 11] [Time from request: 94.000 microseconds] Verifier Flavor: AUTH_NULL (0) Length: 0 Accept State: RPC executed successfully (0) Network File System, READ Reply Error: NFS2ERR_IO [Program Version: 2] [V2 Procedure: READ (6)] Status: NFS2ERR_IO (5) ```Quoted 2 lines
I can locally revert this commit in our kernel, but is there any other way to get it working again?
This is unfortunate.
U-boot hasQuoted 8 lines
} else if ((rlen == -NFSERR_ISDIR) || (rlen == -NFSERR_INVAL)) { /* symbolic link */ nfs_state = STATE_READLINK_REQ; nfs_send();so we either need nfsdv2 to return
NFSERR_ISDIR(for something that isn't a directory) orNFSERR_INVAL(which is not a valid v2 error code), or change u-boot to also check forNFSERR_IO(which is 5).U-Boot's
NFSERR_ISDIRcheck (quoted above) is the Sun-compatible path. TheNFSERR_INVALarm was presumably added for Linux NFSD?So the pre-0ac903d1bfdc code is not something I want to go back to. Returning
NFSERR_INVALis incompatible with the reference NFSv2 implementation, and so isNFSERR_IO.
Quoted 7 lines
Mapping
nfserr_symlinktoNFSERR_ISDIRaffects the READ, WRITE, and SETATTR procedures. The Solaris NFS server returnsNFSERR_ISDIRfor READ and WRITE of a non-REG object, which suggests to me that is the behavior clients will expect.IMO we should leave
nfserr_wrong_typealone until we have a specific real-world complaint to address.
On the U-Boot side of things, the code in question dates back to when NFS support was originally added in 2004. The history here says that someone added the symlink support on top of what was borrowed from NetBSD, so yes, we're likely the originator of the incorrect behavior. But also, this means that everything U-Boot that's ever been using this feature now fails. And given the lag between the kernel change and the bug report, it's not something that's in rapidly changing areas and probably also in deployments that can't be updated. So perhaps things do need to go back to the way it was.
Signature · 1 line
Tom
Chuck Lever
maintainerRe: [PATCH 2/2] NFS: NFSERR_INVAL is not defined by NFSv2
Quoted 154 lines · Tom Rini
Quoted 145 lines · Chuck Lever
Quoted 126 lines · NeilBrown
Quoted 119 lines · Jörg Sommer
Chuck Lever schrieb am Di 09. Dez, 19:28 (-0500):
Quoted 7 lines
From: Chuck Lever <[email protected]>
A documenting comment in
include/uapi/linux/nfs.hclaims incorrectly that NFSv2 definesNFSERR_INVAL. There is no such definition in either RFC 1094 or https://pubs.opengroup.org/onlinepubs/9629799/chap7.htm
NFS3ERR_INVALis introduced in RFC 1813.Hello,
since this commit
0ac903d1bfdce8ff40657c2b7d996947b72b6645was added, U-Boot 2022.04 (I don't know about newer versions) can no longer access symlinks in NFS shares. When I revert this commit, U-Boot can load the file behind the symlink. Real files are no problem.The file I want to load is a symlink at the server:
``` % ls -l /srv/nfs/boot/Image.gz* lrwxrwxrwx 1 root root 41 7. Jul 16:29 /srv/nfs-con/boot/Image.gz -> Image.gz-5.15.213-imx8mm+gfffa4b6d4aea+p1 -rw-r--r-- 1 root root 5279373 7. Jul 16:29 /srv/nfs-con/boot/Image.gz-5.15.213-imx8mm+gfffa4b6d4aea+p1 ```Without this commit:
``` u-boot=> nfs 0x42000000 /srv/nfs/boot/Image.gz Filename '/srv/nfs-con/boot/Image.gz'. Load address: 0x42000000 Loading: ################################################################# done Bytes transferred = 5279373 (508e8d hex) ```But with this commit:
``` u-boot=> nfs 0x42000000 /srv/nfs/boot/Image.gz Filename '/srv/nfs-con/boot/Image.gz'. Load address: 0x42000000 Loading: done ```This is the network traffic:
``` No. Time Protocol Length Info 3 0.000370 Portmap 98 V2 GETPORT Call (Reply In 4) MOUNT(100005) V:1 UDP 4 0.000607 Portmap 70 V2 GETPORT Reply (Call In 3) Port:60340 5 0.000949 Portmap 98 V2 GETPORT Call (Reply In 6) NFS(100003) V:2 UDP 6 0.001046 Portmap 70 V2 GETPORT Reply (Call In 5) Port:2049 7 0.001368 MOUNT 126 V2 MNT Call (Reply In 8) /srv/nfs-con/boot 8 0.008026 MOUNT 102 V2 MNT Reply (Call In 7) 9 0.008389 NFS 146 V2 LOOKUP Call (Reply In 10), DH: 0x8c279135/Image.gz 10 0.008754 NFS 170 V2 LOOKUP Reply (Call In 9), FH: 0xcdddf154 11 0.009095 NFS 146 V2 READ Call (Reply In 12), FH: 0xcdddf154 Offset: 0 Count: 1024 TotalCount: 0 12 0.009189 NFS 70 V2 READ Reply (Call In 11) Error: NFS2ERR_IO 13 0.009511 MOUNT 102 V2 UMNTALL Call (Reply In 14) 14 0.010301 MOUNT 66 V2 UMNTALL Reply (Call In 13) ```From packet 11 V2 READ Call
``` Remote Procedure Call, Type:Call XID:0x000050e1 XID: 0x000050e1 (20705) Message Type: Call (0) RPC Version: 2 Program: NFS (100003) Program Version: 2 Procedure: READ (6) [The reply to this request is in frame 12] Credentials Flavor: AUTH_UNIX (1) Length: 20 Stamp: 0x00000000 Machine Name: <EMPTY> UID: 0 GID: 0 Auxiliary GIDs (0) Verifier Flavor: AUTH_NULL (0) Length: 0 Network File System, READ Call FH: 0xcdddf154 Offset: 0 Count: 1024 TotalCount: 0 [Program Version: 2] [V2 Procedure: READ (6)] file [hash (CRC-32): 0xcdddf154] FileHandle: 010004010100540020bb3809040054002f2edde4000000000000000000000000 Offset: 0 Count: 1024 Total Count: 0 ```From packet 12 V2 READ Reply
``` Remote Procedure Call, Type:Reply XID:0x000050e1 XID: 0x000050e1 (20705) Message Type: Reply (1) [Program: NFS (100003)] [Program Version: 2] [Procedure: READ (6)] Reply State: accepted (0) [This is a reply to a request in frame 11] [Time from request: 94.000 microseconds] Verifier Flavor: AUTH_NULL (0) Length: 0 Accept State: RPC executed successfully (0) Network File System, READ Reply Error: NFS2ERR_IO [Program Version: 2] [V2 Procedure: READ (6)] Status: NFS2ERR_IO (5) ```Quoted 2 lines
I can locally revert this commit in our kernel, but is there any other way to get it working again?
This is unfortunate.
U-boot hasQuoted 8 lines
} else if ((rlen == -NFSERR_ISDIR) || (rlen == -NFSERR_INVAL)) { /* symbolic link */ nfs_state = STATE_READLINK_REQ; nfs_send();so we either need nfsdv2 to return
NFSERR_ISDIR(for something that isn't a directory) orNFSERR_INVAL(which is not a valid v2 error code), or change u-boot to also check forNFSERR_IO(which is 5).U-Boot's
NFSERR_ISDIRcheck (quoted above) is the Sun-compatible path. TheNFSERR_INVALarm was presumably added for Linux NFSD?So the pre-0ac903d1bfdc code is not something I want to go back to. Returning
NFSERR_INVALis incompatible with the reference NFSv2 implementation, and so isNFSERR_IO.Quoted 7 lines
Mapping
nfserr_symlinktoNFSERR_ISDIRaffects the READ, WRITE, and SETATTR procedures. The Solaris NFS server returnsNFSERR_ISDIRfor READ and WRITE of a non-REG object, which suggests to me that is the behavior clients will expect.IMO we should leave
nfserr_wrong_typealone until we have a specific real-world complaint to address.
Quoted 9 lines
On the U-Boot side of things, the code in question dates back to when NFS support was originally added in 2004. The history here says that someone added the symlink support on top of what was borrowed from NetBSD, so yes, we're likely the originator of the incorrect behavior. But also, this means that everything U-Boot that's ever been using this feature now fails. And given the lag between the kernel change and the bug report, it's not something that's in rapidly changing areas and probably also in deployments that can't be updated. So perhaps things do need to go back to the way it was.
That argument doesn't make sense to me, and moves NFSD backwards instead of forward.
Reverting the commit is fine for stable kernels, but getting the revert into mainline will take just as long as fixing it correctly.
The "deployments can't be updated" also doesn't make sense: if they can't be updated, they won't be able to get the revert either.
I'm not convinced.
Signature · 1 line
Chuck Lever
Re: [PATCH 2/2] NFS: NFSERR_INVAL is not defined by NFSv2
Quoted 167 lines · Chuck Lever
Quoted 154 lines · Tom Rini
Quoted 145 lines · Chuck Lever
Quoted 126 lines · NeilBrown
Quoted 119 lines · Jörg Sommer
Chuck Lever schrieb am Di 09. Dez, 19:28 (-0500):
Quoted 7 lines
From: Chuck Lever <[email protected]>
A documenting comment in
include/uapi/linux/nfs.hclaims incorrectly that NFSv2 definesNFSERR_INVAL. There is no such definition in either RFC 1094 or https://pubs.opengroup.org/onlinepubs/9629799/chap7.htm
NFS3ERR_INVALis introduced in RFC 1813.Hello,
since this commit
0ac903d1bfdce8ff40657c2b7d996947b72b6645was added, U-Boot 2022.04 (I don't know about newer versions) can no longer access symlinks in NFS shares. When I revert this commit, U-Boot can load the file behind the symlink. Real files are no problem.The file I want to load is a symlink at the server:
``` % ls -l /srv/nfs/boot/Image.gz* lrwxrwxrwx 1 root root 41 7. Jul 16:29 /srv/nfs-con/boot/Image.gz -> Image.gz-5.15.213-imx8mm+gfffa4b6d4aea+p1 -rw-r--r-- 1 root root 5279373 7. Jul 16:29 /srv/nfs-con/boot/Image.gz-5.15.213-imx8mm+gfffa4b6d4aea+p1 ```Without this commit:
``` u-boot=> nfs 0x42000000 /srv/nfs/boot/Image.gz Filename '/srv/nfs-con/boot/Image.gz'. Load address: 0x42000000 Loading: ################################################################# done Bytes transferred = 5279373 (508e8d hex) ```But with this commit:
``` u-boot=> nfs 0x42000000 /srv/nfs/boot/Image.gz Filename '/srv/nfs-con/boot/Image.gz'. Load address: 0x42000000 Loading: done ```This is the network traffic:
``` No. Time Protocol Length Info 3 0.000370 Portmap 98 V2 GETPORT Call (Reply In 4) MOUNT(100005) V:1 UDP 4 0.000607 Portmap 70 V2 GETPORT Reply (Call In 3) Port:60340 5 0.000949 Portmap 98 V2 GETPORT Call (Reply In 6) NFS(100003) V:2 UDP 6 0.001046 Portmap 70 V2 GETPORT Reply (Call In 5) Port:2049 7 0.001368 MOUNT 126 V2 MNT Call (Reply In 8) /srv/nfs-con/boot 8 0.008026 MOUNT 102 V2 MNT Reply (Call In 7) 9 0.008389 NFS 146 V2 LOOKUP Call (Reply In 10), DH: 0x8c279135/Image.gz 10 0.008754 NFS 170 V2 LOOKUP Reply (Call In 9), FH: 0xcdddf154 11 0.009095 NFS 146 V2 READ Call (Reply In 12), FH: 0xcdddf154 Offset: 0 Count: 1024 TotalCount: 0 12 0.009189 NFS 70 V2 READ Reply (Call In 11) Error: NFS2ERR_IO 13 0.009511 MOUNT 102 V2 UMNTALL Call (Reply In 14) 14 0.010301 MOUNT 66 V2 UMNTALL Reply (Call In 13) ```From packet 11 V2 READ Call
``` Remote Procedure Call, Type:Call XID:0x000050e1 XID: 0x000050e1 (20705) Message Type: Call (0) RPC Version: 2 Program: NFS (100003) Program Version: 2 Procedure: READ (6) [The reply to this request is in frame 12] Credentials Flavor: AUTH_UNIX (1) Length: 20 Stamp: 0x00000000 Machine Name: <EMPTY> UID: 0 GID: 0 Auxiliary GIDs (0) Verifier Flavor: AUTH_NULL (0) Length: 0 Network File System, READ Call FH: 0xcdddf154 Offset: 0 Count: 1024 TotalCount: 0 [Program Version: 2] [V2 Procedure: READ (6)] file [hash (CRC-32): 0xcdddf154] FileHandle: 010004010100540020bb3809040054002f2edde4000000000000000000000000 Offset: 0 Count: 1024 Total Count: 0 ```From packet 12 V2 READ Reply
``` Remote Procedure Call, Type:Reply XID:0x000050e1 XID: 0x000050e1 (20705) Message Type: Reply (1) [Program: NFS (100003)] [Program Version: 2] [Procedure: READ (6)] Reply State: accepted (0) [This is a reply to a request in frame 11] [Time from request: 94.000 microseconds] Verifier Flavor: AUTH_NULL (0) Length: 0 Accept State: RPC executed successfully (0) Network File System, READ Reply Error: NFS2ERR_IO [Program Version: 2] [V2 Procedure: READ (6)] Status: NFS2ERR_IO (5) ```Quoted 2 lines
I can locally revert this commit in our kernel, but is there any other way to get it working again?
This is unfortunate.
U-boot hasQuoted 8 lines
} else if ((rlen == -NFSERR_ISDIR) || (rlen == -NFSERR_INVAL)) { /* symbolic link */ nfs_state = STATE_READLINK_REQ; nfs_send();so we either need nfsdv2 to return
NFSERR_ISDIR(for something that isn't a directory) orNFSERR_INVAL(which is not a valid v2 error code), or change u-boot to also check forNFSERR_IO(which is 5).U-Boot's
NFSERR_ISDIRcheck (quoted above) is the Sun-compatible path. TheNFSERR_INVALarm was presumably added for Linux NFSD?So the pre-0ac903d1bfdc code is not something I want to go back to. Returning
NFSERR_INVALis incompatible with the reference NFSv2 implementation, and so isNFSERR_IO.Quoted 7 lines
Mapping
nfserr_symlinktoNFSERR_ISDIRaffects the READ, WRITE, and SETATTR procedures. The Solaris NFS server returnsNFSERR_ISDIRfor READ and WRITE of a non-REG object, which suggests to me that is the behavior clients will expect.IMO we should leave
nfserr_wrong_typealone until we have a specific real-world complaint to address.Quoted 9 lines
On the U-Boot side of things, the code in question dates back to when NFS support was originally added in 2004. The history here says that someone added the symlink support on top of what was borrowed from NetBSD, so yes, we're likely the originator of the incorrect behavior. But also, this means that everything U-Boot that's ever been using this feature now fails. And given the lag between the kernel change and the bug report, it's not something that's in rapidly changing areas and probably also in deployments that can't be updated. So perhaps things do need to go back to the way it was.
Quoted 2 lines
That argument doesn't make sense to me, and moves NFSD backwards instead of forward.
I don't quite follow. The series here talks about correctness changes that were found by comparison with the relevant documentation and not about behavior with production / deployed systems. And it's not about something new, it's about v2 support. On the U-Boot side I was ready to drop it, except it turns out there's people still actively using it today.
But also, doesn't this fall under the "you can't break ABI" side of things? Especially since people have been using it for decades and there's (seemingly) not some sort of security implication to the fix (and we're talking about NFSv2, so...).
Quoted 2 lines
Reverting the commit is fine for stable kernels, but getting the revert into mainline will take just as long as fixing it correctly.
I disagree about the speed of fixing it (being U-Boot) correctly. I have a fix from Jörg today, and it could be in our October release, yes. When will that actually be seen by people using U-Boot? Well, maybe newer products based on... Fedora will pick up v2027.04, some semis will base on v2027.01, but most places? Probably never.
Quoted 3 lines
The "deployments can't be updated" also doesn't make sense: if they can't be updated, they won't be able to get the revert either.
By deployments I mean U-Boot deployments. It's notoriously hard to update firmwares most of the time. Some testing labs refuse to because of the value in testing the firmware most people likely have deployed rather than the latest and greatest. So most of the time, it's never updated. Can newer systems take advantage of good and specification following update mechanisms? Sure. In practice? Only maybe.
Signature · 1 line
Tom
Chuck Lever
maintainerRe: [PATCH 2/2] NFS: NFSERR_INVAL is not defined by NFSv2
Quoted 21 lines · Tom Rini
Quoted 16 lines · Chuck Lever
Quoted 5 lines · Tom Rini
Quoted 3 lines · Chuck Lever
On Fri, Aug 28, 2026, at 7:33 AM, NeilBrown wrote:
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
U-boot has
} else if ((rlen == -NFSERR_ISDIR) || (rlen == -NFSERR_INVAL)) { /* symbolic link */ nfs_state = STATE_READLINK_REQ; nfs_send();Quoted 3 lines
The "deployments can't be updated" also doesn't make sense: if they can't be updated, they won't be able to get the revert either.
Quoted 6 lines
By deployments I mean U-Boot deployments. It's notoriously hard to update firmwares most of the time. Some testing labs refuse to because of the value in testing the firmware most people likely have deployed rather than the latest and greatest. So most of the time, it's never updated. Can newer systems take advantage of good and specification following update mechanisms? Sure. In practice? Only maybe.
I'm talking about changing NFSD to return NFSERR_ISDIR, which would be picked up by the first "if" check above, which already exists in U-Boot.
That addresses the regression and can be backported into the LTS Linux kernels that have commit 0ac903d1bfdc [*]. It does not depend on making changes to U-Boot.
Since the problem was reported on linux-nfs and refers to a specific Linux kernel commit hash, I assumed the only thing on the table is a code change in NFSD.
Signature · 5 lines
Chuck Lever
[*] AFAICT, the only two LTS kernels that are affected are v6.12
and v6.18. The stable kernels (v7.1 and v7.2) would also be
impacted.Re: [PATCH 2/2] NFS: NFSERR_INVAL is not defined by NFSv2
Quoted 35 lines · Chuck Lever
Quoted 21 lines · Tom Rini
Quoted 16 lines · Chuck Lever
Quoted 5 lines · Tom Rini
Quoted 3 lines · Chuck Lever
On Fri, Aug 28, 2026, at 7:33 AM, NeilBrown wrote:
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
U-boot has
} else if ((rlen == -NFSERR_ISDIR) || (rlen == -NFSERR_INVAL)) { /* symbolic link */ nfs_state = STATE_READLINK_REQ; nfs_send();Quoted 3 lines
The "deployments can't be updated" also doesn't make sense: if they can't be updated, they won't be able to get the revert either.
Quoted 6 lines
By deployments I mean U-Boot deployments. It's notoriously hard to update firmwares most of the time. Some testing labs refuse to because of the value in testing the firmware most people likely have deployed rather than the latest and greatest. So most of the time, it's never updated. Can newer systems take advantage of good and specification following update mechanisms? Sure. In practice? Only maybe.
I'm talking about changing NFSD to return
NFSERR_ISDIR, which would be picked up by the first "if" check above, which already exists in U-Boot.
Quoted 15 lines
That addresses the regression and can be backported into the LTS Linux kernels that have commit
0ac903d1bfdc[*]. It does not depend on making changes to U-Boot.Since the problem was reported on linux-nfs and refers to a specific Linux kernel commit hash, I assumed the only thing on the table is a code change in NFSD.
Signature · 5 lines
Chuck Lever [*] AFAICT, the only two LTS kernels that are affected are v6.12 and v6.18. The stable kernels (v7.1 and v7.2) would also be impacted.
Ah, thanks for explaining more, I hadn't quite followed. Yes, something that doesn't require changing U-Boot is good, thanks.
Signature · 1 line
Tom
Re: [PATCH 2/2] NFS: NFSERR_INVAL is not defined by NFSv2
In reply to Chuck LeverQuoted 30 lines · Chuck Lever
Quoted 21 lines · Tom Rini
Quoted 16 lines · Chuck Lever
Quoted 5 lines · Tom Rini
Quoted 3 lines · Chuck Lever
On Fri, Aug 28, 2026, at 7:33 AM, NeilBrown wrote:
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
U-boot has
} else if ((rlen == -NFSERR_ISDIR) || (rlen == -NFSERR_INVAL)) { /* symbolic link */ nfs_state = STATE_READLINK_REQ; nfs_send();Quoted 3 lines
The "deployments can't be updated" also doesn't make sense: if they can't be updated, they won't be able to get the revert either.
Quoted 6 lines
By deployments I mean U-Boot deployments. It's notoriously hard to update firmwares most of the time. Some testing labs refuse to because of the value in testing the firmware most people likely have deployed rather than the latest and greatest. So most of the time, it's never updated. Can newer systems take advantage of good and specification following update mechanisms? Sure. In practice? Only maybe.
Quoted 3 lines
I'm talking about changing NFSD to return
NFSERR_ISDIR, which would be picked up by the first "if" check above, which already exists in U-Boot.
Good idea.
That matches what OpenSolaris does, which is the closest thing to a real standard for NFSv2.
lines 619-624.
Thanks,
NeilBrown
Quoted 17 lines
That addresses the regression and can be backported into the LTS Linux kernels that have commit
0ac903d1bfdc[*]. It does not depend on making changes to U-Boot.Since the problem was reported on linux-nfs and refers to a specific Linux kernel commit hash, I assumed the only thing on the table is a code change in NFSD.
Signature · 5 lines
Chuck Lever [*] AFAICT, the only two LTS kernels that are affected are v6.12 and v6.18. The stable kernels (v7.1 and v7.2) would also be impacted.
Chuck Lever
maintainerRe: [PATCH 2/2] NFS: NFSERR_INVAL is not defined by NFSv2
Quoted 6 lines · NeilBrown
Quoted 3 lines · Chuck Lever
I'm talking about changing NFSD to return
NFSERR_ISDIR, which would be picked up by the first "if" check above, which already exists in U-Boot.
Quoted 7 lines
Good idea.
That matches what OpenSolaris does, which is the closest thing to a real standard for NFSv2.lines 619-624.
Exactly. Patch coming soon.
Signature · 1 line
Chuck Lever (Come to NFS bake-a-thon! https://nfsv4bat.org)
Quoted 10 lines · Chuck Lever
From: Chuck Lever <[email protected]>
Here are two examples of minor bugs I found when comparing NFSD's human-generated status code definitions with equivalent xdrgen- generated headers.
Chuck Lever (2):
NFSD: RemoveNFSERR_EAGAIN
NFS:NFSERR_INVALis not defined by NFSv2
Quoted 7 lines
fs/nfs_common/common.c | 1 - fs/nfsd/nfs4proc.c | 2 +- fs/nfsd/nfsd.h | 1 - fs/nfsd/nfsproc.c | 2 +- include/trace/misc/nfs.h | 2 -- include/uapi/linux/nfs.h | 3 +-- 6 files changed, 3 insertions(+), 8 deletions(-)
These both look fine to me.
NeilBrown
Reviewed-byQuoted 19 lines · Jeff Layton
Quoted 10 lines · Chuck Lever
From: Chuck Lever <[email protected]>
Here are two examples of minor bugs I found when comparing NFSD's human-generated status code definitions with equivalent xdrgen- generated headers.
Chuck Lever (2):
NFSD: RemoveNFSERR_EAGAIN
NFS:NFSERR_INVALis not defined by NFSv2Quoted 7 lines
fs/nfs_common/common.c | 1 - fs/nfsd/nfs4proc.c | 2 +- fs/nfsd/nfsd.h | 1 - fs/nfsd/nfsproc.c | 2 +- include/trace/misc/nfs.h | 2 -- include/uapi/linux/nfs.h | 3 +-- 6 files changed, 3 insertions(+), 8 deletions(-)
Quoted 4 lines
These both look fine to me.
Reviewed-by Jeff Layton <[email protected]>
Agreed.
I cannot easily find a path that would lead to NFSv2 being presented with nfserr_symlink or nfserr_wrong_type, so that change probably isn't visible. I might have missed something though.
Thanks,
NeilBrown