Some minor RPi5 bits
cover Some minor RPi5 bits
These are taken from the downstream kernel device tree. They are small components that already have upstream support, from older generation RPis or existing arm IP with just minor changes for upstream, tested on rev C and D variants.
Peter Robinson (3):
arm64: dts: broadcom: bcm2712: add arm PMU
arm64: dts: broadcom: bcm2712: Add thermal monitor
arm64: dts: broadcom: bcm2712: Add USB OTG port
.../dts/broadcom/bcm2712-rpi-5-b-base.dtsi | 6 ++ arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 66 +++++++++++++++++++ 2 files changed, 72 insertions(+)
Signature · 1 line
2.55.0
PATCH 1/3 arm64: dts: broadcom: bcm2712: add arm PMU
The bcm2712 SoC in the Raspberry Pi 5 has a standard arm performance management unit that aligns with the Cortex-A76 cores that are in the SoC so add the details in so it can be used.
--- arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)
arch/arm64/boot/dts/broadcom/bcm2712.dtsi +9 -0
@@ -10,6 +10,15 @@ / { interrupt-parent = <&gicv2>; + arm-pmu { + compatible = "arm,cortex-a76-pmu"; + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>; + interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, <&cpu3>; + }; + clocks { /* The oscillator is the root of the clock tree. */ clk_osc: clk-osc {
Signature · 1 line
2.55.0
Re: [PATCH 1/3] arm64: dts: broadcom: bcm2712: add arm PMU
Hi Peter,
Quoted 35 lines · Peter Robinson
The bcm2712 SoC in the Raspberry Pi 5 has a standard arm performance management unit that aligns with the Cortex-A76 cores that are in the SoC so add the details in so it can be used.
Signed-off-by Peter Robinson <[email protected]>Cc Florian Fainelli <[email protected]>Cc Dave Stevenson <[email protected]--- arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)arch/arm64/boot/dts/broadcom/bcm2712.dtsi +9
-0@@ -10,6 +10,15 @@ / { interrupt-parent = <&gicv2>; + arm-pmu { + compatible = "arm,cortex-a76-pmu"; + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>; + interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, <&cpu3>; + }; + clocks { /* The oscillator is the root of the clock tree. */ clk_osc: clk-osc {Signature · 1 line
2.55.0
PATCH 2/3 arm64: dts: broadcom: bcm2712: Add thermal monitor
In reply to Peter RobinsonThe thermal sensors on the bcm2712 (rpi5) are the same infrastructure as on the bcm2711 (rpi4) so add those details so we can get thermal monitoring on the device as it can get quite hot.
--- arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 32 +++++++++++++++++++++++ 1 file changed, 32 insertions(+)
arch/arm64/boot/dts/broadcom/bcm2712.dtsi +32 -0
@@ -508,6 +508,18 @@ hdmi1: hdmi@7c706400 { ddc = <&ddc1>; status = "disabled"; }; + + avs_monitor: avs-monitor@7d542000 { + compatible = "brcm,bcm2711-avs-monitor", + "syscon", "simple-mfd"; + reg = <0x7d542000 0xf00>; + status = "okay"; + + thermal: thermal { + compatible = "brcm,bcm2711-thermal"; + #thermal-sensor-cells = <0>; + }; + }; }; axi: axi {
@@ -724,4 +736,24 @@ hvs: hvs@107c580000 { interrupt-names = "ch0-eof", "ch1-eof", "ch2-eof"; status = "disabled"; }; + + thermal-zones { + cpu_thermal: cpu-thermal { + polling-delay-passive = <1000>; + polling-delay = <1000>; + coefficients = <(-550) 450000>; + thermal-sensors = <&thermal>; + + thermal_trips: trips { + cpu_crit: cpu-crit { + temperature = <110000>; + hysteresis = <0>; + type = "critical"; + }; + }; + + cooling_maps: cooling-maps { + }; + }; + }; };
Signature · 1 line
2.55.0
Re: [PATCH 2/3] arm64: dts: broadcom: bcm2712: Add thermal monitor
Hi Peter,
Quoted 63 lines · Peter Robinson
The thermal sensors on the bcm2712 (rpi5) are the same infrastructure as on the bcm2711 (rpi4) so add those details so we can get thermal monitoring on the device as it can get quite hot.
Signed-off-by Peter Robinson <[email protected]>Cc Florian Fainelli <[email protected]>Cc Dave Stevenson <[email protected]--- arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 32 +++++++++++++++++++++++ 1 file changed, 32 insertions(+)arch/arm64/boot/dts/broadcom/bcm2712.dtsi +32
-0@@ -508,6 +508,18 @@ hdmi1: hdmi@7c706400 { ddc = <&ddc1>; status = "disabled"; }; + + avs_monitor: avs-monitor@7d542000 { + compatible = "brcm,bcm2711-avs-monitor", + "syscon", "simple-mfd"; + reg = <0x7d542000 0xf00>; + status = "okay"; + + thermal: thermal { + compatible = "brcm,bcm2711-thermal"; + #thermal-sensor-cells = <0>; + }; + }; }; axi: axi {@@ -724,4 +736,24 @@ hvs: hvs@107c580000 { interrupt-names = "ch0-eof", "ch1-eof", "ch2-eof"; status = "disabled"; }; + + thermal-zones { + cpu_thermal: cpu-thermal { + polling-delay-passive = <1000>; + polling-delay = <1000>; + coefficients = <(-550) 450000>; + thermal-sensors = <&thermal>; + + thermal_trips: trips { + cpu_crit: cpu-crit { + temperature = <110000>; + hysteresis = <0>; + type = "critical"; + }; + }; + + cooling_maps: cooling-maps { + }; + }; + }; };Signature · 1 line
2.55.0
Doesn't seem to apply cleanly on v7.3-rc1, could you please rebase?
Many thanks,
Andrea
Re: [PATCH 2/3] arm64: dts: broadcom: bcm2712: Add thermal monitor
Hi Andrea,
Quoted 57 lines
Quoted 57 lines
The thermal sensors on the bcm2712 (rpi5) are the same infrastructure as on the bcm2711 (rpi4) so add those details so we can get thermal monitoring on the device as it can get quite hot.
Signed-off-by Peter Robinson <[email protected]>Cc Florian Fainelli <[email protected]>Cc Dave Stevenson <[email protected]--- arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 32 +++++++++++++++++++++++ 1 file changed, 32 insertions(+)arch/arm64/boot/dts/broadcom/bcm2712.dtsi +30
-0@@ -508,6 +508,18 @@ hdmi1: hdmi@7c706400 { ddc = <&ddc1>; status = "disabled"; }; + + avs_monitor: avs-monitor@7d542000 { + compatible = "brcm,bcm2711-avs-monitor", + "syscon", "simple-mfd"; + reg = <0x7d542000 0xf00>; + status = "okay"; + + thermal: thermal { + compatible = "brcm,bcm2711-thermal"; + #thermal-sensor-cells = <0>; + }; + }; }; axi: axi {@@ -724,4 +736,24 @@ hvs: hvs@107c580000 { interrupt-names = "ch0-eof", "ch1-eof", "ch2-eof"; status = "disabled"; }; + + thermal-zones { + cpu_thermal: cpu-thermal { + polling-delay-passive = <1000>; + polling-delay = <1000>; + coefficients = <(-550) 450000>; + thermal-sensors = <&thermal>; + + thermal_trips: trips { + cpu_crit: cpu-crit { + temperature = <110000>; + hysteresis = <0>; + type = "critical"; + }; + }; + + cooling_maps: cooling-maps { + };
Quoted 8 lines
Quoted 6 lines
arch/arm64/boot/dts/broadcom/bcm2712.dtsi +2
-1+ }; + }; }; --2.55.0
Doesn't seem to apply cleanly on v7.3-rc1, could you please rebase?
It should apply cleanly against Florian's next branch here:
https://github.com/Broadcom/stblinux/commits/devicetree-arm64/next
Re: [PATCH 2/3] arm64: dts: broadcom: bcm2712: Add thermal monitor
Hi,
Am 03.09.26 um 20:42 schrieb Peter Robinson:
Quoted 66 lines
Hi Andrea,
Quoted 56 lines
Quoted 56 lines
The thermal sensors on the bcm2712 (rpi5) are the same infrastructure as on the bcm2711 (rpi4) so add those details so we can get thermal monitoring on the device as it can get quite hot.
Signed-off-by Peter Robinson <[email protected]>Cc Florian Fainelli <[email protected]>Cc Dave Stevenson <[email protected]--- arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 32 +++++++++++++++++++++++ 1 file changed, 32 insertions(+)arch/arm64/boot/dts/broadcom/bcm2712.dtsi +29
-0@@ -508,6 +508,18 @@ hdmi1: hdmi@7c706400 { ddc = <&ddc1>; status = "disabled"; }; + + avs_monitor: avs-monitor@7d542000 { + compatible = "brcm,bcm2711-avs-monitor", + "syscon", "simple-mfd"; + reg = <0x7d542000 0xf00>; + status = "okay"; + + thermal: thermal { + compatible = "brcm,bcm2711-thermal"; + #thermal-sensor-cells = <0>; + }; + }; }; axi: axi {@@ -724,4 +736,24 @@ hvs: hvs@107c580000 { interrupt-names = "ch0-eof", "ch1-eof", "ch2-eof"; status = "disabled"; }; + + thermal-zones { + cpu_thermal: cpu-thermal { + polling-delay-passive = <1000>; + polling-delay = <1000>; + coefficients = <(-550) 450000>; + thermal-sensors = <&thermal>; + + thermal_trips: trips { + cpu_crit: cpu-crit { + temperature = <110000>; + hysteresis = <0>; + type = "critical"; + }; + }; + + cooling_maps: cooling-maps {Quoted 8 lines
Quoted 7 lines
arch/arm64/boot/dts/broadcom/bcm2712.dtsi +3
-1+ }; + }; + }; }; --2.55.0
Doesn't seem to apply cleanly on v7.3-rc1, could you please rebase?
Quoted 2 lines
It should apply cleanly against Florian's next branch here:
https://github.com/Broadcom/stblinux/commits/devicetree-arm64/next
this branch based on 7.2-rc1, not sure this is intended.
Florian Fainelli
maintainerRe: [PATCH 2/3] arm64: dts: broadcom: bcm2712: Add thermal monitor
On 9/3/26 11:47, Stefan Wahren wrote:
[snip]
Quoted 4 lines
Quoted 3 lines
Quoted 1 line
Doesn't seem to apply cleanly on v7.3-rc1, could you please rebase?
It should apply cleanly against Florian's next branch here:
https://github.com/Broadcom/stblinux/commits/devicetree-arm64/nextthis branch based on 7.2-rc1, not sure this is intended.
It is intended to be based upon the last -rc1 that was released. v7.3-rc1 is not cut yet, but when it is, I will rebase all of the /next branch on top.
Signature · 1 line
Florian
Re: [PATCH 2/3] arm64: dts: broadcom: bcm2712: Add thermal monitor
Quoted 11 lines · Florian Fainelli
On 9/3/26 11:47, Stefan Wahren wrote:
[snip]Quoted 4 lines
Quoted 3 lines
Quoted 1 line
Doesn't seem to apply cleanly on v7.3-rc1, could you please rebase?
It should apply cleanly against Florian's next branch here:
https://github.com/Broadcom/stblinux/commits/devicetree-arm64/nextthis branch based on 7.2-rc1, not sure this is intended.
It is intended to be based upon the last -rc1 that was released. v7.3-rc1 is not cut yet, but when it is, I will rebase all of the /next branch on top.
But v7.3-rc1 was cut on Sunday 30th Aug IE 4 days ago ;-)
Florian Fainelli
maintainerRe: [PATCH 2/3] arm64: dts: broadcom: bcm2712: Add thermal monitor
Quoted 8 lines · Peter Robinson
Quoted 6 lines · Florian Fainelli
On 9/3/26 11:47, Stefan Wahren wrote:
[snip]Quoted 3 lines
Quoted 3 lines
Quoted 1 line
Doesn't seem to apply cleanly on v7.3-rc1, could you please rebase?
It should apply cleanly against Florian's next branch here:
https://github.com/Broadcom/stblinux/commits/devicetree-arm64/next
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
this branch based on 7.2-rc1, not sure this is intended.
It is intended to be based upon the last -rc1 that was released. v7.3-rc1 is not cut yet, but when it is, I will rebase all of the /next branch on top.
But v7.3-rc1 was cut on Sunday 30th Aug IE 4 days ago ;-)
All of the /next branches have now been rebased against v7.3-rc1.
Signature · 1 line
Florian
Re: [PATCH 2/3] arm64: dts: broadcom: bcm2712: Add thermal monitor
Quoted 12 lines · Florian Fainelli
Quoted 10 lines · Peter Robinson
Quoted 8 lines · Florian Fainelli
On 9/3/26 11:47, Stefan Wahren wrote:
[snip]Quoted 4 lines
Quoted 3 lines
Quoted 1 line
Doesn't seem to apply cleanly on v7.3-rc1, could you please rebase?
It should apply cleanly against Florian's next branch here:
https://github.com/Broadcom/stblinux/commits/devicetree-arm64/nextthis branch based on 7.2-rc1, not sure this is intended.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
It is intended to be based upon the last -rc1 that was released. v7.3-rc1 is not cut yet, but when it is, I will rebase all of the /next branch on top.
But v7.3-rc1 was cut on Sunday 30th Aug IE 4 days ago ;-)
All of the /next branches have now been rebased against v7.3-rc1.
Awesome, thanks, much appreciated.
PATCH 3/3 arm64: dts: broadcom: bcm2712: Add USB OTG port
In reply to Peter RobinsonThe Raspberry Pi 5 has a USB2 OTG port wired up to the Type-C that uses the same IP in earlier generations so wire this up so it can be used.
--- .../dts/broadcom/bcm2712-rpi-5-b-base.dtsi | 6 +++++ arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 25 +++++++++++++++++++ 2 files changed, 31 insertions(+)
arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi +6 -0
@@ -3,6 +3,7 @@ #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/input/input.h> +#include <dt-bindings/power/raspberrypi-power.h> #include "bcm2712.dtsi" / {
@@ -239,6 +240,11 @@ bluetooth: bluetooth { }; }; +&usb { + power-domains = <&power RPI_POWER_DOMAIN_USB>; + status = "okay"; +}; + &hvs { clocks = <&firmware_clocks 4>, <&firmware_clocks 16>; clock-names = "core", "disp";
arch/arm64/boot/dts/broadcom/bcm2712.dtsi +25 -0
@@ -55,6 +55,13 @@ clk_sw_baud: clk-sw-baud { clock-frequency = <96000000>; clock-output-names = "sw-baud"; }; + + clk_usb: clk-usb { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <480000000>; + clock-output-names = "otg"; + }; }; cpus: cpus {
@@ -693,6 +700,19 @@ v3d: gpu@1002000000 { interrupts = <GIC_SPI 250 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 249 IRQ_TYPE_LEVEL_HIGH>; }; + + usb: usb@100480000 { + compatible = "brcm,bcm2835-usb"; + reg = <0x10 0x00480000 0x0 0x10000>; + interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; + #address-cells = <1>; + #size-cells = <0>; + clocks = <&clk_usb>; + clock-names = "otg"; + phys = <&usbphy>; + phy-names = "usb2-phy"; + status = "disabled"; + }; }; vc4: gpu {
@@ -756,4 +776,9 @@ cooling_maps: cooling-maps { }; }; }; + + usbphy: phy { + compatible = "usb-nop-xceiv"; + #phy-cells = <0>; + }; };
Signature · 1 line
2.55.0
Re: [PATCH 3/3] arm64: dts: broadcom: bcm2712: Add USB OTG port
Hi Peter,
Quoted 55 lines · Peter Robinson
The Raspberry Pi 5 has a USB2 OTG port wired up to the Type-C that uses the same IP in earlier generations so wire this up so it can be used.
Signed-off-by Peter Robinson <[email protected]>Cc Florian Fainelli <[email protected]>Cc Dave Stevenson <[email protected]--- .../dts/broadcom/bcm2712-rpi-5-b-base.dtsi | 6 +++++ arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 25 +++++++++++++++++++ 2 files changed, 31 insertions(+)arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi +6
-0@@ -3,6 +3,7 @@ #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/input/input.h> +#include <dt-bindings/power/raspberrypi-power.h> #include "bcm2712.dtsi" / {@@ -239,6 +240,11 @@ bluetooth: bluetooth { }; }; +&usb { + power-domains = <&power RPI_POWER_DOMAIN_USB>; + status = "okay"; +}; + &hvs { clocks = <&firmware_clocks 4>, <&firmware_clocks 16>; clock-names = "core", "disp";arch/arm64/boot/dts/broadcom/bcm2712.dtsi +7
-0@@ -55,6 +55,13 @@ clk_sw_baud: clk-sw-baud { clock-frequency = <96000000>; clock-output-names = "sw-baud"; }; + + clk_usb: clk-usb { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <480000000>; + clock-output-names = "otg"; + }; }; cpus: cpus {
arch/arm64/boot/dts/broadcom/bcm2712.dtsi v3d: gpu@1002000000 { · line 704
Quoted 5 lines
arch/arm64/boot/dts/broadcom/bcm2712.dtsi +2
-0@@ -693,6 +700,19 @@ v3d: gpu@1002000000 { interrupts = <GIC_SPI 250 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 249 IRQ_TYPE_LEVEL_HIGH>; }; + + usb: usb@100480000 {
Please fill in the missing 0 in the unit number. Apart from that, LGTM.
Thanks,
Andrea
Quoted 27 lines
arch/arm64/boot/dts/broadcom/bcm2712.dtsi +16
-0+ compatible = "brcm,bcm2835-usb"; + reg = <0x10 0x00480000 0x0 0x10000>; + interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; + #address-cells = <1>; + #size-cells = <0>; + clocks = <&clk_usb>; + clock-names = "otg"; + phys = <&usbphy>; + phy-names = "usb2-phy"; + status = "disabled"; + }; }; vc4: gpu {@@ -756,4 +776,9 @@ cooling_maps: cooling-maps { }; }; }; + + usbphy: phy { + compatible = "usb-nop-xceiv"; + #phy-cells = <0>; + }; };Signature · 1 line
2.55.0
Florian Fainelli
maintainerRe: [PATCH 3/3] arm64: dts: broadcom: bcm2712: Add USB OTG port
Quoted 56 lines · Andrea della Porta
Hi Peter,
Quoted 53 lines · Peter Robinson
The Raspberry Pi 5 has a USB2 OTG port wired up to the Type-C that uses the same IP in earlier generations so wire this up so it can be used.
Signed-off-by Peter Robinson <[email protected]>Cc Florian Fainelli <[email protected]>Cc Dave Stevenson <[email protected]--- .../dts/broadcom/bcm2712-rpi-5-b-base.dtsi | 6 +++++ arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 25 +++++++++++++++++++ 2 files changed, 31 insertions(+)arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi +6
-0@@ -3,6 +3,7 @@ #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/input/input.h> +#include <dt-bindings/power/raspberrypi-power.h> #include "bcm2712.dtsi" / {@@ -239,6 +240,11 @@ bluetooth: bluetooth { }; }; +&usb { + power-domains = <&power RPI_POWER_DOMAIN_USB>; + status = "okay"; +}; + &hvs { clocks = <&firmware_clocks 4>, <&firmware_clocks 16>; clock-names = "core", "disp";arch/arm64/boot/dts/broadcom/bcm2712.dtsi +7
-0@@ -55,6 +55,13 @@ clk_sw_baud: clk-sw-baud { clock-frequency = <96000000>; clock-output-names = "sw-baud"; }; + + clk_usb: clk-usb { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <480000000>; + clock-output-names = "otg"; + }; };
Quoted 9 lines
arch/arm64/boot/dts/broadcom/bcm2712.dtsi v3d: gpu@1002000000 { · line 704
Quoted 7 lines
arch/arm64/boot/dts/broadcom/bcm2712.dtsi +2
-0cpus: cpus {@@ -693,6 +700,19 @@ v3d: gpu@1002000000 { interrupts = <GIC_SPI 250 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 249 IRQ_TYPE_LEVEL_HIGH>; }; + + usb: usb@100480000 {Please fill in the missing 0 in the unit number. Apart from that, LGTM.
Took care of that while applying, good catch!
Signature · 1 line
Florian
Hey Florian,
Quoted 4 lines
These are taken from the downstream kernel device tree. They are small components that already have upstream support, from older generation RPis or existing arm IP with just minor changes for upstream, tested on rev C and D variants.
These all still apply against rc1 with the already queued display adjustment patch, any further feedback?
Quoted 12 lines
Peter Robinson (3):
arm64: dts: broadcom: bcm2712: add arm PMU
arm64: dts: broadcom: bcm2712: Add thermal monitor
arm64: dts: broadcom: bcm2712: Add USB OTG port.../dts/broadcom/bcm2712-rpi-5-b-base.dtsi | 6 ++ arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 66 +++++++++++++++++++ 2 files changed, 72 insertions(+)--
2.55.0
Quoted 5 lines · Peter Robinson
These are taken from the downstream kernel device tree. They are small components that already have upstream support, from older generation RPis or existing arm IP with just minor changes for upstream, tested on rev C and D variants.
Quoted 9 lines
Peter Robinson (3):
arm64: dts: broadcom: bcm2712: add arm PMU
arm64: dts: broadcom: bcm2712: Add thermal monitor
arm64: dts: broadcom: bcm2712: Add USB OTG port.../dts/broadcom/bcm2712-rpi-5-b-base.dtsi | 6 ++ arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 66 +++++++++++++++++++ 2 files changed, 72 insertions(+)
Applied all 3 to devicetree-arm64/next, thanks!
Signature · 1 line
Florian