mfd: unused driver purge
Subsystems (23)
cover mfd: unused driver purge
From: Arnd Bergmann <[email protected]>
As part of my cleanup of old platforms, I had a look at all drivers that may have become unused because the last platform_data or DT definition was removed, or because of unmet Kconfig dependencies.
These are all the mfd drivers I found. The first ten in the list actually turned out to have been unusable long before my series, and I have added explanations on how I determined this in each patch. The last four patches are still in use in linux-7.3 but become unused after my series [1] that I hope to get merged for 7.4.
Somewhat unorthodox, I took a shortcut here and remove both the mfd drivers and the corresponding subsystem drivers (gpio, hwmon, iio, input, led, media, power, regulator, rtc, video, watchdog, asoc) in a combined patch, to simplify the interdependencies: removing just the mfd driver would leave unselectable or broken drivers in other subsystems. I also have additional patches for each of the other subsystems, currently a total of 300 patches, many of which still need better testing or proper changelog texts.
Please let me know if you all think this approach is ok, or if I should explode this further and turn these 14 patches into 70 individual ones by splitting them per subsystem.
See [2] for the current state of the overall series.
Arnd
[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=board-remove-7.3
Arnd Bergmann (14):
mfd: remove unused 88pm80x driver
mfd: remove unused rdc321x southbridge support
mfd: remove unused si476x driver
mfd: remove unused wm8400 driver
mfd: remove unused adp5520 driver
mfd: remove unused da903x driver
mfd: remove unused lp8788 driver
mfd: remove unused aat2870 driver
mfd: remove unused lm3533 driver
mfd: remove unused rc5t583 driver
mfd: remove unused wm8350 driver
mfd: remove unused mcp-sa11x0/ucb1x00 driver
mfd: remove unused menelaus driver
mfd: remove unused iPaq micro driver
.../ABI/testing/sysfs-class-backlight | 11 - Documentation/admin-guide/devices.txt | 1 - .../admin-guide/media/radio-cardlist.rst | 1 - Documentation/admin-guide/media/si476x.rst | 160 -- .../admin-guide/media/v4l-drivers.rst | 1 - .../devicetree/bindings/regulator/88pm800.txt | 38 - Documentation/hwmon/index.rst | 1 - Documentation/hwmon/wm8350.rst | 30 - .../watchdog/watchdog-parameters.rst | 7 - MAINTAINERS | 14 - drivers/gpio/Kconfig | 22 - drivers/gpio/Makefile | 3 - drivers/gpio/gpio-adp5520.c | 169 -- drivers/gpio/gpio-rdc321x.c | 199 -- drivers/gpio/gpio-wm8350.c | 144 -- drivers/hwmon/Kconfig | 10 - drivers/hwmon/Makefile | 1 - drivers/hwmon/wm8350-hwmon.c | 92 - drivers/iio/adc/Kconfig | 9 - drivers/iio/adc/Makefile | 1 - drivers/iio/adc/lp8788_adc.c | 219 --- drivers/iio/light/Kconfig | 17 - drivers/iio/light/Makefile | 1 - drivers/iio/light/lm3533-als.c | 922 ---------- drivers/input/keyboard/Kconfig | 10 - drivers/input/keyboard/Makefile | 1 - drivers/input/keyboard/adp5520-keys.c | 191 -- drivers/input/misc/88pm80x_onkey.c | 152 -- drivers/input/misc/Kconfig | 10 - drivers/input/misc/Makefile | 1 - drivers/input/touchscreen/Kconfig | 13 - drivers/input/touchscreen/Makefile | 1 - drivers/input/touchscreen/da9034-ts.c | 365 ---- drivers/leds/Kconfig | 47 - drivers/leds/Makefile | 5 - drivers/leds/leds-adp5520.c | 195 -- drivers/leds/leds-da903x.c | 145 -- drivers/leds/leds-lm3533.c | 755 -------- drivers/leds/leds-lp8788.c | 171 -- drivers/leds/leds-wm8350.c | 267 --- drivers/media/radio/Kconfig | 17 - drivers/media/radio/Makefile | 1 - drivers/media/radio/radio-si476x.c | 1523 --------------- drivers/mfd/88pm800.c | 619 ------- drivers/mfd/88pm805.c | 275 --- drivers/mfd/88pm80x.c | 159 -- drivers/mfd/Kconfig | 186 -- drivers/mfd/Makefile | 28 - drivers/mfd/aat2870-core.c | 458 ----- drivers/mfd/adp5520.c | 346 ---- drivers/mfd/da903x.c | 565 ------ drivers/mfd/ipaq-micro.c | 442 ----- drivers/mfd/lm3533-core.c | 635 ------- drivers/mfd/lm3533-ctrlbank.c | 162 -- drivers/mfd/lp8788-irq.c | 194 -- drivers/mfd/lp8788.c | 246 --- drivers/mfd/mcp-core.c | 235 --- drivers/mfd/mcp-sa11x0.c | 304 --- drivers/mfd/menelaus.c | 1251 ------------- drivers/mfd/rc5t583-irq.c | 383 ---- drivers/mfd/rc5t583.c | 299 --- drivers/mfd/rdc321x-southbridge.c | 96 - drivers/mfd/si476x-cmd.c | 1543 ---------------- drivers/mfd/si476x-i2c.c | 861 --------- drivers/mfd/si476x-prop.c | 233 --- drivers/mfd/ucb1x00-assabet.c | 175 -- drivers/mfd/ucb1x00-core.c | 795 -------- drivers/mfd/ucb1x00-ts.c | 445 ----- drivers/mfd/wm8350-core.c | 444 ----- drivers/mfd/wm8350-gpio.c | 217 --- drivers/mfd/wm8350-i2c.c | 64 - drivers/mfd/wm8350-irq.c | 542 ------ drivers/mfd/wm8350-regmap.c | 335 ---- drivers/mfd/wm8400-core.c | 163 -- drivers/power/supply/Kconfig | 22 - drivers/power/supply/Makefile | 3 - drivers/power/supply/da9030_battery.c | 581 ------ drivers/power/supply/lp8788-charger.c | 730 -------- drivers/power/supply/wm8350_power.c | 590 ------ drivers/regulator/88pm800-regulator.c | 287 --- drivers/regulator/Kconfig | 55 - drivers/regulator/Makefile | 8 - drivers/regulator/aat2870-regulator.c | 201 -- drivers/regulator/da903x-regulator.c | 495 ----- drivers/regulator/lp8788-buck.c | 541 ------ drivers/regulator/lp8788-ldo.c | 640 ------- drivers/regulator/rc5t583-regulator.c | 171 -- drivers/regulator/wm8350-regulator.c | 1330 ------------- drivers/regulator/wm8400-regulator.c | 276 --- drivers/rtc/Kconfig | 45 - drivers/rtc/Makefile | 3 - drivers/rtc/rtc-88pm80x.c | 340 ---- drivers/rtc/rtc-lp8788.c | 322 ---- drivers/rtc/rtc-rc5t583.c | 312 ---- drivers/rtc/rtc-wm8350.c | 474 ----- drivers/video/backlight/Kconfig | 41 - drivers/video/backlight/Makefile | 5 - drivers/video/backlight/aat2870_bl.c | 206 --- drivers/video/backlight/adp5520_bl.c | 385 ---- drivers/video/backlight/da903x_bl.c | 160 -- drivers/video/backlight/lm3533_bl.c | 398 ---- drivers/video/backlight/lp8788_bl.c | 190 -- drivers/watchdog/Kconfig | 19 - drivers/watchdog/Makefile | 2 - drivers/watchdog/rdc321x_wdt.c | 281 --- drivers/watchdog/wm8350_wdt.c | 171 -- include/linux/mfd/88pm80x.h | 370 ---- include/linux/mfd/aat2870.h | 164 -- include/linux/mfd/adp5520.h | 298 --- include/linux/mfd/lm3533.h | 99 - include/linux/mfd/lp8788-isink.h | 48 - include/linux/mfd/lp8788.h | 289 --- include/linux/mfd/mcp.h | 63 - include/linux/mfd/menelaus.h | 41 - include/linux/mfd/rc5t583.h | 369 ---- include/linux/mfd/rdc321x.h | 27 - include/linux/mfd/si476x-core.h | 532 ------ include/linux/mfd/si476x-platform.h | 256 --- include/linux/mfd/si476x-reports.h | 154 -- include/linux/mfd/ucb1x00.h | 261 --- include/linux/mfd/wm8350/audio.h | 620 ------- include/linux/mfd/wm8350/comparator.h | 171 -- include/linux/mfd/wm8350/core.h | 692 ------- include/linux/mfd/wm8350/gpio.h | 356 ---- include/linux/mfd/wm8350/pmic.h | 775 -------- include/linux/mfd/wm8350/rtc.h | 265 --- include/linux/mfd/wm8350/supply.h | 129 -- include/linux/mfd/wm8350/wdt.h | 24 - include/linux/mfd/wm8400-audio.h | 1174 ------------ include/linux/mfd/wm8400-private.h | 913 --------- include/linux/mfd/wm8400.h | 27 - include/linux/platform_data/mfd-mcp-sa11x0.h | 17 - include/media/drv-intf/si476x.h | 28 - include/uapi/linux/v4l2-controls.h | 4 +- sound/soc/codecs/Kconfig | 16 - sound/soc/codecs/Makefile | 6 - sound/soc/codecs/si476x.c | 263 --- sound/soc/codecs/wm8350.c | 1638 ----------------- sound/soc/codecs/wm8350.h | 25 - sound/soc/codecs/wm8400.c | 1348 -------------- sound/soc/codecs/wm8400.h | 54 - sound/soc/fsl/fsl-asoc-card.c | 8 - 142 files changed, 2 insertions(+), 39449 deletions(-) delete mode 100644 Documentation/admin-guide/media/si476x.rst delete mode 100644 Documentation/devicetree/bindings/regulator/88pm800.txt delete mode 100644 Documentation/hwmon/wm8350.rst delete mode 100644 drivers/gpio/gpio-adp5520.c delete mode 100644 drivers/gpio/gpio-rdc321x.c delete mode 100644 drivers/gpio/gpio-wm8350.c delete mode 100644 drivers/hwmon/wm8350-hwmon.c delete mode 100644 drivers/iio/adc/lp8788_adc.c delete mode 100644 drivers/iio/light/lm3533-als.c delete mode 100644 drivers/input/keyboard/adp5520-keys.c delete mode 100644 drivers/input/misc/88pm80x_onkey.c delete mode 100644 drivers/input/touchscreen/da9034-ts.c delete mode 100644 drivers/leds/leds-adp5520.c delete mode 100644 drivers/leds/leds-da903x.c delete mode 100644 drivers/leds/leds-lm3533.c delete mode 100644 drivers/leds/leds-lp8788.c delete mode 100644 drivers/leds/leds-wm8350.c delete mode 100644 drivers/media/radio/radio-si476x.c delete mode 100644 drivers/mfd/88pm800.c delete mode 100644 drivers/mfd/88pm805.c delete mode 100644 drivers/mfd/88pm80x.c delete mode 100644 drivers/mfd/aat2870-core.c delete mode 100644 drivers/mfd/adp5520.c delete mode 100644 drivers/mfd/da903x.c delete mode 100644 drivers/mfd/ipaq-micro.c delete mode 100644 drivers/mfd/lm3533-core.c delete mode 100644 drivers/mfd/lm3533-ctrlbank.c delete mode 100644 drivers/mfd/lp8788-irq.c delete mode 100644 drivers/mfd/lp8788.c delete mode 100644 drivers/mfd/mcp-core.c delete mode 100644 drivers/mfd/mcp-sa11x0.c delete mode 100644 drivers/mfd/menelaus.c delete mode 100644 drivers/mfd/rc5t583-irq.c delete mode 100644 drivers/mfd/rc5t583.c delete mode 100644 drivers/mfd/rdc321x-southbridge.c delete mode 100644 drivers/mfd/si476x-cmd.c delete mode 100644 drivers/mfd/si476x-i2c.c delete mode 100644 drivers/mfd/si476x-prop.c delete mode 100644 drivers/mfd/ucb1x00-assabet.c delete mode 100644 drivers/mfd/ucb1x00-core.c delete mode 100644 drivers/mfd/ucb1x00-ts.c delete mode 100644 drivers/mfd/wm8350-core.c delete mode 100644 drivers/mfd/wm8350-gpio.c delete mode 100644 drivers/mfd/wm8350-i2c.c delete mode 100644 drivers/mfd/wm8350-irq.c delete mode 100644 drivers/mfd/wm8350-regmap.c delete mode 100644 drivers/mfd/wm8400-core.c delete mode 100644 drivers/power/supply/da9030_battery.c delete mode 100644 drivers/power/supply/lp8788-charger.c delete mode 100644 drivers/power/supply/wm8350_power.c delete mode 100644 drivers/regulator/88pm800-regulator.c delete mode 100644 drivers/regulator/aat2870-regulator.c delete mode 100644 drivers/regulator/da903x-regulator.c delete mode 100644 drivers/regulator/lp8788-buck.c delete mode 100644 drivers/regulator/lp8788-ldo.c delete mode 100644 drivers/regulator/rc5t583-regulator.c delete mode 100644 drivers/regulator/wm8350-regulator.c delete mode 100644 drivers/regulator/wm8400-regulator.c delete mode 100644 drivers/rtc/rtc-88pm80x.c delete mode 100644 drivers/rtc/rtc-lp8788.c delete mode 100644 drivers/rtc/rtc-rc5t583.c delete mode 100644 drivers/rtc/rtc-wm8350.c delete mode 100644 drivers/video/backlight/aat2870_bl.c delete mode 100644 drivers/video/backlight/adp5520_bl.c delete mode 100644 drivers/video/backlight/da903x_bl.c delete mode 100644 drivers/video/backlight/lm3533_bl.c delete mode 100644 drivers/video/backlight/lp8788_bl.c delete mode 100644 drivers/watchdog/rdc321x_wdt.c delete mode 100644 drivers/watchdog/wm8350_wdt.c delete mode 100644 include/linux/mfd/88pm80x.h delete mode 100644 include/linux/mfd/aat2870.h delete mode 100644 include/linux/mfd/adp5520.h delete mode 100644 include/linux/mfd/lm3533.h delete mode 100644 include/linux/mfd/lp8788-isink.h delete mode 100644 include/linux/mfd/lp8788.h delete mode 100644 include/linux/mfd/mcp.h delete mode 100644 include/linux/mfd/menelaus.h delete mode 100644 include/linux/mfd/rc5t583.h delete mode 100644 include/linux/mfd/rdc321x.h delete mode 100644 include/linux/mfd/si476x-core.h delete mode 100644 include/linux/mfd/si476x-platform.h delete mode 100644 include/linux/mfd/si476x-reports.h delete mode 100644 include/linux/mfd/ucb1x00.h delete mode 100644 include/linux/mfd/wm8350/audio.h delete mode 100644 include/linux/mfd/wm8350/comparator.h delete mode 100644 include/linux/mfd/wm8350/core.h delete mode 100644 include/linux/mfd/wm8350/gpio.h delete mode 100644 include/linux/mfd/wm8350/pmic.h delete mode 100644 include/linux/mfd/wm8350/rtc.h delete mode 100644 include/linux/mfd/wm8350/supply.h delete mode 100644 include/linux/mfd/wm8350/wdt.h delete mode 100644 include/linux/mfd/wm8400-audio.h delete mode 100644 include/linux/mfd/wm8400-private.h delete mode 100644 include/linux/mfd/wm8400.h delete mode 100644 include/linux/platform_data/mfd-mcp-sa11x0.h delete mode 100644 include/media/drv-intf/si476x.h delete mode 100644 sound/soc/codecs/si476x.c delete mode 100644 sound/soc/codecs/wm8350.c delete mode 100644 sound/soc/codecs/wm8350.h delete mode 100644 sound/soc/codecs/wm8400.c delete mode 100644 sound/soc/codecs/wm8400.h
Signature · 41 lines
2.53.0 Cc: Lee Jones <[email protected]> Cc: Daniel Thompson <[email protected]> Cc: Jingoo Han <[email protected]> Cc: Mauro Carvalho Chehab <[email protected]> Cc: Liam Girdwood <[email protected]> Cc: Mark Brown <[email protected]> Cc: Rob Herring <[email protected]> Cc: Krzysztof Kozlowski <[email protected]> Cc: Conor Dooley <[email protected]> Cc: Guenter Roeck <[email protected]> Cc: Linus Walleij <[email protected]> Cc: Bartosz Golaszewski <[email protected]> Cc: Jonathan Cameron <[email protected]> Cc: Dmitry Torokhov <[email protected]> Cc: Pavel Machek <[email protected]> Cc: Michael Hennerich <[email protected]> Cc: Support Opensource <[email protected]> Cc: Sebastian Reichel <[email protected]> Cc: Alexandre Belloni <[email protected]> Cc: Helge Deller <[email protected]> Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected]
PATCH 1/14 mfd: remove unused 88pm80x driver
From: Arnd Bergmann <[email protected]>
This pair of drivers was originally added as companion chips for pxa/mmp SoCs, but the corresponding platform code was never merged, so it has been unused the entire time.
--- .../devicetree/bindings/regulator/88pm800.txt | 38 -- drivers/input/misc/88pm80x_onkey.c | 152 ----- drivers/input/misc/Kconfig | 10 - drivers/input/misc/Makefile | 1 - drivers/mfd/88pm800.c | 619 ------------------ drivers/mfd/88pm805.c | 275 -------- drivers/mfd/88pm80x.c | 159 ----- drivers/mfd/Kconfig | 24 - drivers/mfd/Makefile | 2 - drivers/regulator/88pm800-regulator.c | 287 -------- drivers/regulator/Kconfig | 10 - drivers/regulator/Makefile | 1 - drivers/rtc/Kconfig | 10 - drivers/rtc/Makefile | 1 - drivers/rtc/rtc-88pm80x.c | 340 ---------- include/linux/mfd/88pm80x.h | 370 ----------- 16 files changed, 2299 deletions(-) delete mode 100644 Documentation/devicetree/bindings/regulator/88pm800.txt delete mode 100644 drivers/input/misc/88pm80x_onkey.c delete mode 100644 drivers/mfd/88pm800.c delete mode 100644 drivers/mfd/88pm805.c delete mode 100644 drivers/mfd/88pm80x.c delete mode 100644 drivers/regulator/88pm800-regulator.c delete mode 100644 drivers/rtc/rtc-88pm80x.c delete mode 100644 include/linux/mfd/88pm80x.h
Documentation/devicetree/bindings/regulator/88pm800.txt deleted +0 -38
@@ -1,38 +0,0 @@ -Marvell 88PM800 regulator - -Required properties: -- compatible: "marvell,88pm800" -- reg: I2C slave address -- regulators: A node that houses a sub-node for each regulator within the - device. Each sub-node is identified using the node's name (or the deprecated - regulator-compatible property if present), with valid values listed below. - The content of each sub-node is defined by the standard binding for - regulators; see regulator.txt. - -The valid names for regulators are: - - buck1, buck2, buck3, buck4, buck5, ldo1, ldo2, ldo3, ldo4, ldo5, ldo6, ldo7, - ldo8, ldo9, ldo10, ldo11, ldo12, ldo13, ldo14, ldo15, ldo16, ldo17, ldo18, ldo19 - -Example: - - pmic: 88pm800@31 { - compatible = "marvell,88pm800"; - reg = <0x31>; - - regulators { - buck1 { - regulator-min-microvolt = <600000>; - regulator-max-microvolt = <3950000>; - regulator-boot-on; - regulator-always-on; - }; - ldo1 { - regulator-min-microvolt = <600000>; - regulator-max-microvolt = <15000000>; - regulator-boot-on; - regulator-always-on; - }; -... - }; - };
drivers/input/misc/88pm80x_onkey.c deleted +0 -152
152 lines not on this page · raw message
drivers/input/misc/Kconfig +0 -10
@@ -23,16 +23,6 @@ config INPUT_88PM860X_ONKEY To compile this driver as a module, choose M here: the module will be called 88pm860x_onkey. -config INPUT_88PM80X_ONKEY - tristate "88PM80x ONKEY support" - depends on MFD_88PM800 - help - Support the ONKEY of Marvell 88PM80x PMICs as an input device - reporting power button status. - - To compile this driver as a module, choose M here: the module - will be called 88pm80x_onkey. - config INPUT_88PM886_ONKEY tristate "Marvell 88PM886 onkey support" depends on MFD_88PM886_PMIC
drivers/input/misc/Makefile +0 -1
@@ -6,7 +6,6 @@ # Each configuration option enables a list of files. obj-$(CONFIG_INPUT_88PM860X_ONKEY) += 88pm860x_onkey.o -obj-$(CONFIG_INPUT_88PM80X_ONKEY) += 88pm80x_onkey.o obj-$(CONFIG_INPUT_88PM886_ONKEY) += 88pm886-onkey.o obj-$(CONFIG_INPUT_AB8500_PONKEY) += ab8500-ponkey.o obj-$(CONFIG_INPUT_AD714X) += ad714x.o
drivers/mfd/88pm800.c deleted +0 -619
619 lines not on this page · raw message
drivers/mfd/88pm805.c deleted +0 -275
275 lines not on this page · raw message
drivers/mfd/88pm80x.c deleted +0 -159
159 lines not on this page · raw message
drivers/mfd/Kconfig +0 -24
@@ -858,30 +858,6 @@ config MFD_KEMPLD This driver can also be built as a module. If so, the module will be called kempld-core. -config MFD_88PM800 - tristate "Marvell 88PM800" - depends on I2C - select REGMAP_I2C - select REGMAP_IRQ - select MFD_CORE - help - This supports for Marvell 88PM800 Power Management IC. - This includes the I2C driver and the core APIs _only_, you have to - select individual components like voltage regulators, RTC and - battery-charger under the corresponding menus. - -config MFD_88PM805 - tristate "Marvell 88PM805" - depends on I2C - select REGMAP_I2C - select REGMAP_IRQ - select MFD_CORE - help - This supports for Marvell 88PM805 Power Management IC. This includes - the I2C driver and the core APIs _only_, you have to select individual - components like codec device, headset/Mic device under the - corresponding menus. - config MFD_88PM860X bool "Marvell 88PM8606/88PM8607" depends on I2C=y
drivers/mfd/Makefile +0 -2
@@ -5,8 +5,6 @@ 88pm860x-objs := 88pm860x-core.o 88pm860x-i2c.o obj-$(CONFIG_MFD_88PM860X) += 88pm860x.o -obj-$(CONFIG_MFD_88PM800) += 88pm800.o 88pm80x.o -obj-$(CONFIG_MFD_88PM805) += 88pm805.o 88pm80x.o obj-$(CONFIG_MFD_88PM886_PMIC) += 88pm886.o obj-$(CONFIG_MFD_ACT8945A) += act8945a.o obj-$(CONFIG_MFD_SM501) += sm501.o
drivers/regulator/88pm800-regulator.c deleted +0 -287
287 lines not on this page · raw message
drivers/regulator/Kconfig +0 -10
@@ -75,16 +75,6 @@ config REGULATOR_88PG86X They provide two I2C-controlled DC/DC step-down converters with sleep mode and separate enable pins. -config REGULATOR_88PM800 - tristate "Marvell 88PM800 Power regulators" - depends on MFD_88PM800 - help - This driver supports Marvell 88PM800 voltage regulator chips. - It delivers digitally programmable output, - the voltage is programmed via I2C interface. - It's suitable to support PXA988 chips to control VCC_MAIN and - various voltages. - config REGULATOR_88PM8607 tristate "Marvell 88PM8607 Power regulators" depends on MFD_88PM860X=y
drivers/regulator/Makefile +0 -1
@@ -12,7 +12,6 @@ obj-$(CONFIG_REGULATOR_VIRTUAL_CONSUMER) += virtual.o obj-$(CONFIG_REGULATOR_USERSPACE_CONSUMER) += userspace-consumer.o obj-$(CONFIG_REGULATOR_88PG86X) += 88pg86x.o -obj-$(CONFIG_REGULATOR_88PM800) += 88pm800-regulator.o obj-$(CONFIG_REGULATOR_88PM8607) += 88pm8607.o obj-$(CONFIG_REGULATOR_88PM886) += 88pm886-regulator.o obj-$(CONFIG_REGULATOR_CROS_EC) += cros-ec-regulator.o
drivers/rtc/Kconfig +0 -10
@@ -172,16 +172,6 @@ config RTC_DRV_88PM860X This driver can also be built as a module. If so, the module will be called rtc-88pm860x. -config RTC_DRV_88PM80X - tristate "Marvell 88PM80x" - depends on MFD_88PM800 - help - If you say yes here you get support for RTC function in Marvell - 88PM80x chips. - - This driver can also be built as a module. If so, the module - will be called rtc-88pm80x. - config RTC_DRV_88PM886 tristate "Marvell 88PM886 RTC driver" depends on MFD_88PM886_PMIC
drivers/rtc/Makefile +0 -1
@@ -19,7 +19,6 @@ obj-$(CONFIG_RTC_LIB_KUNIT_TEST) += test_rtc_lib.o # Keep the list ordered. -obj-$(CONFIG_RTC_DRV_88PM80X) += rtc-88pm80x.o obj-$(CONFIG_RTC_DRV_88PM860X) += rtc-88pm860x.o obj-$(CONFIG_RTC_DRV_88PM886) += rtc-88pm886.o obj-$(CONFIG_RTC_DRV_AB8500) += rtc-ab8500.o
drivers/rtc/rtc-88pm80x.c deleted +0 -340
340 lines not on this page · raw message
include/linux/mfd/88pm80x.h deleted +0 -370
370 lines not on this page · raw message
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH 01/14] mfd: remove unused 88pm80x driver
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 7 lines
From: Arnd Bergmann <[email protected]>
This pair of drivers was originally added as companion chips for pxa/mmp SoCs, but the corresponding platform code was never merged, so it has been unused the entire time.
Signed-off-by Arnd Bergmann <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Re: [PATCH 01/14] mfd: remove unused 88pm80x driver
In reply to Arnd BergmannQuoted 7 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This pair of drivers was originally added as companion chips for pxa/mmp SoCs, but the corresponding platform code was never merged, so it has been unused the entire time.
Signed-off-by Arnd Bergmann <[email protected]>
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Re: [PATCH 01/14] mfd: remove unused 88pm80x driver
In reply to Arnd BergmannQuoted 9 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This pair of drivers was originally added as companion chips for pxa/mmp SoCs, but the corresponding platform code was never merged, so it has been unused the entire time.
Signed-off-by Arnd Bergmann <[email protected]>--- .../devicetree/bindings/regulator/88pm800.txt | 38 --
Best regards,
Krzysztof
PATCH 2/14 mfd: remove unused rdc321x southbridge support
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
The rdc321x was a 486-class SoC developed by RDC. While RDC's later products closely resemble the DM&P Vortex86 product line and are still sold under both names, I checked the datasheets for those and found that the GPIO and WDT blocks on them are incompatible with the rtc321x.
Remove this driver, as there is no way to run Linux any more on the older chips after i486 support has been removed.
--- drivers/gpio/Kconfig | 8 - drivers/gpio/Makefile | 1 - drivers/gpio/gpio-rdc321x.c | 199 --------------------- drivers/mfd/Kconfig | 9 - drivers/mfd/Makefile | 1 - drivers/mfd/rdc321x-southbridge.c | 96 ---------- drivers/watchdog/Kconfig | 11 -- drivers/watchdog/Makefile | 1 - drivers/watchdog/rdc321x_wdt.c | 281 ------------------------------ include/linux/mfd/rdc321x.h | 27 --- 10 files changed, 634 deletions(-) delete mode 100644 drivers/gpio/gpio-rdc321x.c delete mode 100644 drivers/mfd/rdc321x-southbridge.c delete mode 100644 drivers/watchdog/rdc321x_wdt.c delete mode 100644 include/linux/mfd/rdc321x.h
drivers/gpio/Kconfig +0 -8
@@ -1946,14 +1946,6 @@ config GPIO_PCIE_IDIO_24 Input filter control is not supported by this driver, and the input filters are deactivated by this driver. -config GPIO_RDC321X - tristate "RDC R-321x GPIO support" - select MFD_CORE - select MFD_RDC321X - help - Support for the RDC R321x SoC GPIOs over southbridge - PCI configuration space. - config GPIO_SODAVILLE bool "Intel Sodaville GPIO support" depends on X86 && OF
drivers/gpio/Makefile +0 -1
@@ -156,7 +156,6 @@ obj-$(CONFIG_GPIO_RASPBERRYPI_EXP) += gpio-raspberrypi-exp.o obj-$(CONFIG_GPIO_RC5T583) += gpio-rc5t583.o obj-$(CONFIG_GPIO_RCAR) += gpio-rcar.o obj-$(CONFIG_GPIO_RDA) += gpio-rda.o -obj-$(CONFIG_GPIO_RDC321X) += gpio-rdc321x.o obj-$(CONFIG_GPIO_REALTEK_OTTO) += gpio-realtek-otto.o obj-$(CONFIG_GPIO_REG) += gpio-reg.o obj-$(CONFIG_GPIO_ROCKCHIP) += gpio-rockchip.o
drivers/gpio/gpio-rdc321x.c deleted +0 -199
199 lines not on this page · raw message
drivers/mfd/Kconfig +0 -9
@@ -1289,15 +1289,6 @@ config MFD_SY7636A To enable support for building sub-devices as modules, choose M here. -config MFD_RDC321X - tristate "RDC R-321x southbridge" - select MFD_CORE - depends on PCI - help - Say yes here if you want to have support for the RDC R-321x SoC - southbridge which provides access to GPIOs and Watchdog using the - southbridge PCI device configuration space. - config MFD_RT4831 tristate "Richtek RT4831 four channel WLED and Display Bias Voltage" depends on I2C
drivers/mfd/Makefile +0 -1
@@ -200,7 +200,6 @@ obj-$(CONFIG_MFD_KEMPLD) += kempld-core.o obj-$(CONFIG_MFD_INTEL_QUARK_I2C_GPIO) += intel_quark_i2c_gpio.o obj-$(CONFIG_LPC_SCH) += lpc_sch.o obj-$(CONFIG_LPC_ICH) += lpc_ich.o -obj-$(CONFIG_MFD_RDC321X) += rdc321x-southbridge.o obj-$(CONFIG_MFD_JANZ_CMODIO) += janz-cmodio.o obj-$(CONFIG_MFD_TPS6586X) += tps6586x.o obj-$(CONFIG_MFD_VX855) += vx855.o
drivers/mfd/rdc321x-southbridge.c deleted +0 -96
96 lines not on this page · raw message
drivers/watchdog/Kconfig +0 -11
@@ -1572,17 +1572,6 @@ config NV_TCO To compile this driver as a module, choose M here: the module will be called nv_tco. -config RDC321X_WDT - tristate "RDC R-321x SoC watchdog" - depends on X86_32 || COMPILE_TEST - depends on PCI - help - This is the driver for the built in hardware watchdog - in the RDC R-321x SoC. - - To compile this driver as a module, choose M here: the - module will be called rdc321x_wdt. - config 60XX_WDT tristate "SBC-60XX Watchdog Timer" depends on (X86 || COMPILE_TEST) && HAS_IOPORT
drivers/watchdog/Makefile +0 -1
@@ -138,7 +138,6 @@ obj-$(CONFIG_SC1200_WDT) += sc1200wdt.o obj-$(CONFIG_SCx200_WDT) += scx200_wdt.o obj-$(CONFIG_PC87413_WDT) += pc87413_wdt.o obj-$(CONFIG_NV_TCO) += nv_tco.o -obj-$(CONFIG_RDC321X_WDT) += rdc321x_wdt.o obj-$(CONFIG_60XX_WDT) += sbc60xxwdt.o obj-$(CONFIG_SBC8360_WDT) += sbc8360.o obj-$(CONFIG_SBC7240_WDT) += sbc7240_wdt.o
drivers/watchdog/rdc321x_wdt.c deleted +0 -281
281 lines not on this page · raw message
include/linux/mfd/rdc321x.h deleted +0 -27
@@ -1,27 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 */ -#ifndef __RDC321X_MFD_H -#define __RDC321X_MFD_H - -#include <linux/types.h> -#include <linux/pci.h> - -/* Offsets to be accessed in the southbridge PCI -* device configuration register */ -#define RDC321X_WDT_CTRL 0x44 -#define RDC321X_GPIO_CTRL_REG1 0x48 -#define RDC321X_GPIO_DATA_REG1 0x4c -#define RDC321X_GPIO_CTRL_REG2 0x84 -#define RDC321X_GPIO_DATA_REG2 0x88 - -#define RDC321X_NUM_GPIO 59 - -struct rdc321x_gpio_pdata { -struct pci_dev *sb_pdev; -unsigned max_gpios; -}; - -struct rdc321x_wdt_pdata { -struct pci_dev *sb_pdev; -}; - -#endif /* __RDC321X_MFD_H */
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH 02/14] mfd: remove unused rdc321x southbridge support
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Incomplete removal of RDC321x support leaves dead reboot fixups, PCI IDs, and a stale MAINTAINERS…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete removal of RDC321x support leaves dead reboot fixups, PCI IDs, and a stale MAINTAINERS entry. --
commit d66c645a0b11af3b988f3b3f1fe1a950247d9884
Author: Arnd Bergmann <[email protected]>
mfd: remove unused rdc321x southbridge support
This commit removes the rdc321x southbridge support (MFD, GPIO, and Watchdog), as the older i486 chips can no longer boot Linux.
Quoted 4 lines
Remove this driver, as there is no way to run Linux any more on the older chips after i486 support has been removed.
Signed-off-by Arnd Bergmann <[email protected]>
[Severity: Low]
Since the entire platform and driver support is being removed, should we also clean up the remaining dead references to the RDC321x platform?
Specifically, the reboot fixup code in arch/x86/kernel/reboot_fixups_32.c has a rdc321x_reset() function and an associated entry in fixups_table that appear to be left behind now that the hardware is no longer supported.
Additionally, the PCI_DEVICE_ID_RDC_R6030 definition in include/linux/pci_ids.h is no longer used by any active driver.
Finally, there is a stale "RDC R-321X SoC" entry in MAINTAINERS that might need to be removed to complete the cleanup.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
Re: [PATCH 02/14] mfd: remove unused rdc321x southbridge support
Quoted 9 lines · On Wed, Sep 9, 2026, at 15:39, [email protected] wrote:
Quoted 4 lines
Remove this driver, as there is no way to run Linux any more on the older chips after i486 support has been removed.
Signed-off-by Arnd Bergmann <[email protected]>[Severity: Low]
Since the entire platform and driver support is being removed, should we also clean up the remaining dead references to the RDC321x platform?
Quoted 6 lines
Specifically, the reboot fixup code in
arch/x86/kernel/reboot_fixups_32.chas ardc321x_reset()function and an associated entry infixups_tablethat appear to be left behind now that the hardware is no longer supported.Additionally, the
PCI_DEVICE_ID_RDC_R6030definition ininclude/linux/pci_ids.his no longer used by any active driver.
This sounds like something that should go through the x86 tree, but probably not this patch.
Quoted 2 lines
Finally, there is a stale "RDC R-321X SoC" entry in
MAINTAINERSthat might need to be removed to complete the cleanup.
Removed this now, and added Florian to Cc here and in the changelog.
Arnd
Re: [PATCH 02/14] mfd: remove unused rdc321x southbridge support
In reply to Arnd BergmannQuoted 11 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The rdc321x was a 486-class SoC developed by RDC. While RDC's later products closely resemble the DM&P Vortex86 product line and are still sold under both names, I checked the datasheets for those and found that the GPIO and WDT blocks on them are incompatible with the rtc321x.
Remove this driver, as there is no way to run Linux any more on the older chips after i486 support has been removed.
Signed-off-by Arnd Bergmann <[email protected]>
Re: [PATCH 02/14] mfd: remove unused rdc321x southbridge support
In reply to Arnd BergmannQuoted 11 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The rdc321x was a 486-class SoC developed by RDC. While RDC's later products closely resemble the DM&P Vortex86 product line and are still sold under both names, I checked the datasheets for those and found that the GPIO and WDT blocks on them are incompatible with the rtc321x.
Remove this driver, as there is no way to run Linux any more on the older chips after i486 support has been removed.
Signed-off-by Arnd Bergmann <[email protected]>
Yours,
Linus Walleij
PATCH 3/14 mfd: remove unused si476x driver
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
The si476x driver was added in linux-3.9 without devicetree support, and has always failed the probe function in the absence of a si476x_platform_data definition.
--- .../admin-guide/media/radio-cardlist.rst | 1 - Documentation/admin-guide/media/si476x.rst | 160 -- .../admin-guide/media/v4l-drivers.rst | 1 - drivers/media/radio/Kconfig | 17 - drivers/media/radio/Makefile | 1 - drivers/media/radio/radio-si476x.c | 1523 ---------------- drivers/mfd/Kconfig | 13 - drivers/mfd/Makefile | 3 - drivers/mfd/si476x-cmd.c | 1543 ----------------- drivers/mfd/si476x-i2c.c | 861 --------- drivers/mfd/si476x-prop.c | 233 --- include/linux/mfd/si476x-core.h | 532 ------ include/linux/mfd/si476x-platform.h | 256 --- include/linux/mfd/si476x-reports.h | 154 -- include/media/drv-intf/si476x.h | 28 - include/uapi/linux/v4l2-controls.h | 4 +- sound/soc/codecs/Kconfig | 5 - sound/soc/codecs/Makefile | 2 - sound/soc/codecs/si476x.c | 263 --- sound/soc/fsl/fsl-asoc-card.c | 8 - 20 files changed, 2 insertions(+), 5606 deletions(-) delete mode 100644 Documentation/admin-guide/media/si476x.rst delete mode 100644 drivers/media/radio/radio-si476x.c delete mode 100644 drivers/mfd/si476x-cmd.c delete mode 100644 drivers/mfd/si476x-i2c.c delete mode 100644 drivers/mfd/si476x-prop.c delete mode 100644 include/linux/mfd/si476x-core.h delete mode 100644 include/linux/mfd/si476x-platform.h delete mode 100644 include/linux/mfd/si476x-reports.h delete mode 100644 include/media/drv-intf/si476x.h delete mode 100644 sound/soc/codecs/si476x.c
Documentation/admin-guide/media/radio-cardlist.rst +0 -1
@@ -23,7 +23,6 @@ radio-sf16fmr2 SF16-FMR2/SF16-FMD2 Radio radio-shark Griffin radioSHARK USB radio receiver shark2 Griffin radioSHARK2 USB radio receiver radio-si470x-common Silicon Labs Si470x FM Radio Receiver -radio-si476x Silicon Laboratories Si476x I2C FM Radio radio-tea5764 TEA5764 I2C FM radio tef6862 TEF6862 Car Radio Enhanced Selectivity Tuner radio-terratec TerraTec ActiveRadio ISA Standalone
Documentation/admin-guide/media/si476x.rst deleted +0 -160
160 lines not on this page · raw message
Documentation/admin-guide/media/v4l-drivers.rst +0 -1
@@ -33,7 +33,6 @@ Video4Linux (V4L) driver-specific documentation saa7134 si470x si4713 - si476x vimc visl vivid
drivers/media/radio/Kconfig +0 -17
@@ -79,23 +79,6 @@ config RADIO_SHARK2 config RADIO_SI4713 tristate "Silicon Labs Si4713 FM Radio with RDS Transmitter support" -config RADIO_SI476X - tristate "Silicon Laboratories Si476x I2C FM Radio" - depends on I2C - depends on MFD_SI476X_CORE - depends on SND_SOC - select SND_SOC_SI476X - help - Choose Y here if you have this FM radio chip. - - In order to control your radio card, you will need to use programs - that are compatible with the Video For Linux 2 API. Information on - this API and pointers to "v4l2" programs may be found at - <file:Documentation/userspace-api/media/index.rst>. - - To compile this driver as a module, choose M here: the - module will be called radio-si476x. - config RADIO_TEA575X tristate
drivers/media/radio/Makefile +0 -1
@@ -22,7 +22,6 @@ obj-$(CONFIG_RADIO_SHARK2) += shark2.o obj-$(CONFIG_RADIO_SHARK) += radio-shark.o obj-$(CONFIG_RADIO_SI470X) += si470x/ obj-$(CONFIG_RADIO_SI4713) += si4713/ -obj-$(CONFIG_RADIO_SI476X) += radio-si476x.o obj-$(CONFIG_RADIO_TEA575X) += tea575x.o obj-$(CONFIG_RADIO_TEA5764) += radio-tea5764.o obj-$(CONFIG_RADIO_TEF6862) += tef6862.o
drivers/media/radio/radio-si476x.c deleted +0 -1523
1,523 lines not on this page · raw message
drivers/mfd/Kconfig +0 -13
@@ -1425,19 +1425,6 @@ config MFD_SEC_I2C on this driver so building this as a module might require proper initial ramdisk or might not boot up as well in certain scenarios. -config MFD_SI476X_CORE - tristate "Silicon Laboratories 4761/64/68 AM/FM radio." - depends on I2C - select MFD_CORE - select REGMAP_I2C - help - This is the core driver for the SI476x series of AM/FM - radio. This MFD driver connects the radio-si476x V4L2 module - and the si476x audio codec. - - To compile this driver as a module, choose M here: the - module will be called si476x-core. - config MFD_SIMPLE_MFD_I2C tristate depends on I2C
drivers/mfd/Makefile +0 -3
@@ -204,9 +204,6 @@ obj-$(CONFIG_MFD_JANZ_CMODIO) += janz-cmodio.o obj-$(CONFIG_MFD_TPS6586X) += tps6586x.o obj-$(CONFIG_MFD_VX855) += vx855.o -si476x-core-y := si476x-cmd.o si476x-prop.o si476x-i2c.o -obj-$(CONFIG_MFD_SI476X_CORE) += si476x-core.o - obj-$(CONFIG_MFD_CS5535) += cs5535-mfd.o obj-$(CONFIG_MFD_OMAP_USB_HOST) += omap-usb-host.o omap-usb-tll.o obj-$(CONFIG_MFD_PM8XXX) += qcom-pm8xxx.o ssbi.o
drivers/mfd/si476x-cmd.c deleted +0 -1543
1,245 lines not on this page · raw message
drivers/mfd/si476x-i2c.c deleted +0 -861
861 lines not on this page · raw message
drivers/mfd/si476x-prop.c deleted +0 -233
233 lines not on this page · raw message
include/linux/mfd/si476x-core.h deleted +0 -532
532 lines not on this page · raw message
include/linux/mfd/si476x-platform.h deleted +0 -256
256 lines not on this page · raw message
include/linux/mfd/si476x-reports.h deleted +0 -154
154 lines not on this page · raw message
include/media/drv-intf/si476x.h deleted +0 -28
Lines of this file are not shown. View the raw message.
sound/soc/codecs/si476x.c deleted +0 -263
263 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.53.0
Part of the diff is not shown here. View the raw message.
[email protected]
AI reviewRe: [PATCH 03/14] mfd: remove unused si476x driver
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The device tree binding 'fsl,imx-audio-si476x' is left orphaned in the fsl-asoc-card.yaml binding…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree binding 'fsl,imx-audio-si476x' is left orphaned in the fsl-asoc-card.yaml binding document. --
commit d07c2cc9eb18a826ae9829a06854385c1084b44d
Author: Arnd Bergmann <[email protected]>
mfd: remove unused si476x driver
This commit removes the unused si476x driver, which was originally added without devicetree support. It drops the MFD core, radio, and ASoC codec drivers, along with cleaning up the corresponding build rules and the fsl-asoc-card matching table.
Quoted 4 lines
sound/soc/fsl/fsl-asoc-card.c +0
-0
[ ... ]
sound/soc/fsl/fsl-asoc-card.c static const struct of_device_id fsl_asoc_card_dt_ids[] = { · line 1396
Quoted 8 lines
sound/soc/fsl/fsl-asoc-card.c +0
-1@@ -1398,7 +1391,6 @@ static const struct of_device_id fsl_asoc_card_dt_ids[] = { { .compatible = "fsl,imx-audio-wm8960", .data = &fsl_asoc_wm8960_pdata }, { .compatible = "fsl,imx-audio-mqs", .data = &fsl_asoc_mqs_pdata }, { .compatible = "fsl,imx-audio-wm8524", .data = &fsl_asoc_wm8524_pdata }, - { .compatible = "fsl,imx-audio-si476x", .data = &fsl_asoc_si476x_pdata }, { .compatible = "fsl,imx-audio-wm8958", .data = &fsl_asoc_wm8958_pdata }, { .compatible = "fsl,imx-audio-nau8822", .data = &fsl_asoc_nau8822_pdata }, { .compatible = "fsl,imx-audio-wm8904", .data = &fsl_asoc_wm8904_pdata },
[Severity: Low]
Since this patch removes the fsl,imx-audio-si476x compatible string from the fsl_asoc_card_dt_ids matching table, should the devicetree bindings documentation in Documentation/devicetree/bindings/sound/fsl-asoc-card.yaml also be updated to remove the orphaned fsl,imx-audio-si476x entry?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
Re: [PATCH 03/14] mfd: remove unused si476x driver
In reply to Arnd BergmannQuoted 7 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The si476x driver was added in linux-3.9 without devicetree support, and has always failed the probe function in the absence of a
si476x_platform_datadefinition.Signed-off-by Arnd Bergmann <[email protected]>
Yours,
Linus Walleij
Re: [PATCH 03/14] mfd: remove unused si476x driver
In reply to Arnd BergmannQuoted 7 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The si476x driver was added in linux-3.9 without devicetree support, and has always failed the probe function in the absence of a
si476x_platform_datadefinition.Signed-off-by Arnd Bergmann <[email protected]>
For drivers/media/radio, include/media/drv-intf/si476x.h, Documentation/admin-guide/media and include/uapi/linux/v4l2-controls.h:
Regards,
Hans
Quoted 33 lines
--- .../admin-guide/media/radio-cardlist.rst | 1 - Documentation/admin-guide/media/si476x.rst | 160 -- .../admin-guide/media/v4l-drivers.rst | 1 - drivers/media/radio/Kconfig | 17 - drivers/media/radio/Makefile | 1 - drivers/media/radio/radio-si476x.c | 1523 ---------------- drivers/mfd/Kconfig | 13 - drivers/mfd/Makefile | 3 - drivers/mfd/si476x-cmd.c | 1543 ----------------- drivers/mfd/si476x-i2c.c | 861 --------- drivers/mfd/si476x-prop.c | 233 --- include/linux/mfd/si476x-core.h | 532 ------ include/linux/mfd/si476x-platform.h | 256 --- include/linux/mfd/si476x-reports.h | 154 -- include/media/drv-intf/si476x.h | 28 - include/uapi/linux/v4l2-controls.h | 4 +- sound/soc/codecs/Kconfig | 5 - sound/soc/codecs/Makefile | 2 - sound/soc/codecs/si476x.c | 263 --- sound/soc/fsl/fsl-asoc-card.c | 8 - 20 files changed, 2 insertions(+), 5606 deletions(-) delete mode 100644 Documentation/admin-guide/media/si476x.rst delete mode 100644 drivers/media/radio/radio-si476x.c delete mode 100644 drivers/mfd/si476x-cmd.c delete mode 100644 drivers/mfd/si476x-i2c.c delete mode 100644 drivers/mfd/si476x-prop.c delete mode 100644 include/linux/mfd/si476x-core.h delete mode 100644 include/linux/mfd/si476x-platform.h delete mode 100644 include/linux/mfd/si476x-reports.h delete mode 100644 include/media/drv-intf/si476x.h delete mode 100644 sound/soc/codecs/si476x.c
PATCH 4/14 mfd: remove unused wm8400 driver
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
This driver requires a platform_data definition, which does not exist in the kernel.
According to Mark Brown, the hardware supported by this driver was never shipped in production.
Since this is clearly unused, remove it.
--- MAINTAINERS | 1 - drivers/mfd/Kconfig | 11 - drivers/mfd/Makefile | 1 - drivers/mfd/wm8400-core.c | 163 ---- drivers/regulator/Kconfig | 7 - drivers/regulator/Makefile | 1 - drivers/regulator/wm8400-regulator.c | 276 ------ include/linux/mfd/wm8400-audio.h | 1174 ---------------------- include/linux/mfd/wm8400-private.h | 913 ----------------- include/linux/mfd/wm8400.h | 27 - sound/soc/codecs/Kconfig | 6 - sound/soc/codecs/Makefile | 2 - sound/soc/codecs/wm8400.c | 1348 -------------------------- sound/soc/codecs/wm8400.h | 54 -- 14 files changed, 3984 deletions(-) delete mode 100644 drivers/mfd/wm8400-core.c delete mode 100644 drivers/regulator/wm8400-regulator.c delete mode 100644 include/linux/mfd/wm8400-audio.h delete mode 100644 include/linux/mfd/wm8400-private.h delete mode 100644 include/linux/mfd/wm8400.h delete mode 100644 sound/soc/codecs/wm8400.c delete mode 100644 sound/soc/codecs/wm8400.h
MAINTAINERS +0 -1
@@ -29398,7 +29398,6 @@ F: drivers/watchdog/wm83*_wdt.c F: include/linux/mfd/arizona/ F: include/linux/mfd/wm831x/ F: include/linux/mfd/wm8350/ -F: include/linux/mfd/wm8400* F: include/linux/regulator/arizona* F: include/linux/wm97xx.h F: include/sound/wm????.h
drivers/mfd/Kconfig +0 -11
@@ -2068,17 +2068,6 @@ config MFD_WM8998 help Support for Wolfson Microelectronics WM8998 low power audio SoC -config MFD_WM8400 - bool "Wolfson Microelectronics WM8400" - select MFD_CORE - depends on I2C=y - select REGMAP_I2C - help - Support for the Wolfson Microelecronics WM8400 PMIC and audio - CODEC. This driver provides common support for accessing - the device, additional drivers must be enabled in order to use - the functionality of the device. - config MFD_WM831X bool
drivers/mfd/Makefile +0 -1
@@ -55,7 +55,6 @@ ifeq ($(CONFIG_MFD_CS47L24),y) arizona-objs += cs47l24-tables.o endif obj-$(CONFIG_MFD_WCD934X) += wcd934x.o -obj-$(CONFIG_MFD_WM8400) += wm8400-core.o wm831x-objs := wm831x-core.o wm831x-irq.o wm831x-otp.o wm831x-objs += wm831x-auxadc.o obj-$(CONFIG_MFD_WM831X) += wm831x.o
drivers/mfd/wm8400-core.c deleted +0 -163
163 lines not on this page · raw message
drivers/regulator/Kconfig +0 -7
@@ -1862,13 +1862,6 @@ config REGULATOR_WM8350 This driver provides support for the voltage and current regulators of the WM8350 AudioPlus PMIC. -config REGULATOR_WM8400 - tristate "Wolfson Microelectronics WM8400 AudioPlus PMIC" - depends on MFD_WM8400 - help - This driver provides support for the voltage regulators of the - WM8400 AudioPlus PMIC. - config REGULATOR_WM8994 tristate "Wolfson Microelectronics WM8994 CODEC" depends on MFD_WM8994
drivers/regulator/Makefile +0 -1
@@ -215,7 +215,6 @@ obj-$(CONFIG_REGULATOR_WM831X) += wm831x-dcdc.o obj-$(CONFIG_REGULATOR_WM831X) += wm831x-isink.o obj-$(CONFIG_REGULATOR_WM831X) += wm831x-ldo.o obj-$(CONFIG_REGULATOR_WM8350) += wm8350-regulator.o -obj-$(CONFIG_REGULATOR_WM8400) += wm8400-regulator.o obj-$(CONFIG_REGULATOR_WM8994) += wm8994-regulator.o ccflags-$(CONFIG_REGULATOR_DEBUG) += -DDEBUG
drivers/regulator/wm8400-regulator.c deleted +0 -276
276 lines not on this page · raw message
include/linux/mfd/wm8400-audio.h deleted +0 -1174
1,174 lines not on this page · raw message
include/linux/mfd/wm8400-private.h deleted +0 -913
913 lines not on this page · raw message
include/linux/mfd/wm8400.h deleted +0 -27
@@ -1,27 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ -/* -* wm8400 client interface -* -* Copyright 2008 Wolfson Microelectronics plc -*/ - -#ifndef __LINUX_MFD_WM8400_H -#define __LINUX_MFD_WM8400_H - -#include <linux/regulator/machine.h> - -#define WM8400_LDO1 0 -#define WM8400_LDO2 1 -#define WM8400_LDO3 2 -#define WM8400_LDO4 3 -#define WM8400_DCDC1 4 -#define WM8400_DCDC2 5 - -struct wm8400_platform_data { -int (*platform_init)(struct device *dev); -}; - -int wm8400_register_regulator (struct device *dev,int reg, -struct regulator_init_data *initdata); - -#endif
sound/soc/codecs/Kconfig +0 -6
@@ -318,7 +318,6 @@ config SND_SOC_ALL_CODECS imply SND_SOC_WM5102 imply SND_SOC_WM5110 imply SND_SOC_WM8350 - imply SND_SOC_WM8400 imply SND_SOC_WM8510 imply SND_SOC_WM8523 imply SND_SOC_WM8524
@@ -2556,11 +2555,6 @@ config SND_SOC_WM8350 tristate depends on MFD_WM8350 -config SND_SOC_WM8400 - tristate - # FIXME nothing selects SND_SOC_WM8400?? - depends on MFD_WM8400 - config SND_SOC_WM8510 tristate "Wolfson Microelectronics WM8510 CODEC" depends on SND_SOC_I2C_AND_SPI
sound/soc/codecs/Makefile +0 -2
@@ -375,7 +375,6 @@ snd-soc-wm5100-y := wm5100.o wm5100-tables.o snd-soc-wm5102-y := wm5102.o snd-soc-wm5110-y := wm5110.o snd-soc-wm8350-y := wm8350.o -snd-soc-wm8400-y := wm8400.o snd-soc-wm8510-y := wm8510.o snd-soc-wm8523-y := wm8523.o snd-soc-wm8524-y := wm8524.o
@@ -825,7 +824,6 @@ obj-$(CONFIG_SND_SOC_WM5100) += snd-soc-wm5100.o obj-$(CONFIG_SND_SOC_WM5102) += snd-soc-wm5102.o obj-$(CONFIG_SND_SOC_WM5110) += snd-soc-wm5110.o obj-$(CONFIG_SND_SOC_WM8350) += snd-soc-wm8350.o -obj-$(CONFIG_SND_SOC_WM8400) += snd-soc-wm8400.o obj-$(CONFIG_SND_SOC_WM8510) += snd-soc-wm8510.o obj-$(CONFIG_SND_SOC_WM8523) += snd-soc-wm8523.o obj-$(CONFIG_SND_SOC_WM8524) += snd-soc-wm8524.o
sound/soc/codecs/wm8400.c deleted +0 -1348
364 lines not on this page · raw message
sound/soc/codecs/wm8400.h deleted +0 -54
54 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.53.0
Part of the diff is not shown here. View the raw message.
Re: [PATCH 04/14] mfd: remove unused wm8400 driver
Quoted 7 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This driver requires a
platform_datadefinition, which does not exist in the kernel.According to Mark Brown, the hardware supported by this driver was never shipped in production.
[email protected]
AI reviewRe: [PATCH 04/14] mfd: remove unused wm8400 driver
In reply to Arnd BergmannSashiko has reviewed this patch and found no issues. It looks great!
Quoted 11 lines
From: Arnd Bergmann <[email protected]>
This driver requires a
platform_datadefinition, which does not exist in the kernel.According to Mark Brown, the hardware supported by this driver was never shipped in production.
Since this is clearly unused, remove it.
Signed-off-by Arnd Bergmann <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4
Re: [PATCH 04/14] mfd: remove unused wm8400 driver
In reply to Arnd BergmannQuoted 5 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This driver requires a
platform_datadefinition, which does not exist in the kernel.
Quoted 7 lines
According to Mark Brown, the hardware supported by this driver was never shipped in production.
Since this is clearly unused, remove it.
Signed-off-by Arnd Bergmann <[email protected]>---
Thanks,
Charles
Re: [PATCH 04/14] mfd: remove unused wm8400 driver
In reply to Arnd BergmannQuoted 11 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This driver requires a
platform_datadefinition, which does not exist in the kernel.According to Mark Brown, the hardware supported by this driver was never shipped in production.
Since this is clearly unused, remove it.
Signed-off-by Arnd Bergmann <[email protected]>
Yours,
Linus Walleij
PATCH 5/14 mfd: remove unused adp5520 driver
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
This driver requires the use of platform_data definitions rather than devicetree, but that was last used on the blackfin architecture in 2018 and nothing could have used it upstream since.
--- .../ABI/testing/sysfs-class-backlight | 11 - MAINTAINERS | 11 - drivers/gpio/Kconfig | 7 - drivers/gpio/Makefile | 1 - drivers/gpio/gpio-adp5520.c | 169 -------- drivers/input/keyboard/Kconfig | 10 - drivers/input/keyboard/Makefile | 1 - drivers/input/keyboard/adp5520-keys.c | 191 --------- drivers/leds/Kconfig | 11 - drivers/leds/Makefile | 1 - drivers/leds/leds-adp5520.c | 195 --------- drivers/mfd/Kconfig | 10 - drivers/mfd/Makefile | 1 - drivers/mfd/adp5520.c | 346 ---------------- drivers/video/backlight/Kconfig | 10 - drivers/video/backlight/Makefile | 1 - drivers/video/backlight/adp5520_bl.c | 385 ------------------ include/linux/mfd/adp5520.h | 298 -------------- 18 files changed, 1659 deletions(-) delete mode 100644 drivers/gpio/gpio-adp5520.c delete mode 100644 drivers/input/keyboard/adp5520-keys.c delete mode 100644 drivers/leds/leds-adp5520.c delete mode 100644 drivers/mfd/adp5520.c delete mode 100644 drivers/video/backlight/adp5520_bl.c delete mode 100644 include/linux/mfd/adp5520.h
Documentation/ABI/testing/sysfs-class-backlight +0 -11
@@ -97,17 +97,6 @@ Description: The <ambient light zone> is device-driver specific: - For ADP5520 and ADP5501, <ambient light zone> can be: - - =========== ================================================ - Ambient sysfs entry - light zone - =========== ================================================ - daylight /sys/class/backlight/<backlight>/daylight_max - office /sys/class/backlight/<backlight>/office_max - dark /sys/class/backlight/<backlight>/dark_max - =========== ================================================ - For ADP8860, <ambient light zone> can be: =========== ================================================
MAINTAINERS +0 -11
@@ -550,17 +550,6 @@ F: Documentation/devicetree/bindings/media/i2c/adi,adp1653.txt F: drivers/media/i2c/adp1653.c F: include/media/i2c/adp1653.h -ADP5520 BACKLIGHT DRIVER WITH IO EXPANDER (ADP5520/ADP5501) -M: Michael Hennerich <[email protected]> -S: Supported -W: http://wiki.analog.com/ADP5520 -W: https://ez.analog.com/linux-software-drivers -F: drivers/gpio/gpio-adp5520.c -F: drivers/input/keyboard/adp5520-keys.c -F: drivers/leds/leds-adp5520.c -F: drivers/mfd/adp5520.c -F: drivers/video/backlight/adp5520_bl.c - ADP5585 GPIO EXPANDER, PWM AND KEYPAD CONTROLLER DRIVER M: Laurent Pinchart <[email protected]> L: [email protected]
drivers/gpio/Kconfig +0 -7
@@ -1325,13 +1325,6 @@ endmenu menu "MFD GPIO expanders" -config GPIO_ADP5520 - tristate "GPIO Support for ADP5520 PMIC" - depends on PMIC_ADP5520 - help - This option enables support for on-chip GPIO found - on Analog Devices ADP5520 PMICs. - config GPIO_ADP5585 tristate "GPIO Support for ADP5585" depends on MFD_ADP5585
drivers/gpio/Makefile +0 -1
@@ -28,7 +28,6 @@ obj-$(CONFIG_GPIO_104_IDIO_16) += gpio-104-idio-16.o obj-$(CONFIG_GPIO_74X164) += gpio-74x164.o obj-$(CONFIG_GPIO_74XX_MMIO) += gpio-74xx-mmio.o obj-$(CONFIG_GPIO_ADNP) += gpio-adnp.o -obj-$(CONFIG_GPIO_ADP5520) += gpio-adp5520.o obj-$(CONFIG_GPIO_ADP5585) += gpio-adp5585.o obj-$(CONFIG_GPIO_AGGREGATOR) += gpio-aggregator.o obj-$(CONFIG_GPIO_ALTERA_A10SR) += gpio-altera-a10sr.o
drivers/gpio/gpio-adp5520.c deleted +0 -169
169 lines not on this page · raw message
drivers/input/keyboard/Kconfig +0 -10
@@ -27,16 +27,6 @@ config KEYBOARD_ADC To compile this driver as a module, choose M here: the module will be called adc_keys. -config KEYBOARD_ADP5520 - tristate "Keypad Support for ADP5520 PMIC" - depends on PMIC_ADP5520 - help - This option enables support for the keypad scan matrix - on Analog Devices ADP5520 PMICs. - - To compile this driver as a module, choose M here: the module will - be called adp5520-keys. - config KEYBOARD_ADP5585 tristate "ADP558x keypad support" depends on MFD_ADP5585
drivers/input/keyboard/Makefile +0 -1
@@ -6,7 +6,6 @@ # Each configuration option enables a list of files. obj-$(CONFIG_KEYBOARD_ADC) += adc-keys.o -obj-$(CONFIG_KEYBOARD_ADP5520) += adp5520-keys.o obj-$(CONFIG_KEYBOARD_ADP5585) += adp5585-keys.o obj-$(CONFIG_KEYBOARD_ADP5588) += adp5588-keys.o obj-$(CONFIG_KEYBOARD_AMIGA) += amikbd.o
drivers/input/keyboard/adp5520-keys.c deleted +0 -191
191 lines not on this page · raw message
drivers/leds/Kconfig +0 -11
@@ -718,17 +718,6 @@ config LEDS_LT3593 LT3593 controller. This controller uses a special one-wire pulse coding protocol to set the brightness. -config LEDS_ADP5520 - tristate "LED Support for ADP5520/ADP5501 PMIC" - depends on LEDS_CLASS - depends on PMIC_ADP5520 - help - This option enables support for on-chip LED drivers found - on Analog Devices ADP5520/ADP5501 PMICs. - - To compile this driver as a module, choose M here: the module will - be called leds-adp5520. - config LEDS_MAX5970 tristate "LED Support for Maxim 5970" depends on LEDS_CLASS
drivers/leds/Makefile +0 -1
@@ -11,7 +11,6 @@ obj-$(CONFIG_LEDS_KUNIT_TEST) += led-test.o # LED Platform Drivers (keep this sorted, M-| sort) obj-$(CONFIG_LEDS_88PM860X) += leds-88pm860x.o obj-$(CONFIG_LEDS_ACER_A500) += leds-acer-a500.o -obj-$(CONFIG_LEDS_ADP5520) += leds-adp5520.o obj-$(CONFIG_LEDS_AN30259A) += leds-an30259a.o obj-$(CONFIG_LEDS_APU) += leds-apu.o obj-$(CONFIG_LEDS_ARIEL) += leds-ariel.o
drivers/leds/leds-adp5520.c deleted +0 -195
195 lines not on this page · raw message
drivers/mfd/Kconfig +0 -10
@@ -115,16 +115,6 @@ config MFD_AS3722 controllers, 11 LDOs, RTC, automatic battery, temperature and over current monitoring, GPIOs, ADC and a watchdog. -config PMIC_ADP5520 - bool "Analog Devices ADP5520/01 MFD PMIC Core Support" - depends on I2C=y - help - Say yes here to add support for Analog Devices ADP5520 and ADP5501, - Multifunction Power Management IC. This includes - the I2C driver and the core APIs _only_, you have to select - individual components like LCD backlight, LEDs, GPIOs and Kepad - under the corresponding menus. - config MFD_AAT2870_CORE bool "AnalogicTech AAT2870" select MFD_CORE
drivers/mfd/Makefile +0 -1
@@ -193,7 +193,6 @@ obj-$(CONFIG_MFD_DB8500_PRCMU) += db8500-prcmu.o # ab8500-core need to come after db8500-prcmu (which provides the channel) obj-$(CONFIG_AB8500_CORE) += ab8500-core.o ab8500-sysctrl.o obj-$(CONFIG_MFD_TIMBERDALE) += timberdale.o -obj-$(CONFIG_PMIC_ADP5520) += adp5520.o obj-$(CONFIG_MFD_ADP5585) += adp5585.o obj-$(CONFIG_MFD_KEMPLD) += kempld-core.o obj-$(CONFIG_MFD_INTEL_QUARK_I2C_GPIO) += intel_quark_i2c_gpio.o
drivers/mfd/adp5520.c deleted +0 -346
346 lines not on this page · raw message
drivers/video/backlight/Kconfig +0 -10
@@ -365,16 +365,6 @@ config BACKLIGHT_WM831X If you have a backlight driven by the ISINK and DCDC of a WM831x PMIC say y to enable the backlight driver for it. -config BACKLIGHT_ADP5520 - tristate "Backlight Driver for ADP5520/ADP5501 using WLED" - depends on PMIC_ADP5520 - help - If you have a LCD backlight connected to the BST/BL_SNK output of - ADP5520 or ADP5501, say Y here to enable this driver. - - To compile this driver as a module, choose M here: the module will - be called adp5520_bl. - config BACKLIGHT_ADP8860 tristate "Backlight Driver for ADP8860/ADP8861/ADP8863 using WLED" depends on I2C
drivers/video/backlight/Makefile +0 -1
@@ -19,7 +19,6 @@ obj-$(CONFIG_LCD_VGG2432A4) += vgg2432a4.o obj-$(CONFIG_BACKLIGHT_88PM860X) += 88pm860x_bl.o obj-$(CONFIG_BACKLIGHT_AAT2870) += aat2870_bl.o -obj-$(CONFIG_BACKLIGHT_ADP5520) += adp5520_bl.o obj-$(CONFIG_BACKLIGHT_ADP8860) += adp8860_bl.o obj-$(CONFIG_BACKLIGHT_ADP8870) += adp8870_bl.o obj-$(CONFIG_BACKLIGHT_APPLE) += apple_bl.o
drivers/video/backlight/adp5520_bl.c deleted +0 -385
385 lines not on this page · raw message
include/linux/mfd/adp5520.h deleted +0 -298
298 lines not on this page · raw message
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH 05/14] mfd: remove unused adp5520 driver
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Incomplete documentation cleanup: left over `_dim` attribute sysfs documentation for the removed…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete documentation cleanup: left over _dim attribute sysfs documentation for the removed ADP5520 driver. --
commit bc7ed836cc23ed6cd96fb2b01eb1e87798e6abff
Author: Arnd Bergmann <[email protected]>
mfd: remove unused adp5520 driver
This driver requires the use of platform_data definitions rather than devicetree, but that was last used on the blackfin architecture in 2018 and nothing could have used it upstream since.
Quoted 12 lines
Documentation/ABI/testing/sysfs-class-backlight +0
-4@@ -97,17 +97,6 @@ Description: The <ambient light zone> is device-driver specific: - For ADP5520 and ADP5501, <ambient light zone> can be: - - =========== ================================================ - Ambient sysfs entry
Documentation/ABI/testing/sysfs-class-backlight Description: · line 102
Quoted 10 lines
Documentation/ABI/testing/sysfs-class-backlight +0
-7- light zone - =========== ================================================ - daylight /sys/class/backlight/<backlight>/daylight_max - office /sys/class/backlight/<backlight>/office_max - dark /sys/class/backlight/<backlight>/dark_max - =========== ================================================ - For ADP8860, <ambient light zone> can be: =========== ================================================
[Severity: Low]
Should the corresponding block for the _dim attributes also be removed?
Further down in this file, under the documentation for the _dim attributes, there is another block describing the sysfs nodes for the ADP5520 driver:
For ADP5520 and ADP5501, <ambient light zone> can be: =========== ================================================ Ambient sysfs entry light zone =========== ================================================ daylight /sys/class/backlight/<backlight>/daylight_dim office /sys/class/backlight/<backlight>/office_dim dark /sys/class/backlight/<backlight>/dark_dim =========== ================================================
Leaving this block behind orphans the documentation for hardware that is no longer supported.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=5
Re: [PATCH 05/14] mfd: remove unused adp5520 driver
Quoted 17 lines · On Wed, Sep 9, 2026, at 15:37, [email protected] wrote:
[Severity: Low]
Should the corresponding block for the_dimattributes also be removed?Further down in this file, under the documentation for the
_dimattributes, there is another block describing the sysfs nodes for the ADP5520 driver:For ADP5520 and ADP5501, <ambient light zone> can be: =========== ================================================ Ambient sysfs entry light zone =========== ================================================ daylight /sys/class/backlight/<backlight>/daylight_dim office /sys/class/backlight/<backlight>/office_dim dark /sys/class/backlight/<backlight>/dark_dim =========== ================================================
Quoted 2 lines
Leaving this block behind orphans the documentation for hardware that is no longer supported.
Fixed now.
Arnd
Re: [PATCH 05/14] mfd: remove unused adp5520 driver
In reply to Arnd BergmannQuoted 7 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This driver requires the use of
platform_datadefinitions rather than devicetree, but that was last used on the blackfin architecture in 2018 and nothing could have used it upstream since.Signed-off-by Arnd Bergmann <[email protected]>
Yours,
Linus Walleij
PATCH 6/14 mfd: remove unused da903x driver
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
This driver was used on a handful of ARM/PXA boards until those got removed a few years ago. Without devicetree support, there is no way to use them upstream.
--- MAINTAINERS | 1 - drivers/input/touchscreen/Kconfig | 13 - drivers/input/touchscreen/Makefile | 1 - drivers/input/touchscreen/da9034-ts.c | 365 ---------------- drivers/leds/Kconfig | 8 - drivers/leds/Makefile | 1 - drivers/leds/leds-da903x.c | 145 ------- drivers/mfd/Kconfig | 11 - drivers/mfd/Makefile | 2 - drivers/mfd/da903x.c | 565 ------------------------- drivers/power/supply/Kconfig | 7 - drivers/power/supply/Makefile | 1 - drivers/power/supply/da9030_battery.c | 581 -------------------------- drivers/regulator/Kconfig | 8 - drivers/regulator/Makefile | 1 - drivers/regulator/da903x-regulator.c | 495 ---------------------- drivers/video/backlight/Kconfig | 7 - drivers/video/backlight/Makefile | 1 - drivers/video/backlight/da903x_bl.c | 160 ------- 19 files changed, 2373 deletions(-) delete mode 100644 drivers/input/touchscreen/da9034-ts.c delete mode 100644 drivers/leds/leds-da903x.c delete mode 100644 drivers/mfd/da903x.c delete mode 100644 drivers/power/supply/da9030_battery.c delete mode 100644 drivers/regulator/da903x-regulator.c delete mode 100644 drivers/video/backlight/da903x_bl.c
MAINTAINERS +0 -1
@@ -7509,7 +7509,6 @@ F: drivers/input/misc/da72??.[ch] F: drivers/input/misc/da90??_onkey.c F: drivers/input/touchscreen/da9052_tsi.c F: drivers/leds/leds-da90??.c -F: drivers/mfd/da903x.c F: drivers/mfd/da90??-*.c F: drivers/mfd/da91??-*.c F: drivers/pinctrl/pinctrl-da90??.c
drivers/input/touchscreen/Kconfig +0 -13
@@ -282,19 +282,6 @@ config TOUCHSCREEN_CYTTSP5 To compile this driver as a module, choose M here: the module will be called cyttsp5. -config TOUCHSCREEN_DA9034 - tristate "Touchscreen support for Dialog Semiconductor DA9034" - depends on PMIC_DA903X - default y - help - Say Y here to enable the support for the touchscreen found - on Dialog Semiconductor DA9034 PMIC. - - If unsure, say N. - - To compile this driver as a module, choose M here: the - module will be called da9034-ts. - config TOUCHSCREEN_DA9052 tristate "Dialog DA9052/DA9053 TSI" depends on PMIC_DA9052
drivers/input/touchscreen/Makefile +0 -1
@@ -29,7 +29,6 @@ obj-$(CONFIG_TOUCHSCREEN_CYTTSP_CORE) += cyttsp_core.o obj-$(CONFIG_TOUCHSCREEN_CYTTSP_I2C) += cyttsp_i2c.o obj-$(CONFIG_TOUCHSCREEN_CYTTSP_SPI) += cyttsp_spi.o obj-$(CONFIG_TOUCHSCREEN_CYTTSP5) += cyttsp5.o -obj-$(CONFIG_TOUCHSCREEN_DA9034) += da9034-ts.o obj-$(CONFIG_TOUCHSCREEN_DA9052) += da9052_tsi.o obj-$(CONFIG_TOUCHSCREEN_DYNAPRO) += dynapro.o obj-$(CONFIG_TOUCHSCREEN_EDT_FT5X06) += edt-ft5x06.o
drivers/input/touchscreen/da9034-ts.c deleted +0 -365
365 lines not on this page · raw message
drivers/leds/Kconfig +0 -8
@@ -638,14 +638,6 @@ config LEDS_WM8350 This option enables support for LEDs driven by the Wolfson Microelectronics WM8350 AudioPlus PMIC. -config LEDS_DA903X - tristate "LED Support for DA9030/DA9034 PMIC" - depends on LEDS_CLASS - depends on PMIC_DA903X - help - This option enables support for on-chip LED drivers found - on Dialog Semiconductor DA9030/DA9034 PMICs. - config LEDS_DA9052 tristate "Dialog DA9052/DA9053 LEDS" depends on LEDS_CLASS
drivers/leds/Makefile +0 -1
@@ -28,7 +28,6 @@ obj-$(CONFIG_LEDS_COBALT_QUBE) += leds-cobalt-qube.o obj-$(CONFIG_LEDS_COBALT_RAQ) += leds-cobalt-raq.o obj-$(CONFIG_LEDS_CPCAP) += leds-cpcap.o obj-$(CONFIG_LEDS_CROS_EC) += leds-cros_ec.o -obj-$(CONFIG_LEDS_DA903X) += leds-da903x.o obj-$(CONFIG_LEDS_DA9052) += leds-da9052.o obj-$(CONFIG_LEDS_GPIO) += leds-gpio.o obj-$(CONFIG_LEDS_GPIO_REGISTER) += leds-gpio-register.o
drivers/leds/leds-da903x.c deleted +0 -145
145 lines not on this page · raw message
drivers/mfd/Kconfig +0 -11
@@ -408,17 +408,6 @@ config MFD_TN48M_CPLD for the SFP slots as well as power supply related information. SFP support depends on the GPIO driver being selected. -config PMIC_DA903X - bool "Dialog Semiconductor DA9030/DA9034 PMIC Support" - depends on I2C=y - help - Say yes here to add support for Dialog Semiconductor DA9030 (a.k.a - ARAVA) and DA9034 (a.k.a MICCO), these are Power Management IC - usually found on PXA processors-based platforms. This includes - the I2C driver and the core APIs _only_, you have to select - individual components like LCD backlight, voltage regulators, - LEDs and battery-charger under the corresponding menus. - config PMIC_DA9052 bool select MFD_CORE
drivers/mfd/Makefile +0 -2
@@ -139,8 +139,6 @@ ifeq ($(CONFIG_SA1100_ASSABET),y) obj-$(CONFIG_MCP_UCB1200) += ucb1x00-assabet.o endif -obj-$(CONFIG_PMIC_DA903X) += da903x.o - obj-$(CONFIG_PMIC_DA9052) += da9052-irq.o obj-$(CONFIG_PMIC_DA9052) += da9052-core.o obj-$(CONFIG_MFD_DA9052_SPI) += da9052-spi.o
drivers/mfd/da903x.c deleted +0 -565
565 lines not on this page · raw message
drivers/power/supply/Kconfig +0 -7
@@ -345,13 +345,6 @@ config BATTERY_BQ27XXX_DT_UPDATES_NVM general-purpose kernels, as this can cause misconfiguration of a smart battery with embedded NVM/flash. -config BATTERY_DA9030 - tristate "DA9030 battery driver" - depends on PMIC_DA903X - help - Say Y here to enable support for batteries charger integrated into - DA9030 PMIC. - config BATTERY_DA9052 tristate "Dialog DA9052 Battery" depends on PMIC_DA9052
drivers/power/supply/Makefile +0 -1
@@ -52,7 +52,6 @@ obj-$(CONFIG_MANAGER_SBS) += sbs-manager.o obj-$(CONFIG_BATTERY_BQ27XXX) += bq27xxx_battery.o obj-$(CONFIG_BATTERY_BQ27XXX_I2C) += bq27xxx_battery_i2c.o obj-$(CONFIG_BATTERY_BQ27XXX_HDQ) += bq27xxx_battery_hdq.o -obj-$(CONFIG_BATTERY_DA9030) += da9030_battery.o obj-$(CONFIG_BATTERY_DA9052) += da9052-battery.o obj-$(CONFIG_CHARGER_DA9150) += da9150-charger.o obj-$(CONFIG_BATTERY_DA9150) += da9150-fg.o
drivers/power/supply/da9030_battery.c deleted +0 -581
581 lines not on this page · raw message
drivers/regulator/Kconfig +0 -8
@@ -312,14 +312,6 @@ config REGULATOR_CROS_EC This driver can also be built as a module. If so, the module will be called cros-ec-regulator. -config REGULATOR_DA903X - tristate "Dialog Semiconductor DA9030/DA9034 regulators" - depends on PMIC_DA903X - depends on !CC_IS_CLANG # https://llvm.org/pr38789 - help - Say y here to support the BUCKs and LDOs regulators found on - Dialog Semiconductor DA9030/DA9034 PMIC. - config REGULATOR_DA9052 tristate "Dialog Semiconductor DA9052/DA9053 regulators" depends on PMIC_DA9052
drivers/regulator/Makefile +0 -1
@@ -38,7 +38,6 @@ obj-$(CONFIG_REGULATOR_BD718XX) += bd718x7-regulator.o obj-$(CONFIG_REGULATOR_BD9571MWV) += bd9571mwv-regulator.o obj-$(CONFIG_REGULATOR_BD957XMUF) += bd9576-regulator.o obj-$(CONFIG_REGULATOR_BQ257XX) += bq257xx-regulator.o -obj-$(CONFIG_REGULATOR_DA903X) += da903x-regulator.o obj-$(CONFIG_REGULATOR_BD96801) += bd96801-regulator.o obj-$(CONFIG_REGULATOR_DA9052) += da9052-regulator.o obj-$(CONFIG_REGULATOR_DA9055) += da9055-regulator.o
drivers/regulator/da903x-regulator.c deleted +0 -495
495 lines not on this page · raw message
drivers/video/backlight/Kconfig +0 -7
@@ -277,13 +277,6 @@ config BACKLIGHT_CGBC backlight subsystem. It communicates with the board controller to adjust LCD backlight using PWM signals. -config BACKLIGHT_DA903X - tristate "Backlight Driver for DA9030/DA9034 using WLED" - depends on PMIC_DA903X - help - If you have a LCD backlight connected to the WLED output of DA9030 - or DA9034 WLED output, say Y here to enable this driver. - config BACKLIGHT_DA9052 tristate "Dialog DA9052/DA9053 WLED" depends on PMIC_DA9052
drivers/video/backlight/Makefile +0 -1
@@ -28,7 +28,6 @@ obj-$(CONFIG_BACKLIGHT_AW99706) += aw99706.o obj-$(CONFIG_BACKLIGHT_BD6107) += bd6107.o obj-$(CONFIG_BACKLIGHT_CGBC) += cgbc_bl.o obj-$(CONFIG_BACKLIGHT_CLASS_DEVICE) += backlight.o -obj-$(CONFIG_BACKLIGHT_DA903X) += da903x_bl.o obj-$(CONFIG_BACKLIGHT_DA9052) += da9052_bl.o obj-$(CONFIG_BACKLIGHT_EP93XX) += ep93xx_bl.o obj-$(CONFIG_BACKLIGHT_GPIO) += gpio_backlight.o
drivers/video/backlight/da903x_bl.c deleted +0 -160
160 lines not on this page · raw message
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH 06/14] mfd: remove unused da903x driver
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Incomplete driver removal leaves behind orphaned header, MAINTAINERS entry, and stale defconfig…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete driver removal leaves behind orphaned header, MAINTAINERS entry, and stale defconfig options. --
commit 5d7f5a2366c42ef6c4fd37de982c54aaa25f59e1
Author: Arnd Bergmann <[email protected]>
mfd: remove unused da903x driver
This driver was used on a handful of ARM/PXA boards until those got removed a few years ago. Without devicetree support, there is no way to use them upstream.
MAINTAINERS F: drivers/input/misc/da72??.[ch] · line 7578
Quoted 10 lines
MAINTAINERS +0
-1@@ -7575,7 +7575,6 @@ F: drivers/input/misc/da72??.[ch] F: drivers/input/misc/da90??_onkey.c F: drivers/input/touchscreen/da9052_tsi.c F: drivers/leds/leds-da90??.c -F: drivers/mfd/da903x.c F: drivers/mfd/da90??-*.c
[Severity: Low]
Does this incomplete removal leave behind the orphaned header file include/linux/mfd/da903x.h? It appears the header is no longer used but was not deleted in this commit.
Additionally, should the MAINTAINERS entry for include/linux/mfd/da903x.h (at line 7590) be removed along with it?
Finally, are there stale defconfig options (CONFIG_PMIC_DA903X=y) left in arch/arm/configs/pxa_defconfig (at line 322) and arch/arm/configs/pxa3xx_defconfig (at line 57) that should be cleaned up as well, to avoid minor kernel configuration warnings when running make defconfig?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6
Re: [PATCH 06/14] mfd: remove unused da903x driver
Quoted 6 lines · On Wed, Sep 9, 2026, at 15:39, [email protected] wrote:
Does this incomplete removal leave behind the orphaned header file
include/linux/mfd/da903x.h? It appears the header is no longer used but was not deleted in this commit.Additionally, should the
MAINTAINERSentry forinclude/linux/mfd/da903x.h(at line 7590) be removed along with it?
Right, fixed both.
Quoted 5 lines
Finally, are there stale defconfig options (
CONFIG_PMIC_DA903X=y) left inarch/arm/configs/pxa_defconfig(at line 322) andarch/arm/configs/pxa3xx_defconfig(at line 57) that should be cleaned up as well, to avoid minor kernel configuration warnings when running make defconfig?
I'm leaving these for a later point, the defconfigs are already very outdated and in need of a refresh.
Arnd
Re: [PATCH 06/14] mfd: remove unused da903x driver
In reply to Arnd BergmannHi,
Quoted 26 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This driver was used on a handful of ARM/PXA boards until those got removed a few years ago. Without devicetree support, there is no way to use them upstream.
Signed-off-by Arnd Bergmann <[email protected]>--- MAINTAINERS | 1 - drivers/input/touchscreen/Kconfig | 13 - drivers/input/touchscreen/Makefile | 1 - drivers/input/touchscreen/da9034-ts.c | 365 ---------------- drivers/leds/Kconfig | 8 - drivers/leds/Makefile | 1 - drivers/leds/leds-da903x.c | 145 ------- drivers/mfd/Kconfig | 11 - drivers/mfd/Makefile | 2 - drivers/mfd/da903x.c | 565 ------------------------- drivers/power/supply/Kconfig | 7 - drivers/power/supply/Makefile | 1 - drivers/power/supply/da9030_battery.c | 581 -------------------------- drivers/regulator/Kconfig | 8 - drivers/regulator/Makefile | 1 - drivers/regulator/da903x-regulator.c | 495 ---------------------- drivers/video/backlight/Kconfig | 7 - drivers/video/backlight/Makefile | 1 -
Quoted 8 lines
drivers/video/backlight/da903x_bl.c | 160 ------- 19 files changed, 2373 deletions(-) delete mode 100644 drivers/input/touchscreen/da9034-ts.c delete mode 100644 drivers/leds/leds-da903x.c delete mode 100644 drivers/mfd/da903x.c delete mode 100644 drivers/power/supply/da9030_battery.c delete mode 100644 drivers/regulator/da903x-regulator.c delete mode 100644 drivers/video/backlight/da903x_bl.c
-- Sebastian
Re: [PATCH 06/14] mfd: remove unused da903x driver
In reply to Arnd BergmannQuoted 7 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This driver was used on a handful of ARM/PXA boards until those got removed a few years ago. Without devicetree support, there is no way to use them upstream.
Signed-off-by Arnd Bergmann <[email protected]>
Yours,
Linus Walleij
PATCH 7/14 mfd: remove unused lp8788 driver
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
This driver was apparently never used upstream, and without devicetree support cannot be used by external board support.
The MAINTAINER entry was already removed in 2021 as the email address bounced.
--- drivers/iio/adc/Kconfig | 9 - drivers/iio/adc/Makefile | 1 - drivers/iio/adc/lp8788_adc.c | 219 -------- drivers/leds/Kconfig | 7 - drivers/leds/Makefile | 1 - drivers/leds/leds-lp8788.c | 171 ------ drivers/mfd/Kconfig | 10 - drivers/mfd/Makefile | 1 - drivers/mfd/lp8788-irq.c | 194 ------- drivers/mfd/lp8788.c | 246 --------- drivers/power/supply/Kconfig | 8 - drivers/power/supply/Makefile | 1 - drivers/power/supply/lp8788-charger.c | 730 -------------------------- drivers/regulator/Kconfig | 6 - drivers/regulator/Makefile | 2 - drivers/regulator/lp8788-buck.c | 541 ------------------- drivers/regulator/lp8788-ldo.c | 640 ---------------------- drivers/rtc/Kconfig | 6 - drivers/rtc/rtc-lp8788.c | 322 ------------ drivers/video/backlight/Kconfig | 6 - drivers/video/backlight/Makefile | 1 - drivers/video/backlight/lp8788_bl.c | 190 ------- include/linux/mfd/lp8788-isink.h | 48 -- include/linux/mfd/lp8788.h | 289 ---------- 24 files changed, 3649 deletions(-) delete mode 100644 drivers/iio/adc/lp8788_adc.c delete mode 100644 drivers/leds/leds-lp8788.c delete mode 100644 drivers/mfd/lp8788-irq.c delete mode 100644 drivers/mfd/lp8788.c delete mode 100644 drivers/power/supply/lp8788-charger.c delete mode 100644 drivers/regulator/lp8788-buck.c delete mode 100644 drivers/regulator/lp8788-ldo.c delete mode 100644 drivers/rtc/rtc-lp8788.c delete mode 100644 drivers/video/backlight/lp8788_bl.c delete mode 100644 include/linux/mfd/lp8788-isink.h delete mode 100644 include/linux/mfd/lp8788.h
drivers/iio/adc/Kconfig +0 -9
@@ -905,15 +905,6 @@ config IMX93_ADC This driver can also be built as a module. If so, the module will be called imx93_adc. -config LP8788_ADC - tristate "LP8788 ADC driver" - depends on MFD_LP8788 - help - Say yes here to build support for TI LP8788 ADC. - - To compile this driver as a module, choose M here: the module will be - called lp8788_adc. - config LPC18XX_ADC tristate "NXP LPC18xx ADC driver" depends on ARCH_LPC18XX || COMPILE_TEST
drivers/iio/adc/Makefile +0 -1
@@ -77,7 +77,6 @@ obj-$(CONFIG_INA2XX_ADC) += ina2xx-adc.o obj-$(CONFIG_INGENIC_ADC) += ingenic-adc.o obj-$(CONFIG_INTEL_DC_TI_ADC) += intel_dc_ti_adc.o obj-$(CONFIG_INTEL_MRFLD_ADC) += intel_mrfld_adc.o -obj-$(CONFIG_LP8788_ADC) += lp8788_adc.o obj-$(CONFIG_LPC18XX_ADC) += lpc18xx_adc.o obj-$(CONFIG_LPC32XX_ADC) += lpc32xx_adc.o obj-$(CONFIG_LTC2309) += ltc2309.o
drivers/iio/adc/lp8788_adc.c deleted +0 -219
219 lines not on this page · raw message
drivers/leds/Kconfig +0 -7
@@ -511,13 +511,6 @@ config LEDS_LP8501 It is similar as LP5523, but output power selection is available. And register layout and engine program schemes are different. -config LEDS_LP8788 - tristate "LED support for the TI LP8788 PMIC" - depends on LEDS_CLASS - depends on MFD_LP8788 - help - This option enables support for the Keyboard LEDs on the LP8788 PMIC. - config LEDS_LP8860 tristate "LED support for the TI LP8860 4 channel LED driver" depends on LEDS_CLASS && I2C && OF
drivers/leds/Makefile +0 -1
@@ -55,7 +55,6 @@ obj-$(CONFIG_LEDS_LP5562) += leds-lp5562.o obj-$(CONFIG_LEDS_LP5569) += leds-lp5569.o obj-$(CONFIG_LEDS_LP55XX_COMMON) += leds-lp55xx-common.o obj-$(CONFIG_LEDS_LP8501) += leds-lp8501.o -obj-$(CONFIG_LEDS_LP8788) += leds-lp8788.o obj-$(CONFIG_LEDS_LP8860) += leds-lp8860.o obj-$(CONFIG_LEDS_LP8864) += leds-lp8864.o obj-$(CONFIG_LEDS_LT3593) += leds-lt3593.o
drivers/leds/leds-lp8788.c deleted +0 -171
171 lines not on this page · raw message
drivers/mfd/Kconfig +0 -10
@@ -1603,16 +1603,6 @@ config MFD_LP3943 With these functionalities, it can be used for LED string control or general usage such like a GPIO controller and a PWM controller. -config MFD_LP8788 - bool "TI LP8788 Power Management Unit Driver" - depends on I2C=y - select MFD_CORE - select REGMAP_I2C - select IRQ_DOMAIN - help - TI LP8788 PMU supports regulators, battery charger, RTC, - ADC, backlight driver and current sinks. - config MFD_TI_LMU tristate "TI Lighting Management Unit driver" depends on I2C
drivers/mfd/Makefile +0 -1
@@ -150,7 +150,6 @@ obj-$(CONFIG_MFD_AXP20X_I2C) += axp20x-i2c.o obj-$(CONFIG_MFD_AXP20X_RSB) += axp20x-rsb.o obj-$(CONFIG_MFD_LP3943) += lp3943.o -obj-$(CONFIG_MFD_LP8788) += lp8788.o lp8788-irq.o obj-$(CONFIG_MFD_TI_LMU) += ti-lmu.o
drivers/mfd/lp8788-irq.c deleted +0 -194
194 lines not on this page · raw message
drivers/mfd/lp8788.c deleted +0 -246
246 lines not on this page · raw message
drivers/power/supply/Kconfig +0 -8
@@ -555,14 +555,6 @@ config CHARGER_LP8727 help Say Y here to enable support for LP8727 Charger Driver. -config CHARGER_LP8788 - tristate "TI LP8788 charger driver" - depends on MFD_LP8788 - depends on LP8788_ADC - depends on IIO - help - Say Y to enable support for the LP8788 linear charger. - config CHARGER_GPIO tristate "GPIO charger" depends on GPIOLIB || COMPILE_TEST
drivers/power/supply/Makefile +0 -1
@@ -76,7 +76,6 @@ obj-$(CONFIG_CHARGER_MAX8903) += max8903_charger.o obj-$(CONFIG_CHARGER_TWL4030) += twl4030_charger.o obj-$(CONFIG_CHARGER_TWL6030) += twl6030_charger.o obj-$(CONFIG_CHARGER_LP8727) += lp8727_charger.o -obj-$(CONFIG_CHARGER_LP8788) += lp8788-charger.o obj-$(CONFIG_CHARGER_GPIO) += gpio-charger.o obj-$(CONFIG_CHARGER_MANAGER) += charger-manager.o obj-$(CONFIG_CHARGER_LT3651) += lt3651-charger.o
drivers/power/supply/lp8788-charger.c deleted +0 -730
730 lines not on this page · raw message
drivers/regulator/Kconfig +0 -6
@@ -555,12 +555,6 @@ config REGULATOR_LP87565 provides four step-down converters. It supports software based voltage control for different voltage domains -config REGULATOR_LP8788 - tristate "TI LP8788 Power Regulators" - depends on MFD_LP8788 - help - This driver supports LP8788 voltage regulator chip. - config REGULATOR_LTC3589 tristate "LTC3589 8-output voltage regulator" depends on I2C
drivers/regulator/Makefile +0 -2
@@ -65,8 +65,6 @@ obj-$(CONFIG_REGULATOR_LP3972) += lp3972.o obj-$(CONFIG_REGULATOR_LP872X) += lp872x.o obj-$(CONFIG_REGULATOR_LP873X) += lp873x-regulator.o obj-$(CONFIG_REGULATOR_LP87565) += lp87565-regulator.o -obj-$(CONFIG_REGULATOR_LP8788) += lp8788-buck.o -obj-$(CONFIG_REGULATOR_LP8788) += lp8788-ldo.o obj-$(CONFIG_REGULATOR_LP8755) += lp8755.o obj-$(CONFIG_REGULATOR_LTC3589) += ltc3589.o obj-$(CONFIG_REGULATOR_LTC3676) += ltc3676.o
drivers/regulator/lp8788-buck.c deleted +0 -541
541 lines not on this page · raw message
drivers/regulator/lp8788-ldo.c deleted +0 -640
640 lines not on this page · raw message
drivers/rtc/Kconfig +0 -6
@@ -317,12 +317,6 @@ config RTC_DRV_HYM8563 This driver can also be built as a module. If so, the module will be called rtc-hym8563. -config RTC_DRV_LP8788 - tristate "TI LP8788 RTC driver" - depends on MFD_LP8788 - help - Say Y to enable support for the LP8788 RTC/ALARM driver. - config RTC_DRV_MAX6900 tristate "Maxim MAX6900" help
drivers/rtc/rtc-lp8788.c deleted +0 -322
141 lines not on this page · raw message
drivers/video/backlight/lp8788_bl.c deleted +0 -190
190 lines not on this page · raw message
include/linux/mfd/lp8788-isink.h deleted +0 -48
48 lines not on this page · raw message
include/linux/mfd/lp8788.h deleted +0 -289
289 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.53.0
Part of the diff is not shown here. View the raw message.
[email protected]
AI reviewRe: [PATCH 07/14] mfd: remove unused lp8788 driver
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Incomplete cleanup: orphaned Makefile entry for `rtc-lp8788.o`. --
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete cleanup: orphaned Makefile entry for rtc-lp8788.o.
--
commit b9b327cd8a968733772283e939af3a5d5a3cf637
Author: Arnd Bergmann <[email protected]>
mfd: remove unused lp8788 driver
This commit removes the unused lp8788 driver and its sub-device drivers across multiple subsystems. The driver lacks devicetree support and has apparently never been used upstream.
Quoted 4 lines
drivers/rtc/Kconfig +0
-0
[ ... ]
drivers/rtc/Kconfig config RTC_DRV_HYM8563 · line 325
Quoted 10 lines
drivers/rtc/Kconfig +0
-6@@ -317,12 +317,6 @@ config RTC_DRV_HYM8563 This driver can also be built as a module. If so, the module will be called rtc-hym8563. -config RTC_DRV_LP8788 - tristate "TI LP8788 RTC driver" - depends on MFD_LP8788 - help - Say Y to enable support for the LP8788 RTC/ALARM driver. -
[Severity: Low]
This patch removes the CONFIG_RTC_DRV_LP8788 symbol here, and also deletes the drivers/rtc/rtc-lp8788.c source file. Should the corresponding build rule in drivers/rtc/Makefile also be removed?
Currently, drivers/rtc/Makefile still contains this entry:
obj-$(CONFIG_RTC_DRV_LP8788) += rtc-lp8788.o
Since the Kconfig symbol is no longer defined, it evaluates to an empty string, leaving a dead configuration line in the build system.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=7
Re: [PATCH 07/14] mfd: remove unused lp8788 driver
Quoted 10 lines · On Wed, Sep 9, 2026, at 15:39, [email protected] wrote:
[Severity: Low]
This patch removes theCONFIG_RTC_DRV_LP8788symbol here, and also deletes thedrivers/rtc/rtc-lp8788.csource file. Should the corresponding build rule indrivers/rtc/Makefilealso be removed?Currently,
drivers/rtc/Makefilestill contains this entry:
obj-$(CONFIG_RTC_DRV_LP8788) += rtc-lp8788.oSince the
Kconfigsymbol is no longer defined, it evaluates to an empty string, leaving a dead configuration line in the build system.
Fixed now, the line accidentally ended up being removed in the wrong patch after a botched rebase.
Arnd
Re: [PATCH 07/14] mfd: remove unused lp8788 driver
In reply to Arnd BergmannQuoted 9 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This driver was apparently never used upstream, and without devicetree support cannot be used by external board support.
The MAINTAINER entry was already removed in 2021 as the email address bounced.
Signed-off-by Arnd Bergmann <[email protected]>
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Re: [PATCH 07/14] mfd: remove unused lp8788 driver
In reply to Arnd BergmannHi,
Quoted 38 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This driver was apparently never used upstream, and without devicetree support cannot be used by external board support.
The MAINTAINER entry was already removed in 2021 as the email address bounced.
Signed-off-by Arnd Bergmann <[email protected]>--- drivers/iio/adc/Kconfig | 9 - drivers/iio/adc/Makefile | 1 - drivers/iio/adc/lp8788_adc.c | 219 -------- drivers/leds/Kconfig | 7 - drivers/leds/Makefile | 1 - drivers/leds/leds-lp8788.c | 171 ------ drivers/mfd/Kconfig | 10 - drivers/mfd/Makefile | 1 - drivers/mfd/lp8788-irq.c | 194 ------- drivers/mfd/lp8788.c | 246 --------- drivers/power/supply/Kconfig | 8 - drivers/power/supply/Makefile | 1 - drivers/power/supply/lp8788-charger.c | 730 -------------------------- drivers/regulator/Kconfig | 6 - drivers/regulator/Makefile | 2 - drivers/regulator/lp8788-buck.c | 541 ------------------- drivers/regulator/lp8788-ldo.c | 640 ---------------------- drivers/rtc/Kconfig | 6 - drivers/rtc/rtc-lp8788.c | 322 ------------ drivers/video/backlight/Kconfig | 6 - drivers/video/backlight/Makefile | 1 - drivers/video/backlight/lp8788_bl.c | 190 ------- include/linux/mfd/lp8788-isink.h | 48 -- include/linux/mfd/lp8788.h | 289 ---------- 24 files changed, 3649 deletions(-) delete mode 100644 drivers/iio/adc/lp8788_adc.c delete mode 100644 drivers/leds/leds-lp8788.c delete mode 100644 drivers/mfd/lp8788-irq.c
Quoted 8 lines
delete mode 100644 drivers/mfd/lp8788.c delete mode 100644 drivers/power/supply/lp8788-charger.c delete mode 100644 drivers/regulator/lp8788-buck.c delete mode 100644 drivers/regulator/lp8788-ldo.c delete mode 100644 drivers/rtc/rtc-lp8788.c delete mode 100644 drivers/video/backlight/lp8788_bl.c delete mode 100644 include/linux/mfd/lp8788-isink.h delete mode 100644 include/linux/mfd/lp8788.h
-- Sebastian
Re: [PATCH 07/14] mfd: remove unused lp8788 driver
In reply to Arnd BergmannQuoted 9 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This driver was apparently never used upstream, and without devicetree support cannot be used by external board support.
The MAINTAINER entry was already removed in 2021 as the email address bounced.
Signed-off-by Arnd Bergmann <[email protected]>
Yours,
Linus Walleij
PATCH 8/14 mfd: remove unused aat2870 driver
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
This driver was apparently never used, as it has has no devicetree support and never had corresponding platform_data definitions.
--- drivers/mfd/Kconfig | 12 - drivers/mfd/Makefile | 1 - drivers/mfd/aat2870-core.c | 458 -------------------------- drivers/regulator/Kconfig | 7 - drivers/regulator/Makefile | 1 - drivers/regulator/aat2870-regulator.c | 201 ----------- drivers/video/backlight/Kconfig | 7 - drivers/video/backlight/Makefile | 1 - drivers/video/backlight/aat2870_bl.c | 206 ------------ include/linux/mfd/aat2870.h | 164 --------- 10 files changed, 1058 deletions(-) delete mode 100644 drivers/mfd/aat2870-core.c delete mode 100644 drivers/regulator/aat2870-regulator.c delete mode 100644 drivers/video/backlight/aat2870_bl.c delete mode 100644 include/linux/mfd/aat2870.h
drivers/mfd/Kconfig +0 -12
@@ -115,18 +115,6 @@ config MFD_AS3722 controllers, 11 LDOs, RTC, automatic battery, temperature and over current monitoring, GPIOs, ADC and a watchdog. -config MFD_AAT2870_CORE - bool "AnalogicTech AAT2870" - select MFD_CORE - depends on I2C=y - depends on GPIOLIB || COMPILE_TEST - depends on GPIOLIB_LEGACY - help - If you say yes here you get support for the AAT2870. - This driver provides common support for accessing the device, - additional drivers must be enabled in order to use the - functionality of the device. - config MFD_AT91_USART tristate "AT91 USART Driver" select MFD_CORE
drivers/mfd/Makefile +0 -1
@@ -206,7 +206,6 @@ obj-$(CONFIG_MFD_QCOM_RPM) += qcom_rpm.o obj-$(CONFIG_MFD_SPMI_PMIC) += qcom-spmi-pmic.o obj-$(CONFIG_TPS65911_COMPARATOR) += tps65911-comparator.o obj-$(CONFIG_MFD_TPS65090) += tps65090.o -obj-$(CONFIG_MFD_AAT2870_CORE) += aat2870-core.o obj-$(CONFIG_MFD_AT91_USART) += at91-usart.o obj-$(CONFIG_MFD_ATMEL_FLEXCOM) += atmel-flexcom.o obj-$(CONFIG_MFD_ATMEL_HLCDC) += atmel-hlcdc.o
drivers/mfd/aat2870-core.c deleted +0 -458
458 lines not on this page · raw message
drivers/regulator/Kconfig +0 -7
@@ -132,13 +132,6 @@ config REGULATOR_ANATOP regulators. It is recommended that this option be enabled on i.MX6 platform. -config REGULATOR_AAT2870 - tristate "AnalogicTech AAT2870 Regulators" - depends on MFD_AAT2870_CORE - help - If you have a AnalogicTech AAT2870 say Y to enable the - regulator driver. - config REGULATOR_AB8500 bool "ST-Ericsson AB8500 Power Regulators" depends on AB8500_CORE
drivers/regulator/Makefile +0 -1
@@ -16,7 +16,6 @@ obj-$(CONFIG_REGULATOR_88PM8607) += 88pm8607.o obj-$(CONFIG_REGULATOR_88PM886) += 88pm886-regulator.o obj-$(CONFIG_REGULATOR_CROS_EC) += cros-ec-regulator.o obj-$(CONFIG_REGULATOR_CPCAP) += cpcap-regulator.o -obj-$(CONFIG_REGULATOR_AAT2870) += aat2870-regulator.o obj-$(CONFIG_REGULATOR_AB8500) += ab8500-ext.o ab8500.o obj-$(CONFIG_REGULATOR_ACT8865) += act8865-regulator.o obj-$(CONFIG_REGULATOR_ACT8945A) += act8945a-regulator.o
drivers/regulator/aat2870-regulator.c deleted +0 -201
201 lines not on this page · raw message
drivers/video/backlight/Kconfig +0 -7
@@ -388,13 +388,6 @@ config BACKLIGHT_88PM860X help Say Y to enable the backlight driver for Marvell 88PM8606. -config BACKLIGHT_AAT2870 - tristate "AnalogicTech AAT2870 Backlight" - depends on MFD_AAT2870_CORE - help - If you have a AnalogicTech AAT2870 say Y to enable the - backlight driver. - config BACKLIGHT_LM3509 tristate "Backlight Driver for LM3509" depends on I2C
drivers/video/backlight/Makefile +0 -1
@@ -18,7 +18,6 @@ obj-$(CONFIG_LCD_TDO24M) += tdo24m.o obj-$(CONFIG_LCD_VGG2432A4) += vgg2432a4.o obj-$(CONFIG_BACKLIGHT_88PM860X) += 88pm860x_bl.o -obj-$(CONFIG_BACKLIGHT_AAT2870) += aat2870_bl.o obj-$(CONFIG_BACKLIGHT_ADP8860) += adp8860_bl.o obj-$(CONFIG_BACKLIGHT_ADP8870) += adp8870_bl.o obj-$(CONFIG_BACKLIGHT_APPLE) += apple_bl.o
drivers/video/backlight/aat2870_bl.c deleted +0 -206
206 lines not on this page · raw message
include/linux/mfd/aat2870.h deleted +0 -164
164 lines not on this page · raw message
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH 08/14] mfd: remove unused aat2870 driver
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 6 lines
From: Arnd Bergmann <[email protected]>
This driver was apparently never used, as it has has no devicetree support and never had corresponding
platform_datadefinitions.Signed-off-by Arnd Bergmann <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=8
Re: [PATCH 08/14] mfd: remove unused aat2870 driver
In reply to Arnd BergmannQuoted 6 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This driver was apparently never used, as it has has no devicetree support and never had corresponding
platform_datadefinitions.Signed-off-by Arnd Bergmann <[email protected]>
Yours,
Linus Walleij
PATCH 9/14 mfd: remove unused lm3533 driver
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
This driver has apparently never had any users, as it does not support devicetree probing, and no lm3533_platform_data definition ever existed upstream.
--- drivers/iio/light/Kconfig | 17 - drivers/iio/light/Makefile | 1 - drivers/iio/light/lm3533-als.c | 922 ---------------------------- drivers/leds/Kconfig | 13 - drivers/leds/Makefile | 1 - drivers/leds/leds-lm3533.c | 755 ----------------------- drivers/mfd/Kconfig | 13 - drivers/mfd/Makefile | 1 - drivers/mfd/lm3533-core.c | 635 ------------------- drivers/mfd/lm3533-ctrlbank.c | 162 ----- drivers/video/backlight/Kconfig | 11 - drivers/video/backlight/Makefile | 1 - drivers/video/backlight/lm3533_bl.c | 398 ------------ include/linux/mfd/lm3533.h | 99 --- 14 files changed, 3029 deletions(-) delete mode 100644 drivers/iio/light/lm3533-als.c delete mode 100644 drivers/leds/leds-lm3533.c delete mode 100644 drivers/mfd/lm3533-core.c delete mode 100644 drivers/mfd/lm3533-ctrlbank.c delete mode 100644 drivers/video/backlight/lm3533_bl.c delete mode 100644 include/linux/mfd/lm3533.h
drivers/iio/light/Kconfig +0 -17
@@ -394,23 +394,6 @@ config RPR0521 To compile this driver as a module, choose M here: the module will be called rpr0521. -config SENSORS_LM3533 - tristate "LM3533 ambient light sensor" - depends on MFD_LM3533 - help - If you say yes here you get support for the ambient light sensor - interface on National Semiconductor / TI LM3533 Lighting Power - chips. - - The sensor interface can be used to control the LEDs and backlights - of the chip through defining five light zones and three sets of - corresponding output-current values. - - The driver provides raw and mean adc readings along with the current - light zone through sysfs. A threshold event can be generated on zone - changes. The ALS-control output values can be set per zone for the - three current output channels. - config LTR390 tristate "LTR-390UV-01 ambient light and UV sensor" depends on I2C
drivers/iio/light/Makefile +0 -1
@@ -35,7 +35,6 @@ obj-$(CONFIG_SENSORS_ISL29028) += isl29028.o obj-$(CONFIG_ISL29125) += isl29125.o obj-$(CONFIG_ISL76682) += isl76682.o obj-$(CONFIG_JSA1212) += jsa1212.o -obj-$(CONFIG_SENSORS_LM3533) += lm3533-als.o obj-$(CONFIG_LTR390) += ltr390.o obj-$(CONFIG_LTR501) += ltr501.o obj-$(CONFIG_LTRF216A) += ltrf216a.o
drivers/iio/light/lm3533-als.c deleted +0 -922
922 lines not on this page · raw message
drivers/leds/Kconfig +0 -13
@@ -262,19 +262,6 @@ config LEDS_LM3532 controlled manually or using PWM input or using ambient light automatically. -config LEDS_LM3533 - tristate "LED support for LM3533" - depends on LEDS_CLASS - depends on MFD_LM3533 - help - This option enables support for the LEDs on National Semiconductor / - TI LM3533 Lighting Power chips. - - The LEDs can be controlled directly, through PWM input, or by the - ambient-light-sensor interface. The chip supports - hardware-accelerated blinking with maximum on and off periods of 9.8 - and 77 seconds respectively. - config LEDS_LM3642 tristate "LED support for LM3642 Chip" depends on LEDS_CLASS && I2C
drivers/leds/Makefile +0 -1
@@ -39,7 +39,6 @@ obj-$(CONFIG_LEDS_IS31FL319X) += leds-is31fl319x.o obj-$(CONFIG_LEDS_IS31FL32XX) += leds-is31fl32xx.o obj-$(CONFIG_LEDS_LM3530) += leds-lm3530.o obj-$(CONFIG_LEDS_LM3532) += leds-lm3532.o -obj-$(CONFIG_LEDS_LM3533) += leds-lm3533.o obj-$(CONFIG_LEDS_LM355x) += leds-lm355x.o obj-$(CONFIG_LEDS_LM36274) += leds-lm36274.o obj-$(CONFIG_LEDS_LM3642) += leds-lm3642.o
drivers/leds/leds-lm3533.c deleted +0 -755
755 lines not on this page · raw message
drivers/mfd/Kconfig +0 -13
@@ -1917,19 +1917,6 @@ config MENELAUS and other features that are often used in portable devices like cell phones and PDAs. -config MFD_LM3533 - tristate "TI/National Semiconductor LM3533 Lighting Power chip" - depends on I2C - select MFD_CORE - select REGMAP_I2C - help - Say yes here to enable support for National Semiconductor / TI - LM3533 Lighting Power chips. - - This driver provides common support for accessing the device; - additional drivers must be enabled in order to use the LED, - backlight or ambient-light-sensor functionality of the device. - config MFD_TIMBERDALE tristate "Timberdale FPGA" select MFD_CORE
drivers/mfd/Makefile +0 -1
@@ -227,7 +227,6 @@ obj-$(CONFIG_MFD_SEC_CORE) += sec-core.o obj-$(CONFIG_MFD_SEC_ACPM) += sec-acpm.o obj-$(CONFIG_MFD_SEC_I2C) += sec-i2c.o obj-$(CONFIG_MFD_SYSCON) += syscon.o -obj-$(CONFIG_MFD_LM3533) += lm3533-core.o lm3533-ctrlbank.o obj-$(CONFIG_MFD_VEXPRESS_SYSREG) += vexpress-sysreg.o obj-$(CONFIG_MFD_RETU) += retu-mfd.o obj-$(CONFIG_MFD_AS3711) += as3711.o
drivers/mfd/lm3533-core.c deleted +0 -635
635 lines not on this page · raw message
drivers/mfd/lm3533-ctrlbank.c deleted +0 -162
162 lines not on this page · raw message
drivers/video/backlight/Kconfig +0 -11
@@ -215,17 +215,6 @@ config BACKLIGHT_SY7758 Say Y to enable the backlight driver for the Silergy SY7758 backlight controller found in Ayaneo Pocket S2. -config BACKLIGHT_LM3533 - tristate "Backlight Driver for LM3533" - depends on MFD_LM3533 - help - Say Y to enable the backlight driver for National Semiconductor / TI - LM3533 Lighting Power chips. - - The backlights can be controlled directly, through PWM input, or by - the ambient-light-sensor interface. The chip supports 256 brightness - levels. - config BACKLIGHT_LOCOMO tristate "Sharp LOCOMO LCD/Backlight Driver" depends on SHARP_LOCOMO
drivers/video/backlight/Makefile +0 -1
@@ -37,7 +37,6 @@ obj-$(CONFIG_BACKLIGHT_KTD253) += ktd253-backlight.o obj-$(CONFIG_BACKLIGHT_KTD2801) += ktd2801-backlight.o obj-$(CONFIG_BACKLIGHT_KTZ8866) += ktz8866.o obj-$(CONFIG_BACKLIGHT_LM3509) += lm3509_bl.o -obj-$(CONFIG_BACKLIGHT_LM3533) += lm3533_bl.o obj-$(CONFIG_BACKLIGHT_LM3630A) += lm3630a_bl.o obj-$(CONFIG_BACKLIGHT_LM3639) += lm3639_bl.o obj-$(CONFIG_BACKLIGHT_LOCOMO) += locomolcd.o
drivers/video/backlight/lm3533_bl.c deleted +0 -398
398 lines not on this page · raw message
include/linux/mfd/lm3533.h deleted +0 -99
22 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.53.0
Part of the diff is not shown here. View the raw message.
[email protected]
AI reviewRe: [PATCH 09/14] mfd: remove unused lm3533 driver
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Leftover sysfs ABI documentation files for the removed LM3533 driver. --
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Leftover sysfs ABI documentation files for the removed LM3533 driver. --
commit dd454943eacd9b46650ee0d6e1e22a90fadba749
Author: Arnd Bergmann <[email protected]>
mfd: remove unused lm3533 driver
This commit removes the lm3533 driver, including the MFD core, LED, ALS, and backlight components, as it has never had any users and lacks devicetree support.
Quoted 7 lines
mfd: remove unused lm3533 driver
This driver has apparently never had any users, as it does not support devicetree probing, and no
lm3533_platform_datadefinition ever existed upstream.Signed-off-by Arnd Bergmann <[email protected]>
[Severity: Low]
Does this commit leave orphaned sysfs ABI documentation behind? The patch removes the driver source files but it looks like the associated ABI documentation files were left in the tree:
- Documentation/ABI/testing/sysfs-bus-i2c-devices-lm3533
- Documentation/ABI/testing/sysfs-bus-iio-light-lm3533-als
- Documentation/ABI/testing/sysfs-class-backlight-driver-lm3533
- Documentation/ABI/testing/sysfs-class-led-driver-lm3533
Should these documentation files be removed along with the source files?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=9
Re: [PATCH 09/14] mfd: remove unused lm3533 driver
In reply to Arnd BergmannQuoted 5 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This driver has apparently never had any users, as it does not support devicetree probing, and no
lm3533_platform_datadefinition ever existed upstream.
I don't believe we ever required board files to be upstreamed?
There's also on-going work to enable devicetree support for this one:
https://lore.kernel.org/lkml/[email protected]/
Johan
Re: [PATCH 09/14] mfd: remove unused lm3533 driver
Quoted 8 lines · Johan Hovold
Quoted 5 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This driver has apparently never had any users, as it does not support devicetree probing, and no
lm3533_platform_datadefinition ever existed upstream.I don't believe we ever required board files to be upstreamed?
No, but there is a general requirement that code must be usable.
With my series to drop almost all Arm board files, the use of platform_data becomes so obscure that it becomes reasonable to assume that any driver that requires platform_data and does not already have an upstream definition for it is fundamentally broken.
The only platforms that still use board files now are:
arm/omap1
arm/s3c
m68k/coldfire
mips/alchemy
mips/bcm63xx
mips/rb532
mips/txx9
sh/sh77xx
All of these are now over 20 years old, so I don't expect anyone to add new board support or maintain boards for them except for what is already upstream.
Quoted 3 lines
There's also on-going work to enable devicetree support for this one:
https://lore.kernel.org/lkml/[email protected]/
Ok, I've dropped this patch, thanks for pointing this one out!
Arnd
PATCH 10/14 mfd: remove unused rc5t583 driver
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
Ricoh RC5T583 support was added in 2012, but no upstream code ever defined the corresponding platform_data, and there is no devicetree support, so this is all dead code.
--- drivers/mfd/Kconfig | 14 - drivers/mfd/Makefile | 1 - drivers/mfd/rc5t583-irq.c | 383 -------------------------- drivers/mfd/rc5t583.c | 299 -------------------- drivers/regulator/Kconfig | 10 - drivers/regulator/Makefile | 1 - drivers/regulator/rc5t583-regulator.c | 171 ------------ drivers/rtc/Kconfig | 10 - drivers/rtc/Makefile | 1 - drivers/rtc/rtc-rc5t583.c | 312 --------------------- include/linux/mfd/rc5t583.h | 369 ------------------------- 11 files changed, 1571 deletions(-) delete mode 100644 drivers/mfd/rc5t583-irq.c delete mode 100644 drivers/mfd/rc5t583.c delete mode 100644 drivers/regulator/rc5t583-regulator.c delete mode 100644 drivers/rtc/rtc-rc5t583.c delete mode 100644 include/linux/mfd/rc5t583.h
drivers/mfd/Kconfig +0 -14
@@ -1291,20 +1291,6 @@ config MFD_RT5120 is targeted at providing the CPU voltage, memory, I/O and peripheral power rails in home entertainment devices. -config MFD_RC5T583 - bool "Ricoh RC5T583 Power Management system device" - depends on I2C=y - select MFD_CORE - select REGMAP_I2C - help - Select this option to get support for the RICOH583 Power - Management system device. - This driver provides common support for accessing the device - through i2c interface. The device supports multiple sub-devices - like GPIO, interrupts, RTC, LDO and DCDC regulators, onkey. - Additional drivers must be enabled in order to use the - different functionality of the device. - config MFD_RK8XX tristate select MFD_CORE
drivers/mfd/Makefile +0 -1
@@ -217,7 +217,6 @@ obj-$(CONFIG_MFD_INTEL_PMC_BXT) += intel_pmc_bxt.o obj-$(CONFIG_MFD_PALMAS) += palmas.o obj-$(CONFIG_MFD_VIPERBOARD) += viperboard.o obj-$(CONFIG_MFD_NTXEC) += ntxec.o -obj-$(CONFIG_MFD_RC5T583) += rc5t583.o rc5t583-irq.o obj-$(CONFIG_MFD_RK8XX) += rk8xx-core.o obj-$(CONFIG_MFD_RK8XX_I2C) += rk8xx-i2c.o obj-$(CONFIG_MFD_RK8XX_SPI) += rk8xx-spi.o
drivers/mfd/rc5t583-irq.c deleted +0 -383
383 lines not on this page · raw message
drivers/mfd/rc5t583.c deleted +0 -299
299 lines not on this page · raw message
drivers/regulator/Kconfig +0 -10
@@ -1214,16 +1214,6 @@ config REGULATOR_RASPBERRYPI_TOUCHSCREEN_V2 unit. The regulator is used to enable power to the display and to control backlight PWM. -config REGULATOR_RC5T583 - tristate "RICOH RC5T583 Power regulators" - depends on MFD_RC5T583 - help - Select this option to enable the power regulator of RICOH - PMIC RC5T583. - This driver supports the control of different power rails of device - through regulator interface. The device supports multiple DCDC/LDO - outputs which can be controlled by i2c communication. - config REGULATOR_RK808 tristate "Rockchip RK805/RK808/RK809/RK817/RK818 Power regulators" depends on MFD_RK8XX
drivers/regulator/Makefile +0 -1
@@ -140,7 +140,6 @@ obj-$(CONFIG_REGULATOR_PBIAS) += pbias-regulator.o obj-$(CONFIG_REGULATOR_RAA215300) += raa215300.o obj-$(CONFIG_REGULATOR_RASPBERRYPI_TOUCHSCREEN_ATTINY) += rpi-panel-attiny-regulator.o obj-$(CONFIG_REGULATOR_RASPBERRYPI_TOUCHSCREEN_V2) += rpi-panel-v2-regulator.o -obj-$(CONFIG_REGULATOR_RC5T583) += rc5t583-regulator.o obj-$(CONFIG_REGULATOR_RK808) += rk808-regulator.o obj-$(CONFIG_REGULATOR_RN5T618) += rn5t618-regulator.o obj-$(CONFIG_REGULATOR_ROHM) += rohm-regulator.o
drivers/regulator/rc5t583-regulator.c deleted +0 -171
171 lines not on this page · raw message
drivers/rtc/Kconfig +0 -10
@@ -630,16 +630,6 @@ config RTC_DRV_TPS65910 This driver can also be built as a module. If so, the module will be called rtc-tps65910. -config RTC_DRV_RC5T583 - tristate "RICOH 5T583 RTC driver" - depends on MFD_RC5T583 - help - If you say yes here you get support for the RTC on the - RICOH 5T583 chips. - - This driver can also be built as a module. If so, the module - will be called rtc-rc5t583. - config RTC_DRV_RC5T619 tristate "RICOH RC5T619 RTC driver" depends on MFD_RN5T618
drivers/rtc/Makefile +0 -1
@@ -143,7 +143,6 @@ obj-$(CONFIG_RTC_DRV_PS3) += rtc-ps3.o obj-$(CONFIG_RTC_DRV_PXA) += rtc-pxa.o obj-$(CONFIG_RTC_DRV_R7301) += rtc-r7301.o obj-$(CONFIG_RTC_DRV_R9701) += rtc-r9701.o -obj-$(CONFIG_RTC_DRV_RC5T583) += rtc-rc5t583.o obj-$(CONFIG_RTC_DRV_RC5T619) += rtc-rc5t619.o obj-$(CONFIG_RTC_DRV_RK808) += rtc-rk808.o obj-$(CONFIG_RTC_DRV_RP5C01) += rtc-rp5c01.o
drivers/rtc/rtc-rc5t583.c deleted +0 -312
312 lines not on this page · raw message
include/linux/mfd/rc5t583.h deleted +0 -369
369 lines not on this page · raw message
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH 10/14] mfd: remove unused rc5t583 driver
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Incomplete feature removal: the patch deletes the core MFD_RC5T583 driver and header, but leaves…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete feature removal: the patch deletes the core MFD_RC5T583 driver and header, but leaves behind the GPIO driver and its Kconfig/Makefile entries. --
commit 311a4001bd9ad092f34b02c5b27077bd1e8dfc62
Author: Arnd Bergmann <[email protected]>
mfd: remove unused rc5t583 driver
The commit removes the Ricoh RC5T583 MFD, regulator, and RTC drivers along with their header file due to the lack of platform data and devicetree support.
Quoted 6 lines
drivers/mfd/Kconfig +0
-0@@ -1291,20 +1291,6 @@ config MFD_RT5120 is targeted at providing the CPU voltage, memory, I/O and peripheral
drivers/mfd/Kconfig config MFD_RT5120 · line 1301
Quoted 10 lines
drivers/mfd/Kconfig +0
-8power rails in home entertainment devices. -config MFD_RC5T583 - bool "Ricoh RC5T583 Power Management system device" - depends on I2C=y - select MFD_CORE - select REGMAP_I2C - help - Select this option to get support for the RICOH583 Power - Management system device.
[Severity: Low]
Does this removal break Kconfig consistency and leave dead code in the tree?
The config GPIO_RC5T583 in drivers/gpio/Kconfig still depends on MFD_RC5T583, which violates Kconfig rules since the target dependency is now missing.
Additionally, drivers/gpio/gpio-rc5t583.c is left in the tree and still includes the deleted <linux/mfd/rc5t583.h> header, making it unbuildable, and its entry is still present in drivers/gpio/Makefile.
Should the GPIO driver be removed in this patch as well?
Quoted 9 lines
drivers/mfd/Kconfig +0
-6- This driver provides common support for accessing the device - through i2c interface. The device supports multiple sub-devices - like GPIO, interrupts, RTC, LDO and DCDC regulators, onkey. - Additional drivers must be enabled in order to use the - different functionality of the device. - config MFD_RK8XX tristate select MFD_CORE
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=10
Re: [PATCH 10/14] mfd: remove unused rc5t583 driver
Quoted 11 lines · On Wed, Sep 9, 2026, at 15:39, [email protected] wrote:
[Severity: Low]
Does this removal breakKconfigconsistency and leave dead code in the tree?The config
GPIO_RC5T583indrivers/gpio/Kconfigstill depends onMFD_RC5T583, which violatesKconfigrules since the target dependency is now missing.Additionally,
drivers/gpio/gpio-rc5t583.cis left in the tree and still includes the deleted <linux/mfd/rc5t583.h> header, making it unbuildable, and its entry is still present indrivers/gpio/Makefile.Should the GPIO driver be removed in this patch as well?
Right, I had this as a separate patch but folded that in here now.
Arnd
Re: [PATCH 10/14] mfd: remove unused rc5t583 driver
In reply to Arnd BergmannQuoted 7 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Ricoh RC5T583 support was added in 2012, but no upstream code ever defined the corresponding
platform_data, and there is no devicetree support, so this is all dead code.Signed-off-by Arnd Bergmann <[email protected]>
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 11/14 mfd: remove unused wm8350 driver
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
This driver was used on the i.MX31 ADS reference board from Freescale and the smdk6410 reference board from Samsung. Both used platform_data based driver probing and are now gone from the kernel.
Since probing with devicetree has never been supported by wm8350, it is clear that nothing can use the driver on an upstream kernel, and it is unlikely that anyone is still interested in a devicetree conversion, so remove it.
--- Documentation/hwmon/index.rst | 1 - Documentation/hwmon/wm8350.rst | 30 - .../watchdog/watchdog-parameters.rst | 7 - MAINTAINERS | 1 - drivers/gpio/Kconfig | 7 - drivers/gpio/Makefile | 1 - drivers/gpio/gpio-wm8350.c | 144 -- drivers/hwmon/Kconfig | 10 - drivers/hwmon/Makefile | 1 - drivers/hwmon/wm8350-hwmon.c | 92 - drivers/leds/Kconfig | 8 - drivers/leds/Makefile | 1 - drivers/leds/leds-wm8350.c | 267 --- drivers/mfd/Kconfig | 15 - drivers/mfd/Makefile | 4 - drivers/mfd/wm8350-core.c | 444 ----- drivers/mfd/wm8350-gpio.c | 217 --- drivers/mfd/wm8350-i2c.c | 64 - drivers/mfd/wm8350-irq.c | 542 ------ drivers/mfd/wm8350-regmap.c | 335 ---- drivers/power/supply/Kconfig | 7 - drivers/power/supply/Makefile | 1 - drivers/power/supply/wm8350_power.c | 590 ------ drivers/regulator/Kconfig | 7 - drivers/regulator/Makefile | 1 - drivers/regulator/wm8350-regulator.c | 1330 ------------- drivers/rtc/Kconfig | 10 - drivers/rtc/Makefile | 1 - drivers/rtc/rtc-wm8350.c | 474 ----- drivers/watchdog/Kconfig | 8 - drivers/watchdog/Makefile | 1 - drivers/watchdog/wm8350_wdt.c | 171 -- include/linux/mfd/wm8350/audio.h | 620 ------- include/linux/mfd/wm8350/comparator.h | 171 -- include/linux/mfd/wm8350/core.h | 692 ------- include/linux/mfd/wm8350/gpio.h | 356 ---- include/linux/mfd/wm8350/pmic.h | 775 -------- include/linux/mfd/wm8350/rtc.h | 265 --- include/linux/mfd/wm8350/supply.h | 129 -- include/linux/mfd/wm8350/wdt.h | 24 - sound/soc/codecs/Kconfig | 5 - sound/soc/codecs/Makefile | 2 - sound/soc/codecs/wm8350.c | 1638 ----------------- sound/soc/codecs/wm8350.h | 25 - 44 files changed, 9494 deletions(-) delete mode 100644 Documentation/hwmon/wm8350.rst delete mode 100644 drivers/gpio/gpio-wm8350.c delete mode 100644 drivers/hwmon/wm8350-hwmon.c delete mode 100644 drivers/leds/leds-wm8350.c delete mode 100644 drivers/mfd/wm8350-core.c delete mode 100644 drivers/mfd/wm8350-gpio.c delete mode 100644 drivers/mfd/wm8350-i2c.c delete mode 100644 drivers/mfd/wm8350-irq.c delete mode 100644 drivers/mfd/wm8350-regmap.c delete mode 100644 drivers/power/supply/wm8350_power.c delete mode 100644 drivers/regulator/wm8350-regulator.c delete mode 100644 drivers/rtc/rtc-wm8350.c delete mode 100644 drivers/watchdog/wm8350_wdt.c delete mode 100644 include/linux/mfd/wm8350/audio.h delete mode 100644 include/linux/mfd/wm8350/comparator.h delete mode 100644 include/linux/mfd/wm8350/core.h delete mode 100644 include/linux/mfd/wm8350/gpio.h delete mode 100644 include/linux/mfd/wm8350/pmic.h delete mode 100644 include/linux/mfd/wm8350/rtc.h delete mode 100644 include/linux/mfd/wm8350/supply.h delete mode 100644 include/linux/mfd/wm8350/wdt.h delete mode 100644 sound/soc/codecs/wm8350.c delete mode 100644 sound/soc/codecs/wm8350.h
Documentation/hwmon/index.rst +0 -1
@@ -296,7 +296,6 @@ Hardware Monitoring Kernel Drivers w83l785ts w83l786ng wm831x - wm8350 xgene-hwmon xdp710 xdpe12284
Documentation/hwmon/wm8350.rst deleted +0 -30
@@ -1,30 +0,0 @@ -Kernel driver wm8350-hwmon -========================== - -Supported chips: - - * Wolfson Microelectronics WM835x PMICs - - Prefix: 'wm8350' - - Datasheet: - - - http://www.wolfsonmicro.com/products/WM8350 - - http://www.wolfsonmicro.com/products/WM8351 - - http://www.wolfsonmicro.com/products/WM8352 - -Authors: Mark Brown <[email protected]> - -Description ------------ - -The WM835x series of PMICs include an AUXADC which can be used to -monitor a range of system operating parameters, including the voltages -of the major supplies within the system. Currently the driver provides -simple access to these major supplies. - -Voltage Monitoring ------------------- - -Voltages are sampled by a 12 bit ADC. For the internal supplies the ADC -is referenced to the system VRTC.
Documentation/watchdog/watchdog-parameters.rst +0 -7
@@ -699,13 +699,6 @@ wm831x_wdt: ------------------------------------------------- -wm8350_wdt: - nowayout: - Watchdog cannot be stopped once started - (default=kernel config parameter) - -------------------------------------------------- - sun4v_wdt: timeout_ms: Watchdog timeout in milliseconds 1..180000, default=60000)
MAINTAINERS +0 -1
@@ -29385,7 +29385,6 @@ F: drivers/video/backlight/wm83*_bl.c F: drivers/watchdog/wm83*_wdt.c F: include/linux/mfd/arizona/ F: include/linux/mfd/wm831x/ -F: include/linux/mfd/wm8350/ F: include/linux/regulator/arizona* F: include/linux/wm97xx.h F: include/sound/wm????.h
drivers/gpio/Kconfig +0 -7
@@ -1792,13 +1792,6 @@ config GPIO_WM831X Say yes here to access the GPIO signals of WM831x power management chips from Wolfson Microelectronics. -config GPIO_WM8350 - tristate "WM8350 GPIOs" - depends on MFD_WM8350 - help - Say yes here to access the GPIO signals of WM8350 power management - chips from Wolfson Microelectronics. - config GPIO_WM8994 tristate "WM8994 GPIOs" depends on MFD_WM8994
drivers/gpio/Makefile +0 -1
@@ -211,7 +211,6 @@ obj-$(CONFIG_GPIO_WCD934X) += gpio-wcd934x.o obj-$(CONFIG_GPIO_WHISKEY_COVE) += gpio-wcove.o obj-$(CONFIG_GPIO_WINBOND) += gpio-winbond.o obj-$(CONFIG_GPIO_WM831X) += gpio-wm831x.o -obj-$(CONFIG_GPIO_WM8350) += gpio-wm8350.o obj-$(CONFIG_GPIO_WM8994) += gpio-wm8994.o obj-$(CONFIG_GPIO_WS16C48) += gpio-ws16c48.o obj-$(CONFIG_GPIO_XGENE) += gpio-xgene.o
drivers/gpio/gpio-wm8350.c deleted +0 -144
144 lines not on this page · raw message
drivers/hwmon/Kconfig +0 -10
@@ -2728,16 +2728,6 @@ config SENSORS_WM831X This driver can also be built as a module. If so, the module will be called wm831x-hwmon. -config SENSORS_WM8350 - tristate "Wolfson Microelectronics WM835x" - depends on MFD_WM8350 - help - If you say yes here you get support for the hardware - monitoring features of the WM835x series of PMICs. - - This driver can also be built as a module. If so, the module - will be called wm8350-hwmon. - config SENSORS_ULTRA45 tristate "Sun Ultra45 PIC16F747" depends on SPARC64
drivers/hwmon/Makefile +0 -1
@@ -251,7 +251,6 @@ obj-$(CONFIG_SENSORS_W83627EHF) += w83627ehf.o obj-$(CONFIG_SENSORS_W83L785TS) += w83l785ts.o obj-$(CONFIG_SENSORS_W83L786NG) += w83l786ng.o obj-$(CONFIG_SENSORS_WM831X) += wm831x-hwmon.o -obj-$(CONFIG_SENSORS_WM8350) += wm8350-hwmon.o obj-$(CONFIG_SENSORS_XGENE) += xgene-hwmon.o obj-$(CONFIG_SENSORS_YOGAFAN) += yogafan.o
drivers/hwmon/wm8350-hwmon.c deleted +0 -92
92 lines not on this page · raw message
drivers/leds/Kconfig +0 -8
@@ -610,14 +610,6 @@ config LEDS_WM831X_STATUS This option enables support for the status LEDs of the WM831x series of PMICs. -config LEDS_WM8350 - tristate "LED Support for WM8350 AudioPlus PMIC" - depends on LEDS_CLASS - depends on MFD_WM8350 - help - This option enables support for LEDs driven by the Wolfson - Microelectronics WM8350 AudioPlus PMIC. - config LEDS_DA9052 tristate "Dialog DA9052/DA9053 LEDS" depends on LEDS_CLASS
drivers/leds/Makefile +0 -1
@@ -94,7 +94,6 @@ obj-$(CONFIG_LEDS_TPS6105X) += leds-tps6105x.o obj-$(CONFIG_LEDS_TURRIS_OMNIA) += leds-turris-omnia.o obj-$(CONFIG_LEDS_UPBOARD) += leds-upboard.o obj-$(CONFIG_LEDS_WM831X_STATUS) += leds-wm831x-status.o -obj-$(CONFIG_LEDS_WM8350) += leds-wm8350.o obj-$(CONFIG_LEDS_WRAP) += leds-wrap.o # Kinetic ExpressWire Protocol
drivers/leds/leds-wm8350.c deleted +0 -267
267 lines not on this page · raw message
drivers/mfd/Kconfig +0 -15
@@ -2027,21 +2027,6 @@ config MFD_WM831X_SPI for accessing the device, additional drivers must be enabled in order to use the functionality of the device. -config MFD_WM8350 - bool - -config MFD_WM8350_I2C - bool "Wolfson Microelectronics WM8350 with I2C" - select MFD_WM8350 - select REGMAP_I2C - depends on I2C=y - help - The WM8350 is an integrated audio and power management - subsystem with watchdog and RTC functionality for embedded - systems. This option enables core support for the WM8350 with - I2C as the control interface. Additional options must be - selected to enable support for the functionality of the chip. - config MFD_WM8994 tristate "Wolfson Microelectronics WM8994" select MFD_CORE
drivers/mfd/Makefile +0 -4
@@ -60,10 +60,6 @@ wm831x-objs += wm831x-auxadc.o obj-$(CONFIG_MFD_WM831X) += wm831x.o obj-$(CONFIG_MFD_WM831X_I2C) += wm831x-i2c.o obj-$(CONFIG_MFD_WM831X_SPI) += wm831x-spi.o -wm8350-objs := wm8350-core.o wm8350-regmap.o wm8350-gpio.o -wm8350-objs += wm8350-irq.o -obj-$(CONFIG_MFD_WM8350) += wm8350.o -obj-$(CONFIG_MFD_WM8350_I2C) += wm8350-i2c.o wm8994-objs := wm8994-core.o wm8994-irq.o wm8994-regmap.o obj-$(CONFIG_MFD_WM8994) += wm8994.o obj-$(CONFIG_MFD_WM97xx) += wm97xx-core.o
drivers/mfd/wm8350-core.c deleted +0 -444
444 lines not on this page · raw message
drivers/mfd/wm8350-gpio.c deleted +0 -217
217 lines not on this page · raw message
drivers/mfd/wm8350-i2c.c deleted +0 -64
64 lines not on this page · raw message
drivers/mfd/wm8350-irq.c deleted +0 -542
542 lines not on this page · raw message
drivers/mfd/wm8350-regmap.c deleted +0 -335
335 lines not on this page · raw message
drivers/power/supply/Kconfig +0 -7
@@ -74,13 +74,6 @@ config WM831X_POWER Say Y here to enable support for the power management unit provided by Wolfson Microelectronics WM831x PMICs. -config WM8350_POWER - tristate "WM8350 PMU support" - depends on MFD_WM8350 - help - Say Y here to enable support for the power management unit - provided by the Wolfson Microelectronics WM8350 PMIC. - config TEST_POWER tristate "Test power driver" help
drivers/power/supply/Makefile +0 -1
@@ -16,7 +16,6 @@ obj-$(CONFIG_IP5XXX_POWER) += ip5xxx_power.o obj-$(CONFIG_MAX8925_POWER) += max8925_power.o obj-$(CONFIG_WM831X_BACKUP) += wm831x_backup.o obj-$(CONFIG_WM831X_POWER) += wm831x_power.o -obj-$(CONFIG_WM8350_POWER) += wm8350_power.o obj-$(CONFIG_TEST_POWER) += test_power.o obj-$(CONFIG_BATTERY_88PM860X) += 88pm860x_battery.o
drivers/power/supply/wm8350_power.c deleted +0 -590
590 lines not on this page · raw message
drivers/regulator/Kconfig +0 -7
@@ -1824,13 +1824,6 @@ config REGULATOR_WM831X Support the voltage and current regulators of the WM831x series of PMIC devices. -config REGULATOR_WM8350 - tristate "Wolfson Microelectronics WM8350 AudioPlus PMIC" - depends on MFD_WM8350 - help - This driver provides support for the voltage and current regulators - of the WM8350 AudioPlus PMIC. - config REGULATOR_WM8994 tristate "Wolfson Microelectronics WM8994 CODEC" depends on MFD_WM8994
drivers/regulator/Makefile +0 -1
@@ -209,7 +209,6 @@ obj-$(CONFIG_REGULATOR_VQMMC_IPQ4019) += vqmmc-ipq4019-regulator.o obj-$(CONFIG_REGULATOR_WM831X) += wm831x-dcdc.o obj-$(CONFIG_REGULATOR_WM831X) += wm831x-isink.o obj-$(CONFIG_REGULATOR_WM831X) += wm831x-ldo.o -obj-$(CONFIG_REGULATOR_WM8350) += wm8350-regulator.o obj-$(CONFIG_REGULATOR_WM8994) += wm8994-regulator.o ccflags-$(CONFIG_REGULATOR_DEBUG) += -DDEBUG
drivers/regulator/wm8350-regulator.c deleted +0 -1330
113 lines not on this page · raw message
drivers/rtc/rtc-wm8350.c deleted +0 -474
474 lines not on this page · raw message
drivers/watchdog/wm8350_wdt.c deleted +0 -171
171 lines not on this page · raw message
include/linux/mfd/wm8350/audio.h deleted +0 -620
620 lines not on this page · raw message
include/linux/mfd/wm8350/comparator.h deleted +0 -171
171 lines not on this page · raw message
include/linux/mfd/wm8350/core.h deleted +0 -692
692 lines not on this page · raw message
include/linux/mfd/wm8350/gpio.h deleted +0 -356
356 lines not on this page · raw message
include/linux/mfd/wm8350/pmic.h deleted +0 -775
775 lines not on this page · raw message
include/linux/mfd/wm8350/rtc.h deleted +0 -265
265 lines not on this page · raw message
include/linux/mfd/wm8350/supply.h deleted +0 -129
129 lines not on this page · raw message
include/linux/mfd/wm8350/wdt.h deleted +0 -24
Lines of this file are not shown. View the raw message.
sound/soc/codecs/wm8350.c deleted +0 -1638
1,638 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.53.0
Part of the diff is not shown here. View the raw message.
Re: [PATCH 11/14] mfd: remove unused wm8350 driver
Quoted 10 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This driver was used on the i.MX31 ADS reference board from Freescale and the smdk6410 reference board from Samsung. Both used
platform_databased driver probing and are now gone from the kernel.Since probing with devicetree has never been supported by wm8350, it is clear that nothing can use the driver on an upstream kernel, and it is unlikely that anyone is still interested in a devicetree conversion, so remove it.
[email protected]
AI reviewRe: [PATCH 11/14] mfd: remove unused wm8350 driver
In reply to Arnd BergmannThank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Stale documentation references to the removed wm8350 driver. --
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Stale documentation references to the removed wm8350 driver.
--
commit 180d02f3fe78e14ad7acf9b29e2590c4c4ee3a29
Author: Arnd Bergmann <[email protected]>
mfd: remove unused wm8350 driver
This commit removes the wm8350 driver entirely, as it relied on platform data probing for development boards that have been dropped from the kernel. It removes the core driver along with its hwmon, gpio, led, power, regulator, rtc, watchdog, and sound codec components.
Quoted 10 lines
mfd: remove unused wm8350 driver
This driver was used on the i.MX31 ADS reference board from Freescale and the smdk6410 reference board from Samsung. Both used
platform_databased driver probing and are now gone from the kernel.Since probing with devicetree has never been supported by wm8350, it is clear that nothing can use the driver on an upstream kernel, and it is unlikely that anyone is still interested in a devicetree conversion, so remove it.
[Severity: Low]
Since the wm8350 driver is being completely removed here, should we also update the documentation files that still reference it as a working example?
Currently, there are a few places left behind that point developers to the removed driver code. For instance, in Documentation/scheduler/completion.rst referencing wait_for_completion_interruptible_timeout:
why (e.g. see drivers/mfd/wm8350-core.c wm8350_read_auxadc())::
And its Chinese translation in Documentation/translations/zh_CN/scheduler/completion.rst:
(例如,见drivers/mfd/wm8350-core.c wm8350_read_auxadc()::
Additionally, Documentation/sound/soc/jack.rst points to the removed codec:
CODEC integrated jack detection can be see in the WM8350 driver.
Would it make sense to update these documents to point to a different, active driver as an example to avoid confusing developers who might try to look up the removed files?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=11
Re: [PATCH 11/14] mfd: remove unused wm8350 driver
In reply to Arnd BergmannQuoted 6 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This driver was used on the i.MX31 ADS reference board from Freescale and the smdk6410 reference board from Samsung. Both used
platform_databased driver probing and are now gone from the kernel.
Quoted 6 lines
Since probing with devicetree has never been supported by wm8350, it is clear that nothing can use the driver on an upstream kernel, and it is unlikely that anyone is still interested in a devicetree conversion, so remove it.
Signed-off-by Arnd Bergmann <[email protected]>
Re: [PATCH 11/14] mfd: remove unused wm8350 driver
In reply to Arnd BergmannQuoted 6 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This driver was used on the i.MX31 ADS reference board from Freescale and the smdk6410 reference board from Samsung. Both used
platform_databased driver probing and are now gone from the kernel.
Quoted 7 lines
Since probing with devicetree has never been supported by wm8350, it is clear that nothing can use the driver on an upstream kernel, and it is unlikely that anyone is still interested in a devicetree conversion, so remove it.
Signed-off-by Arnd Bergmann <[email protected]>---
Thanks,
Charles
Re: [PATCH 11/14] mfd: remove unused wm8350 driver
In reply to Arnd BergmannHi,
Quoted 73 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This driver was used on the i.MX31 ADS reference board from Freescale and the smdk6410 reference board from Samsung. Both used
platform_databased driver probing and are now gone from the kernel.Since probing with devicetree has never been supported by wm8350, it is clear that nothing can use the driver on an upstream kernel, and it is unlikely that anyone is still interested in a devicetree conversion, so remove it.
Signed-off-by Arnd Bergmann <[email protected]>--- Documentation/hwmon/index.rst | 1 - Documentation/hwmon/wm8350.rst | 30 - .../watchdog/watchdog-parameters.rst | 7 - MAINTAINERS | 1 - drivers/gpio/Kconfig | 7 - drivers/gpio/Makefile | 1 - drivers/gpio/gpio-wm8350.c | 144 -- drivers/hwmon/Kconfig | 10 - drivers/hwmon/Makefile | 1 - drivers/hwmon/wm8350-hwmon.c | 92 - drivers/leds/Kconfig | 8 - drivers/leds/Makefile | 1 - drivers/leds/leds-wm8350.c | 267 --- drivers/mfd/Kconfig | 15 - drivers/mfd/Makefile | 4 - drivers/mfd/wm8350-core.c | 444 ----- drivers/mfd/wm8350-gpio.c | 217 --- drivers/mfd/wm8350-i2c.c | 64 - drivers/mfd/wm8350-irq.c | 542 ------ drivers/mfd/wm8350-regmap.c | 335 ---- drivers/power/supply/Kconfig | 7 - drivers/power/supply/Makefile | 1 - drivers/power/supply/wm8350_power.c | 590 ------ drivers/regulator/Kconfig | 7 - drivers/regulator/Makefile | 1 - drivers/regulator/wm8350-regulator.c | 1330 ------------- drivers/rtc/Kconfig | 10 - drivers/rtc/Makefile | 1 - drivers/rtc/rtc-wm8350.c | 474 ----- drivers/watchdog/Kconfig | 8 - drivers/watchdog/Makefile | 1 - drivers/watchdog/wm8350_wdt.c | 171 -- include/linux/mfd/wm8350/audio.h | 620 ------- include/linux/mfd/wm8350/comparator.h | 171 -- include/linux/mfd/wm8350/core.h | 692 ------- include/linux/mfd/wm8350/gpio.h | 356 ---- include/linux/mfd/wm8350/pmic.h | 775 -------- include/linux/mfd/wm8350/rtc.h | 265 --- include/linux/mfd/wm8350/supply.h | 129 -- include/linux/mfd/wm8350/wdt.h | 24 - sound/soc/codecs/Kconfig | 5 - sound/soc/codecs/Makefile | 2 - sound/soc/codecs/wm8350.c | 1638 ----------------- sound/soc/codecs/wm8350.h | 25 - 44 files changed, 9494 deletions(-) delete mode 100644 Documentation/hwmon/wm8350.rst delete mode 100644 drivers/gpio/gpio-wm8350.c delete mode 100644 drivers/hwmon/wm8350-hwmon.c delete mode 100644 drivers/leds/leds-wm8350.c delete mode 100644 drivers/mfd/wm8350-core.c delete mode 100644 drivers/mfd/wm8350-gpio.c delete mode 100644 drivers/mfd/wm8350-i2c.c delete mode 100644 drivers/mfd/wm8350-irq.c delete mode 100644 drivers/mfd/wm8350-regmap.c delete mode 100644 drivers/power/supply/wm8350_power.c delete mode 100644 drivers/regulator/wm8350-regulator.c delete mode 100644 drivers/rtc/rtc-wm8350.c delete mode 100644 drivers/watchdog/wm8350_wdt.c delete mode 100644 include/linux/mfd/wm8350/audio.h delete mode 100644 include/linux/mfd/wm8350/comparator.h
Quoted 8 lines
delete mode 100644 include/linux/mfd/wm8350/core.h delete mode 100644 include/linux/mfd/wm8350/gpio.h delete mode 100644 include/linux/mfd/wm8350/pmic.h delete mode 100644 include/linux/mfd/wm8350/rtc.h delete mode 100644 include/linux/mfd/wm8350/supply.h delete mode 100644 include/linux/mfd/wm8350/wdt.h delete mode 100644 sound/soc/codecs/wm8350.c delete mode 100644 sound/soc/codecs/wm8350.h
-- Sebastian
Re: [PATCH 11/14] mfd: remove unused wm8350 driver
In reply to Arnd BergmannQuoted 6 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This driver was used on the i.MX31 ADS reference board from Freescale and the smdk6410 reference board from Samsung. Both used
platform_databased driver probing and are now gone from the kernel.
Quoted 6 lines
Since probing with devicetree has never been supported by wm8350, it is clear that nothing can use the driver on an upstream kernel, and it is unlikely that anyone is still interested in a devicetree conversion, so remove it.
Signed-off-by Arnd Bergmann <[email protected]>
Yours,
Linus Walleij
PATCH 12/14 mfd: remove unused mcp-sa11x0/ucb1x00 driver
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
The sa1100 platform has been removed, so these drivers are no longer used anywhere.
--- Documentation/admin-guide/devices.txt | 1 - drivers/mfd/Kconfig | 24 - drivers/mfd/Makefile | 8 - drivers/mfd/mcp-core.c | 235 ------ drivers/mfd/mcp-sa11x0.c | 304 ------- drivers/mfd/ucb1x00-assabet.c | 175 ---- drivers/mfd/ucb1x00-core.c | 795 ------------------- drivers/mfd/ucb1x00-ts.c | 445 ----------- include/linux/mfd/mcp.h | 63 -- include/linux/mfd/ucb1x00.h | 261 ------ include/linux/platform_data/mfd-mcp-sa11x0.h | 17 - 11 files changed, 2328 deletions(-) delete mode 100644 drivers/mfd/mcp-core.c delete mode 100644 drivers/mfd/mcp-sa11x0.c delete mode 100644 drivers/mfd/ucb1x00-assabet.c delete mode 100644 drivers/mfd/ucb1x00-core.c delete mode 100644 drivers/mfd/ucb1x00-ts.c delete mode 100644 include/linux/mfd/mcp.h delete mode 100644 include/linux/mfd/ucb1x00.h delete mode 100644 include/linux/platform_data/mfd-mcp-sa11x0.h
Documentation/admin-guide/devices.txt +0 -1
@@ -262,7 +262,6 @@ 10 = /dev/adbmouse Apple Desktop Bus mouse 11 = /dev/vrtpanel Vr41xx embedded touch panel 13 = /dev/vpcmouse Connectix Virtual PC Mouse - 14 = /dev/touchscreen/ucb1x00 UCB 1x00 touchscreen 15 = /dev/touchscreen/mk712 MK712 touchscreen 128 = /dev/beep Fancy beep device 129 =
drivers/mfd/Kconfig +0 -24
@@ -2258,30 +2258,6 @@ config MFD_QCOM_PM8008 under it in the device tree. Additional drivers must be enabled in order to use the functionality of the device. -menu "Multimedia Capabilities Port drivers" - depends on ARCH_SA1100 - -config MCP - tristate - -# Interface drivers -config MCP_SA11X0 - tristate "Support SA11x0 MCP interface" - depends on ARCH_SA1100 - select MCP - -# Chip drivers -config MCP_UCB1200 - tristate "Support for UCB1200 / UCB1300" - depends on MCP_SA11X0 - select MCP - -config MCP_UCB1200_TS - tristate "Touchscreen interface support" - depends on MCP_UCB1200 && INPUT - -endmenu - config MFD_VEXPRESS_SYSREG tristate "Versatile Express System Registers" depends on VEXPRESS_CONFIG && GPIOLIB
drivers/mfd/Makefile +0 -8
@@ -126,14 +126,6 @@ obj-$(CONFIG_MFD_OCELOT) += ocelot-soc.o obj-$(CONFIG_MFD_CPCAP) += motorola-cpcap.o -obj-$(CONFIG_MCP) += mcp-core.o -obj-$(CONFIG_MCP_SA11X0) += mcp-sa11x0.o -obj-$(CONFIG_MCP_UCB1200) += ucb1x00-core.o -obj-$(CONFIG_MCP_UCB1200_TS) += ucb1x00-ts.o - -ifeq ($(CONFIG_SA1100_ASSABET),y) -obj-$(CONFIG_MCP_UCB1200) += ucb1x00-assabet.o -endif obj-$(CONFIG_PMIC_DA9052) += da9052-irq.o obj-$(CONFIG_PMIC_DA9052) += da9052-core.o
drivers/mfd/mcp-core.c deleted +0 -235
235 lines not on this page · raw message
drivers/mfd/mcp-sa11x0.c deleted +0 -304
304 lines not on this page · raw message
drivers/mfd/ucb1x00-assabet.c deleted +0 -175
175 lines not on this page · raw message
drivers/mfd/ucb1x00-core.c deleted +0 -795
795 lines not on this page · raw message
drivers/mfd/ucb1x00-ts.c deleted +0 -445
445 lines not on this page · raw message
include/linux/mfd/mcp.h deleted +0 -63
63 lines not on this page · raw message
include/linux/mfd/ucb1x00.h deleted +0 -261
261 lines not on this page · raw message
include/linux/platform_data/mfd-mcp-sa11x0.h deleted +0 -17
@@ -1,17 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* -* Copyright (C) 2005 Russell King. -*/ -#ifndef __MFD_MCP_SA11X0_H -#define __MFD_MCP_SA11X0_H - -#include <linux/types.h> - -struct mcp_plat_data { -u32 mccr0; -u32 mccr1; -unsigned int sclk_rate; -void *codec_pdata; -}; - -#endif
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH 12/14] mfd: remove unused mcp-sa11x0/ucb1x00 driver
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [High] The commit deletes headers `<linux/platform_data/mfd-mcp-sa11x0.h>` and `<linux/mfd/ucb1x00.h>`…
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] The commit deletes headers <linux/platform_data/mfd-mcp-sa11x0.h> and <linux/mfd/ucb1x00.h>, but the SA1100 platform still exists and relies on them, causing build errors.
- [Medium] Referencing a removed Kconfig symbol MCP_UCB1200 leaves the collie_battery driver as orphaned dead code.
--
commit 3e512215b27ee60439f00d2cbf7fccc06602c45a
Author: Arnd Bergmann <[email protected]>
Subject: mfd: remove unused mcp-sa11x0/ucb1x00 driver
This commit removes the MCP and UCB1x00 MFD drivers, along with their associated platform data headers and Kconfig entries. The removal is based on the premise that the sa1100 platform has been removed and these drivers are no longer used anywhere.
Quoted 4 lines
mfd: remove unused mcp-sa11x0/ucb1x00 driver
The sa1100 platform has been removed, so these drivers are no longer used anywhere.
[Severity: High]
Is the sa1100 platform fully removed in this series? Looking at the tree, arch/arm/mach-sa1100/assabet.c and arch/arm/mach-sa1100/collie.c still exist and unconditionally include the headers deleted by this patch.
For example, arch/arm/mach-sa1100/assabet.c includes the headers and instantiates the platform data:
#include <linux/platform_data/mfd-mcp-sa11x0.h>
...
static struct mcp_plat_data assabet_mcp_data = {
...
Since this commit deletes include/linux/mfd/ucb1x00.h and include/linux/platform_data/mfd-mcp-sa11x0.h, does this cause a build failure when compiling the assabet or collie boards?
[ ... ]
Quoted 25 lines
drivers/mfd/Kconfig +0
-17@@ -2258,30 +2258,6 @@ config MFD_QCOM_PM8008 under it in the device tree. Additional drivers must be enabled in order to use the functionality of the device. -menu "Multimedia Capabilities Port drivers" - depends on ARCH_SA1100 - -config MCP - tristate - -# Interface drivers -config MCP_SA11X0 - tristate "Support SA11x0 MCP interface" - depends on ARCH_SA1100 - select MCP - -# Chip drivers -config MCP_UCB1200 - tristate "Support for UCB1200 / UCB1300" - depends on MCP_SA11X0 - select MCP
drivers/mfd/Kconfig config MFD_QCOM_PM8008 · line 2263
Quoted 10 lines
drivers/mfd/Kconfig +0
-7- -config MCP_UCB1200_TS - tristate "Touchscreen interface support" - depends on MCP_UCB1200 && INPUT - -endmenu - config MFD_VEXPRESS_SYSREG tristate "Versatile Express System Registers" depends on VEXPRESS_CONFIG && GPIOLIB
[Severity: Medium]
Does removing the MCP_UCB1200 config symbol leave the collie_battery driver as orphaned dead code?
Looking at drivers/power/supply/Kconfig, BATTERY_COLLIE depends on SA1100_COLLIE && MCP_UCB1200. Furthermore, drivers/power/supply/collie_battery.c still includes the now-deleted include/linux/mfd/ucb1x00.h header.
If this Kconfig symbol is removed without cleaning up the power supply subsystem, it causes an unmet dependency warning and leaves the battery driver unselectable.
[ ... ]
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=12
Re: [PATCH 12/14] mfd: remove unused mcp-sa11x0/ucb1x00 driver
Quoted 8 lines · On Wed, Sep 9, 2026, at 15:48, [email protected] wrote:
Quoted 3 lines
The sa1100 platform has been removed, so these drivers are no longer used anywhere.
[Severity: High]
Is the sa1100 platform fully removed in this series? Looking at the tree,arch/arm/mach-sa1100/assabet.candarch/arm/mach-sa1100/collie.cstill exist and unconditionally include the headers deleted by this patch.
As explained in the cover letter, the platform is only removed in another series I posted.
Quoted 4 lines
[Severity: Medium]
Does removing theMCP_UCB1200config symbol leave thecollie_batterydriver as orphaned dead code?
Quoted 8 lines
Looking at
drivers/power/supply/Kconfig,BATTERY_COLLIEdepends onSA1100_COLLIE&&MCP_UCB1200. Furthermore,drivers/power/supply/collie_battery.cstill includes the now-deletedinclude/linux/mfd/ucb1x00.hheader.If this
Kconfigsymbol is removed without cleaning up the power supply subsystem, it causes an unmet dependency warning and leaves the battery driver unselectable.
I have separate patches for this.
Arnd
Re: [PATCH 12/14] mfd: remove unused mcp-sa11x0/ucb1x00 driver
In reply to Arnd BergmannQuoted 6 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The sa1100 platform has been removed, so these drivers are no longer used anywhere.
Signed-off-by Arnd Bergmann <[email protected]>
Yours,
Linus Walleij
PATCH 13/14 mfd: remove unused menelaus driver
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
Menelaus was a companion chip for the omap24xx platform, which has been remvoed from the kernel, so now the menelaus driver is unused and can be removed.
--- drivers/mfd/Kconfig | 10 - drivers/mfd/Makefile | 1 - drivers/mfd/menelaus.c | 1251 ---------------------------------- drivers/rtc/Kconfig | 9 - include/linux/mfd/menelaus.h | 41 -- 5 files changed, 1312 deletions(-) delete mode 100644 drivers/mfd/menelaus.c delete mode 100644 include/linux/mfd/menelaus.h
drivers/mfd/Kconfig +0 -10
@@ -1893,16 +1893,6 @@ config TWL6040_CORE additional drivers must be enabled in order to use the functionality of the device (audio, vibra). -config MENELAUS - bool "TI TWL92330/Menelaus PM chip" - depends on I2C=y && ARCH_OMAP2 - help - If you say yes here you get support for the Texas Instruments - TWL92330/Menelaus Power Management chip. This include voltage - regulators, Dual slot memory card transceivers, real-time clock - and other features that are often used in portable devices like - cell phones and PDAs. - config MFD_TIMBERDALE tristate "Timberdale FPGA" select MFD_CORE
drivers/mfd/Makefile +0 -1
@@ -102,7 +102,6 @@ obj-$(CONFIG_MFD_TPS65912_SPI) += tps65912-spi.o obj-$(CONFIG_MFD_TPS6594) += tps6594-core.o obj-$(CONFIG_MFD_TPS6594_I2C) += tps6594-i2c.o obj-$(CONFIG_MFD_TPS6594_SPI) += tps6594-spi.o -obj-$(CONFIG_MENELAUS) += menelaus.o obj-$(CONFIG_TWL4030_CORE) += twl-core.o twl4030-irq.o twl6030-irq.o obj-$(CONFIG_TWL4030_POWER) += twl4030-power.o
drivers/mfd/menelaus.c deleted +0 -1251
1,251 lines not on this page · raw message
drivers/rtc/Kconfig +0 -9
@@ -570,15 +570,6 @@ config RTC_DRV_BQ32K This driver can also be built as a module. If so, the module will be called rtc-bq32k. -config RTC_DRV_TWL92330 - bool "TI TWL92330/Menelaus" - depends on MENELAUS - help - If you say yes here you get support for the RTC on the - TWL92330 "Menelaus" power management chip, used with OMAP2 - platforms. The support is integrated with the rest of - the Menelaus driver; it's not separate module. - config RTC_DRV_TWL4030 tristate "TI TWL4030/TWL5030/TWL6030/TPS659x0" depends on TWL4030_CORE
include/linux/mfd/menelaus.h deleted +0 -41
41 lines not on this page · raw message
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH 13/14] mfd: remove unused menelaus driver
Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider: - [Low] Removing `include/linux/mfd/menelaus.h` breaks the build for `arch/arm/mach-omap2/` because the…
Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Low] Removing include/linux/mfd/menelaus.h breaks the build for arch/arm/mach-omap2/ because the OMAP24xx platform and N8x0 board files were not actually removed from the kernel.
- [Low] Selection of a non-existent Kconfig symbol (MENELAUS).
- [Low] Dangling file reference in the MAINTAINERS file and orphaned defconfig entry.
--
commit a734289fbadac21de1944b368a0a47eb10c6d46e
Author: Arnd Bergmann <[email protected]>
mfd: remove unused menelaus driver
Menelaus was a companion chip for the omap24xx platform, which has been remvoed from the kernel, so now the menelaus driver is unused and can be removed.
Quoted 3 lines
Menelaus was a companion chip for the omap24xx platform, which has been remvoed from the kernel, so now the menelaus driver is unused and can be removed.
[Severity: Low]
Is the omap24xx platform completely removed?
It looks like arch/arm/mach-omap2/board-n8x0.c and arch/arm/mach-omap2/common-board-devices.h still exist and unconditionally include the deleted header, which breaks the build for OMAP2 configurations:
arch/arm/mach-omap2/board-n8x0.c:
#include <linux/mfd/menelaus.h>
arch/arm/mach-omap2/common-board-devices.h:
#include <linux/mfd/menelaus.h>
extern struct menelaus_platform_data n8x0_menelaus_platform_data;This isn't a bug, but there's a typo (remvoed) in the commit message.
drivers/mfd/Kconfig config TWL6040_CORE · line 1897
Quoted 10 lines
drivers/mfd/Kconfig +0
-2@@ -1893,16 +1893,6 @@ config TWL6040_CORE additional drivers must be enabled in order to use the functionality of the device (audio, vibra). -config MENELAUS - bool "TI TWL92330/Menelaus PM chip"
[Severity: Low]
Does removing this config break Kconfig dependencies?
arch/arm/mach-omap2/Kconfig still selects this for ARCH_OMAP2PLUS_TYPICAL:
arch/arm/mach-omap2/Kconfig:config ARCH_OMAP2PLUS_TYPICAL
select MENELAUS if ARCH_OMAP2
Selecting a non-existent symbol triggers a Kconfig warning.
[ ... ]
drivers/mfd/menelaus.c
Quoted 6 lines
drivers/mfd/menelaus.c deleted +0
-0@@ -1,1251 +0,0 @@
[Severity: Low]
Should the reference to this file in MAINTAINERS also be removed?
MAINTAINERS:
F: drivers/mfd/menelaus.c
[ ... ]
drivers/rtc/Kconfig config RTC_DRV_BQ32K · line 574
Quoted 10 lines
drivers/rtc/Kconfig +0
-2@@ -570,15 +570,6 @@ config RTC_DRV_BQ32K This driver can also be built as a module. If so, the module will be called rtc-bq32k. -config RTC_DRV_TWL92330 - bool "TI TWL92330/Menelaus"
[Severity: Low]
Does this leave an orphaned defconfig entry?
arch/arm/configs/omap2plus_defconfig still references the removed config:
arch/arm/configs/omap2plus_defconfig:
CONFIG_RTC_DRV_TWL92330=y
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=13
Re: [PATCH 13/14] mfd: remove unused menelaus driver
Quoted 7 lines · On Wed, Sep 9, 2026, at 15:49, [email protected] wrote:
[Severity: Low]
Is the omap24xx platform completely removed?It looks like
arch/arm/mach-omap2/board-n8x0.candarch/arm/mach-omap2/common-board-devices.hstill exist and unconditionally include the deleted header, which breaks the build for OMAP2 configurations:
Quoted 6 lines
arch/arm/mach-omap2/board-n8x0.c:#include <linux/mfd/menelaus.h>
arch/arm/mach-omap2/common-board-devices.h:#include <linux/mfd/menelaus.h> extern struct menelaus_platform_data n8x0_menelaus_platform_data;
As mentioned in the cover letter, this is one of the four drivers that are only orphaned after the series I sent yesterday to remove omap2 and other platforms.
Quoted 10 lines
drivers/mfd/menelaus.c
Quoted 6 lines
drivers/mfd/menelaus.c deleted +0
-0@@ -1,1251 +0,0 @@[Severity: Low]
Should the reference to this file inMAINTAINERSalso be removed?
Quoted 2 lines
MAINTAINERS:
F:drivers/mfd/menelaus.c
This was accidentally removed in the omap2 patch, moving it to this patch now.
Quoted 16 lines
[ ... ]
drivers/rtc/Kconfig config RTC_DRV_BQ32K · line 574
Quoted 10 lines
drivers/rtc/Kconfig +0
-2@@ -570,15 +570,6 @@ config RTC_DRV_BQ32K This driver can also be built as a module. If so, the module will be called rtc-bq32k. -config RTC_DRV_TWL92330 - bool "TI TWL92330/Menelaus"[Severity: Low]
Does this leave an orphaned defconfig entry?
Quoted 4 lines
arch/arm/configs/omap2plus_defconfigstill references the removed config:
arch/arm/configs/omap2plus_defconfig:CONFIG_RTC_DRV_TWL92330=y
This is now removed in the omap2 removal patch as well.
Arnd
Re: [PATCH 13/14] mfd: remove unused menelaus driver
In reply to Arnd BergmannQuoted 7 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Menelaus was a companion chip for the omap24xx platform, which has been remvoed from the kernel, so now the menelaus driver is unused and can be removed.
Signed-off-by Arnd Bergmann <[email protected]>
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Re: [PATCH 13/14] mfd: remove unused menelaus driver
In reply to Arnd BergmannQuoted 7 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Menelaus was a companion chip for the omap24xx platform, which has been remvoed from the kernel, so now the menelaus driver is unused and can be removed.
Signed-off-by Arnd Bergmann <[email protected]>
Yours,
Linus Walleij
PATCH 14/14 mfd: remove unused iPaq micro driver
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
The iPaq support has been removed from the kernel, this driver is no longer used anywhere.
--- drivers/mfd/Kconfig | 10 - drivers/mfd/Makefile | 1 - drivers/mfd/ipaq-micro.c | 442 --------------------------------------- 3 files changed, 453 deletions(-) delete mode 100644 drivers/mfd/ipaq-micro.c
drivers/mfd/Kconfig +0 -10
@@ -780,16 +780,6 @@ config MFD_INTEL_PMC_BXT Register and P-unit access. In addition this creates devices for iTCO watchdog and telemetry that are part of the PMC. -config MFD_IPAQ_MICRO - bool "Atmel Micro ASIC (iPAQ h3100/h3600/h3700) Support" - depends on SA1100_H3600 - select MFD_CORE - help - Select this to get support for the Microcontroller found in - the Compaq iPAQ handheld computers. This is an Atmel - AT90LS8535 microcontroller flashed with a special iPAQ - firmware using the custom protocol implemented in this driver. - config MFD_IQS62X tristate "Azoteq IQS620A/621/622/624/625 core support" depends on I2C
drivers/mfd/Makefile +0 -1
@@ -218,7 +218,6 @@ obj-$(CONFIG_MFD_RETU) += retu-mfd.o obj-$(CONFIG_MFD_AS3711) += as3711.o obj-$(CONFIG_MFD_AS3722) += as3722.o obj-$(CONFIG_MFD_STW481X) += stw481x.o -obj-$(CONFIG_MFD_IPAQ_MICRO) += ipaq-micro.o obj-$(CONFIG_MFD_IQS62X) += iqs62x.o obj-$(CONFIG_MFD_MENF21BMC) += menf21bmc.o obj-$(CONFIG_MFD_HI6421_PMIC) += hi6421-pmic-core.o
drivers/mfd/ipaq-micro.c deleted +0 -442
442 lines not on this page · raw message
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH 14/14] mfd: remove unused iPaq micro driver
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [High] The patch removes the MFD_IPAQ_MICRO core driver, but leaves behind references to its non-existent…
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] The patch removes the MFD_IPAQ_MICRO core driver, but leaves behind references to its non-existent Kconfig symbol in select statements, as well as orphaned child drivers and header files.
- [Low] The commit message does not follow the mandatory prefix and capitalization rules for the MFD subsystem.
--
commit 083382aa696919c18a4b69206eaec876c285e518
Author: Arnd Bergmann <[email protected]>
mfd: remove unused iPaq micro driver
The iPaq support has been removed from the kernel, this driver is no longer used anywhere.
Quoted 1 line
mfd: remove unused iPaq micro driver
[Severity: Low]
Is the commit message subject missing the standard MFD prefix format? It appears the format should be "mfd: <Driver>: <Capitalized description>" rather than "mfd: remove unused iPaq micro driver".
drivers/mfd/Kconfig config MFD_INTEL_PMC_BXT · line 784
Quoted 10 lines
drivers/mfd/Kconfig +0
-2@@ -780,16 +780,6 @@ config MFD_INTEL_PMC_BXT Register and P-unit access. In addition this creates devices for iTCO watchdog and telemetry that are part of the PMC. -config MFD_IPAQ_MICRO - bool "Atmel Micro ASIC (iPAQ h3100/h3600/h3700) Support"
[Severity: High]
Are there still orphaned references to this config symbol in other parts of the tree?
For example, arch/arm/mach-sa1100/Kconfig still selects this symbol for SA1100_H3600:
select MFD_IPAQ_MICRO
This causes unmet dependency warnings during the build.
Additionally, child drivers like KEYBOARD_IPAQ_MICRO in drivers/input/keyboard/Kconfig still depend on it:
depends on MFD_IPAQ_MICRO
which turns them into unselectable dead code.
Should the child driver source files and headers be removed as well? In drivers/leds/leds-ipaq-micro.c, micro_leds_brightness_set() attempts to call a function from the MFD core that has just been removed:
return ipaq_micro_tx_msg_sync(micro, &msg);
The header include/linux/mfd/ipaq-micro.h also remains, declaring APIs like ipaq_micro_tx_msg() that no longer have an implementation.
Quoted 8 lines
drivers/mfd/Kconfig +0
-8- depends on SA1100_H3600 - select MFD_CORE - help - Select this to get support for the Microcontroller found in - the Compaq iPAQ handheld computers. This is an Atmel - AT90LS8535 microcontroller flashed with a special iPAQ - firmware using the custom protocol implemented in this driver. -
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=14
Re: [PATCH 14/14] mfd: remove unused iPaq micro driver
Quoted 5 lines · On Wed, Sep 9, 2026, at 15:43, [email protected] wrote:
For example,
arch/arm/mach-sa1100/Kconfigstill selects this symbol forSA1100_H3600:select
MFD_IPAQ_MICRO
Quoted 8 lines
This causes unmet dependency warnings during the build.
Additionally, child drivers like
KEYBOARD_IPAQ_MICROindrivers/input/keyboard/Kconfigstill depend on it:depends on
MFD_IPAQ_MICROwhich turns them into unselectable dead code.
The platform patch has to come first, yes.
Quoted 3 lines
Should the child driver source files and headers be removed as well? In
drivers/leds/leds-ipaq-micro.c,micro_leds_brightness_set()attempts to call a function from the MFD core that has just been removed:
I have separate patches for the other ones in this case but could fold them in here if necessary.
Quoted 4 lines
return ipaq_micro_tx_msg_sync(micro, &msg);The header
include/linux/mfd/ipaq-micro.halso remains, declaring APIs likeipaq_micro_tx_msg()that no longer have an implementation.
Removing that file as well now.
Arnd
Re: [PATCH 14/14] mfd: remove unused iPaq micro driver
In reply to Arnd BergmannQuoted 6 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The iPaq support has been removed from the kernel, this driver is no longer used anywhere.
Signed-off-by Arnd Bergmann <[email protected]>
Also delete the header as Sashiko says, with that:
Yours,
Linus Walleij
Quoted 48 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
As part of my cleanup of old platforms, I had a look at all drivers that may have become unused because the last
platform_dataor DT definition was removed, or because of unmetKconfigdependencies.These are all the mfd drivers I found. The first ten in the list actually turned out to have been unusable long before my series, and I have added explanations on how I determined this in each patch. The last four patches are still in use in linux-7.3 but become unused after my series [1] that I hope to get merged for 7.4.
Somewhat unorthodox, I took a shortcut here and remove both the mfd drivers and the corresponding subsystem drivers (gpio, hwmon, iio, input, led, media, power, regulator, rtc, video, watchdog, asoc) in a combined patch, to simplify the interdependencies: removing just the mfd driver would leave unselectable or broken drivers in other subsystems. I also have additional patches for each of the other subsystems, currently a total of 300 patches, many of which still need better testing or proper changelog texts.
Please let me know if you all think this approach is ok, or if I should explode this further and turn these 14 patches into 70 individual ones by splitting them per subsystem.
See [2] for the current state of the overall series.
Arnd
[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=board-remove-7.3Arnd Bergmann (14):
mfd: remove unused 88pm80x driver
mfd: remove unused rdc321x southbridge support
mfd: remove unused si476x driver
mfd: remove unused wm8400 driver
mfd: remove unused adp5520 driver
mfd: remove unused da903x driver
mfd: remove unused lp8788 driver
mfd: remove unused aat2870 driver
mfd: remove unused lm3533 driver
mfd: remove unused rc5t583 driver
mfd: remove unused wm8350 driver
mfd: remove unused mcp-sa11x0/ucb1x00 driver
mfd: remove unused menelaus driver
mfd: remove unused iPaq micro driver
Quoted 15 lines
.../ABI/testing/sysfs-class-backlight | 11 - Documentation/admin-guide/devices.txt | 1 - .../admin-guide/media/radio-cardlist.rst | 1 - Documentation/admin-guide/media/si476x.rst | 160 -- .../admin-guide/media/v4l-drivers.rst | 1 - .../devicetree/bindings/regulator/88pm800.txt | 38 - Documentation/hwmon/index.rst | 1 - Documentation/hwmon/wm8350.rst | 30 - .../watchdog/watchdog-parameters.rst | 7 - MAINTAINERS | 14 - drivers/gpio/Kconfig | 22 - drivers/gpio/Makefile | 3 - drivers/gpio/gpio-adp5520.c | 169 -- drivers/gpio/gpio-rdc321x.c | 199 -- drivers/gpio/gpio-wm8350.c | 144 --
For GPIO:
Quoted 21 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
As part of my cleanup of old platforms, I had a look at all drivers that may have become unused because the last
platform_dataor DT definition was removed, or because of unmetKconfigdependencies.These are all the mfd drivers I found. The first ten in the list actually turned out to have been unusable long before my series, and I have added explanations on how I determined this in each patch. The last four patches are still in use in linux-7.3 but become unused after my series [1] that I hope to get merged for 7.4.
Somewhat unorthodox, I took a shortcut here and remove both the mfd drivers and the corresponding subsystem drivers (gpio, hwmon, iio, input, led, media, power, regulator, rtc, video, watchdog, asoc) in a combined patch, to simplify the interdependencies: removing just the mfd driver would leave unselectable or broken drivers in other subsystems. I also have additional patches for each of the other subsystems, currently a total of 300 patches, many of which still need better testing or proper changelog texts.
Quoted 3 lines
Please let me know if you all think this approach is ok, or if I should explode this further and turn these 14 patches into 70 individual ones by splitting them per subsystem.
Sounds good to me, especially if Lee makes an immutable branch from this pull so we can all pull it in...
Thanks.
Signature · 1 line
Dmitry