linux-next: build failure after merge of the pagemap-headers tree
Mark Brown
maintainerHi all,
After merging the pagemap-headers tree, today's linux-next build (powerpc ppc4xx_defconfig) failed like this:
In file included from /tmp/next/build/include/linux/preempt.h:11,
from /tmp/next/build/include/linux/alloc_tag.h:11,
from /tmp/next/build/include/linux/percpu.h:5,
from /tmp/next/build/arch/powerpc/include/asm/time.h:14,
from /tmp/next/build/arch/powerpc/platforms/44x/sam440ep.c:21:/tmp/next/build/include/linux/acpi.h: In function '__free_acpi_object_free':/tmp/next/build/include/linux/cleanup.h:211:92: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
211 | static __always_inline void __free_##_name(void *p) { _type _T = *(_type *)p; _free; }
| ^/tmp/next/build/include/linux/acpi.h:31:1: note: in expansion of macro 'DEFINE_FREE'
31 | DEFINE_FREE(acpi_object_free, union acpi_object *, if (_T) ACPI_FREE(_T));
| ^~~~~~~~~~~cc1: all warnings being treated as errors
make[6]: *** [/tmp/next/build/scripts/Makefile.build:290: arch/powerpc/platforms/44x/sam440ep.o] Error 1 make[6]: *** Waiting for unfinished jobs....
In file included from /tmp/next/build/include/linux/preempt.h:11,
from /tmp/next/build/include/linux/sched.h:15,
from /tmp/next/build/include/linux/ratelimit.h:6,
from /tmp/next/build/include/linux/dev_printk.h:16,
from /tmp/next/build/include/linux/device.h:15,
from /tmp/next/build/include/linux/platform_device.h:13,
from /tmp/next/build/arch/powerpc/platforms/44x/warp.c:11:/tmp/next/build/include/linux/acpi.h: In function '__free_acpi_object_free':/tmp/next/build/include/linux/cleanup.h:211:92: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
211 | static __always_inline void __free_##_name(void *p) { _type _T = *(_type *)p; _free; }
| ^/tmp/next/build/include/linux/acpi.h:31:1: note: in expansion of macro 'DEFINE_FREE'
31 | DEFINE_FREE(acpi_object_free, union acpi_object *, if (_T) ACPI_FREE(_T));
| ^~~~~~~~~~~cc1: all warnings being treated as errors
Caused by commit
f54586fcd661e (ACPI: fan: Use __free() to simplify AML error handling)
(it was also causing lots of warnings in other GCC configurations but didn't trip -Werror in allmodconfig since it doesn't seem to upset clang.). I have reverted that commit for today.
Hi Mark,
Quoted 36 lines · Mark Brown
Hi all,
After merging the pagemap-headers tree, today's linux-next build (powerpc
ppc4xx_defconfig) failed like this:In file included from
/tmp/next/build/include/linux/preempt.h:11,from /tmp/next/build/include/linux/alloc_tag.h:11, from /tmp/next/build/include/linux/percpu.h:5, from /tmp/next/build/arch/powerpc/include/asm/time.h:14, from /tmp/next/build/arch/powerpc/platforms/44x/sam440ep.c:21:
/tmp/next/build/include/linux/acpi.h: In function '__free_acpi_object_free':/tmp/next/build/include/linux/cleanup.h:211:92: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
211 | static__always_inlinevoid __free_##_name(void *p) {_type_T = *(_type *)p;_free; }
| ^/tmp/next/build/include/linux/acpi.h:31:1: note: in expansion of macro 'DEFINE_FREE'31 | DEFINE_FREE(acpi_object_free, union acpi_object *, if (_T) ACPI_FREE(_T)); | ^~~~~~~~~~~cc1: all warnings being treated as errors
make[6]: *** [/tmp/next/build/scripts/Makefile.build:290:arch/powerpc/platforms/44x/sam440ep.o] Error 1 make[6]: *** Waiting for unfinished jobs....
In file included from/tmp/next/build/include/linux/preempt.h:11,from /tmp/next/build/include/linux/sched.h:15, from /tmp/next/build/include/linux/ratelimit.h:6, from /tmp/next/build/include/linux/dev_printk.h:16, from /tmp/next/build/include/linux/device.h:15, from /tmp/next/build/include/linux/platform_device.h:13, from /tmp/next/build/arch/powerpc/platforms/44x/warp.c:11:
/tmp/next/build/include/linux/acpi.h: In function '__free_acpi_object_free':/tmp/next/build/include/linux/cleanup.h:211:92: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
211 | static__always_inlinevoid __free_##_name(void *p) {_type_T = *(_type *)p;_free; }
| ^/tmp/next/build/include/linux/acpi.h:31:1: note: in expansion of macro 'DEFINE_FREE'31 | DEFINE_FREE(acpi_object_free, union acpi_object *, if (_T) ACPI_FREE(_T)); | ^~~~~~~~~~~cc1: all warnings being treated as errors
Quoted 7 lines
Caused by commit
f54586fcd661e(ACPI: fan: Use__free()to simplify AML error handling)(it was also causing lots of warnings in other GCC configurations but didn't trip -Werror in allmodconfig since it doesn't seem to upset clang.). I have reverted that commit for today.
Sorry for the breakage!
Apparently, I forgot to fix up the patch before applying it (even though I update the changelog to that effect).
Should be fixed now.
Thanks, Rafael