Skip to contentSkip to conversation

powerpc/boot: Drop unused min_t()/max_t() helpers

PATCH In review Thorsten Blum 2 participants 3 messages Aug 28 – Oct 3 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 powerpc/boot: Drop unused min_t()/max_t() helpers

Commit c762c69e106f ("powerpc/boot: Add support for XZ compression") added min_t() and max_t() to support XZ in the boot wrapper. However, since commit 9f121705503a ("lib/xz: replace min_t with min") XZ no longer depends on these helpers. Remove them from the boot wrapper.

---
Changes in v2:
- Mention the commit that removed XZ's dependency on min_t(), fixing the build failure seen with v1
- v1: https://lore.kernel.org/r/[email protected]/

---
 arch/powerpc/boot/types.h | 3 ---
 1 file changed, 3 deletions(-)
arch/powerpc/boot/types.h +0 -3
index 8a4c418b7260..c5085c2632bf 100644
@@ -37,9 +37,6 @@ typedef s64 int64_t;
 	(void) (&_x == &_y);	\
 	_x > _y ? _x : _y; })
 
-#define min_t(type, a, b) min(((type) a), ((type) b))
-#define max_t(type, a, b) max(((type) a), ((type) b))
-
 typedef int bool;
 
 #ifndef true
#1 lore raw
Quoted 29 lines · Thorsten Blum

Commit c762c69e106f ("powerpc/boot: Add support for XZ compression") added min_t() and max_t() to support XZ in the boot wrapper. However, since commit 9f121705503a ("lib/xz: replace min_t with min") XZ no longer depends on these helpers. Remove them from the boot wrapper.

---
Changes in v2:
- Mention the commit that removed XZ's dependency on min_t(), fixing the build failure seen with v1
- v1: https://lore.kernel.org/r/[email protected]/

---
 arch/powerpc/boot/types.h | 3 ---
 1 file changed, 3 deletions(-)
arch/powerpc/boot/types.h +0 -3
index 8a4c418b7260..c5085c2632bf 100644
@@ -37,9 +37,6 @@ typedef s64 int64_t;
 	(void) (&_x == &_y);	\
 	_x > _y ? _x : _y; })
 
-#define min_t(type, a, b) min(((type) a), ((type) b))
-#define max_t(type, a, b) max(((type) a), ((type) b))
-
 typedef int bool;
 
 #ifndef true
#2 lore raw
In reply to Thorsten Blum
Quoted 6 lines · Thorsten Blum

Commit c762c69e106f ("powerpc/boot: Add support for XZ compression") added min_t() and max_t() to support XZ in the boot wrapper. However, since commit 9f121705503a ("lib/xz: replace min_t with min") XZ no longer depends on these helpers. Remove them from the boot wrapper.

Quoted 8 lines

---
Changes in v2:
- Mention the commit that removed XZ's dependency on min_t(), fixing the build failure seen with v1
- v1: https://lore.kernel.org/r/[email protected]/

---
 arch/powerpc/boot/types.h | 3 ---
 1 file changed, 3 deletions(-)

Gentle ping?

Thanks,
Thorsten