Skip to contentSkip to conversation

Input: applespi - drop redundant input->dev.parent assignment

PATCH New Dmitry Torokhov 1 participant 1 message Oct 8

Subsystems (2)
HID Input drivers
lore
Share & tools
lore

Dmitry Torokhov

author maintainer
#0 lore raw

PATCH 1/1 Input: applespi - drop redundant input->dev.parent assignment

devm_input_allocate_device() already initializes input->dev.parent to the supplied parent device, so the explicit assignments in applespi_register_touchpad_device() and applespi_probe() are redundant. Remove them.

Reported-by [email protected]
Assisted-by LLM
Signed-off-by Dmitry Torokhov <[email protected]>
---
 drivers/input/keyboard/applespi.c | 2 --
 1 file changed, 2 deletions(-)
drivers/input/keyboard/applespi.c +0 -2
index b5ff71cd5a70..da8fa3938a36 100644
@@ -1259,7 +1259,6 @@ applespi_register_touchpad_device(struct applespi_data *applespi,
 
 	touchpad_input_dev->name = "Apple SPI Touchpad";
 	touchpad_input_dev->phys = "applespi/input1";
-	touchpad_input_dev->dev.parent = &applespi->spi->dev;
 	touchpad_input_dev->id.bustype = BUS_SPI;
 	touchpad_input_dev->id.vendor = SYNAPTICS_VENDOR_ID;
 	touchpad_input_dev->id.product =

@@ -1686,7 +1685,6 @@ static int applespi_probe(struct spi_device *spi)
 
 	applespi->keyboard_input_dev->name = "Apple SPI Keyboard";
 	applespi->keyboard_input_dev->phys = "applespi/input0";
-	applespi->keyboard_input_dev->dev.parent = &spi->dev;
 	applespi->keyboard_input_dev->id.bustype = BUS_SPI;
 
 	applespi->keyboard_input_dev->evbit[0] =
Signature · 5 lines
2.56.0.385.gd3acb90ef8-goog


-- 
Dmitry